- Mar 21, 2018
-
-
Georg Ringer authored
In order to show all tables in the recycler record selection even though the label is the same, the table name must be used as part of the identifier. Resolves: #84505 Releases: master, 8.7 Change-Id: I952a94182fde1e052071bb45d065910f4cd73086 Reviewed-on: https://review.typo3.org/56403 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Mar 20, 2018
-
-
Georg Ringer authored
Simplify the recycler module by reducing the overhead of extbase. Resolves: #84477 Releases: master Change-Id: I79a74686a54aa0f5fcee06c39e046f9e35fee9d1 Reviewed-on: https://review.typo3.org/56363 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Mar 06, 2018
-
-
Łukasz Uznański authored
Add and handle button to select all records from all pages in recycler. Right now, there is pagination, which means that you can select 50 records max. Resolves: #81310 Releases: master Change-Id: Icfc0c93e5cff5cd9573a6a39b615ce0c6e1d273c Reviewed-on: https://review.typo3.org/54849 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Feb 20, 2018
-
-
Andreas Fernandez authored
This patch refactors how the recycler queries records in deep page structures. Instead of resolving each level of the page tree on demand and executing the complex logic of creating query builders and paging all over again, a list of page ids is generated once and stored in the Caching Framework for the current request. This list is then used in an multiple `IN()` statements (depending on the DBMS engine used). Also, some wrong type hints and a wrong language file reference are fixed. Resolves: #83702 Releases: master, 8.7 Change-Id: Ie3314b5a9209fb5585f95a70c16b35639951c197 Reviewed-on: https://review.typo3.org/55472 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Feb 16, 2018
-
-
Christian Kuhn authored
To further support the PSR-7 / PSR-15 and removal of GeneralUtility::_GP() and friends efforts, all controllers no longer use the second 'ResponseInterface $response' argument given by dispatchers: Dispatchers should not assume which type of response a controller returns, there is no point in preparing this object. Instead, controllers now always create one of HtmlResponse, JsonResponse or RedirectResponse on their own and return these objects. Changes overview: * Always use "new" to instantiate a response, PSR-15 middlewares allow fiddling with the object if needed, xclassing these classes is never needed, we instead can rely on proper API usage. * All controller actions drop the second $response argument and add ResponseInterface return type hint. * Some controllers action also drop first $request argument, but only if the action does not need access to ServerParams at all. Those controllers that access _GP or _POST or similar currently, keep $request for now - they have to be refactored later anyway and then need $request. Change-Id: Icce283b3c19be14ef1adeec761cfd63c90ab24c5 Resolves: #83939 Releases: master Reviewed-on: https://review.typo3.org/55754 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Feb 10, 2018
-
-
Andreas Fernandez authored
Resolves: #83839 Releases: master Change-Id: I1e72f959a7ec91c3834fc04ddf175c5c8cb441f2 Reviewed-on: https://review.typo3.org/55656 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Andreas Fernandez authored
The UC of a backend user is now updated only once per request, if there are actual changes. Resolves: #83839 Releases: master, 8.7 Change-Id: I859f8b2cc94b6254251ecf639222201cbf57f1ad Reviewed-on: https://review.typo3.org/55641 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Dec 27, 2017
-
-
Benni Mack authored
Some PHP classes still contain unused use statements. They have been removed. Thanks to @cd on his initial patch https://review.typo3.org/52014/ Resolves: 83432 Releases: master Change-Id: I9020f505a826c40fcf11f75f87245293e7c6154f Reviewed-on: https://review.typo3.org/55217 Reviewed-by:
-
- Dec 19, 2017
-
-
Benni Mack authored
Instead of integers, the permission constants should be used throughout the TYPO3 Core. Resolves: #83383 Releases: master Change-Id: I00c10f97fc800d9533866c98284bbd22cd1bb575 Reviewed-on: https://review.typo3.org/55156 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Dec 12, 2017
-
-
Susanne Moog authored
Change-Id: I36167b0a8b61532adbafea93c88c93097ea52d73 Resolves: #83297 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55042 Tested-by:
-
- Dec 09, 2017
-
-
Claus Due authored
Instead of annotating and type-hinting specific cache frontend implementations, TYPO3 should program to the FrontendInterface instead. This patch corrects that. Change-Id: Ibc8d31cf78459e700ab9fe3448a53cbe83bccc61 Resolves: #81461 References: #81432 Releases: master Reviewed-on: https://review.typo3.org/53116 Tested-by:
-
Benni Mack authored
The new JsonResponse object should be used throughout the TYPO3 Backend in order to properly call json_encode() with the right flags automatically, making the code inside the controllers simpler. Resolves: #83267 Releases: master Change-Id: Ie03fb1414a965a61632897f0e25645a67f3225a5 Reviewed-on: https://review.typo3.org/54995 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Nov 27, 2017
-
-
Alexander Schnitzler authored
This patch applies the phpdoc_types rule of the php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types Releases: master, 8.7 Resolves: #83106 Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770 Reviewed-on: https://review.typo3.org/54770 Reviewed-by:
-
- Oct 17, 2017
-
-
Benni Mack authored
TYPO3 Core does not use isAdmin() API of BackendUsers consistently, as there are some places where a direct access to $BE_USER->[admin]. Resolves: #82783 Releases: master Change-Id: I5ae42a79826a3512be8755aabb32b910f4f6c826 Reviewed-on: https://review.typo3.org/54414 Reviewed-by:
-
- Oct 16, 2017
-
-
Georg Ringer authored
Add the user who deleted a record to the recycler information and also show the avatar of the user. Resolves: #69340 Releases: master Change-Id: Id7d86d737b2759c6746baefa4b60659b6e9527eb Reviewed-on: https://review.typo3.org/54379 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Sep 09, 2017
-
-
Matthias Vogel authored
This patch removes the separate request handler for backend modules, which was accessed via "&M=moduleName" GET parameter. This is now migrated into the RouteDispatcher which can dispatch modules as well. Now, modules are called via the "&route" parameter like all other routes. Additionally, the requested URLs for modules were requested with the additional "moduleToken" which is now called "token". This way, special treatment for modules when dispatching is removed, however the security checks are still in place so this is kept as is. All places where URLs are generated can now still be accessed via `BackendUtility::getModuleUrl()` which can deal with routes, module names and routePaths (from the URL) to keep backwards-compatibility. Next Steps: - Migration wizard for bookmarks + Streamline bookmarks code (see todos) - Check what needs to be added in ExtensionManagementUtility - Introduce slugs in routes for BE, e.g. /file-edit/{fileId}/ and /mod...
-
- Aug 23, 2017
-
-
Wouter Wolters authored
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
- Jul 08, 2017
-
-
Stephan Großberndt authored
Respect the number of records to fetch configured in TSconfig using mod.recycler.recordsPageLimit again. Releases: master, 8.7 Resolves: #81803 Related: #1835 Change-Id: Ic156e290d39ad38e02541bfe7fe80a16296b2f37 Reviewed-on: https://review.typo3.org/53412 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Jun 12, 2017
-
-
DanielRuf authored
Typecasting with (int) is about 2-3 times faster than using intval(). Change-Id: Ifddcaaf9bf5c1fa77c632df10cba62c82d4614d1 Resolves: #81544 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53183 Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
- May 17, 2017
-
-
Wouter Wolters authored
EXT:recycler has some deprecated code that is now removed. Releases: master Resolves: #81237 Change-Id: I6db8ac155f2fe06a07528fbe17855c036f593e96 Reviewed-on: https://review.typo3.org/52642 Reviewed-by:
-
- May 12, 2017
-
-
Benni Mack authored
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Apr 06, 2017
-
-
Christer Vindberg authored
Changed so doctrine constraints without the corresponding bind values aren't passed around. The $constraints variable defined in CleanerTask->cleanTable is reused in CleanerTask->deleteFilesForTable, but without the doctrine createNamedParameter bind variables, since the querybuilder is recreated. This caused the task to fail. Resolves: #80675 Releases: master Change-Id: I2da9b33f884f51bf9d90a9d08841fb4491eedea2 Reviewed-on: https://review.typo3.org/52362 Tested-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
-
- Mar 28, 2017
-
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Feb 24, 2017
-
-
Morton Jonuschat authored
Deprecate BackendUtility::getRecordsByField() as it has a flawed design due to passing SQL fragments. This contradicts the goal of using named parameters for all queries in the core and requires passing the original QueryBuilder object in addition to the stringified constraint. Replace all calls to the method with direct usage of the QueryBuilder and deprecate the method. Resolves: #79122 Releases: master Change-Id: I8b040b98e20271aff84ef16fb89b59a406d54003 Reviewed-on: https://review.typo3.org/51078 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- Feb 17, 2017
-
-
Morton Jonuschat authored
Enforce consistent ordering of deleted records. Change-Id: Ibcb5e61c8cf848b2e25702aef3a2d4ca6bd1cfe6 Resolves: #79800 Releases: master Reviewed-on: https://review.typo3.org/51732 Tested-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
-
- Dec 03, 2016
-
-
Manuel Selbach authored
According to task #78437 queries should follow the prepared statement principle. Thus method BackendUtiltiy::getRecordsByField() has to be refactored to retrieve a queryBuilder which holds the parameter assigned to e.g. additional where clause, etc. otherwise the parameter and the dynamically generated placeholders in the queryQuilder will be reset. Change-Id: Id66d7b2fcfc5bcdca4d920b645c2285ded0c160a Resolves: #78704 Releases: master Reviewed-on: https://review.typo3.org/50664 Reviewed-by:
-
- Oct 26, 2016
-
-
Manuel Selbach authored
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- Sep 01, 2016
-
-
Georg Ringer authored
The optional arguments of RecyclerUtility::getRecordPath are not used anymore and are deprecated. Resolevs: #75637 Releases: master Change-Id: I30b3c3d05ebf9b4961060106b4a02d5c7a4a5089 Reviewed-on: https://review.typo3.org/49682 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- Aug 22, 2016
-
-
Georg Ringer authored
To be in sync with all other modules, the recycler button in the toolbar is moved to the right. Resolves: #77570 Releases: master, 7.6 Change-Id: I6d681239d1d9dc10be356b576c0ac9cb1315a187 Reviewed-on: https://review.typo3.org/49541 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- Jun 03, 2016
-
-
Helmut Hummel authored
To make the set of restrictions that are in effect when creating queries with the QueryBuilder becomes more understandable, we need to remove the QueryContext and the magic applied to that and replace it with the following behavior: delete, hidden, starttime, endtime restrictions are always enabled and need to be removed if needed. Other restrictions need to be provided manually depending on the desired result. Resolves: #76167 Resolves: #76264 Releases: master Change-Id: Iaf0cb08475ed44966838c3fbdd5756d3ba6ebcc1 Reviewed-on: https://review.typo3.org/48049 Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
-
- May 28, 2016
-
-
Valentin Despa authored
Remove the second parameter of sL and replace it with htmlspecialchars directly in the code. Resolves: #76325 Related: #71917 Releases: master Change-Id: I6668eea01d80446a6b6f2ec95435c6e3d93cb0c3 Reviewed-on: https://review.typo3.org/48346 Reviewed-by:
-
- May 05, 2016
-
-
Michael Oehlhof authored
Resolves: #75718 Releases: master Change-Id: I27a14e694cd17132bf71d2687b8ea2366409fa27 Reviewed-on: https://review.typo3.org/47763 Reviewed-by:
-
- Apr 27, 2016
-
-
Michael Oehlhof authored
Resolves: #75636 Releases: master Change-Id: I49611c3d0e6a0ec56e05871c5beb7f7de4bce949 Reviewed-on: https://review.typo3.org/47682 Reviewed-by:
-
- Apr 19, 2016
-
-
Morton Jonuschat authored
This name change transports the intent of the query context better and makes it more intuitive to use. Instead of explicitly disabling all enable fields and the deleted flag using the following code: $queryBuilder->getQueryContext() ->setIgnoreEnableFields(true) ->setIncludeDeleted(true); the more descriptive predefined context can be used: $queryBuilder->getQueryContext()->setContext('unrestricted') Releases: master Resolves: #75751 Change-Id: I4d38a328c2b6707a32f26022b4abfc48e945c0ed Reviewed-on: https://review.typo3.org/47759 Reviewed-by:Susanne Moog <typo3@susannemoog.de> Tested-by:
-
- Apr 18, 2016
-
-
Michael Oehlhof authored
Resolves: #75717 Releases: master Change-Id: I210f838568c47469eb9926b7b4b6774578a28732 Reviewed-on: https://review.typo3.org/47733 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #75713 Releases: master Change-Id: Ia82c7055e71ec154264f6b658addf49c5f9187a5 Reviewed-on: https://review.typo3.org/47730 Reviewed-by:
-
- Jan 16, 2016
-
-
Bernhard Kraft authored
When using the recycler as normal user (non admin) it isn't possible to restore any pages as the underlying BE API methods by default only allow to check for access to non-deleted pages. This situation is circumvented by disabling the "delete" flag in TCA while checking for access to deleted pages. Resolves: #70863 Releases: 7.6, master Change-Id: Ibf6ff305a6dbcf3eaf99fdca89b7bf7c78677319 Reviewed-on: https://review.typo3.org/45292 Reviewed-by:
-
- Jan 14, 2016
-
-
Andreas Fernandez authored
If enabled for an user or being an admin, deleted pages above the selected item are also recovered. If an user does not have this ability, the recover button is locked. Resolves: #1835 Releases: master Change-Id: I98d9876ee95f36cda64fc0730169197b153a2e7f Reviewed-on: https://review.typo3.org/36744 Reviewed-by:
-
- Dec 21, 2015
-
-
Benni Mack authored
The recycler module handles conversions to UTF8 and to other charsets, although the backend is solely UTF-8 since TYPO3 4.5. The logic and the according functions have been removed as they have no effect and only add complexity to code and slows down processing. Resolves: #72334 Releases: master Change-Id: Ifdae4a494e84dec1a7c42e96f36e48ecbf840ff3 Reviewed-on: https://review.typo3.org/45373 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
