- Jul 10, 2022
-
-
Oliver Klee authored
This helps avoid breakage when GeneralUtility will switch to strict mode. This change also prevents a bunch of possible invalid array access warnings. Resolves: #97584 Related: #97578 Releases: main Change-Id: Iaf23147d2ffdbca3a5c8205b2c32926c46084021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75079 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
linawolf authored
The outdated links in EXT:install are improved in https://forge.typo3.org/issues/97885 Releases: main, 11.5 Resolves: #97886 Change-Id: I25979df8f9f322461ffc6d03ab9030240c2e0e8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75090 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
linawolf authored
Releases: main, 11.5, 10.4 Resolves: #97885 Change-Id: Ib274d3d85f1311f100afe8e12167ebc6eaab21db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75089 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
linawolf authored
- mention the methods of the removed hook to make it easier for developers to search for them. - add missing description of the ModifyAllowedItemsEvent Releases: main Resolves: #97881 Related: #97454 Change-Id: I3667514d8d6b6ef1865e161d77ce18ec2999cca8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75081 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
- Jul 09, 2022
-
-
Andreas Fernandez authored
The ReST helper tool at https://forger.typo3.com/utilities/rst produced faulty ReST files for quite some time where the trailing colon was missing from labels. Changelog files affected by this issue are hereby fixed with this commit. Resolves: #97882 Releases: main Change-Id: I96b361b0128680d4bc6434c8ddf1aefc0d280df0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75084 Tested-by:
-
Torben Hansen authored
With this change constructor property promotion is used in ext:felogin where possible. Also 2 superfluous overrides of EventDispatcherInterface have been removed, since the property is already inherited through ActionController. Resolves: #97805 Releases: main Change-Id: I48ac97fe86dc068db023e247039ab38669c868e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74974 Reviewed-by:
-
Oliver Klee authored
This helps avoid breakage when GeneralUtility will switch to strict mode. This change also prevents a bunch of possible invalid array access warnings. Resolves: #97580 Related: #97578 Releases: main Change-Id: Iba6eae561cf8e3607474287683d606a63d14f041 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75080 Tested-by:
-
Andreas Fernandez authored
The confirmation dialog when FormEngine requests an update never came up in FlexForms as the array key used in `TYPO3\CMS\Backend\Form\Behavior\ReloadOnFieldChange->toArray()` didn't match the key in the `typo3-backend-form-reload` handler in FormEngine JavaScript, which is solved in this commit. Resolves: #97804 Related: #91787 Releases: main, 11.5 Change-Id: I1b95e836408a579d1b3e075f7614d7907bf94a37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75085 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Stefan Bürk authored
This patch raises egulias/email-validator to min version of 3.2.1, which incorporates latest changes. This also contains a fix to avoid the usage of PHP8.2 deprecated methods, namely `utf8_encode()` and `utf8_decode()`. Used commands: > composer req egulias/email-validator:"^3.2.1" > composer req egulias/email-validator:"^3.2.1" \ -d typo3/sysext/core --no-update Resolves: #97879 Releases: main, 11.5 Change-Id: Ia985dd3171ec988201022052d036b00e765c2654 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75074 Tested-by:Benni Mack <benni@typo3.org> Tested-by:
-
Larry Garfield authored
This introduces two new events to replace the old modify hooks in LinkBrowser. They are a direct 1:1 replacement. Resolves: #97454 Releases: main Change-Id: Ic79b3c9c56452188323574d92b9fe91c37a2da29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74798 Tested-by:
-
Benni Mack authored
Due to a regression in TYPO3 v11.5.11, using typolink.parameter with stdWrap might also return more than just the URL. This change reverts this behavior by overlaying the decoded typolink string with the original decoded typolink string. Resolves: #97869 Related: #90404 Related: #80896 Releases: main, 11.5 Change-Id: I22010983886a8da8a339aa6376d36303f3b729b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75046 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Larry Garfield authored
Resolves: #97880 Releases: main Change-Id: I582ee8b408ef3df97e0ca9696de95083a9c49bc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75077 Tested-by:
-
- Jul 08, 2022
-
-
Larry Garfield authored
This patch addresses most "undefined property" PHPStan messages. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97596 Releases: main, 11.5 Change-Id: I8c599166fa1747cc34573a035598eaaadbf680cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74583 Tested-by:
-
dsteinborn authored
"msclkid" is the Click ID parameter of Microsoft / Bing which should be excluded from cHash generation. Resolves: #97870 Releases: main, 11.5, 10.4 Change-Id: I9c625e559cb2c7cf031466730ea4eab2e376f9ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75047 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Uwe Trotzek authored
This change transforms the processed record of FlexForms into a human-readable format. This is especially useful when comparing changes in the history module or the workspaces diff view. The diff needs to be formatted with line breaks and tabs as the output is passed through "htmlspecialchars" before it will be displayed. The white-space css setting needs to be changed to "pre-wrap", because this is the only setting where line breaks and tabs are kept and the text will still be word-wrapped. The old view is used as a fallback, if no record is available (import preview). Resolves: #91148 Releases: main, 11.5 Change-Id: Iab1dfb59f98dc712b8984a8087525634b5ec4ebd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64260 Tested-by:
-
Mathias Brodala authored
The Guzzle handler stack allows for pushing handlers/middlewares with a name which simplifies debugging. A possibly defined handler name is now pushed onto the stack as well. Resolves: #97873 Releases: main, 11.5 Change-Id: I94ecbe7bc26f550111407f19f71add3ca7c3a6b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75050 Tested-by:
-
Oliver Hader authored
Escaping SQL `LIKE` wildcards is only provided via `QueryBuilder::escapeLikeWildcards()`, but would be useful as `Connection::escapeLikeWildcards()` as well (without having the demand to create another `QueryBuilder` instance). With this patch, both methods are available: * `QueryBuilder::escapeLikeWildcards()`, and * `Connection::escapeLikeWildcards()` Resolves: #97878 Releases: main, 11.5, 10.4 Change-Id: Ia8968dee944300949c6bb2be5b15e2d02a589d25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75072 Tested-by:
-
Andreas Fernandez authored
The TYPO3 icon set is updated to version 3.1.2 which fixes a regression with buttons. See full changelog here: https://github.com/TYPO3/TYPO3.Icons/compare/v3.1.0...v3.1.2 Executed commands: cd Build nvm use yarn add @typo3/icons@^3.1.2 grunt build Resolves: #97872 Resolves: #97842 Releases: main Change-Id: Iba778452d913defbf34654ec52efa08cd5728f02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75049 Tested-by:
-
Larry Garfield authored
This introduces two new events to interact with the backend controller page generation process. They mirror and replace the renderPreProcess and renderPostProcess hooks, which are removed. The vestigial constructorPostProcess hook is also removed entirely. Resolves: #97451 Releases: main Change-Id: I58bccf341b478eedc87c9a9dd81fac788bba0a91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74797 Tested-by:
-
- Jul 07, 2022
-
-
Benni Mack authored
This change reduces the logic within TMENU in order to further unify link generation within the menu rendering. Resolves: #97865 Releases: main Change-Id: I495b167b7e6e302fc7e8b04757eab1eb8e359528 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75043 Tested-by:
-
Larry Garfield authored
This patch adds property and return types to the core Request class. Parameter types cannot be added to methods from RequestInterface as it has no typed version yet. Doing so allows for the removal of a lot of now-unnecessary tests as well as PHPstan baseline issues. This patch also notes, but does not correct, the incorrect implementation of getUri(), which this implementation permits to return null even though that is a PSR-7 violation. Fixing that has several knock-on effects better addressed in future patches. Resolves: #97620 Releases: main Change-Id: I9b754a261b77fa8fdb6fa58706edf8a5c5248be4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74634 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
Larry Garfield authored
Fluid's TagBuilder::getAttribute() is doc-typed as returning `string`, but the description says it returns `?string`. That meant PHPStan believes the `$file !== null` check is unnecessary, when it actually is. The TagBuilder class is not in core, though, but in the typo3fluid vendored package, so it cannot be corrected from here. However, the `$attributes` array is already requested above, and then href/src is removed from it anyway because it's the same piece of data. So just reading off of the array we already have and doing missing-value handling there ourselves resolves the PHPStan issue, is slightly more consistent with what the next line does (the unset() call), and is ever so slightly faster as it skips a method call. Resolves: #97743 Releases: main Change-Id: I4b24eebdfded4c02c5d59eac2ee00d1cc036d0da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74828 Tested-by:
Felix P. <f.pachowsky@neusta.de> Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
Vanessa Räbiger <vmartens91@gmail.com> Tested-by:
-
Larry Garfield authored
ComparisonInterface's documented types and actual types are inconsistent. This patch corrects the types to be consistent with what the actual code does, which allows for the removal of several PHPStan errors. Resolves: #97604 Releases: main Change-Id: Ib58def06b4c702443f4aac63a667cadfac26dc49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74655 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
linawolf authored
Introduce development and API section, so they can be referenced. Resolves: #97140 Releases: main Change-Id: I28051e09c7800c2653b288460bb618c2bcb987f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73857 Tested-by:
-
Oliver Klee authored
Storage folder identifiers can also be int-like strings, which causes them to automatically get cast to int when used as array keys. Our types annotations need to reflect this in order to keep developers and static analysis for taking those array keys to be always strings (which can lead to type errors and has recently done so). Resolves: #97858 Relates: #97851 Relates: #97711 Releases: main, 11.5 Change-Id: If0fbfab5792446cfe10564803d8d540dd3cc6bb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75033 Tested-by:
-
Benni Mack authored
This change adds two new PSR-14 Events * \TYPO3\CMS\Frontend\Event\AfterCacheableContentIsGeneratedEvent * \TYPO3\CMS\Frontend\Event\AfterCachedPageIsPersistedEvent which replace $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-cached'] $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-all'] and $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['usePageCache'] $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['insertPageIncache'] hooks. Those hooks were much important and powerful, receiving even more power by the new Events, which allow manipulating content stored in cache, or when a page was cached in the Frontend. Additionally, the TSFE->generatePage_postProcessing() method does now require a ServerRequestInterface as first paramter, to be able to pass the current request to the new events. Resolves: #97862 Releases: main Change-Id: Ibd97d22ec1c4a726a78164b234bf8b4ce41f9dca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75039 Tested-by:
-
Oliver Hader authored
Several places in the TYPO3 core fall back to using 'http' as protocol for links in case none was given. In order to adjust this behavior new $GLOBALS['TYPO3_CONF_VARS']['SYS']['defaultScheme'] setting has been introduced, which uses 'http' as default. In order to adjust the default protocol, one has to add the following assignment to their LocalConfiguration.php settings: $GLOBALS['TYPO3_CONF_VARS']['SYS']['defaultScheme'] = 'https' Resolves: #97111 Releases: main, 11.5 Change-Id: I8c86a3b98dfdfef96c6e433de28e24c1af7f27ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73867 Reviewed-by:
-
Georg Ringer authored
Fix a notice if a browse menu is being generated but no parent page is available. Resolves: #97608 Releases: main, 11.5 Change-Id: Id0674fddccf62e02febdfa7b609521d0db3114b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74603 Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Lina Wolf authored
Releases: main, 11.5, 10.4 Resolves: #97867 Change-Id: I5948ff1ab539d6f90da9034fdd05c104ea344c25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75044 Tested-by:
-
Simon Schaufelberger authored
The TSconfig options "mod.web_layout.disableNewContentElementWizard" and "mod.newContentElementWizard.override" are removed with this patch as they are serving edge-case usages. Resolves: #97701 Related: #92504 Related: #92507 Releases: main Change-Id: I5d8b24fa4bb339fdd0435c7ea29b38b2fa86caf7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74777 Tested-by:
-
Oliver Klee authored
Methods from InaccessibleFolder should not be called and always throw an exception when called. Annotate this to help static code analysis understand this. Resolves: #97859 Releases: main, 11.5 Change-Id: Id3f563e5cd2780715a860de7faf567f9cb960d30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75034 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benni Mack authored
Various properties can be accessed directly via TypoScript config settings. * $TSFE->spamProtectEmailAddresses * $TSFE->intTarget * $TSFE->extTarget * $TSFE->fileTarget * $TSFE->baseUrl They have been marked as deprecated. In addition, some internal functionality is now marked as @internal as well, somehow related to the deprecated properties. Resolves: #97866 Releases: main Change-Id: Ieecd1674783a1d9b9092528d16a988568e857e18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75040 Tested-by:
-
- Jul 06, 2022
-
-
Oliver Klee authored
This helps reduce warnings when extensions are type-checked with PHPStan. Resolves: #97820 Releases: main, 11.5 Change-Id: Iee5cd28402d9e33af0bfaa34815552ba331718ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74991 Tested-by:
-
- Jul 05, 2022
-
-
Andreas Fernandez authored
The method FileStorageTreeProvider->getSubfoldersRecursively() iterates an array of subfolders and prepares folder information based on the iterated data. This functionality has a minor flaw, thanks to PHP, in case a folder is named with numbers only, PHP treats array indices as integer if they can be parsed as such, leading to TypeErrors as the method prepareFolderInformation() expects a nullable string. The passed subfolder name is now cast to string to solve this issue. Resolves: #97851 Releases: main, 11.5 Change-Id: I3357121c4892d6063b6714e4e7b436b3ebdd1802 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75028 Tested-by:
-
Benni Mack authored
This change removes the internal property "indexedDocTitle" which is filled by the PageTitleProvider API. This API is then moved to Indexed Search to use the same logic to fetch the "real" page title (without site title etc) when a plugin is registered. Resolves: #97861 Releases: main Change-Id: Ide1b8d1b700d9e555e02d4a02af154f05cb54130 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75036 Tested-by:
-
Markus Friedrich authored
Adapts several content objects to use the local TypoScriptFrontendController instance of ContentObjectRenderer, to reduce usage of global objects and to avoid conflicts when different frontend environments are used, e.g. while indexing with EXT:solr. This adaption should be safe as the ContentObjectRenderer falls back to the global TypoScriptFrontendController, which was used in the content objects until now. If TypoScriptFrontendController is not available, a ContentRenderingException is thrown. Resolves: #97638 Releases: main Change-Id: I224829359f150739931da8b972ac3afded67a0fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74681 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
With the upgrade of TypeScript to version 4.7, typescript-eslint reported itself as incompatible. To solve this, all eslint related packages are updated to their respective latest version. Executed commands: cd Build nvm use yarn add --dev \ @typescript-eslint/eslint-plugin@^5.30.5 \ @typescript-eslint/parser@^5.30.5 \ @typescript-eslint/typescript-estree@^5.30.5 \ eslint@^8.19.0 grunt build Resolves: #97854 Related: #97698 Releases: main, 11.5 Change-Id: Id59b1658b1d83bfa537629b8d1df32c3624351b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75027 Tested-by: -
Nikita Hovratov authored
Resolves: #97855 Releases: main, 11.5 Change-Id: I2cff602b6b77f451061024797adec94713f8b82e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75032 Tested-by:
-
- Jul 04, 2022
-
-
Andreas Fernandez authored
To improve both, UX and acceptance tests (incl. automated screenshots for docs), a notification is now dispatched when records were saved via EditDocumentController. Resolves: #95271 Releases: main Change-Id: I98b43bb9ecf643d634740ffc4241943a49a5a87f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74196 Tested-by:
-
Francois Suter authored
In two places \TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapFactory accesses the TCA for some table without checking if it exists. Resolves: #97853 Releases: main, 11.5 Change-Id: I02c46153013c920cc771f085f872004e9a22ab3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75025 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
