Skip to content
Snippets Groups Projects
Commit 3fcd8ae9 authored by Larry Garfield's avatar Larry Garfield Committed by Stefan Bürk
Browse files

[BUGFIX] Fix type issues in Request

This patch adds property and return types to the core Request class.
Parameter types cannot be added to methods from RequestInterface
as it has no typed version yet.

Doing so allows for the removal of a lot of now-unnecessary tests
as well as PHPstan baseline issues.

This patch also notes, but does not correct, the incorrect
implementation of getUri(), which this implementation permits
to return null even though that is a PSR-7 violation. Fixing
that has several knock-on effects better addressed in
future patches.

Resolves: #97620
Releases: main
Change-Id: I9b754a261b77fa8fdb6fa58706edf8a5c5248be4
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74634


Tested-by: default avatarDaniel Haupt <mail@danielhaupt.de>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarDaniel Haupt <mail@danielhaupt.de>
Reviewed-by: default avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed...
parent ba0294bc
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment