- May 06, 2019
-
-
Oliver Hader authored
Phar Stream Wrapper has been upgraded to version 3.1.1 in order to solve performance and alias resolving issues. The interceptor has been streamlined further. composer require typo3/phar-stream-wrapper:^3.1.1 Resolves: #88277 Releases: master, 9.5, 8.7 Change-Id: Id6b08557ab507ef66e54d1f39992272fe4791405 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60673 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Patrick Lenk authored
The for HTMLtableCells in parseFunc_RTE has been removed. Empty cells still contain the non-breaking space. Resolves: #87771 Releases: master Change-Id: Ic95a215f07597954cebffc7aff73dd15dcce986b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59784 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Change-Id: Ic1e1d0f8fd1a128e542e7cada389d681ac41e10f Resolves: #88265 Releases: master, 9.5, 8.7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60648 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Benni Mack authored
In order to access resolved route parts by enhancers, the TypoScript RequestWrapper should allow to access the PageArguments object. This way, it is easier to migrate existing conditions like [globalVar = GP:singlepartner > 0] to [request.getPageArguments().get('singlepartner') > 0] Resolves: #88252 Releases: master, 9.5 Change-Id: I6abed5badac342c88d2b40d38ecf1ea632f321d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60637 Tested-by:Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
If `mod.web_layout.disableNewContentElementWizard=1` is set, the "New Content Element" wizard is skipped and EditDocumentController's FormEngine is called directly. In that case, the modal must not get opened as this doesn't work in combination with FormEngine. Resolves: #88075 Releases: master, 9.5 Change-Id: Idada95f426496b49131463ec1d0e8462df163e70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60627 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- May 05, 2019
-
-
Benjamin Franzke authored
Instead of offloading the work to wait for the final page content, concurrent requests now wait for the real page content to be rendered (and deliver the content from cache once ready) instead of sending a 503 response code and the famous "Page is being generated" message. The logic to wait for the rendered page (lock and wait) is already there thanks to the page locking, but was deliberately circumvented by the temporary page cache content before to get rid of waiting requests in high-load situations. This approach to simply skip the temporary cache and wait for the renderer to finish has been tested using the skip_page_is_being_generated extension in wild for 3 years (for TYPO3 v6, v7, v8 and v9). Note: In case the increased number of waiting requests has a negative impact on sites with high server load, a additional proxy cache should be considered in front of the server to make sure clients are served a valid response without waiting until new content is ready. The motivation for this change: The 503 status code together with the "Page is being generated message" does not only occur for slow or high traffic sites. It will be displayed even for two concurrent requests, no matter how fast the page rendered or how low the current traffic is. The requests only need to (nearly) arrive at the same time. This can easily be reproduced using two parallel curl requests: for i in {1..2}; do curl -sv https://doma.in/foo |& grep '^< HTTP'& done There would be one "503 Service unavailable" response when /foo has not yet been rendered to the cache before. An explanation for the releaseLock('pagesection') addition in TSFE::getFromCache(): This has been added as the pagesection lock – which is acquired in TemplateService::start() – was implicitly released in setPageCacheContent() before. Now this would block concurrent rendering for pages with $_GET-aware plugins, therefore we release the pagesection lock early, after the pagesection cache has been generated. Releases: master, 9.5, 8.7 Resolves: #87980 Change-Id: I034f410335b3035c5863b26e3e689ca29b5f3f80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60307 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
-
Richard Haeser authored
To get a valid Twitter card, you need to specify the type of card by setting the twitter:card metatag. The value of this metatag is now set to summary by default. If this value need to be changed, you can use the MetaTag API and set the twitter:card property with the replace option enabled. Resolves: #88258 Releases: master, 9.5 Change-Id: Iaeaafb2408102c2844623155611cffffa8919d43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60647 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
- May 04, 2019
-
-
Andreas Fernandez authored
With #82368, the Configuration API is used in the Extension Manager to check specific configuration. However, for automatic extension installation the wrong setting was checked. This patch now uses the correct setting, fixing an issue with extensions not getting installed after upload. Resolves: #87818 Related: #82368 Releases: master, 9.5 Change-Id: If18e96c4c17d06723805b4dd6c8807adabe19966 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60625 Tested-by:
-
- May 03, 2019
-
-
Andreas Fernandez authored
Technically, it's sufficient to annotate $originalResource as type of ResourceInterface because all other annotated types implement the interface anyway. This also bypasses an issue with the rewritten ClassSchema, as it can't handle multiple annotated types of a property and fails do determine a class type. Resolves: #88268 Releases: master, 9.5 Change-Id: I641d3771eef39128df9ba7a51db2ebc2e0dd67a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60649 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Susanne Moog authored
While hardening the ImageService it was restricted to core's FileReference instead of also allowing extbase FileReferences - the code for converting them is still there but not reachable anymore due to the restrictive type hint. Resolves: #88221 Releases: master Change-Id: Id6c2ef70182f33cd28d13b4ffba7a8796548ff25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60567 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- May 02, 2019
-
-
Anja Leichsenring authored
The touch command raises a PHP WARNING if the test file can not be created, but the next line would already skip the test if this happens. So the warning is useless and gets silenced. Resolves: #88255 Releases: master, 9.5, 8.7 Change-Id: Id9685b6e7da8665609fa7df7f25867ab4d19a6a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60640 Tested-by:
-
- Apr 30, 2019
-
-
Benni Mack authored
In TYPO3 v8, new page translations within pages_language_overlay were visible by default when using plain DataHandler. In TYPO3 v9, due to the merge into "pages" for translations, the default value for "hidden" is used. Every new page translation is now hidden by default - this is a different behavior. Tests had to be modified to make this work again. However, the change now removes the "hacks" within the tests, and adds the functionality to take-over the "hidden" flag from the default record. For future TYPO3 major versions, the hidden field could be migrated into a "allowLanguageSynchronization" once the Context API is used throughout Core properly. Resolves: #88248 Releases: master, 9.5 Change-Id: I2a684a0d4225451c3fbfc0021c09935c1224aaca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60632 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Richard Haeser authored
When generating the XML sitemap for records, the language of the records will be checked. Only records from the current language or all languages are added to the XML sitemap. Resolves: #87912 Resolves: #87841 Releases: master, 9.5 Change-Id: Ibc2bc847840ff7ae6d34aa0b0b40fbe163ce2b78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60629 Tested-by:
Soren Malling <soren@meteko.dk> Tested-by:
-
- Apr 29, 2019
-
-
Benni Mack authored
In order to allow custom functionality like "Skip pages of type XYZ", a new hook is added to the SlugHelper which can be added via $GLOBALS['TCA']['pages']['columns']['slug']['config']['generatorOptions']['postModifiers'] The userFunc needs to return the new / modified $slug which is then put through the sanitize() method. TYPO3 Core does not provide custom functionality so this hook allows to build everything a custom installation or extension wants to hook in. Resolves: #88198 Releases: master, 9.5 Change-Id: Iad548da69ba001c696afd7d7f834d4950318c029 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60418 Tested-by:
-
Benni Mack authored
In the initial implementation a "versioning" state was missing in the record state for TYPO3 v9.5. If now an editor edits an existing root page (pid=0) in a workspace, this results in a fatal error when accessing DataHandler. The patch adds the versionized functionality. Resolves: #88167 Resolves: #87949 Releases: master, 9.5 Change-Id: I0c69518ecd20aafc5481eea482832c020c01f662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60500 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
Jan Delius authored
Resolves: #88246 Releases: master, 9.5, 8.7 Change-Id: Iad8558cbe22caaefd659fef1681452a962b5cdf7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60620 Tested-by:
Rico Drexler <rico.drexler@gmx.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Andreas Fernandez authored
The delete command triggered by the page tree's context menu was invoked by loading a URL in the module iframe which caused timing issues due to subsequent requests. This patch invokes an AJAX call instead to deleted pages. Resolves: #87416 Releases: master, 9.5 Change-Id: I457df1a21e703f98f6b1a182f6165f60cfd13b21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60621 Tested-by:
-
Andreas Fernandez authored
The Install Tool ships bootstrap on its own, which doesn't make much sense right now, since other components get used from EXT:core as well. For now, the separated bootstrap gets removed and the one of EXT:core is used instead. Resolves: #88219 Related: #88213 Releases: master, 9.5, 8.7 Change-Id: I53425f56a44fa9782d7f3776175ac08bc746e5ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60565 Tested-by:
-
Susanne Moog authored
The ImageViewHelper uses properties 'title' and 'alternative' from file without checking whether they exist or not. This results in an exception for example with freshly uploaded files. Releases: master Resolves: #88222 Change-Id: I2b251e5f885bd00119a958e6bc2275c7e672336f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60568 Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
-
- Apr 28, 2019
-
-
Dominik Merkel authored
A new convenience function has been integrated which allows the user to change the label of an element within the structure tree. Releases: master Resolves: #84757 Change-Id: I7095dfbec8731714ceb2a73bb62b58aaa3cb8957 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60582 Tested-by:
-
Mathias Brodala authored
Now by default, mails sent with the EmailFinisher contain both a plaintext and an HTML part. The latter can be controlled with the new "addHtmlPart" option which is enabled by default. The former "format" option is removed from the backend UI and migrated to the new "addHtmlPart" option. Resolves: #87200 Releases: master Change-Id: Id0a58e8cfee07926a555d0d921fed8b41832cb77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60611 Tested-by:
-
Mathias Brodala authored
Also deprecate the single recipients options in favor of their list successors. Resolves: #80420 Releases: master Change-Id: I5bad6da8809bd362110025296564e3eff0df70a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60544 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Björn Jacob authored
The property "elementDescription" has been documented for both the backend (form editor) and the frontend of the form framework. In addition, some minor contextual and spelling problems have been fixed. Resolves: #84229 Releases: master, 9.5 Change-Id: Ifc9039b3dc434a20783d8d67b5d6efcd1eed113e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60609 Tested-by:
-
Ralf Zimmermann authored
Resolves: #88239 Releases: master, 9.5 Change-Id: I09df1600304e4f0cff6d4cab6f45b0c966525a3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60608 Tested-by:
Dominik Merkel <merkel.dominik@googlemail.com> Tested-by:
-
Mathias Brodala authored
Resolves: #87009 Releases: master Change-Id: I533ccf9959f0e9e3a485a3317af8befc8befeb98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593 Tested-by:
-
Mathias Brodala authored
A valid FlexForm field must have a "TCEforms" wrapper around the field configuration as can be seen in the FlexFormTools class. Resolves: #88013 Releases: master Change-Id: I986f4fdf6f32c7174b3967f75729bc1122d4fdbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60607 Tested-by:
-
- Apr 27, 2019
-
-
Michael Waack authored
The form plugin now only renders the checkbox for overriding the finishers if finishers are available at all. Also finishers without options are ignored. Resolves: #84774 Releases: master Change-Id: I1165d054340457fdd219024f28b877a21458b603 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60570 Tested-by:
-
Susanne Moog authored
When configuring a form with a file size validator it can be helpful to know what the servers' max upload capabilities are. As it may make sense to set bigger values and then contact a server admin to adjust the server settings, we do not want to restrict the input field. Instead, a hint with the current configuration has been added to inform the editor / integrator of the current limitations. Resolves: #88055 Releases: master Change-Id: Iaae73f8df87f47484e29a810c7531a117e35a286 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60595 Tested-by:
-
Ralf Zimmermann authored
Enriches the ext:form MimeTypeValidator error object with the mime type of the validated file. Resolves: #88236 Releases: master, 9.5 Change-Id: Ie2ec6950c58841f4f942e38acf4a36a9b8b9635c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60601 Reviewed-by:
-
Ralf Zimmermann authored
Use contextual flexform sheets to identify ext:form finisher overrides within the frontend. Resolves: #88011 Releases: master, 9.5 Change-Id: I0a21deed29419281478f358ff61986d65b26dd0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60548 Tested-by:
-
Björn Jacob authored
In addition, a couple of valuable examples have been added. Resolves: #84135 Releases: master, 9.5 Change-Id: I4de1570c990d190b4293b536b3bcdfc6e9cb8f82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60600 Tested-by:
-
Susanne Moog authored
With the security fix in #f3445f96 checks on EXT:form file handling were added to ensure secure form definition files. These checks are based on FAL hooks. One of these - preFileAdd - contains checks based on the content of the file to add, to do that, the file content is fetched via file_get_contents. Due to a missing guard this was executed for all file add operations instead of only for form definitions resulting in performance loss and high memory usage. The check has now been implemented. Resolves: #88235 Releases: master, 9.5 Change-Id: Ie685df3d67d6ee58b1cd08f18acab1208a487ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60596 Tested-by:
-
Susanne Moog authored
When having a broken form configuration, the formEditor is not able to load because of JavaScript errors. These errors are not fixable for an editor as they most likely happen because of admins/integrators changing and breaking the form. Instead of displaying a loading indicator without a hint on the error that happened, a top level catch displaying a flash message has now been implemented. Resolves: #84595 Releases: master, 9.5 Change-Id: I44cf49d8e344629bc1a3250eade6267c7debdf00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60598 Tested-by:
-
Sybille Peters authored
Resolves: #88223 Releases: master, 9.5 Change-Id: Ib6d13fcbfa4de1c0e28b6af95a26ec9fc90c4387 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60571 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Ralf Zimmermann authored
Show all possible finisher options which can be overridden within the form plugin even if if they are not part of a form definition. Resolves: #86635 Resolves: #85033 Releases: master, 9.5 Change-Id: Ie5ce8e2fb97e2c3fde92cbcb405d77818d1c7bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60577 Tested-by:
-
Björn Jacob authored
The missing translations of the validator "Number of submitted values" have been added. Resolves: #88234 Releases: master, 9.5 Change-Id: I97c8865ff2ff5a46d6d5dd598143781c5fb6d7d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60590 Tested-by:
-
Dominik Merkel authored
Releases: master, 9.5 Resolves: #87198 Change-Id: I91b8b2f0d161ef89ba4896b063685ef2e2c8544d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60588 Tested-by:
-
Michael Waack authored
Resolves: #88022 Releases: master, 9.5 Change-Id: I7d86f8061d71357307d939d4c4359e9da1b2c68a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60549 Tested-by:
-
Björn Jacob authored
Furthermore, move some documentation around regarding finishers and validators to have the information at one central place. In addition, fix a PHP comment regarding the MimeType validator. Resolves: #88212 Releases: master, 9.5 Change-Id: Ifa437294c05d3f9dba16f8bb17ac88a43796595b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60554 Tested-by:
-
Michael Waack authored
Resolves: #84699 Releases: master, 9.5 Change-Id: I2733556eae95db5f44867323cd217c4b3ea0127c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60576 Tested-by:
-
