Skip to content
Snippets Groups Projects
Commit f9f6694a authored by Susanne Moog's avatar Susanne Moog Committed by Ralf Zimmermann
Browse files

[BUGFIX] Add guard clause to preFileAdd form hook

With the security fix in #f3445f96 checks on EXT:form file handling
were added to ensure secure form definition files. These checks are
based on FAL hooks. One of these - preFileAdd - contains checks based
on the content of the file to add, to do that, the file content is
fetched via file_get_contents. Due to a missing guard this was executed
for all file add operations instead of only for form definitions
resulting in performance loss and high memory usage. The check has
now been implemented.

Resolves: #88235
Releases: master, 9.5
Change-Id: Ie685df3d67d6ee58b1cd08f18acab1208a487ce7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60596


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarDominik Merkel <merkel.dominik@googlemail.com>
Tested-by: default avatarRalf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: default avatarOliver Hader <oliver.hader@typo3.org>
Reviewed-by: default avatarDominik Merkel <merkel.dominik@googlemail.com>
Reviewed-by: default avatarRalf Zimmermann <ralf.zimmermann@tritum.de>
parent 2081a5d6
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment