- Jan 13, 2020
-
-
Benni Mack authored
HMENU provides a way to directly create the external link if a page is of type "External URLs" but typolink does not resulting in a) more bandwidth / hits for TYPO3 when using typolink b) different results / expectations. The patch makes typolink handle external URLs like HMENU. Resolves: #90008 Releases: master Change-Id: I712e79f2a399b50d9781bca75f623a419a29f09e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62630 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Daniel Goerz authored
When generating the list of pages for a sitemap in an alternative language only pages are considered that are actually translated or covered by the fallback strategy. Additionally the method generateItems() in the internal class PagesXmlSitemapDataProvider is now protected. Resolves: #90046 Releases: master, 9.5 Change-Id: I54557e0485ae7791ac51fa975991d6d9c9211b61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62865 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Markus Klein authored
The name clash with the PHP native exception is not beneficial. We replace it with \InvalidArgumentException. Resolves: #90101 Releases: master Change-Id: Icc53bcca2dcc24352f4edd4f2e9ef66df7bdfdd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62862 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Felix P. <f.pachowsky@neusta.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
When the PageTypeDecorator is used for routing, currently ALL available typeNums must be registered, otherwise links to pages with a typeNum just get their type removed (fallback to default). A new check is added when creating links (resolving these URLs with a GET type= parameter works just fine) for skipping unmapped arguments when decorating. Resolves: #87817 Resolves: #88836 Releases: master, 9.5 Change-Id: I252cf80de2befed8396cc93b1bc737d77aa18b31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383 Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
-
Joerg Boesche authored
The sys_category TCA configuration behavior is now the same as in tt_content. Flags and labels for the languages in the select single dropdown. Resolves: #89607 Releases: master, 9.5 Change-Id: I5a4c2df7294b699136b62cbf4f68d2ceeae43b8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62860 Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
-
Markus Klein authored
If a select field is comprised of static and dynamic (database relation) values the order of items stored in database is preserved when showing the select field. Resolves: #87672 Releases: master, 9.5, 8.7 Change-Id: I95ed9d523f68eb106c22bbbcd14e60a17a2c0293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62856 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
- Jan 12, 2020
-
-
Daniel Goerz authored
The list module now takes the available SiteLanguages into account when rendering the buttons for creating new translations of records. If a language gets deleted from the site configuration it is no longer possible to create record translations to this language. Resolves: #86662 Releases: master, 9.5 Change-Id: If03598fbb63496d36c93cd832cbdb3028b5e32e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62854 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Daniel Goerz authored
Resolves: #90099 Releases: master, 9.5 Change-Id: Ia3917f8a33aa6c76c20cbcc5e107546520113ab3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62858 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Markus Klein authored
Example: [traverse(request.getQueryParams(), 'tx_news_pi/news') > 0] Resolves: #89176 Releases: master, 9.5 Change-Id: Ic589f68382951c203afa5ad6a7bc16fbddbc20b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61708 Tested-by:
-
Georg Ringer authored
A condition like [getTSFE().id == 1] is evaluated in BE as well and logged an error 'Unable to get a property on a non-object'. This patch ensures that conditions based on getTSFE() are treated gracefully and are evaluated to false. Resolves: #87021 Releases: master, 9.5 Change-Id: If56a8b7bd66b9f7e66bdc8ce5f56c8df890cf655 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59129 Tested-by:
-
Susanne Moog authored
As feedit has been removed from the core, EditToolbarService is no longer in use. As it was marked as internal it is removed without further notice. Resolves: #90098 Releases: master Change-Id: I5e8a622c5581e46539afe43a1aed3486c6d5ae11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62853 Tested-by:
-
Susanne Moog authored
As config.extTarget might not be set, passing it by reference results in the string "< config.extTarget" being passed instead - which will not evaluate to empty therefor breaking the fallback chain. Resolves: #89994 Releases: master, 9.5 Change-Id: Ice368e3d139309b32fb886538ef69437f62b3cc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62752 Tested-by:
-
Markus Klein authored
The labels have been moved around before and these place have been forgotten to be updated. Resolves: #90096 Related: #87882 Releases: master Change-Id: I738e7b5230ed300449e25acedc4f06fccdd588d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62850 Tested-by:
-
Volker Kemeter authored
Since sys_file_metadata records are stored on pid=0, there is no site configuration available. This situation is similar to be_users.limitToLanguage feature, where all languages of all sites need to be visible (depending on the backend user rights). This patch adds an option for the TranslationConfigurationProvider to render all languages of all sites as a combined list if the given pageId is 0 (based on the current user rights). Resolves: #88897 Releases: master Change-Id: I14b1bb6ae5c8577571cf5fa7bc2da1c1824c0f58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61419 Tested-by:
-
Markus Klein authored
The DefaultTcaSchema::enrich() function dynamically adds TCA-defined ctrl-fields to the SQL schema definition for a provided set of tables. The function used to add these definition for any table that is defined in TCA, independent whether the table actually exists in any ext_tables.sql file. While this behaviour is no problem under the assumption that the function is always called with the content of all ext_tables.sql files, this is a problem if the function is called with only a subset of those ext_tables.sql files. One example is the "extension manager tables" upgrade in the Install Tool. Despite the fact that the function was documented that it needs to be called with the full set of tables, it actually is not strictly necessary to do so. This patch changes the requirement for the enrich() function and changes the behaviour to not dynamically create tables if those are found in TCA. Technical detail to the reported bug: The table definitions created by this class are usually overruled by whatever might be defined in an ext_tables.sql file. In case of the upgrade wizard (where only extension manager tables are requested) the table definitions for all TCA tables were created based on the best practice suggestions from the core. If the present DB schema (created by the real ext_tables.sql files) mismatched those suggested definitions a DB schema change was proposed, hence the wizard kept popping up. Resolves: #89535 Releases: master, 9.5 Change-Id: I78594f1ee0878e8d3f5606901d0abb7fe0023059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62154 Tested-by:
-
Georg Ringer authored
Remove the feature switch `betaTranslationServer` and use the new translation server by default. Resolves: #89992 Releases: master Change-Id: Iab61c913d1a6df3cc1b509e731d30616392c43a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62747 Tested-by:
-
Georg Ringer authored
As the description is using a textarea element in the backend, editors can add a multi-line text. The line breaks should be shown in the frontend as well by using f:format.nl2br. Resolves: #89611 Releases: master Change-Id: Ia2b1b2ef896004b1ec91a1719d48826efdc3fb91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62629 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
-
- Jan 10, 2020
-
-
Benni Mack authored
In the environment module, the removed <i:constant> viewhelper is still referenced, which can easily be used by assigning the proper variable to Fluid. This change was merged last week due to the TYPO3_version logic. Resolves: #90077 Related: #90007 Releases: master Change-Id: Ie3ccd03b757303e253a71bea26c60406552e3d5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62838 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Manuel Selbach authored
With this change $connection::query() is used instead of $connection::exec() which can not be used for statements that return results, see: https://www.php.net/manual/de/pdo.exec.php#61702 Resolves: #82686 Releases: master, 9.5, 8.7 Change-Id: Ic4b2cc8caec0bc74ffa730b09d03ca0009ca1751 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62841 Tested-by:
-
Benni Mack authored
Using Class constants instead of constants that are defined during runtime has the following benefits: - Naming can be made more consistent (and separated) - Speeding up requests where the constants are not needed - Benefit from Opcaching of class loading instead of dynamic runtime definition - Testing framework has less "bootstrap" to do This affects the following constants: - TYPO3_copyright_year - TYPO3_URL_GENERAL - TYPO3_URL_LICENSE - TYPO3_URL_EXCEPTION - TYPO3_URL_DONATE - TYPO3_URL_WIKI_OPCODECACHE The constants are now deprecated. In addition, the "Typo3Copyright" class is now called "TYPO3Information". Resolves: #89866 Releases: master Change-Id: I607c90cb281179bda9875504d258daefd3471868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
With Dependency Injection, the new PSR-14 based EventDispatcher, built into TYPO3 Core should never be exposed to our core code, since we should always reference the EventDispatcherInterface. We do this in almost all cases, except for a few places where we introduced PSR-14 before DI. Resolves: #90034 Releases: master Change-Id: I59e74333360c98b3c2e16c1b3df6fbd8bbf450f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62778 Tested-by:
-
Benni Mack authored
This change cleans up some RelationHandler code: - Working with true boolean inside RelationHandler for getValueArray() - RelationHandler->MM_oppositeFieldConf is an array, but declared wrongly as string (since forever!) - detecting the MM_oppositeTable property should not need a $tmp variable, but using a direct assignment - and unset() is not needed due to PHP7s memory management - internal $isSet flags should be boolean, instead of a number Resolves: #90066 Releases: master Change-Id: Ifff2a016a7be945ba6a1dd265e06b1e52bee5de7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62830 Reviewed-by:
-
Georg Ringer authored
The method inet_pton returns false if the provided IP address is invalid. This needs to be checked to avoid errors. Resolves: #90059 Releases: master, 9.5, 8.7 Change-Id: Ic3c7955eb64aff723b31862ef9c7c95e31a098b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62833 Tested-by:
-
Benni Mack authored
During the TYPO3 v9 install tool refactoring, a simple PHP array syntax mistake did not correctly set the fluid variable "systemInformationCgiDetected" which always resulted in not running in a CGI environment. The change adapts the array variable assigment. Resolves: #87320 Releases: master, 9.5 Change-Id: I2368ff033a6318d67c9153be20816d13ad8bd08d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62837 Reviewed-by:
Michael Schams <typo3@2018.schams.net> Reviewed-by:
-
- Jan 09, 2020
-
-
Helmut Hummel authored
The AbstractTask always had methods setScheduler and unsetScheduler to avoid serialization of the scheduler instance. These methods are called by the scheduler API before serializing (unset) and after unserializing (set). Use these methods in favor of the __sleep and __wakup calls to avoid issues with third party subclasses that implement these methods and to make sure tasks that are already serialized with an outdated logger instance are properly updated on next run without the need to clean them up manually. Releases: master, 9.5 Resolves: #86941 Resolves: #87780 Change-Id: I140973fa952c5c41b8eac966ba3b541420ec060b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60306 Tested-by:
-
Benni Mack authored
The symfony/mailer instance needs an email address in the form of new Address($emailAddress, $name); The MailUtility::getSystemReplyTo() returns a strange (Swiftmailer-like) syntax, which was implemented wrong when migrating to Symfony/Mailer. The change switches the constructor arguments to be used in the correct order ($email, $name). Resolves: #90040 Releases: master Change-Id: I2f2bfc67b47fdd1327895c96bd27b2d481805a1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62836 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Benni Mack authored
The BasicFileUtility was very important before the FAL API was introduced in TYPO3 v6. Since TYPO3 v10, the last important parts have been removed, which is why the PHP class is now marked as internal. In addition, several internal methods have been removed, the "setFileExtensionPermission" method is still there in order to avoid PHP Fatal Errors so extensions can stay compatible with TYPO3 v9 and TYPO3 v10. Resolves: #90020 Releases: master Change-Id: I1c6903f914722c5ddca79dd16f5766984f8c10db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62764 Tested-by:
-
Benni Mack authored
To optimize TYPO3 for Opcaching and speeding up performance, as well as simplyfing the bootstrap (also for the testing framework) the constants * TYPO3_version * TYPO3_branch are moved to a new PHP class "Typo3Version". This reduces the necessity to define the constants, and since TYPO3 Bootstrap continues to use the class, the constants are defined in the constructor for TYPO3 v10, and will be removed in TYPO3 v11. Resolves: #90007 Releases: master Change-Id: I18942023c0e234a328d45f724a6b3092c801982c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62740 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Benni Mack authored
LinkAnalyzer now stores the response as JSON instead of PHP serialize. A fallback mechanism when unpacking uses unserialize() as fallback to keep records in the database. Resolves: #89944 Releases: master Change-Id: Ic3a2ba058d916936cc5c46a0a8e279bc07bfe60c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62631 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
- Jan 08, 2020
-
-
Benni Mack authored
RelationHandler->dbPaths was added in 2003 by kasper, but NEVER ever used since then in TYPO3 Core, or does it serve any purpose. So this property can safely be removed. Resolves: #90065 Releases: master Change-Id: I361925e68e1025436799ceb97c7e1156d45e250a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62829 Tested-by:
-
Oliver Hader authored
* avoid assigning and forwarding multiple variables * preparation for further enhancements of view helpers * Uri UnitTest case mostly tested TypoLinkCodecService (it was a FunctionalTest) and to 1/3 a simple additionalParams case * Link UnitTest case mostly tested TypoLinkCodecService (it was a FunctionalTest) Resolves: #90022 Releases: master Change-Id: If65e42d4ca8085855f3f335d1eb2604be9a36fe0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775 Tested-by:
-
- Jan 07, 2020
-
-
Chris Müller authored
The maximum line length of documentation files (80 characters) should be reflected in the .editorconfig as described in https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/GeneralConventions/CodingGuidelines.html#line-length Resolves: #90054 Releases: master, 9.5 Change-Id: Ib1c3f2f2fbae999b7d157949f1a59876c2ff451d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62818 Tested-by:
-
- Jan 06, 2020
-
-
Oliver Hader authored
Resolves: #90057 Releases: master, 9.5 Change-Id: Ifee8153c4f49b7fdde544a51bc19ee7d6e21b323 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62821 Tested-by:
-
Naderio authored
Correct formatting of codeblock in "Link Browser" description. Releases: master, 9.5, 8.7 Resolves: #90058 Change-Id: Ifbfff20a38cadef84e7e9c500fb846f2bbdccd3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62822 Tested-by:
Rudy Gnodde <rudy@famouswolf.com> Tested-by:
-
Oliver Hader authored
Permutations are currently used in test cases - however it would be possible to make use of this functionality in regular sources as well. That's why corresponding methods are moved into a new PermutationUtility implementation. Resolves: #90055 Releases: master, 9.5 Change-Id: I05d978ada2021c7db1b7abeb8a21a825472ae8cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62819 Tested-by:
-
- Dec 31, 2019
-
-
Sybille Peters authored
The <be:link.editRecord> and <be:url.editRecord> now have an option argument "fields" which can be used to limit the edit form to only these fields (instead of the entire record). The fields should be passed in a comma separated list. Resolves: #89644 Releases: master Change-Id: I28913c072578aacd1da95c3bacebea35f8958bac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62298 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Michael Schams authored
Symfony version 5 expects an integer as the return value from Command::execute() in the Command class. This bugfix returns 0 to satisfy Symfony version 5 requirements. Resolves: #90032 Releases: master Change-Id: Id759707091f6695388b19b9d081beaf8c137c3cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62780 Tested-by:
-
Benni Mack authored
The change of issue #90019 introduced a mis-spelling in hte variable naming, where the variable was named "$tscPid" but the original code was "$tscPID" which should be used as well. Resolves: #90041 Releases: master Change-Id: Idaad179968fb4b0953f7b12a8c7660793797cf02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62812 Tested-by:
-
Oliver Hader authored
TYPO3 backend does not need PHP session handling since it has its own session handling implementation. Resolves: #90024 Releases: master Change-Id: I9d8ccaf38c62b86d3b6945b2c631a2602b4aa73f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60173 Tested-by:
-
Benni Mack authored
TYPO3's page permissions are based on five fields and a bitset. - perms_userid - perms_groupid - perms_user - perms_group - perms_everybody For permissions of a page there is - show page ("show") - edit page properties ("edit page") - edit page contents / records ("edit content") - delete page ("delete") - create new subpages ("new") In addition, these can be pre-set globally or via PageTSconfig. The DataHandler currently uses a mix between strings and integers for defining these values. A new PagePermissionAssembler class builds together the page permissions now, allowing to thin out certain parts of DataHandlers responsibility. The following properties and methods are now deprecated: - DataHandler->defaultPermissions - DataHandler->pMap - DataHandler->setTSconfigPermissions() - DataHandler->assemblePermissions() The methods - DataHandler->doesRecordExist() - DataHandler->recordInfoWithPermissionCheck() should only be called with integers as permission argument in the future. Resolves: #90019 Releases: master Change-Id: I3724cb8661fe2b7cc5e1f8ab34d17dd4fa68c11b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62763 Tested-by:
-
