- Apr 12, 2018
-
-
Andreas Fernandez authored
This reverts commit 7ef32708. The original patch does not work well with a huge record set as the processing time per request is too high. Also, the recover button for a single record does not work anymore, as the action is not called properly via AJAX. Resolves: #84700 Related: #81310 Releases: master Change-Id: I4ba5d2982ef57c62d03f76df3ae5bf2ca3c9bdf8 Reviewed-on: https://review.typo3.org/56637 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Fernandez authored
Resolves: #84697 Related: #83987 Releases: master Change-Id: I292b5942144c1453921ba7ce490e26209dee187f Reviewed-on: https://review.typo3.org/56635 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Apr 11, 2018
-
-
Markus Klein authored
If the logger for some reason couldn't be created by GeneralUtility or causes an exception or error itself the triggered ErrorHandler or ExceptionHandler must not try to use the (non-existing) logger. Resolves: #84646 Releases: master, 8.7 Change-Id: I46ba22bf4141c37db6530912b9e34252d1fb462c Reviewed-on: https://review.typo3.org/56598 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Helmut Hummel authored
Resolves: #84683 Releases: master Change-Id: I08d2fceeabd9d2d6ff52d65e35c03fc4336b8141 Reviewed-on: https://review.typo3.org/56625 Reviewed-by:
Wittkiel Gruppe <ts@wittkiel-gruppe.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Apr 10, 2018
-
-
Sybille Peters authored
Resolves: #84686 Releases: master Change-Id: Ib652d17685b65004d68ade431200d8f88e87dff1 Reviewed-on: https://review.typo3.org/56627 Tested-by:
-
Helmut Hummel authored
Change-Id: Ied93632cfdf9221044577b8506ffa82f317a8756 Reviewed-on: https://review.typo3.org/56626 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Apr 09, 2018
-
-
Oliver Hader authored
Change-Id: I27ae8aa8699a382f2d2a71a215931f6de7425738 Reviewed-on: https://review.typo3.org/56621 Tested-by:
-
Oliver Hader authored
Change-Id: Ifb953ea1058c45a59273493170b7c3e567da104b Reviewed-on: https://review.typo3.org/56620 Reviewed-by:
-
Mathias Schreiber authored
Pages of the doktype “sys_folder” are no longer shown as valid entrypoints into a site. Resolves: #84663 Releases: master Change-Id: I92fa2966ccf9319df52d656a30ec35a767c2dd21 Reviewed-on: https://review.typo3.org/56604 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Benni Mack authored
The site configuration contains the value of the <html lang="..."> attribute and should be set. Resolves: #84679 Releases: master Change-Id: Ia91fdffbb6bf9be884a0f7242ebb960d8ce17b5d Reviewed-on: https://review.typo3.org/56619 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Susanne Moog authored
Resolves: #84677 Releases: master Change-Id: I2d1887dd982e95e633755eed75f3bb0cdfe4d4ec Reviewed-on: https://review.typo3.org/56618 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Simon Gilli authored
This patch fixes some minor issues in getter methods. Resolves: #84670 Releases: master Change-Id: I4123238ca17bc3c3463090117b975997ea092a7e Reviewed-on: https://review.typo3.org/56610 Tested-by:
-
Oliver Hader authored
Using empty values for absRefPrefix as needle in strpos() will throw a warning. In order to avoid that, it's now checked more explicitly if the prefixed slash originally was absRefPrefix. Resolves: #84676 Releases: master Change-Id: I7515e8d283b2d68e39f7a0451432d453471088f0 Reviewed-on: https://review.typo3.org/56616 Tested-by:
-
Benni Mack authored
Resolves: #84678 Releases: master Change-Id: Ie4f338cc5ce6200319b407b9426442d3ae843942 Reviewed-on: https://review.typo3.org/56617 Reviewed-by:
-
Susanne Moog authored
- add void return types - add access modifiers for constants - fix some null coalescing - remove superfluous comments - add newline before namespace Resolves: #84662 Releases: master Change-Id: I1288b27b1edbd99b0624a66a5fb01cd02547b5ec Reviewed-on: https://review.typo3.org/56602 Tested-by:
-
Susanne Moog authored
Resolves: #84674 Releases: master Change-Id: Ia3283ffcf4973e5b511a57de25cb73490916e4d2 Reviewed-on: https://review.typo3.org/56614 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Mathias Schreiber authored
Resolves: #DOCS Releases: master Change-Id: I9644f255336076f09c2c570c981549a39846e776 Reviewed-on: https://review.typo3.org/56603 Tested-by:
-
Benjamin Kott authored
Resolves: #84675 Releases: master Change-Id: If8873b88bd5976729ac75b1ef876bdc9ccd2b6ae Reviewed-on: https://review.typo3.org/56615 Tested-by:
-
Mathias Schreiber authored
The page hierarchy is now properly displayed in the sites module Resolves: #84664 Releases: master Change-Id: Ib390c0322042e6ddf433576df42219eeb3377525 Reviewed-on: https://review.typo3.org/56605 Tested-by:
-
Tim Schreiner authored
Keep the value for the defined sorting field when a record is deleted. This improves the quality of restored records especially for tt_content records when a whole page is restored. This change might be breaking for functional tests in third-party extensions that rely on deleted records. Resolves: #84658 Releases: master Change-Id: I7714d73d07a8c78da56603230bde8ede6c02d8f4 Reviewed-on: https://review.typo3.org/56609 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
-
Georg Ringer authored
With issue #81280 a break statement has been added which breaks the check of permissons "extend to subpage". Resolves: #84293 Releases: master Change-Id: I2a2735a95bd933c4890e1cf829b0d9e5650dd63c Reviewed-on: https://review.typo3.org/56369 Reviewed-by:
-
- Apr 08, 2018
-
-
Susanne Moog authored
Let the adminpanel and redirect upgrade wizards make use of the abstract wizard for installing extensions, which includes handling composer based installations. Resolves: #84660 Releases: master Change-Id: Iab7f3ed44945362a315a7f4d32497c6a1c70d779 Reviewed-on: https://review.typo3.org/56559 Tested-by:
-
Susanne Moog authored
Due to different path handling, the path separators need to be streamlined before using the path. Windows can handle both / and \ but not in the same path. Resolves: #84661 Releases: master Change-Id: I138f0be68a9ffd017a840411bee92695b51e989d Reviewed-on: https://review.typo3.org/56601 Tested-by:
-
Susanne Moog authored
Resolves: #84649 Releases: master Change-Id: I98ec184e4b2d15d04515ba121babb470ac832882 Reviewed-on: https://review.typo3.org/56606 Reviewed-by:
-
- Apr 07, 2018
-
-
Simon Gilli authored
ServerRequestInterface->getQueryParams() returns as string value which has to be converted to an integer before passing it to Site->getLanguageById(). Resolves: #84652 Related: #84581 Releases: master Change-Id: Ibfdb2043aa5f6aee1e7e3cf92d752c7f399ef39b Reviewed-on: https://review.typo3.org/56599 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Helmut Hummel authored
Upgrade wizards that download extensions from TER must no do so in composer mode as they would create an unusable system. But in case the extension is found, in the system, these wizards still activate them. Resolves: #82318 Releases: master, 8.7 Change-Id: I5ad1fdfeb81ad809497d8a88db32325639cd236b Reviewed-on: https://review.typo3.org/56582 Reviewed-by:
Joshua Westerheide <account@jdoubleu.de> Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- Apr 06, 2018
-
-
Christian Kuhn authored
TYPO3 is famously known for the "multi-site" functionality, allowing multiple websites running within one TYPO3 instance. However, configuring a multi-site had various downsides, mostly regarding to domain/entrypoint handling for a site, and if lots of languages were in place. Concepts like "absRefPrefix", "baseURL", various language related TypoScript settings, and the infamous "L" GET parameter can now be seen obsolete. Also, handling page-not-found or access-denied errors have never been easier, as every admin/integrator is able to configure this. What TYPO3 calls a "site" is a entrypoint / pagetree, and contains both configuration values relevant for Backend and Frontend. A site configuration has a unique (human-readable) "site identifier" and the following additional values: * Root page ID This is a page on the root level (pid=0) or having "is_siteroot" checked. * The base path / base URL This HTTP entry point e.g. https://www.mydomain.com/ ("Base URL" / HTTP entry point, like https://www.mydomain.com/) -- This allows to fully identify a pagetree with an entrypoint without having to guess during "runtime". * The definition of all available languages for this pagetree, including the default language for this specific pagetree. -- This includes both values for backend-related as well as information, previously only settable via TypoScript. This way, it is possible to have a TYPO3 installation with 20 languages, but only using 5 languages within one pagetree (site), using 15 different languages in another site, while also giving meaning for all records within one site. A site configuration can be added or edited within the TYPO3 Backend in a new backend module for admins, and is then persisted in "typo3conf/sites/site-identifier/config.yaml". The configuration format yaml is chosen as it minimizes the risk of doing hacks, but the concept of a SiteConfiguration can be adapted / exchanged to be overloaded or found in various other places in the future. Adding a site configuration for a project has various benefits: - Configuration is in one place, stored in the file system thus, is deployable. - Configuration can be done by an integrator/admin without any programming skills => in one place. - The necessity to query sys_language is only needed when configuring a site. - No need to configure TSconfig options like "previewDomains" and "defaultLanguageLabel" are gone. is - No need to configure any TypoScript conditions, or even TypoScript settings related to language handling. - It is possible to configure error handling on a per-site level, even language-dependant, without having to code or configure anything. However, if no site is configured for a pagetree, the previous behaviour is still in place, allowing to migrate slowly to the sites handling, as some key functionality like URL path handling for speaking URLs is not in place yet. It is important to understand that adding a site configuration comes with various restrictions: - "sys_domain" handling is not necessary anymore, as a page is resolved via the domain+base URL given in the configuration - Any previously configured TypoScript conditions based on L parameter do not apply anymore if a site is configured - This also applies to any config.*language* related TypoScript setting. - It is necessary to use a URI with scheme and path to configure a site, where as previously, TYPO3 would work without a base URL. - mod_rewrite or something similar is a requirement for sites to work properly. Further improvements not yet implemented: - Ensure backend modules like Web->Page, Web->View, Web->List and Web->Info only show records in the configured site languages. - Enable the possibility to handle "domain entry aliases", also for multi-server setups with different domain names. - Ensure the new Site module can handle "read-only" / deployable site configurations. - Allow to activate a language for a site to be editable in the Backend but not be available in the Frontend for everybody. - Handling "Storage Folder" on the top level with different language entries. - Improve URL generation in frontend to skip sys_domain resolving. - TypoScript conditions for [site = my-identifier] and [siteLanguage = dk]. - Improve proper caching for rootline resolving of pages without restrictions. - Improve resolving of siteLanguage from the current request. - Linking from one site to a page of a different site. - Centralizing access to sys_language and sys_domain. - Handle copying/moving of records to a different site with different languages and language settings. - Handle configuration change (like deleting a language in the configuration - what should happen to the translated records?) Next up for 9.3: - Adding "Routers" on top of sites for URL resolving of pages and records. - Handle Storage Folders on top level rootline - Handle Mount Points New API: - New Entity classes "Site" and "SiteLanguage" are resolved as part of a PSR-15 middleware and available for pages in FE and BE when possible. - A SiteFinder object is used to query Site and SiteLanguage objects and used in various places. - The new PageUriBuilder allows to create links to pages without any relation to the current request, and are already in use in Frontend links and Backend preview links. - A PageErrorHandlerInterface allows to custom error handlers to be introduced by extensions and configured on any site. Site handling is considered still "under development" until TYPO3 9 LTS, and implementation as well as the configuration format might change in the next sprint releases, in order to gather feedback on what is missing in the implementation. As a site configuration will be mandatory for TYPO3 v10.0, some changes regarding sys_language and sys_domain will follow. Beware: - Due to the definition of every record of default language (language=0), it might be possible to switch to locales for languages and get rid of the language ID. - sys_domain won't make it any much longer. Resolves: #84581 Releases: master Change-Id: Iabeeb6835a98c8f5a71d502379ed63a68dfad6dd Reviewed-on: https://review.typo3.org/56505 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Susanne Moog authored
The admin panel has been extracted into an own extension. To enable users to de-activate the admin panel completely, the hard coupling between the extension and other parts of the core had to be resolved. With this change, the initialization of both adminPanel and feedit were moved into PSR-15 middlewares. Additionally all parameters related to the adminPanel were removed from the FrontendBackend- UserAuthentication. As feedit is tigthly coupled with the adminPanel some changes had to be made to its initialization, too. The flow of the adminPanel initialization and rendering were streamlined to allow modules to make use of the request object. Due to these changes in the control flow of the application the two existing tests were removed and new tests will be rewritten once the API is declared as stable. Releases: master Resolves: #84641 Change-Id: I72beefde0d792d3f4295c45aa27204c817d2de7a Reviewed-on: https://review.typo3.org/56558 Tested-by:
-
Frank Naegler authored
This patch change a icon to be consistent, the icon was misleading and had the wrong color. Now the „add“-icon is used instead of the „missing“-icon. Resolves: #84642 Releases: master Change-Id: I4563badbaab956798c9df58dce5e9e7f3c436c5a Reviewed-on: https://review.typo3.org/56580 Reviewed-by:
-
Andreas Fernandez authored
Any given attribute stored in the `P` parameter is kept and attached to the return URL of the upload form. Resolves: #83923 Releases: master, 8.7, 7.6 Change-Id: Id6ff93f0a30691f7bde84275128a34eb479499de Reviewed-on: https://review.typo3.org/56592 Tested-by:
Steffen Kamper <info@sk-typo3.de> Tested-by:
-
Frank Naegler authored
Resolves: #84600 Releases: master, 8.7, 7.6 Change-Id: I3f4698e892c98aadb41d3e6ba4f1e974a2ca479d Reviewed-on: https://review.typo3.org/56544 Tested-by:
-
Tim Schreiner authored
The MethodCallMatcher contains wrong argument definition for methods * TYPO3\CMS\Core\TypoScript\TemplateService->getFromMPmap * TYPO3\CMS\Core\TypoScript\TemplateService->initMPmap_create Resolves: #84648 Releases: master Change-Id: I31f68570efbbb9b6ba46e5aaccb90401cc3028fc Reviewed-on: https://review.typo3.org/56586 Tested-by:
-
Andreas Fernandez authored
This patch let's the Maintenance Area flush the `l10n` caches after language packs were downloaded. Since the Install Tool uses "hacked settings", we have to create a new instance of the `CacheManager` to be able to operate on the mentioned cache. The same handling can be seen in `ClearCacheService::clearAll()`. Resolves: #84645 Releases: master Change-Id: I221bd0d77f2991eac550316586002a8329bb36df Reviewed-on: https://review.typo3.org/56583 Tested-by:
-
Andreas Fernandez authored
The checkbox "Show hidden content elements" currently checks any selected language. This is malfunctioning in case the language "Default" is selected in the "Language" view, as it won't affect any translation. The patch now changes the handling to add the language constraint only if the view renders multiple languages and any language is selected, that is not the default language. Resolves: #84589 Resolves: #84573 Releases: master, 8.7 Change-Id: I572d594e5828d423e67a40481f44857df79ebae9 Reviewed-on: https://review.typo3.org/56532 Tested-by:
-
Joshua Westerheide authored
Change-Id: I10e4061dcb54dda3460d248bc7ae436ee12103a0 Resolves: #84636 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/56575 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Tim Schreiner <schreiner.tim@gmail.com> Tested-by:
-
Joshua Westerheide authored
Due to the appended extension key an invalid directory structure was created. The language pack ".zip" files already contain extension directories. Resolves: #84638 Releases: master Related: #84131 Change-Id: I19d4fa418a5c09a88fb814fb0780e122655a24b0 Reviewed-on: https://review.typo3.org/56577 Reviewed-by:
-
Benni Mack authored
The "mother of building all links in Frontend" is moved into PageLinkBuilder. Along with this, building a mountPointMap is moved into the PageLinkBuilder as well, as this is solely needed. Existing methods are deprecated: * TemplateService->linkData * TemplateService->getFromMPmap * TemplateService->initMPmap_create The existing hook is moved into PageLinkBuilder as well, so functionality like RealURL will work the same. Resolves: #84637 Releases: master Change-Id: I513bd721a77ed8959f3c8b4bfc4eaa25dd05eacc Reviewed-on: https://review.typo3.org/56576 Tested-by:
-
Wouter Wolters authored
Resolves: #84630 Releases: master, 8.7 Change-Id: Ie3af5ddd3721e546718cfa88ea219c40dc666e51 Reviewed-on: https://review.typo3.org/56555 Tested-by:
-
Mathias Brodala authored
This logic is already implemented in AbstractConditionViewHelper::renderStatic(). Resolves: #84627 Releases: master Change-Id: Iaf1fa4630fcc5df0ef22bec55d4fa15df1aa0986 Reviewed-on: https://review.typo3.org/56561 Tested-by:
-
- Apr 05, 2018
-
-
Nicole Cordes authored
To be able to improve the layout of field information, the span tag is added to the list of allowed tags in html. Resolves: #84633 Releases: master, 8.7 Change-Id: If3a60002cb8b7a7473e96820bdb35ac9c8111bab Reviewed-on: https://review.typo3.org/56573 Tested-by:
-
