- Mar 29, 2023
-
-
Wouter Wolters authored
This change updates the main TYPO3 code base vendor/ directory to lock to latest packages from our main dependencies, ready for the next v12.x release, so the "non-composer mode" has various updated dependencies shipped. Used commands: composer update "symfony/*" "doctrine/*" -W Resolves: #100322 Releases: main, 11.5 Change-Id: Ib483549b89115132ece28686e0f0dc5463a052a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78276 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Andreas Fernandez authored
If the document model in a ckeditor instance is changed, the changes are now immediately written back to the related source element and a `change` event is dispatched, recovering the modal window when closing the FormEngine. Resolves: #98717 Releases: main Change-Id: If605018a2c11e6448900639b2b8fd0fa5d0f4c2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78322 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Oliver Klee authored
Resolves: #100346 Releases: main Change-Id: Ib9f9113400bb69aee6e36f58596a98e1c7d0ac9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78318 Tested-by:
-
Torben Hansen authored
If the global password policy has been disabled and the backend password function is used, it is possible to submit an empty password, if the user manually removes the `required` attribute from the password fields in the password reset form. This change ensures, that an empty password will not be accepted by the backend password reset function. Resolves: #100295 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I20f6fa7f81650964e38e9b2bbb436cf3e06dbf16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78324 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
The change in #100342 was not complete and might lead to exceptions when a regular route name not matching a module is passed as the start module, e.g. when reloading the browser while EditDocumentController is open. This is now guarded by a check whether whatever is coming in is an actual registered module before attempting to resolve potential module aliases. Resolves: #100352 Related: #100342 Releases: main Change-Id: I71805b147df3eb9421d0fce36940dd3873edef4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78326 Tested-by:
-
Andreas Fernandez authored
FormEngine's date picker now uses the document's HTML `lang` attribute to determine its language to use. Resolves: #99768 Releases: main Change-Id: I03474cd521c154885db23efedc6b19a7304b14f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78313 Tested-by:
Henrik Ziegenhain <henrik@ziegenhain.me>
-
Oliver Klee authored
Add some type casts that are necessary in order to make the internal Extbase classes strict. Also complete some incomplete (and hence incorrect) return type annotations. Resolves: #100347 Relates: #100346 Releases: main Change-Id: I76e1a21c0ed122e3e017eea52d9e50f0651f5d51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78319 Tested-by:
-
Andreas Fernandez authored
If BE_USER->uc['startModule'] is a "legacy" alias value, resolving the start module in the BackendController fails, leading to a recursively rendered backend. The ModuleProvider API is now used to resolve the according backend module and using its original module name. Resolves: #100342 Releases: main Change-Id: Ia00e989530f153cff4d3328a99e615733c6395c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78314 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
The two TypoScript related condition functions "loginUser()" and "usergroup()" are rather old school and suffer from being imprecise since they don't differentiate between frontend and backend users. They can be switched to variables "frontend.user" and "backend.user" pretty easily, especially with feature #93591 being available since v11. The patch deprecates these conditions and adds a .rst file outlining 1:1 transition examples. Resolves: #100349 Related: #93591 Releases: main Change-Id: Ifeb146fe63f4a4a1b7702117ab48de8ac5bd1af1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78320 Tested-by:
-
Benni Mack authored
When having a % in the format, the strftime() method should be used from the DateFormatter. Resolves: #100350 Related: #95872 Releases: main Change-Id: I376382c22e11cef4e826c3cefcf114abbf6034f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78323 Tested-by:
-
Christian Eßl authored
Improve the performance of FileStorageTreeProvider significantly by avoiding fetching the parent and children folders multiple times. In tests with ~6000 folders, this roughly halves the number of reading operations on the filesystem and reduces the time required for rendering the tree structure from ~9 seconds to ~4.5 seconds. Resolves: #100230 Releases: main Change-Id: Id32b38e48bd7ad052a79bd36d4c46271c807b100 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78183 Reviewed-by:
-
Andreas Fernandez authored
Within `.form-group`, the elements `.panel` and `.panel-group` get a visible overflow applied to not cut off FormEngine wizards, e.g. color pickers. Resolves: #99815 Releases: main, 11.5 Change-Id: I088ef82f2503152c1fd457362bf95f3f799754b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78312 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Alexander Schnitzler authored
During the removal of the ObjectManager (Extbase), the way the DataMapper instantiates entities when thawing objects, i.e. fetching a database row and transform it back into an entity object, changed. doctrine/instantiator had been used to create empty objects, i.e. creating objects without calling their constructor. Now, entities with constructors cannot be thawed any longer. To bring back this way of working (which existed for as long as Extbase itself does), doctrine/instantiator is brought back and used. > composer req doctrine/instantiator:^2.0 Releases: main Resolves: #100207 Related: #96208 Change-Id: Iabaddb2a027ea208c0eee75c26ea53f36e7e3285 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78051 Reviewed-by:
Daniel Goerz <daniel.goerz@b13.com> Tested-by:
-
Nikita Hovratov authored
Only the table "tt_content" overrides the label for the sys_language_uid field on palette level with "EXT:frontend/.../locallang_ttc.xlf:sys_language_uid_formlabel". However, this label is exactly the same as "EXT:core/.../locallang_general.xlf:LGL.language". Therefore, the first mentioned label is removed in favour of the original one. Note: The second label was probably introduced in 2010 when the original field contained "Language:" (with colons at the end). This has been removed in the meantime. See commit: b6fb9732 Resolves: #100344 Releases: main Change-Id: I8285cf95b9c0b9bd583bb6a6d63c9d29db7e3467 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78316 Tested-by:
-
Peter Kraume authored
The redirects backend module should have precedence before the Page TSConfig and the TypoScript module. Resolves: #100340 Releases: main Change-Id: I7f0c56c59b9f7b6ac3d850087b6764a7ac1eb3be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78309 Reviewed-by:
-
- Mar 28, 2023
-
-
Josef Glatz authored
Releases: main, 11.5 Resolves: #100339 Change-Id: I4b24fdced525703367da88981d8d9996e14fda9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78307 Tested-by:
-
Oliver Klee authored
Add type declarations to help static code analysis and to improve code readability. Resolves: #100328 Releases: main Change-Id: Ic7ef004fea08e6e4210b271ecedd1f04372501ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78280 Tested-by:
-
Tobias Gaertner authored
There are several checks related to array key '_CURRENT_VERSION' on versioned records. Since PHP 8 those checks are not safe anymore and can result in errors. Releases: main, 11.5 Resolves: #100336 Change-Id: I8b5a956a987a3d8c9690e824e0fccfd6570e0069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78301 Reviewed-by:
-
Oliver Klee authored
- use first-class callables - add type declarations Resolves: #100326 Releases: main Change-Id: I258fb22ea32fe7fe6deac1014b18ea3f9ae68821 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78279 Tested-by:
-
Chris Müller authored
Resolves: #100331 Related: #96147 Related: #99746 Related: #99802 Related: #99803 Related: #99834 Releases: main Change-Id: Icf6df514510dc3bd45fc824b15085963bda42fe2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78295 Reviewed-by:
-
Christian Kuhn authored
"True" MM relations (intermediata table with uid_local and uid_foreign columns, and no TCA for this table) are still hard to configure in TYPO3. One reason is the amount of TCA config options: It's often not clear to developers which ones need to be set, and which ones are optional or useless. One of the 'useless' options is MM_insert_fields: It allows setting a column in the intermediate table to a configured value. Intermediate tables are transparent in TYPO3: They are fully managed by the system, there is not way to edit them within the framework. As such, having an additional column within intermediate tables that carry some value, is useless. Looking at usages within extensions of MM_insert_fields, it turns out developers typically confuse it with MM_match_fields (this config is a story on its own). Developers simply tend to set both MM_insert_fields and MM_match_fields to the same value "to be sure". The patch deprecates MM_insert_fields without substitution in v12. TYPO3 v13 will actively remove this config option from TCA. Resolves: #100335 Releases: main Change-Id: I7832321fb3bcbfc00bb6f288c6f0cd5ceb41dc64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78297 Reviewed-by:
-
Sebastian Klein authored
The content element "Section index of subpages from selected pages" now also respects the setting "Show in Section Menus". Resolves: #100262 Releases: main, 11.5 Change-Id: I92c52cd48c0732410ded00c508fdd16633d67035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78218 Tested-by:
-
Chris Müller authored
Resolves: #100332 Releases: main Change-Id: I10bf6b31ff0eba3bdce69b0c512836c77a269baf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78296 Tested-by:
-
Benni Mack authored
Change-Id: I890274b2574c6af78b9406df0f89557ba7998425 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78293 Tested-by:
-
Benni Mack authored
Change-Id: I4ee75d7c8f3c5a24f43fa0c0b04ce0762dfc77c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78292 Reviewed-by:
-
Andreas Nedbal authored
This feature adds the CKEditor Inspector to backend RTE forms in Development context with $GLOBALS['TYPO3_CONF_VARS']['BE']['debug'] or the CKEditor configuration `editor.config.debug` being set. The Inspector aids plugin developers in debugging the intermediate CKEditor model. Resolves: #100284 Releases: main Change-Id: Ie18cd6c0b9854304fd3cbea521f5a434d4520a0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78243 Reviewed-by:
-
- Mar 27, 2023
-
-
Christian Kuhn authored
phpunit ^10 expects test data providers to be static. Using rector rule StaticDataProviderClassMethodRector, this bulk change adapts most of them in typo3/sysext/*/Tests/Functional. A couple of data providers use $this, those are left out for now and need to be adapted with dedicated patches since they need more refactoring. Resolves: #100325 Related: #100264 Related: #100249 Releases: main Change-Id: I0ad91f00e04b0a658976a584c697bf0465c094ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78281 Tested-by:
-
Wouter Wolters authored
To prevent issues when upgrading to Symfony 6.3.x-dev the return type of TextDescriptor::describeApplication is changed to void. Releases: main Resolves: #100324 Change-Id: I4663202abda3ef49287306bde0125af223d1b026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78278 Reviewed-by:
-
Stefan Bürk authored
With #99629 outgoing webhooks has been implemented. This also provide a simple way to create custom webhook messages for any PSR-14 event. Therefore, the `RedirectWasHit` event can be used to provide an additional webhook type and showcase the needed steps to add this for a core PSR-14 event. This change provides a webhook message for the already existing PSR-14 `RedirectWasHitEvent` of `ext:redirects`. Resolves: #100305 Related: #99629 Releases: main Change-Id: If63a665571402f9491c8a576516ec25080e7c31c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78261 Tested-by:
-
Christian Kuhn authored
setMethodsExcept() on mocks has been removed with phpunit 10. There are three usages in one test case, those can be converted to onlyMethods() easily. Resolves: #100323 Related: #100249 Releases: main Change-Id: Ifa2a992971727e5deed8e32a2b33a71dbb6efb99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78277 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Jasmina Ließmann authored
Some specific TYPO3 terms have a special spelling. Therefore update the spelling from "PageTsConfig" to "page TSconfig" and "UserTsConfig" to "user TSconfig" as once defined here: https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/GeneralConventions/Glossary.html Resolves: #99856 Releases: main Change-Id: I37d280a8c8a35bf8737eb2f694f1101fb8645783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77725 Reviewed-by:
-
Torben Hansen authored
A new PSR-14 event `EnrichPasswordValidationContextDataEvent` is introduced to allow extension authors to enrich the `ContextData` DTO before a password is validated against a password policy. Additionally, the `ContextData` DTO in the `PasswordReset` class now includes the backend user username and realName attribute, which can be used in custom password policy validators. Resolves: #100294 Releases: main Signed-off-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Oliver Klee authored
see https://www.php.net/manual/en/functions.first_class_callable_syntax.php Resolves: #100315 Releases: main Change-Id: Ib915e7329d2a803dca241f533e0297c4cd13e204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78270 Reviewed-by:
-
Oliver Klee authored
This improves both code readability as well as type safety in the tests. Resolves: #100313 Releases: main Change-Id: Ib647d5107f48564e847e8c6a9444ae25f83175e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78268 Tested-by:
-
Oliver Klee authored
- use parameter and return type declarations - use the same parameter names as in the mocked method - drop useless `self::anything()` calls - drop `self::isType()` calls that duplicate the native type declarations This improves code readability and type safety in the tests. Resolves: #100314 Releases: main Change-Id: Icc572eb327b09b05f8637a7d91eb7bc7188344be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78269 Tested-by:
-
Benni Mack authored
The list module shows the dropdown of possible translations now in the same automatic width (instead of the full width) - the same way as in page module. Resolves: #100306 Releases: main Change-Id: I94dfd93f2d94a73b90a839183590da613af0cf84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78262 Reviewed-by:
-
Christian Kuhn authored
* Static DP * Avoid withConsecutive() - kinda useless in this case anyways * Don't use $this in DP Resolves: #100320 Related: #100249 Releases: main Change-Id: Ia1fbdf1152786037f5bb9c9295ed3f57491000d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78274 Tested-by:
-
Christian Kuhn authored
phpunit 10 expects files that end with Test.php to contain tests. Two fixture files are renamed since phpunit detects them as test cases, but they are not. Resolves: #100321 Related: #100249 Releases: main Change-Id: Icdf0cc44328c7687544e90c612128b1db2ea48fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78275 Tested-by:
-
Alexander Schnitzler authored
Releases: main Resolves: #100283 Change-Id: I9281b4d8b276fda9628a4fbac085ca7b82ebf95f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78240 Reviewed-by:
-
Benni Mack authored
A new TypoScript cObject "EXTBASEPLUGIN" is added for Extbase plugins to allow Extbase authors to not reference the Extbase Bootstrap class anymore. This way, newcomers do not have to worry about running defining USER/USER_INT things, which is not relevant for them. As most existing users use the API, it does not matter much, except for places. In the future, Extbase logic can / should be moved to the Extbase Plugin Content Object, while removing the dependency on the ConfigurationManager and the cacheable actions from the Bootstrap and RequestBuilder classes. At the current point, this is very much convenience and helps to further document to distinguish between Plugins (= PHP code) and regular Content Types. Resolves: #100293 Releases: main Change-Id: Ia3a7cceddd9f93dc606c3194828d26bed5a8f2b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76517 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
