- Feb 06, 2024
-
-
Dimitri König authored
There have been quite a lot of patches around the pagelayout condition, which was introduced in early TYPO3 v11. It was broken in the beginning and got fixed with #98044. Soon after, a major refactoring of the ConditionMatcher has been applied with #100047, which re-introduced bugs regarding the pagelayout TypoScript condition. These have partially fixed with #100764 and #100921. The affected code is a bit messy due to a weird sorted array returned by the 'rootline' methods and classes, which we can't resolve right now. The fix itself revolves a last issue by reversing the rootline again. This was already done in the old backend ConditionMatcher. The frontend ConditionMatcher received the fullRootline, which is already reversed (deepest first). With the introduction of IncludeTreeConditionMatcherVisitor this has been unified, but the array_reverse was forgotten. In addition, the fullRootline from the frontend controller and BackendUtility::getPagesTSconfig() calls are sorted with `ksort` before passed over, meaning we always receive a top-down (root-first) rootline. Hence, the array_reverse is a viable fix for both backend and frontend. The patch covers BE pageTS, FE TypoScript and FE getData with tests to cover the situation once and for all. Resolves: #102268 Related: #100047 Related: #100764 Related: #100921 Related: #98044 Related: #97816 Releases: main, 12.4 Change-Id: Ibec77f3cf63073e40e4a711d69f584b9265b1ad6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Andreas Kienast authored
Resolves: #103055 Releases: main, 12.4 Change-Id: If1c9f1dee8952faba5ed65bf54770a51aefdd37d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82812 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Feb 05, 2024
-
-
Andreas Kienast authored
The version was outdated and is removed as it is not needed, since there is no intent to publish the build-folder as-is on npmjs. Resolves: #103039 Releases: main, 12.4 Change-Id: I799e03b00caefea946fb9700a6863ae325551f90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82782 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Stefan Bürk authored
To give extensions the ability to change the expected database schema, adding or changing columns of existing TYPO3 Core tables or other extension tables, `ext_tables.sql` of extension are read and taken as partial table definitions. All table definitions are merged at a later point in the `ConnectionMigrator`, forcing proper handling of partial table information. This change moves the table definition merge process from the `ConnectionMigrator` to the `SchemaMigrator` at the earliest possible place to pave the way for further code cleanups. Resolves: #103015 Related: #103014 Releases: main Change-Id: I7f5bfa6f438604ca6295f20eb85fb9e24a44189a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82758 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Bartsch authored
The element browsers, such as file browser, folder browser or the create folder browser are rendering the FileList in the `browse` mode. In this case the context menu component is not loaded. This is correct, since using the context menu inside the modal would lead to various side effects. Because the JS component is not loaded for mentioned reasons, wrapping the icons with the click menu needs to be omitted. This otherwise leads to further side effect, e.g. loading a second folder tree in the create folder browser. Therefore, this change now omits wrapping the icon with then click menu when the Filelist is used in the `browse` mode. Resolves: #103001 Releases: main, 12.4 Change-Id: Ifd4daf5487b5dd9c74553d48cd0c2270b2c4f58b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82755 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Stefan Bürk authored
This change adds further MySQL Server versions to the `Build/Scripts/runTests.sh` to allow executing local functional and acceptance tests with these version. Added versions: - MySQL 8.1 - MySQL 8.2 - MySQL 8.3 Resolves: #103030 Releases: main, 12.4, 11.5 Change-Id: I578ed524560ae1907ab8a79df7694470f9aa234a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82777 Tested-by:
-
Simon Praetorius authored
This patch should cover all of the arguments and variants both <f:image /> and <f:uri.image /> offer to generate images in Fluid templates. Resolves: #103013 Releases: main Change-Id: Ibf55b785d74d076edef121ac2f43e862677acdd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82757 Tested-by:
-
- Feb 04, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save \ @lit/reactive-element@^2.0.4 \ lit@^3.1.2 \ lit-element@^4.0.4 \ lit-html@^3.1.2 npm run build Resolves: #103024 Releases: main, 12.4 Change-Id: Iec49465ce10b9da4cd2a05bcc13c09dd49508ef0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82768 Tested-by:
-
- Feb 03, 2024
-
-
Stefan Bürk authored
Doctrine DBAL released the stable version for the next major version, v4.0.0. [1] This change upgrades to the stable version and ends the usage of the release candidate as intermediate solution. Stability workaround for the distribution test composer.json is removed. > \ composer req --no-update --no-install \ -d typo3/sysext/redirects \ "doctrine/dbal":"^4.0" ; \ composer req --no-update --no-install \ -d typo3/sysext/core \ "doctrine/dbal":"^4.0" ; \ composer req --no-update --no-install \ -d typo3/sysext/install \ "doctrine/dbal":"^4.0" ; \ composer req -W \ "doctrine/dbal":"^4.0" > COMPOSER=composer.dist.json composer rem --no-update \ -d Build/composer "doctrine/dbal" [1] https://github.com/doctrine/dbal/releases/tag/4.0.0 Resolves: #103029 Related: #102875 Releases: main Change-Id: I36986769273822473a6ee9133af19c0c253b64e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82776 Tested-by:Oliver Wand <wand@itaw.de>
-
Stefan Bürk authored
TYPO3 uses a composer package [1] to import locales along with translations and a custom script has been added to create and update included translation files. This change updates the language files with the last updates and requires the package with the current highest version as minimum. Used command(s): > composer req --dev \ "sokil/php-isocodes-db-i18n":"^4.0.19" > php Build/Scripts/updateIsoDatabase.php [1] sokil/php-isocodes-db-i18n Resolves: #103027 Related: #100659 Releases: main, 12.4 Change-Id: I2839113ed3894cec58b41c85abd59039cab00725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82773 Tested-by:Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Stefan Bürk authored
The `Symfony\Component\Translation\Dumper\XliffFileDumper` is extended to add processing workflowes needed to update the xliff files based on the ISO Database with `Build/Scripts/updateIsoDatabase.php`. Symfony 7 added method types and return types, and therefore the extended method `dump()` needs a compatible return type. The corresponding `:void` return type is added now. Resolves: #103026 Releases: main, 12.4 Change-Id: Id39dbbab9cccffc0b0900267bdc411187623f6fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82772 Reviewed-by:
-
Jochen Roth authored
Currently, having a inlineLanguageLabelFiles defined without passing any additional config leads to an undefined key warning. This has been fixed by adding a fallback to an empty array. Resolves: #103020 Releases: main Change-Id: I4234a8efe5d33ee53afebbfe8d4fc36859b032ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82762 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Feb 02, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save \ @codemirror/autocomplete@^6.12.0 \ @codemirror/lang-html@^6.4.8 \ @codemirror/language@^6.10.1 \ @codemirror/lint@^6.5.0 \ @codemirror/view@^6.23.1 \ @lezer/common@^1.2.1 \ @lezer/lr@^1.4.0 npm run build Resolves: #103023 Releases: main, 12.4 Change-Id: I4b21ebc335f3bc3483a957e0c6c48d62e0e4f622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82765 Reviewed-by: -
Albrecht Köhnlein authored
The methods `logicalAnd()` and `logicalOr()` allow any number of constraints as parameters. The outdated PHPdoc comment still said "two". Resolves: #103007 Releases: main, 12.4 Change-Id: I582eb3f1c17fb3149a49a15649469794ce386149 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82753 Tested-by:
-
Stefan Bürk authored
The `Build/Scripts/runTests.sh` supports `podman` and `docker` as container cli binary since quite a while now, albeit docker has been kept as default if not specified using `-b`. This change removes the hard default and will now use `podman` as default. In case `podman` is not available `docker` is used. As a side-effect, the binary for CI is no longer enforced the hard way. PostgreSQL 16 is added as database version. Resolves: #103018 Releases: main, 12.4, 11.5 Change-Id: Iedcd7cbcd2380adb6781bd8b4f075da86e25c03b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82761 Tested-by:
-
- Feb 01, 2024
-
-
Oliver Bartsch authored
There is no valid reason to force a minimum amount of 5 records to be displayed in the list view. Therefore, the range is reset to 0 - 10000, as it was before #92103. Resolves: #103011 Related: #92103 Releases: main, 12.4 Change-Id: Icd22e6a77dc554774dcde6a6a3dc3c2a799d2d7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82759 Reviewed-by:
Christian Weiske <typo3-2022@cweiske.de> Tested-by:
-
Albrecht Köhnlein authored
In case modules do not provide a "shortDescription" the module card is now rendered without title in the "About" module Resolves: #103005 Releases: main, 12.4 Change-Id: Ic383df283eb7c3e3e175862f808ea731531ccfff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82752 Tested-by:
-
- Jan 31, 2024
-
-
Peter Kraume authored
Resolves: #102999 Related: #98545 Releases: main Change-Id: I0d8b4f6d05cf77dee49265912029b8257e7b92e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82727 Reviewed-by:
-
Stefan Bürk authored
The first argument after processing defined options has been stored into the variable `TEST_FILE`. This value was passed to PHPUnit based commands as last argument, defining the test case to execute (or a subset). Removing this workaround and directly passing remaining options to the command makes special arguments like `-e` obsolete and unblocks more generic command passing. This change removes this variable and passes all remaining arguments after option processing directly to the PHPUnit command and paves the way for future command improvements. Note: This makes the `-e` option basically obsolete, but is kept for now to minimize muscle memory issues. Using it will display a `deprecation` notice at the end of the script - so it gets recognized. Resolves: #102769 Releases: main, 12.4, 11.5 Change-Id: I9a85206330a7e1b58d81dc5a2c97a13831af29a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82360 Reviewed-by: -
Benjamin Franzke authored
This reverts commit dba95382. Reason for revert: * The close button has tabIndex -1 so no aria-label is needed. Note: aria-label would have been useful in combination with #102372, but that patch was reverted as well, because with think a clearing button is not needed for keyboard users that use keyboard shortcuts anyway. * The patch introduced new inline JavaScript which we want to avoid, also writing into TYPO3.lang directly via inline JavaScript is not ideal. Releases: main Resolves: #102998 Reverts: #102524 Related: #102372 Change-Id: I0f2fed9b56484697ddb97fee1a905c83fbc49107 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82736 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
-
Willi Wehmeier authored
Add a title and aria-label to the clear input button added on all input fields with the class t3js-clearable. Resolves: #102524 Releases: main, 12.4 Change-Id: I10b2829b259779ac72abb939ddcfd4ea2e899bc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81972 Reviewed-by:
Christian Rath-Ulrich <christian@rath-ulrich.de> Tested-by:
-
Oliver Bartsch authored
To prevent PHP from encoding the numeric keys of the available languages as string, which would lead to JavaScript errors, `array_values` is now applied to the filtered list of languages. This resets the keys and therefore ensures a continuous numeric sequence starting from 0. Reference: https://www.php.net/manual/en/function.json-encode.php#refsect1-function.json-encode-notes Resolves: #102911 Releases: main, 12.4 Change-Id: Ieca55dd815d1389f44823b252df8da75196d0fdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82720 Reviewed-by:
-
Oliver Bartsch authored
The element browser string (bparams), forwarding different information between states is using the pipe ("|") character as separator. With #101231, this string got extended by also respecting a "disallowed" file extension list, next to the "allowed" list. Since this information is stored as one part, an additional separator ";" was introduced. However, this character now leads to problems, depending on the used environment (see linked references). To circumvent this, the separator is changed to the "~" character for now, as this is not a reserved character, according to RFC3986. In the long run, this string should anyways be replaced by a more robust solution. * https://github.com/traefik/traefik/issues/9164 * https://github.com/symfony/symfony/pull/51709 * https://datatracker.ietf.org/doc/html/rfc3986#section-2.2 Resolves: #102992 Related: #101231 Releases: main, 12.4 Change-Id: I05e3548305d7ff50bd6db94fd2236aba95e80edb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82716 Tested-by: -
Sascha Nowak authored
When fetching a lot of records from database the memory is nearly doubled in the fetchAll function. It seems php keeps references or creates an array copy that could not be garbage collected. Enforcing a manuell gc_collect_cycles does not help either. Resolves: #102986 Releases: main, 12.4, 11.5 Change-Id: I2da5f1e0126aa1dc867c8fb3074be4a11491f8f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82700 Tested-by:
-
Chris Müller authored
The index file in its current state does not has any value to the user. Mostly numbers are displayed as reference. Resolves: #102996 Releases: main, 12.4 Change-Id: I6a4c52e5c295bb27f5fd85045f2c3f9451bea1e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82722 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Jan 30, 2024
-
-
Benjamin Franzke authored
Releases: main Resolves: #102994 Related: #102959 Change-Id: I9fbb13d333cf9a773d5cfa3742d693595f694aec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82717 Tested-by:
-
Oliver Bartsch authored
There might be no comma in front of an extension scanner tag. This should not lead to an error as it's unrelated for this check and will already be catched by the "validateLastLine" check. Resolves: #102987 Releases: main, 12.4, 11.5 Change-Id: Icda7cbb1b01ced39ee80311e15bccdfd9318b953 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82701 Tested-by:
-
linawolf authored
Merge right after the 13.0 release. Resolves: #102988 Releases: main Change-Id: Icbd2ffae07b15901ec8a0e3678805995bd4305c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82702 Tested-by:
Chris Müller <typo3@krue.ml>
-
Benni Mack authored
Change-Id: I6ac434754d0963e4d1d4cdf7f7536cc9d717c0ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82714 Reviewed-by:
-
Benni Mack authored
Change-Id: I4da133935b36f216ba4a621cda058b2c0da588ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82713 Tested-by:
-
Nikita Hovratov authored
A new event listener for the ModifyContentElementWizardItem Event is added to check for `list_type` items. If no list types are defined, the related wizard item `plugins_list` is removed from the wizard as it has no functionality alone. Resolves: #102989 Related: #102985 Releases: main Change-Id: I178c4cb779dadab29dba833beb6ff23a7ab90d49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82703 Reviewed-by:
-
Oliver Bartsch authored
This patch prevents empty categories in the wizard and prevents an undefined array key warning. Resolves: #102990 Releases: main, 12.4 Change-Id: Iec69d1d3e3df66d9a054dfe382afe3d282fec332 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82704 Reviewed-by:
-
- Jan 29, 2024
-
-
Benni Mack authored
This change moves indexed search to the proper CType level in order to avoid using 'list' for plugins as well, similar to felogin. An upgrade wizard is in place, migrating existing records as well as corresponding backend user group permissions. Resolves: #102985 Releases: main Change-Id: I7061f26a1c4efaf9dcc57e0dfc91c64d360953f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82665 Tested-by:
-
Chris Müller authored
Resolves: #102905 Releases: main Change-Id: I0cfd33a4c938bdc9c5fc4bb08f541736e97ecf42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82604 Tested-by:
-
Andreas Kienast authored
This commit replaces the `reasons` property in Indexed Search's `Indexer` class with a more descriptive `IndexStatus` enum. Resolves: #102955 Releases: main Change-Id: I56bbdce8f525f539142b0891e4e10e51f8d78e6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82670 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Nikita Hovratov authored
There are two identical labels for the FormEngine general tab. This is the default tab, if no first tab is defined explicitly. Use the more specific version in Form/locallang_tabs.xlf and drop the other label bundled randomly into locallang_core.xlf. Resolves: #102983 Releases: main Change-Id: Id55f20b4a93349815a48c3feb7c445acb3588f1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82697 Reviewed-by:
-
Benni Mack authored
With #100759, f:translate has been changed to use the extbase LocalizationUtility in all scopes. This triggers the ConfigurationManager, which fetches TypoScript setup from the Request attribute. But TS setup is never set in fully cached page content scenarios and there is usually no Fluid view triggered in this scope. The admin panel however renders in "fully cached" as well, which then fails when trying to fetch TS setup. We *do* want extbase to fail in this scenario, since TS is important for extbase configuration and it needs to rely on TS setup being set in Frontend. The patch thus works around the issue in admin panel directly. The situation should resolve later again, when work on LocalizationUtility finished. Resolves: #102638 Related: #100759 Releases: main, 12.4 Change-Id: I5cf8af6593f37299e71b8555b79bf05c0e5e9c09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82396 Reviewed-by:
-
Simon Praetorius authored
Fluid 2.10.0 introduced a regression concerning the handling of local and global variables, which was fixed with 2.10.1. Executed command: composer req typo3fluid/fluid:^2.10.1 Resolves: #102984 Releases: main Change-Id: Ica56338d520b3a10d12bb94e2fb8e4d41ee5cef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82698 Reviewed-by:
-
Christian Kuhn authored
typo3/testing-framework no longer loads EXT:install in functional tests by default. The patch adapts a couple of tests to cope with this. Note core will continue to refactor in this area after 13.0: It for instance needs to be sorted out if the upgrade wizard infrastructure should be moved to EXT:core. For this reason, no full communication happened in this area, yet. > composer u typo3/testing-framework Resolves: #102982 Releses: main Change-Id: Id786a2f16d336b6e9d80519e7f944d560f61d8bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82695 Tested-by:
-
Oliver Bartsch authored
In case no replacement has been done, e.g. due to an already modified version, don't update the server configuration file, since this might lead to an endless loop. Resolves: #102977 Releases: main Change-Id: If5cc0d33450c5b14b9f2e9ab1aec958ec02420ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82693 Reviewed-by:
-
