- Nov 26, 2016
-
-
Wouter Wolters authored
addCssInlineBlock is called with 5 parameters instead of 4 in PageGenerator. We can safely remove the 5th argument. Fixed two typos too. Resolves: #78785 Releases: master Change-Id: I468345b6792e7103a68858d9d7b59e657d94023a Reviewed-on: https://review.typo3.org/50770 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Nov 22, 2016
-
-
Benni Mack authored
Directory names, which have an invalid UTF encoding, cause the preg_match() to return false. To avoid that the complete statement in GeneralUtility::validPathStr() returns true in this case, a strict comparison against 0 is added, so that we ensure that strings with invalid encodings are rejected by this API method. As a consequence UTF-16 encoded path names are rejected as well, if the system / file system does not support them. Resolves: #73453 Releases: master, 8.4, 7.6, 6.2 Security-Commit: c54aa56d18815aa1867ec54358ad419ea03ec205 Security-Bulletins: TYPO3-CORE-SA-2016-023, 024 Change-Id: Iedd6628050d8cdf2efe429bcd7b577f5a6d11805 Reviewed-on: https://review.typo3.org/50744 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Nov 20, 2016
-
-
Benjamin Franzke authored
The seachword input field has appended. It's not clear why that was ever needed. But it's kinda useless and requires quite some css hacks to hide that, if the label and input field are inlined. Change-Id: I0387e46c2b0e9f8ae2e9a174cf042b6d4972f18b Releases: master, 7.6 Resolves: #78727 Reviewed-on: https://review.typo3.org/50685 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Anja Leichsenring authored
Preciding whitespace in the xml input string causes xml2array() to fail with an error message. This whitespace is often introduced by formatting code via IDE, so blaming the developer only helps so far. Inserting a trim() before the input is processed mitigates the problem. Resolves: #78752 Releases: master, 7.6 Change-Id: I3b9d3c81b64d502e7cefef80e72bef3a1bd9b3da Reviewed-on: https://review.typo3.org/50716 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
-
Claus Due authored
This change makes the clear cache toolbar item dynamically either render a drop-down as it did before, or render a single link directly if there is only a single clear cache action. If any hooks or permissions add additional items the drop- down is rendered again. Change-Id: Iadac80405bf1152a849d4d4269a9bc0728b0b459 Releases: master Resolves: #78656 Reviewed-on: https://review.typo3.org/50594 Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
Benni Mack authored
Instead of calling / setting properties from the outside, the backend user constructor can set options like lockIP centralized. This way, certain implementations from third-party extensions can just instantiate the object. Resolves: #78660 Releases: master Change-Id: If43ca2533968b54c842cbe01531fc6c33ee5352c Reviewed-on: https://review.typo3.org/50596 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
-
- Nov 18, 2016
-
-
Georg Ringer authored
Provide a title in the backend as well for the user dropdown Furthermore an empty module section is prevented. Resolves: #78475 Releases: master Change-Id: Ie1fd96c345a9bde2c2bc3c7f3248cf56e40729a7 Reviewed-on: https://review.typo3.org/50407 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Markus Klein authored
This allows to configure the ordering cirteria for suggest wizard search results. Resolves: #78523 Releases: master Change-Id: I4bbcbeab765b037ba3b3457a2bc9ca3323f95f59 Reviewed-on: https://review.typo3.org/50460 Tested-by:
-
Alexander Opitz authored
Show sessionTimeout as integer. Resolves: #78692 Releases: master Change-Id: Ia8bb8fa48018a3c9df5791ad8b2081e20f2b0211 Reviewed-on: https://review.typo3.org/50651 Tested-by:
Thomas Mayer <thomas.mayer@2bis10.de> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Benjamin Franzke authored
Commit 84ab4133 (https://review.typo3.org/49416) fixed the origin parameter to include the full host (and thus the scheme). The full host url was not urlencoded. As the scheme contains slashes this has to be encoded as well. Change-Id: Ifb73dfc11ef723049729e0475eb6ac234db6a3eb Releases: master, 7.6 Resolves: #78728 Reviewed-on: https://review.typo3.org/50686 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Benni Mack authored
The getRootline() method of ExtendedTemplateService is broken because of an incomplete replacement of the web_ts changes. See https://review.typo3.org/#/c/50626/ The fix replaces the rootline variable in the last occurence by the correct replacement. Related: #78675 Resolves: #76545 Releases: master Change-Id: Ib554679fd86230e183801e9b234a8138d4518cd3 Reviewed-on: https://review.typo3.org/50695 Tested-by:
-
Claus Due authored
This patch fixes a regression after https://review.typo3.org/#/c/50590/ which unfortunately caused some custom implementations (e.g. static info tables extension) to fail with a PHP fatal error. Change-Id: I61f7327208e20a973471fbfed02fe83c00d3995c Resolves: #78746 Releases: master Reviewed-on: https://review.typo3.org/50708 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Anja Leichsenring authored
If an invalid extension name is passed to a 'EXT:...' path, the GeneralUtility::getFileAbsFileName function returns an empty string. This results in a scan of '\' in the first place, and the resulting error is not helpful for finding the source of the missing icons in the TCA select box. A check for a valid directory name and an exception in case of failure will help the situation. Resolves: #78737 Releases: master, 7.6 Change-Id: I9d5159eac9b511e879144789eecb40eafcc0288c Reviewed-on: https://review.typo3.org/50699 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Christian Kuhn authored
The patch refactors the TCA tree form engine data calculation. The tree now works with "new" (not yet persisted) records, even if the record has types in combination with flex forms. For instance, a new ext:news tt_content element now renders the category tree within flex forms, even in new tt_content records that have not been saved. The TCA tree no longer fetches all items when opening a record initially, but defers that to the ajax request. This gives a massive performance improvement on initial load of a record if the displayed TCA tree is bigger. The ajax request itself now compiles only data of the requested TCA field, also resulting in a significant performance improvement. As example, ext:styleguide "elements select" is now rendered much quicker and the single ajax calls per tree are reduced from about 4 seconds to less than a second each with my test data. Change-Id: If3c4c1779f5fe1510ffc13d1c9f1151bddab13e9 Resolves: #78744 Releases: master Reviewed-on: https://review.typo3.org/50700 Reviewed-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Helmut Hummel authored
The session id is also additionally stored in the user property array in AbstractUserAuthentication. When regenerating the session id, we must update the session id in this user property as well, otherwise it leads to failures in session handling (like #69763). The workaround introduce for #69763 can stay, because it mitigates other reasons for invalid tokens in the URL by redirecting to the login page. Resolves: #78739 Related: #69763 Releases: master, 7.6, 6.2 Change-Id: Ib58e6b5dacae3b9e431e662e214557411fd668f3 Reviewed-on: https://review.typo3.org/50701 Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Nov 17, 2016
-
-
Wouter Wolters authored
Move all CSH language files from ext:lang to Resources/Private/Language Resolves: #78648 Releases: master Change-Id: I88102b1291b1628e91a5e0ee9c54d648d0160a51 Reviewed-on: https://review.typo3.org/50585 Reviewed-by:
-
Markus Klein authored
Resolves: #69763 Releases: master, 7.6 Change-Id: Ib5ec7e26cadb51b972ff617f23121cebd490bdb5 Reviewed-on: https://review.typo3.org/50688 Tested-by:
-
Benni Mack authored
The method GeneralUtility::getUserObj() already shows that it will be exactly the same as makeInstance(), thus it will be deprecated in TYPO3 v9.0, so the comments can be changed accordingly already. Resolves: #78734 Releases: master Change-Id: I5487e8bc0d1c140110d30098e656f5205750c0f2 Reviewed-on: https://review.typo3.org/50694 Tested-by:
-
Josef Glatz authored
Width and height is automatically set for pixel based backend logos. This patch makes sure this also is done for svg file format. Releases: master, 7.6 Resolves: #78590 Change-Id: Iff1dddc827d002e10fd4ec6f3b57bc16920b1c86 Reviewed-on: https://review.typo3.org/50522 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Frans Saris authored
Resolves: #69763 Releases: master, 7.6 Change-Id: I2d9e80b7c669c55067690aedf5a7c91256d7c28b Reviewed-on: https://review.typo3.org/50660 Reviewed-by:
-
- Nov 16, 2016
-
-
Sascha Egerer authored
Fluid defines it's own template processors that are currently overridden in the TYPO3 Fluid rendering context. This becomes important if fluid standalone adds template processors or adjusts it's RenderingContext constructor like in https://github.com/TYPO3/Fluid/pull/220 Change-Id: I69b044e308421665ea8c88be7789da1a4323828f Resolves: #78651 Releases: master Reviewed-on: https://review.typo3.org/50590 Tested-by:
-
Benjamin Franzke authored
The new BE Login form API in commit 9099b64c missed to pass $_GET['redirect_url'] into the login template, which caused redirect_url to work only for already logged-in sessions. Change-Id: I13081f303047e93863d8ce820d8e4fade0cea89b Resolves: #78719 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50677 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Frans Saris authored
Resolves: #78699 Releases: master, 7.6 Change-Id: If238a92e20f2382ad3b37a231992a122eff80826 Reviewed-on: https://review.typo3.org/50661 Reviewed-by:
Frederic Gaus <frederic.gaus@flagbit.de> Reviewed-by:
-
- Nov 15, 2016
-
-
Wouter Wolters authored
While dumping a file in the frontend no exceptions are caught. When a exception happens a 500 HTTP status is thrown. Catch all exceptions to return the correct 404 HTTP status. Releases: master,7.6,6.2 Resolves: #76153 Change-Id: Ice7097b6a41432ec580f99185d352307c5f55394 Reviewed-on: https://review.typo3.org/48080 Reviewed-by:
-
Benni Mack authored
The crawler is still included via a require_once in indexed_search, even though the class loader since TYPO3 6.2 does that transparently. So, the method is still called, which makes it impossible to move EXT:crawler lib to a different location inside the extension. The patch removes the call to the method, as the autoloader fetches the file anyway. It also deprecates the method call within EXT:indexed_search. Resolves: #78679 Releases: master Change-Id: I9654b89a520fe0aefd55a713613db794b8c88f72 Reviewed-on: https://review.typo3.org/50643 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Wouter Wolters authored
The PHP parser is removed, so we can drop the value from the default list of available file extensions. We do not need to check for the php file anymore in the AbstractFunctionModule class. Resolves: #78681 Releases: master Change-Id: I25ea50c7a615374849394298a8b87e7bbf50a8d3 Reviewed-on: https://review.typo3.org/50644 Tested-by:
Daniel Windloff <daniel.jc.windloff@googlemail.com> Reviewed-by:
-
- Nov 14, 2016
-
-
Wouter Wolters authored
Remove the empty else statement in AbstractRecordList which is not needed. Resolves: #78682 Releases: master Change-Id: I135fe879ee6f08be1234704836fa4f2f74a5e12b Reviewed-on: https://review.typo3.org/50645 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Nov 13, 2016
-
-
Benni Mack authored
The TypoScript option config.mainScript allows to set the frontend entrypoint from "index.php" to something else. As this has some bigger conceptual flaws (e.g. if this option is set, backend preview will not work, as the backend preview does not know about the selected TypoScript in the frontend), the option is removed in favor of creating custom extensions to e.g. hook into the frontend rendering to replace index.php. Resolves: #78668 Releases: master Change-Id: Idecdbc93fba33d9b8fecfa39c064fbeea4986a8d Reviewed-on: https://review.typo3.org/50603 Tested-by:
-
Frank Naegler authored
Adding items for type selectTree with pageTsConfig does not work as documented. The TCA tree needs multi-root handling to handle that. Additionally, some slight changes in the order of elements when items are calculated are needed. Resolves: #78628 Releases: master Change-Id: Iecf0225c0eeaab8ea661997cad26e68d255d8460 Reviewed-on: https://review.typo3.org/50565 Tested-by:
-
Wouter Wolters authored
Add missing type information to phpDoc. Resolves: #78678 Releases: master, 7.6 Change-Id: Id626c849bacc46f7a66c6936d34a71b1b2678f2f Reviewed-on: https://review.typo3.org/50640 Reviewed-by:
-
Tymoteusz Motylewski authored
The t3_origuid field is now covered in functional tests for DataHandler in workspaces module (Regular/PublishAll suite). Releases: master, 7.6 Resolves: #78637 Change-Id: I6f10bc4973e86e559744021e1c0e0ca4c53105e8 Reviewed-on: https://review.typo3.org/50573 Reviewed-by:
-
Claus Due authored
This change switches the internal behavior of the VariableFrontend when combined with the TransientMemoryBackend. Before this patch the VariableFrontend was only capable of storing strings and would serialize all variables it received, and unserialize all variables it retrieves. Rather than do this unnecessary serializing, a new contract is implemented to indicate that the backend implementing the contract is capable of storing non-string values, including references to objects. When the VariableFrontend detects this contract it skips the serialize/unserialize steps. Change-Id: I255dbda2ae3791ad6325c5b4ad67c97e172e22f4 Releases: master, 7.6 Resolves: #78664 Reviewed-on: https://review.typo3.org/50600 Tested-by:
-
Helmut Hummel authored
The API method added in for #70606 does not create extension folders, which makes the API incomplete and more or less useless. Move the method call to create the folder into the API method. Although the creation is done later then, the code in question didn't need the folders anyway. Resolves: #78631 Related: #70606 Releases: master, 7.6 Change-Id: I17b3527cd2c26e0bb1bdfedcb68dc7ae6064500d Reviewed-on: https://review.typo3.org/50561 Tested-by:
-
Georg Ringer authored
Using the type number for the pagination page field improves the usability. Resolves: #78608 Releases: master, 7.6 Change-Id: I963bda892bb7a0ec72b2726f6086808dd421ac1c Reviewed-on: https://review.typo3.org/50545 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
Patrik Karisch authored
Symfony has one of the best BC promises in the PHP world. Which means it will be never a problem to allow all new minor versions of a supported major release, even if there are deprecations. Deprecations don't infer with existing code. Resolves: #77983 Resolves: #76118 Related: #73517 Releases: master, 7.6 Change-Id: I221bb61674b3e4aaa7676d0929dae2ec18e01627 Reviewed-on: https://review.typo3.org/49965 Reviewed-by:
-
Nicole Cordes authored
Currently it is not possible to install an extension which has special sub-dependencies (e.g. dependencies of sub-extensions). During the installation of an extension, the download information is fetched too early and might not contain all necessary downloads. Furthermore later installation actions add new dependencies, which have to be resolved before any other extension can be installed. This patch ensures all dependencies and their sub-dependencies are fetched before the first installation. All installation information is now correctly ordered, as the last one added has to be the first one in the installation queue. Resolves: #78666 Relates: #66152 Releases: master, 7.6 Change-Id: Idd9242aa1e2ecac3deb542290627fdf9c5479edc Reviewed-on: https://review.typo3.org/50602 Tested-by:
-
Benni Mack authored
The system extension "tstemplate" still uses a lot of $GLOBAL objects which are only used within the classes itself. These are solely related to the "web_ts" (Web => Template) module. The code is refactored by using protected object members. Resolves: #78675 Releases: master Change-Id: Ic9bbcd9dfd4d9d9f9d976bead46c5d03d887aec6 Reviewed-on: https://review.typo3.org/50626 Reviewed-by:
-
Markus Klein authored
The XML push-parser now correctly collects the data for description and upload comment. When the data contain line breaks the characterData() method is called multiple times for each line of data. Resolves: #78306 Releases: master, 7.6 Change-Id: Ibfa446b92904572d1f4530b265e94228857a5f02 Reviewed-on: https://review.typo3.org/50516 Reviewed-by:
-
Helmut Hummel authored
If a link to a mount point or a shortcut is created, the id argument in the url points to the id of the real page, where the mount or the shortcut points to. This is why we need to take the id of the final page to be hashed and not the one used to generate the link. We also need to move cHash calculation below shortcut resolving. Resolves: #78238 Releases: master, 7.6, 6.2 Change-Id: I96c4305c6d769a5851c17d6fdcba3cd7584fc3ec Reviewed-on: https://review.typo3.org/50184 Tested-by:
-
- Nov 12, 2016
-
-
Markus Klein authored
Adding an empty alert message to the fieldChangeFunc array causes the fieldChangeFunc_hash to mismatch when pagination or search is used in the link browser popup. Add a check for an empty value, which is already present in another place in Core. Resolves: #75743 Releases: master, 7.6 Change-Id: I1a15400960d577c1a2a0a905643b56533d957100 Reviewed-on: https://review.typo3.org/50586 Tested-by:
-
