- Aug 08, 2023
-
-
Benni Mack authored
Change-Id: Ibdd8edc8f940289469c925b969415c7790c20a61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80452 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 07, 2023
-
-
Andreas Fernandez authored
The module menu is currently in a bad shape where different loose DOM elements and scripts are tangled together and do stuff. Previously, the module state was stored as a JSON-encoded string in the container of the actual module menu, which isn't refreshed when the module menu is reloaded via AJAX, leading to endless "loading" modules a freshly installed extension may add. Also, the JSON string gets parsed once and is then cached for faster access times. This patch accomplished multiple things: * the module state information is moved to the `nav` element of the module menu that's part of the reload process, always having the current state * an internal `flushModuleCache()` function is introduced to clear the cached, parsed state This is not an ideal solution but the best way the issue can be fixed in short-term. In long-term, the whole module structure and its handling need refactoring. Resolves: #100493 Releases: main, 12.4 Change-Id: I28342d7b207638e307c2ca7f4f50f2f4e6d27dbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80366 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #101605 Releases: main, 12.4 Change-Id: I1da8af5b5b0025ad0f25349fe6d4893eddbd5eaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80432 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Thomas Hohn authored
Moved assignment of $destPid = $sortInfo['pid'] after check if $sortInfo is an array, since the method call to getSortNumber can return other values than an array. Resolves: #101606 Releases: main, 12.4, 11.5 Change-Id: I3cfef35b351a0cd1fa8197702cce9e3b05871fcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80431 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
Remove -j and -k and only use -i to specify database versions. This is more easy to use, parse and validate. Resolves: #101604 Releases: main, 12.4, 11.5 Change-Id: Ie6b9343c6f244a294d636f0e5c09d24c5e1845fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80428 Tested-by:
-
- Aug 06, 2023
-
-
Rémy DANIEL authored
Linkvalidator extension has a couple of known issues, especially with external link checking. Those issues are now documented, so integrators can acknowledge them and implement counter-measures. Resolves: #101597 Releases: main, 12.4, 11.5 Change-Id: I00dc01243426fc56c21a4bd11815c3009e3dd3ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80364 Tested-by:
Stefan B�rk <stefan@buerk.tech> Reviewed-by:
-
Christian Kuhn authored
Fix a happy little regex to deal with "TCEforms" removal of #97126. This should fix finisher override FormEngine rendering. Resolves: #101050 Related: #97126 Releases: main, 12.4 Change-Id: Ia8d893c3f3b31f7af83b3d9f2ae533b3e557f5a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80363 Tested-by:
-
Chris Müller authored
Resolves: #101600 Related: #101114 Releases: 12.4 Change-Id: I9893e4c8b8eff5e05575984ab37e7f22612b26a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80420 Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Chris Müller authored
In some cases, classes are displayed like "TYPO3CMSCoreTypeContextualFeedbackSeverity" as backslashes are neither quotes not enclosed in a ":php:" directive. Where appropriate, we now link to the source code directly instead of just mentioning a class (with ":t3src:)". This is helpful, for example, for the severity enum, when you just want to know the available cases. Additionally, other mentions of PHP classes are now enclosed in a ":php:" directive instead double ticks. Resolves: #101599 Releases: main, 12.4 Change-Id: I2b384e388e6b6544c0a534a2bb23e97bc7c7fc1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80419 Tested-by:
-
- Aug 05, 2023
-
-
Christian Spoo authored
`PersistedAliasMapper` and `PersistentPatternMapper` both should only use int-like string route arguments as possible UID candidates for the following DB lookup. Thus, check if the arguments are truly numerical before passing them to the database queries. Resolves: #93105 Releases: main, 12.4 Change-Id: Ic3b9b5415abfce602b6be7c8031202823ea25e60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80416 Tested-by:
-
Sebastian Klein authored
Extensions can provide static data using the file "ext_tables_static+adt.sql". If this file exists, a button is automatically created in the Extension Manager. As soon as you click the button, the static SQL data will be imported. Existing data will be dropped. A new modal now warns the user before executing the file, with buttons to start or abort the task. Resolves: #100118 Releases: main, 12.4 Change-Id: Ie33a89d6957428f390edeaa2700639bc13ac8b7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80362 Tested-by:
-
Rémy DANIEL authored
If the svg-tree component is embedded in an iframe, and if the iframe src get changed by navigating to another url, pending AjaxRequest will be cancelled by the browser, without letting us the opportunity to properly catch the thrown error. As a workaround, we register an unload event on the iframe's window, and mute notifications to the user. Resolves: #101340 Releases: main, 12.4, 11.5 Change-Id: I8572fde4bf278481a32a459f802af69356ce28a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80361 Tested-by:
-
Gordon Brüggemann authored
Resolves: #99725 Releases: main, 12.4, 11.5 Change-Id: I4682cbe57b4908e13c219c5be4b0810c0d348bf1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80412 Tested-by:
-
Torben Hansen authored
With the introduction of configurable password policies, the `PasswordPolicyValidator` has been introduced. The class is however marked as `@internal`, which basically was a mistake. 3rd party extensions providing users the possibility to change a password should be able to validate the new password against the globally configured password policy by using the `isValidPassword()` method in the `PasswordPolicyValidator` class. The change therefore mark the class as public API by removing the `@internal` annotation. Resolves: #101579 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I8869a8465199a2c071d3d780af640a0c903404c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80357 Tested-by:
-
Oliver Bartsch authored
Resolves: #101592 Releases: main, 12.4 Change-Id: I56e7f9c4f7768d4034bc267261e3a31ecff4ff4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80410 Tested-by:
-
Oliver Bartsch authored
The listener identifier is now exposed into the ListenerProvider, making this information available, e.g. in the configuration module. Resolves: #101584 Releases: main, 12.4 Change-Id: I3dbcc4182532c6da0239d0e7bd715e081d1c283e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80401 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #101583 Releases: main, 12.4 Change-Id: Ie32b0ba494364b9a0d129f79d7b153243395efbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80360 Tested-by:
-
Anja Leichsenring authored
New ISO data has been published, so we update our set. Resolves: #101582 Releases: main, 12.4 Change-Id: I42bb256121a2dc66d350a8c3e5fbc563abe5310b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80359 Reviewed-by:
-
Daniel Siepmann authored
Ignore missing sys_csp_resolution table and return empty result instead of breaking the installation. Resolves: #101570 Releases: main, 12.4 Change-Id: Id6834e5c0fdb530a2f2fb3a90bef4c223bed1734 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80358 Reviewed-by:
-
- Aug 04, 2023
-
-
Sascha Nowak authored
Resolves: #101577 Releases: 12.4, main Change-Id: If2093146c7066e37881e43ff96c527f5e1efd482 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80356 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
linawolf authored
The 5th parameter of ExtensionUtility::registerPlugin is thegroup and not `ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT` Fixes the name to the correct function and adds example code. Resolves: #101575 Releases: main, 12.4, 11.5 Change-Id: I05a344ee11aaa8a9b3187a11528e2e506f47756d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80354 Tested-by:
-
Lukas Maxheim authored
* This commit updates the command "redirects:checkintegrity" to use the table format for clearer and more organized output. * Now, the list of hits will be presented in a user-friendly tabular layout, improving readability and overall user experience. Resolves: #99492 Releases: main, 12.4 Change-Id: Id20cb2f39ff797786c2080557db0a993a987b32e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80393 Tested-by:
-
Anja Leichsenring authored
Releases: main, 12.4, 11.5 Resolves: #101574 Change-Id: I6617e9c31a20b84269ae708d177b4ebf81ba97d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80229 Reviewed-by:
-
Stefan Bürk authored
Resolves: #101552 Releases: main, 12.4, 11.5 Change-Id: If9f12fa195f119b715e163c578188d8634b68b50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80315 Tested-by:
-
Christian Spoo authored
parent::__construct() of MemcachedBackend calls setCompression() which determines compression based on state of $this->usePeclModule. This property needs to be set before parent::__construct() is called. Resolves: #99495 Releases: main, 12.4, 11.5 Change-Id: Ibc6c3a2378c5187748b4394d440232600de193e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80387 Tested-by:
-
Tobias Liebig authored
This test checks lowlevel things like usergroup to be changed by GeneralUtility::fixPermissions(). Various tests in this area have been disabled on Windows already. They are problematic in macOS driven docker as well since macOS heavily messes around with access rights. We give up on this now, and reduce the details test checks of GeneralUtility::fixPermissions() a bit by removing that test. Resolves: #101568 Releases: main, 12.4, 11.5 Change-Id: I36e781302285dc1966633723abdc8f15bf84ef06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80382 Tested-by:
-
Stephan Jorek authored
Resolves: #101529 Releases: main, 12.4 Change-Id: I56bc70e244d810a275eea6e17f16f0f94b69b42f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80384 Tested-by:
-
- Aug 03, 2023
-
-
Simon Schaufelberger authored
While the backend already renders preview images of for example YouTube videos in the media module, it doesn't show the preview image anywhere else, for example in the page module and the Media elements within a "Text and Media" content element. This patch shows the generated preview image within the page module and the "Text and Media" content element as well. Resolves: #95454 Releases: main, 12.4, 11.5 Change-Id: I4e404cf41627d5ee9ac165ee46817a456dbecaa8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80353 Tested-by:
-
Jasmina Ließmann authored
In the page module it is possible to display the content of the languages side by side with the "Language Comparison" mode. With different amounts of text in the content elements of each language, the page TSconfig option `mod.web_layout.defLangBinding = 1` can help to arrange the content in a more structured way. If the `mod.web_layout.defLangBinding = 1` option was activated, the first button for creating new content elements was displayed on a white background. With this patch, the button is now displayed on a gray background, analogous to the rest of the content area. Resolves: #101536 Releases: main, 12.4 Change-Id: I88a47d8010d0520bea84f01f9c21408e0f3908f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80352 Tested-by:
Jasmina Lie�mann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Spoo authored
Invoke `str_ends_with` on lowercased filesystem entries in order to check for allowed extensions. This is more stable than `substr`ing the comma-separated list of extensions. Resolves: #101035 Releases: main, 12.4 Change-Id: I6a0eee1f6ddb7406a8da168ed489aba6bfc83263 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80230 Tested-by:
-
Oliver Bartsch authored
Apply type cast to the input value to prevent a TypeError. Resolves: #101555 Releases: main, 12.4 Change-Id: If2db6d0cc793999f2ce93d16cfedadb12325c316 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80231 Tested-by:
-
Stefan Bürk authored
With PHP8.3 the `ReflectionProperty->setValue()` method emits a E_DEPRECATED if a value should be set to a class and the context is not set as first argument. For instanciated classes the class needs to be provided, which is not possible for a static class or property. The solution for this is to use `null` as first argument as context object. That avoids the deprecation and keeps the backward compatibility. The testing-framework provides a tool to keep and handle static Framework state, which uses reflection under the hood and therefore needs the null context for `setValue()`. To verify manually use: > Build/Scripts/runTests.sh -s functional -p 8.3 Note: Activating in CI runs will be shuffeld in a dedicated change afterwards. Resolves: #101548 Releases: main, 12.4 Change-Id: I13fae7a20162eb3a48910ca91a5a1b178d5a1821 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80228 Tested-by: -
Jasmina Ließmann authored
Several H1 headings are used in some card views. As a result, the semantic structure for these views is not correct. The relevant H1 headings are changed to h2. Resolves: #101545 Releases: main, 12.4 Change-Id: Ic53d92a52b1ae75adda18a63bc76633d7ffcfa44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80227 Tested-by:
-
Christian Kuhn authored
With workspaces and the extbase test related blog_example being fixed, we can finally add a primary key on MM tables that have no uid field. Resolves: #101425 Related: #101528 Related: #101537 Related: #95061 Releases: main, 12.4 Change-Id: I2cd44e3f21dac4b774b8067839a6d2abb8d759fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80308 Reviewed-by:
-
Chris Müller authored
Resolves: #101539 Releases: main, 12.4 Change-Id: Id77ae5fb63c0de3d22cb1a4f4302c76476369b67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80305 Tested-by:
-
Stefan Bürk authored
Update the typo3/testing-framework to pull in a needed correction as preparation for functional tests with PHP 8.3. Used command(s): > composer require --dev \ typo3/testing-framework:^8.0.2 Resolves: #101538 Releases: main, 12.4, 11.5 Change-Id: Id26531be8c49a9b1ee9624c178342659b28d3eab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80301 Reviewed-by:
-
- Aug 02, 2023
-
-
Christian Kuhn authored
Similar to the recently fixed other MM TCA setup of blog_example, the "related_posts" is adapted as well. This removes the last mm table definition from ext_tables.sql - the auto-creation kicks in as expected now. Resolves: #101537 Related: #101528 Releases: main, 12.4 Change-Id: Ia92ce6bbc78a493e1a2028bd9ab7a31952181dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80299 Reviewed-by:
-
Andreas Fernandez authored
When creating a new site configuration, deleting the default language (English) and importing a new language afterwards now doesn't create an invalid site configuration with languageId 0 missing. Resolves: #100439 Releases: main, 12.4 Change-Id: Ic6a83328e92941e4c9894019aab5162f0b3937d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80226 Reviewed-by:
-
Helmut Hummel authored
While the initial idea to store the current ContentObjectRender (cObj) instance in a request attribute, to pass it along to code that requires both, the request and a cObj, is solid, we missed that cObj itself does not require to hold the request as attribute. The patch changes this: The request attribute is only set for ContentObjects, as these are actually responsible for rendering and eventually evaluating a request or the cObj instance. This makes sure, that an instance of cObj is available for Extbase plugins as well as for Fluid view helpers, which can access the request via RenderingContext. By changing the concept slightly, all places that previously added the cObj to the request can be removed in favor of doing so only in AbstractContentObject and ContentObjectRenderer::callUserFunction. The latter is at least required for TypoScript using the old way of calling Extbase plugins with USER and it's userFunc property. The circular reference is now removed, by not passing the request that contains the cObj attribute to the cObj itself. This means: * When a cObj is available, one can obtain the request using its getter * Such request objects, do NOT contain an attribute containing the cObj * The cObj request attribute can now be obtained in all content objects (such as EXTBASEPLUGIN or FLUIDTEMPLATE) and user functions, that are called from be ContentObjectRenderer. Releases: main, 12.4 Resolves: #101170 Resolves: #100872 Related: #100623 Change-Id: I6acb1a92c8b02f1be2f3a396fe9d9465d6482033 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79521 Tested-by:
-
linawolf authored
They should conform to the settings in `.editorconfig`. When your editor uses the `.editorconfig` file, these files become very hard to edit. I would backport this to make backports easier. Resolves: #101527 Releases: main, 12.4 Change-Id: I41e1782b46bbbf327106089f39dc28d2ca358761 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80296 Reviewed-by:
-
