- Dec 04, 2023
-
-
Oliver Bartsch authored
By using named parameters a couple of unused parameters can be omitted on calling BU::thumbCode(). Resolves: #102577 Releases: main, 12.4 Change-Id: Ic53ae287aab63a083e19662e217764defb3712ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82020 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benni Mack authored
Since TYPO3 v12.4, TYPO3 uses locales such as "de_DE" or "de-AT" in Site Configuration natively. In order to resolve the "locale dependencies" natively, a new Locale object needs to be created be the "Locales" factory class. This is needed to check for "de_AT.locallang.xlf" and falling back to "de.locallang.xlf" in a multi-step mode. This change adapts one place in Extbase's LocalizationUtility where a new Locale object was previously instantiated via new Locale() instead of using the "Locales" class which deals with all dependencies (incl. manually defined dependencies) directly there. A new comment is added to explain this inside the constructor of Locale. In addition, some more tests are added (including the ones that did not work before), as well as an example that it does not matter if the file is called "de-AT.locallang.xlf" (with a hyphen) or "de_CH.locallang.xlf" (with an underscore) Resolves: #102579 Related: #101710 Releases: main, 12.4 Change-Id: Id51082e75cf635bbe3cbdfc906dc2a7442ab06af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82019 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Stefan Bürk authored
TYPO3 uses a composer package [1] to import locales along with translations and a custom script has been added to create and update included translation files. This change updates the language files with the last updates and requires the package with the current highest version as minimum. Used command(s): > composer req --dev \ "sokil/php-isocodes-db-i18n":"^4.0.17" > Build/Scripts/runTests.sh \ -s checkIsoDatabase \ -p 8.1 [1] sokil/php-isocodes-db-i18n Resolves: #102596 Releases: main, 12.4 Change-Id: I21a9e5d5215e0146d3f87aeee3b833979ba05f07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82080 Reviewed-by:
-
- Dec 02, 2023
-
-
Christian Kuhn authored
Also fix one unneeded null coalescing operator usage, which was discovered with this release. > composer require --dev phpstan/phpstan:^1.10.47 Resolves: #102584 Releases: main, 12.4 Change-Id: I19876bfe33fcf05166df7e0d92696c2368b29490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82068 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Dec 01, 2023
-
-
Patrick Schriner authored
Allow a title argument to be set in the IconViewHelper. The give title will be passed to the `Icon` object and will be rendered as title attribute in the icon HTML markup, enhancing accessibility. Resolves: #102314 Releases: main, 12.4 Change-Id: Ifbaf5961cda843054c7933025617d3d18a4887f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82062 Tested-by:
-
Stefan Bürk authored
New `core-testing-phpXY` images has been build and released. This change update used image version to: * core-testing-php81:2.8 - php 8.1.26 (patchlevel) * core-testing-php82:1.7 - php 8.2.13 (patchlevel) * core-testing-php83:1.8 - php 8.3.0 (major) [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/6ead80df3d46bf1f0c2363e8728435b2d2363fba Resolves: #102575 Releases: main, 12.4, 11.5 Change-Id: I85a8b0a97d63fea01c790fd9c7ab5d51536a21b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82053 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Andreas Kienast authored
This commit updates TypeScript to 5.3 and related packages used for JavaScript building. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^6.13.1 \ @typescript-eslint/parser@^6.13.1 \ @typescript-eslint/typescript-estree@^6.13.1 \ eslint@^8.54.0 \ eslint-plugin-lit@^1.10.1 \ eslint-plugin-wc@^2.0.4 \ typescript@^5.3.2 npm run build Updated `eslint` packages revealed issues in the `@typo3/backend/page-tree/page-tree` module that are fixed along with the updates. Resolves: #102564 Releases: main, 12.4 Change-Id: Ibd2ff74b3ea2b42511cf775a94f1725d08e4065d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82055 Tested-by:Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Sascha Nowak authored
When the endtime of a page is lower than the default lifetime (24h), the calculation did not respect the endtime and set the lifetime to default lifetime. This lead to cache entries with incorrect lifetimes. The upper bound of the cache lifetime is now additionally clamped to the endtime of the current page. Resolves: #102525 Related: #102422 Releases: main, 12.4 Change-Id: I5e2c48fcfd237fb0eca130aba8812224368474ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82017 Tested-by:
-
Benjamin Franzke authored
(Custom) element children are not guaranteed to be available by the time the element is added to the DOM — i.e. when the connectedCallback() is triggered by the browser. That means we can not assume that value-picker <select> children will always be available. Note that it worked most of the times, because JavaScript modules are loaded asynchronously, and thus "most of the times" execute later after the DOM is rendered, but when the server is really busy, the HTML output can be rendered very late, so that a connectedCallback is triggered immediately when an opening tag is written to the DOM — even before the childrens are attached. (Otherwise the browsers would have to delay the connectedCallback's until the closing tag is rendered, but that's not the case — at least not in google chrome.) To circumvent this we use a slotchange listener (which is basically a mutation observer) to assure we are notified about async child updates. Resolves: #102550 Related: #102330 Releases: main, 12.4 Change-Id: I73179335c390f08f42f3426dcffec338f6355d61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82018 Reviewed-by:
-
- Nov 30, 2023
-
-
Benni Mack authored
This changes the behaviour of config.sendCacheHeaders = 1. When a non-cacheable option is used, the HTTP Response Headers for ensuring that a response should never be cached (that is Cache-Control: private, no-store) should be sent at any time, as it could contain sensitive information, regardless of the TypoScript option. The TypoScript option config.sendCacheHeaders is then only used to actually explicitly send the headers for a fully client-cacheable page (e.g. for a proxy), to explicitly allow the cached content to be stored for a defined amount of time. In addition, a lot of tests have been adapted to remove this option as it does not have any effect in the tests if the option is set. Resolves: #102445 Releases: main, 12.4 Change-Id: I603e73a114eb9668910484da7e9dc4e0e33e56ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82016 Tested-by:
-
Garvin Hicking authored
When entering the sequence "/*" into any t3editor instance (i.e. TypoScript editor in the backend), it puts the browser in an endless loop. The reason is that the method `stream.next()` declares to either return a string value or `void` (=`undefined`), but the code checks for `null`. The check is now fixed and another cases where a loose null comparison was used is adapted as well. Note that a loose null comparison between null and undefined return equality, but a strict comparison doesn't. Resolves: #101893 Related: #101803 Releases: main, 12.4 Change-Id: If1c090daf13a6d730a2e5b96d46afab171fbcde2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82046 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
- Nov 29, 2023
-
-
Oliver Bartsch authored
The form framework adds a warning flash messages to the page module in case a page contains a form content element, having some error. In case of a generic invalid form configuration, the message now also displays the corresponding form identifier of the form configuration, containing the invalid configuration. Resolves: #102557 Releases: main, 12.4 Change-Id: I592a415692822200608f218268f1406fc33df118 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82044 Reviewed-by:
-
Markus Klein authored
The ext_tables_static+adt.sql data are now re-imported, if its data changed, when setting up the extensions. This happens either from within the Extension Manager, or via the CLI command. Moreover, a legacy value, which was already taken care of in `ReloadSqlDataViewHelper`, is now respected as well. Resolves: #102376 Releases: main, 12.4 Change-Id: I67074f8b98acd0bbfc7ce03732b18f759e1d81de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82043 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Oliver Bartsch authored
Usage of ServerRequestFactory::fromGlobals() on CLI is discouraged as the request url, used to create the request is invalid, except the $_SERVER variable is adjusted beforehand. To properly inform the developer, a dedicated exception is now being thrown, if in CLI context. Resolves: #102533 Releases: main, 12.4 Change-Id: Ie84fdf9c0555eeeaf5438a2ed29acabbe2755965 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82015 Tested-by:
-
Garvin Hicking authored
The ClassMapGenerator is used in non-composer ("legacy") mode installations and builds files used for PSR-autoloading. It only parsed class|interface|trait files, but not files containing enum type definitions. Thus, the PSR-autoloading created by this classmap was not able to autoload these enum files. The underlying code had been adapted from the Composer libraries some time in the past, meanwhile that code from Composer was extracted to the package "composer/class-map-generator" and has drifted from the current TYPO3 implementation. That implementation at https://github.com/composer/class-map-generator/blob/953cc4ea32e0c31f2185549c7d216d7921f03da9/src/PhpFileParser.php#L118 supports "enum" class loading in case the PHP version matches. This patch simply also adds "enum" as a recognized identifier. Resolves: #102498 Releases: main, 12.4 Change-Id: I1b98e8ceeecd25f1512d3539e84de6c725a8e3c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82042 Tested-by: -
Oliver Bartsch authored
To avoid unnecessary initialization of page title providers and calling any stdWrap, an early return is added to `TSFE::generatePageTitle` for the case that `noPageTitle` is set to "2", as this means do not render the title tag at all. Resolves: #102555 Releases: main, 12.4 Change-Id: Ia879218e84db865bce11bca8c61f33c7266884b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82014 Tested-by:
-
Daniel Hoffmann authored
When a file or folder is rename()'ed, the name property is updated immediately. The file list controller handling a rename thus needs to park the old name in a variable to render the correct 'before' name. The patch fixes this and cleans up the class a bit. Resolves: #102478 Releases: main, 12.4 Change-Id: I438fa351febc821242c401cb208e644617f2f090 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82041 Tested-by:
-
Achim Fritz authored
The return value of HtmlentitiesDecodeViewHelper can be null e.g. {foo -> f:format.htmlentitiesDecode()} with foo might be undefined Resolves: #102553 Releases: main, 12.4 Change-Id: I41fa1917f23a40a742e1ebc27ef37d6fee0bd858 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82013 Tested-by: -
Christoph Lehmann authored
Don't check accessibility to current page again. This is already done in the TypoScriptFrontendController. In addition some PHPStan issues are resolved. Resolves: #102121 Releases: main, 12.4 Change-Id: Id3757e214cf73e027092f3c8ce0bc7d5709e0e04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82035 Tested-by:
-
Benni Mack authored
This commit updates all Symfony components to version 6.4, as 6.3 ran out of support. Symfony 6.4 also marks an LTS release. Please see the upgrade document at [1]. Executed command: composer require \ symfony/config:^6.4 \ symfony/console:^6.4 \ symfony/dependency-injection:^6.4 \ symfony/doctrine-messenger:^6.4 \ symfony/expression-language:^6.4 \ symfony/filesystem:^6.4 \ symfony/finder:^6.4 \ symfony/http-foundation:^6.4 \ symfony/mailer:^6.4 \ symfony/messenger:^6.4 \ symfony/mime:^6.4 \ symfony/options-resolver:^6.4 \ symfony/property-access:^6.4 \ symfony/property-info:^6.4 \ symfony/rate-limiter:^6.4 \ symfony/routing:^6.4 \ symfony/uid:^6.4 \ symfony/var-dumper:^6.4 \ symfony/yaml:^6.4 \ -W composer require --dev \ symfony/translation:^6.4 \ -W [1]: https://github.com/symfony/symfony/blob/6.4/UPGRADE-6.4.md Resolves: #102552 Releases: main, 12.4 Change-Id: I01f8fcedff74eac49a6901651b36584272f93b82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82036 Tested-by: -
Oliver Bartsch authored
The link attributes of a field control are added to the link tag using implodeAttributes() with the second parameter `xhtmlSafe` set to `true`. To prevent double encoding, previously applied "hsc" calls are removed. Resolves: #102541 Releases: main, 12.4 Change-Id: If7b4f036b9cea71162a5265458e53dc05b91b7b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82010 Reviewed-by:
-
Oliver Bartsch authored
Adds the loading="lazy" HTML attribute to a couple of img tags, used to display thumbnails in the backend. This will improve performance, especially for larger listings, e.g. in the filelist module. Resolves: #102501 Releases: main, 12.4 Change-Id: I5f4b7c37786e8f4283bb997f40c501f09984e410 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82011 Tested-by:
-
Mathias Brodala authored
Aside from being disabled itself, a form field can also be placed in a container which is disabled statically or using variants. In either case the field must not be validated since it is not rendered and thus cannot be filled by the user. Resolves: #102083 Releases: main, 12.4 Change-Id: I8f2bcd45d3563907bf5737628020ab8bf50a68bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82004 Tested-by:
-
Willi Wehmeier authored
Max values have been set to the input fields in the TCA of the sys_file_metadata table. The settings have been adjusted to the set varchar length in the ext_tables.sql file. Additionally the language column length has been adjusted to the other fields. The length is set from 12 to 45. Resolves: #102456 Releases: main, 12.4 Change-Id: Id2b7d510c16b5c2659fa0a7367edeb4f49b782f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82003 Reviewed-by:
-
Oliver Bartsch authored
Since #101859, the `setFields` property of the record list, which contains the fields to show / download is initialized in the start() method. To enable the "all columns" option again, overwriting of the property is now done after calling start(). Additionally, the module data call is removed as this is done by record list already. Resolves: #102538 Related: #101859 Releases: main, 12.4 Change-Id: I39d7348b4eaa848f012cf238abc54e3a0e5d2e31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82002 Tested-by:
-
Christian Kuhn authored
The new version fixes a false positive, adds a second warning for a problem that already is logged in the baseline, and sadly introduces one new false positive. > composer req --dev phpstan/phpstan:^1.10.46 > composer req --dev phpstan/phpstan-phpunit:^1.3.15 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102544 Releases: main, 12.4 Change-Id: I79e3854458f1061b4943d0b3fab78b1a7502b13f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82001 Tested-by:
-
- Nov 27, 2023
-
-
Christian Rath-Ulrich authored
Resolves: #102534 Releases: main, 12.4 Change-Id: I09c5cc656702c7c262638a95a28d6d0f0cf79cf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81911 Tested-by:
-
Christian Kuhn authored
> composer require --dev phpstan/phpstan:^1.10.45 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102536 Releases: main, 12.4 Change-Id: Ie529eba3c951d20bf4d0b6f2b838d329ac771805 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81982 Tested-by:
-
Christian Kuhn authored
Patch for issue #101364 came with a bug using a wrong visitor. This leads to potentially broken nested condition matching calculation and cache files being written too often. Resolves: #102531 Related: #101364 Related: #97816 Releases: main, 12.4 Change-Id: Ica84e17da9ddf4671d0f1197248eb5b396d7e8b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81910 Tested-by:
-
Benjamin Franzke authored
With #100885 the availability of the normalizedParams request attribute became a requirement for user sessions initialized with a custom PSR-7 request. Extensions like EXT:container relied on the fact that a plain request object could be passed to `Bootstrap::initializeBackendUser()`. This will be fixed in EXT:container[1] but in case other extensions relied on this as well, a fallback is now provided. [1] https://github.com/b13/container/pull/461 Resolves: #102520 Related: #100885 Releases: main, 12.4 Change-Id: Idbf5a6b3d72ecab4a9943d7bb2febf41fa4b6635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81908 Reviewed-by:
-
Georg Ringer authored
To avoid exceptions during the ckeditor migration the type is forced to be a string. Resolves: #102521 Releases: main, 12.4 Change-Id: Icfdedb5b6ef74720e8f7da205a66115bc6d7a39a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81909 Tested-by:
-
- Nov 26, 2023
-
-
Oliver Bartsch authored
In case an extension should be installed via the extension manager, containing code which might stop the PHP request, e.g. the common "defined('TYPO3_MODE') or die();" check, the corresponding JS component does no longer generate a SyntaxError on calling .json() on the empty response body. Instead, the error is caught and the integrator is being informed via a flash message. Resolves: #102512 Releases: main, 12.4 Change-Id: I4acc6f972be91b137c943edfec51d283e9268426 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81966 Tested-by:
-
- Nov 25, 2023
-
-
Andreas Wolf authored
Resolves: #102479 Releases: main, 12.4 Change-Id: Ic708efab47c319d60d3137c0630944bdece0bfb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81963 Reviewed-by:
-
madaxel authored
The request attribute 'frontend.typoscript' might not be initialized at the point of calling `$request->getAttribute` and will return null. Even if this indicates that something is trying to access extbase to early in the stack without taking care to bootstrap it properly, the core should avoid a fatal error at that point. Therefore, a access guard is added in the `getTypoScriptSetup` method of the `FrontendConfigurationManager` to mitigate the fatal php error. The added guard does not fix the invalid state at that point as this is impossible, so extensions messing around in that early state may now not fatal but left with an invalid and incomplete state anyway. Note: This will replaced with a dedicated meaningfull exception in v13 only in followup. Resolves: #102457 Releases: main, 12.4 Change-Id: I00ec0e95d3f5b92abf9ee5dabcf24369b5d6374b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81962 Reviewed-by:
-
- Nov 24, 2023
-
-
Oliver Hader authored
In favor of applying content security policies, inline JavaScript is dropped when navigating back to the previous form step. Resolves: #102460 Releases: main, 12.4 Change-Id: I2822067968f9b35b2f41598787b0ff6b52f20c72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81960 Tested-by:
-
Jasmina Ließmann authored
In the "References from this item" area of the "Element Information" modal, there is s preview link for references of type page. In #101276 a problem with the preview links was solved but another one introduced so that the preview links were now always deactivated. This patch now sets the correct variable in the fluid template. Resolves: #102515 Related: #101276 Releases: main, 12.4 Change-Id: I4e129c98a067e015c7dd4e56af9eb006044bab83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81907 Tested-by:
-
Jasmina Ließmann authored
The “Element information” modal displays, among other things, references to and from the selected record. In the "References from this item" area, the icon of the current data record was incorrectly always displayed. With this patch, the appropriate icon of the referenced record is now always displayed. Resolves: #102514 Releases: main, 12.4 Change-Id: I707f2c73d7d94cf02311868cbef480ff6e3cd121 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81961 Tested-by:
-
Oliver Bartsch authored
In some cases the element might not be available, making the data attributes not accessible. To prevent type errors, proper checks are added. Resolves: #102510 Releases: main, 12.4 Change-Id: I061fcb3fe4f153ff45230a86ed11edf1dfb76cd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81906 Reviewed-by:
-
Stefan Bürk authored
Used command(s): > composer req --dev \ "typo3/testing-framework":"^8.0.7" Resolves: #102506 Releases: main Change-Id: Ib0ca2770420cdcb7ff4464a785f44e01bf02e192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81914 Reviewed-by: -
Elias Häußler authored
When downloading or updating extension using extension manager, the resulting extensions are now properly iterated using `Object.keys`. This is necessary since the extensions are provided as objects instead of simple arrays. In addition, the relevant methods in ExtensionManagementService now have proper type declarations and annotations. Resolves: #101430 Releases: main, 12.4 Change-Id: I112d59326ed5cb788bad919a7b556f7ee95b2b41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81953 Tested-by:
-
