- Jun 13, 2024
-
-
Andreas Nedbal authored
Before it was not really clear if/where a select check box header was collapsible. This patch unifies the layout with the one of the recordlist tables, adding a button specifically responsible to collapse/expand the group. Resolves: #98683 Releases: main, 12.4 Change-Id: I6b47cdc9cd2673a85aaa0bfb85dd70534e4ffc33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84638 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Christian Weiske authored
The link validator "missing links" report shows the title of the field which contains the missing link. This title is loaded from `TCA.$table.columns.$field.label`, but it is possible to use content-element specific labels in `TCA.$table.types.$contenttype.columnsOverrides.*.label`, and this is not supported by the validator. The patch first tries to load the overridden label and then falls back to the normal TCA column label. This fixes titles of elements generated by the "mask" extension, which only sets labels via overrides. Resolves: #104035 Releases: main, 12.4 Change-Id: I1fa43a4cf0dbc910a8d2eea9b868aaf1cdbead0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84687 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Garvin Hicking authored
Currently both the Install Tool and Environment > Directory Status sets the directory "typo3conf" as being mandatory and tries to create it. This is no longer needed in Composer mode. Resolves: #104074 Releases: main, 12.4 Change-Id: I880ec2b7ff0be642c2673bb7110ef95f3dc125d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84637 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Christian Rath-Ulrich authored
Resolves: #104025 Releases: main, 12.4 Change-Id: I32b509644018eaa4de452f499d525c6822addad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84636 Reviewed-by:
-
Jasmina Ließmann authored
The TYPO3 backend has a bookmark function with which records can be saved as bookmarks. Since any other record type can be saved in addition to pages, the corresponding link titles are now adjusted. Resolves: #104053 Releases: main, 12.4 Change-Id: If8c894bdcd6e2aa0cbe3c29276a32ac18355a370 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84678 Tested-by:
-
Garvin Hicking authored
Extbase reserves a couple of keywords for internal use: * action * controller * format (resolving fluid templates for HTML, json, ...) * __trustedProperties * __referrer The notiation "__" (and "@" for sub-arrays) is indiciative of being reserved keywords, however action/controller/format are not. These are now mentioned specifically in the Fluid ViewHelper "arguments" parameter, so that they can show up in the auto-generated documentation. This should help to prevent integrators and developers from advertly using an argument like "format" as a custom variable/property name. Efforts have been made to document this also here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/4525 https://github.com/TYPO3-Documentation/TYPO3CMS-Exceptions/pull/155 Resolves: #102246 Releases: main, 12.4, 11.5 Change-Id: I55a306aaa0ba783f9202350d198c9fdf08f5a997 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84673 Reviewed-by:
-
- Jun 12, 2024
-
-
Michael Telgkamp authored
The rootpages in the site configuration do not have intendation any longer. The computation of the margin value and the unused inline style are removed. Resolves: #104066 Releases: main, 12.4 Change-Id: Ic75d7e10638b2ee3fb06f42add1a36c180f754e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84635 Tested-by:
-
Christian Kuhn authored
> Build/Scripts/runTests.sh Before: Memory: 469.06 MB After: Memory: 373.02 MB Reason: phpunit executes data providers early and keeps data sets in memory. The "xml parser big content" tests create megabytes of data kept in memory. Moving the data generation from data providers to the test execution reduces overall memory usage significantly. Resolves: #104076 Releases: main, 12.4, 11.5 Change-Id: I0ad49824fc1d4c309158b74474853d36af22ffb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84669 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104060 Related: #104046 Releases: main, 12.4 Change-Id: I2b7b8c8911cd3f5552a287a73942c11806f4b8bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84634 Tested-by:
-
Christian Rath-Ulrich authored
To improve accessibility, an aria-label is added to all context menu buttons to allow assistive technologies to announce them correctly. Resolves: #102490 Releases: main, 12.4 Change-Id: Ia397ab17a8fcbfe3a1ea75e86733a6a5a778653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84667 Tested-by:
-
Oliver Bartsch authored
The "revert selection" action of the SelectCheckBoxElement does now properly handle the current element's "checked" state. This way, the action button gets visible once the initial state is changed (by checking / unchecking checkboxes) and is disabled again, in case the initial state gets restored. Resolves: #104062 Releases: 12.4 Change-Id: Iad14f36c1b8c0de23f4c152a5fd4ba1a4fbee6da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84628 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jun 11, 2024
-
-
Georg Ringer authored
The string "false" is cast to true and therefore 0/1 must be used in examples. Resolves: #99211 Releases: main, 12.4, 11.5 Change-Id: I5519cd1917b81c1dbb90fbb6746541735e4940ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84528 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Jasmina Ließmann authored
The "About" module lists, among other things, all backend modules available in the system. If an admin or editor does not have access to a module, it will not be displayed in the "About" module list. Some of the modules listed contained a note that the module was only accessible to administrators. With the introduction of the system maintainer role, this note is no longer applicable. In addition, this note was missing for some modules that cannot be made accessible to the editor at all (e.g. "Access" module). If an admin/system maintainer wants to check which backend modules an editor can access, he usually switches to the backend user (via the "Backend Users" backend module). Calling the "About" module is not sufficient at this point, as settings in backend user groups and the backend user accounts themselves also influence whether a backend user can access a backend module or not. For this reason, this note in the "About" module is now being removed. Resolves: #104040 Releases: main, 12.4 Change-Id: Ib27581a9f1fc48985d42550622caffcf0615a0d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84632 Tested-by:
-
Oliver Hader authored
Change-Id: I86360df1a2a39b3fb1ebca927fe2a714bc887691 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84600 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: If61da3b4e4166c368989faab63ae87c26330e588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84599 Tested-by:
-
Andreas Kienast authored
The drag&drop issue reported in #103877 also affects the icons in the page tree, which was not fixed back then. This commit now takes care of the page tree icons as well. Resolves: #104033 Related: #103877 Releases: 12.4, 11.5 Change-Id: I92381a07bfba2d90d7fc1a85097c54f0d4a7b282 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84593 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Franzke authored
Avoid redirecting to /typo3/empty, which is not helpful to the context. As long as there is not module context in shared record-edit links, it's best to show the first backend module on close of such a view. Resolves: #104028 Releases: main, 12.4 Change-Id: Ia7d50f4e906e92b7f93b6e444f7b18fafcc1ea1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84577 Tested-by:
-
- Jun 10, 2024
-
-
Garvin Hicking authored
When the configuration for `mod.web_layout.BackendLayouts` contains column definitions with an empty content, this will make both the list view and the normal page view in the backend fail. This makes using the GUI editing of the 'backend_layout' records impossible to be fixed/addressed. This patch now does a more lax check on the 'columns.' array to prevent PHP error notices on invalid array key access. Resolves: #103425 Releases: main, 12.4, 11.5 Change-Id: I68c9b5a1ee8f0a70e3808338aa9dd2ed6f12c882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84572 Tested-by:
-
Oliver Bartsch authored
When inserting a record via the element browser, the value argument needs either to be formatted manually or left empty, allowing the element browser to format the identifier automatically. By omitting the value in the `PageBrowser` module, the value is now correctly formatted by the element browser to "pages_<uid>". This makes the "node-action" usable for TCA group fields, which allow more than one record type. The same logic is also used by the `BrowseDatabase` module, which also omits the value argument. Resolves: #103700 Releases: main, 12.4 Change-Id: I80e2cc696d85b5ec83432c35a263b19f9752b0ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84553 Reviewed-by:
-
Sandra Erbel authored
Releases: main, 12.4 Resolves: #104024 Change-Id: Ie2ffbbaa4867c1d8f0724a0f2352551599caef59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84552 Tested-by:
morgane garcia <morgane.garcia@ideative.ch> Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104016 Releases: main, 12.4 Change-Id: I509554667d6aa5a97a51419ecef79fd60ccb377a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84471 Reviewed-by:
-
Sandra Erbel authored
Releases: main, 12.4 Resolves: #104022 Change-Id: I31703188cd154cd8fec433b4ce47f8acbb93bab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84470 Tested-by:
-
Stefan Bürk authored
PHPUnit changed the way how double creation is handled internally and now emits an exception if a manually defined `mock class name` should be registered. In some places within the unit tests, manual mock class names have been used, because the names are needed for cross referencing at a later point. For this, different approaches have been used, for example hardcoded MD5 hashes as strings or creating hashes of static values like `md5('1')`, and also reused hashes in different places or in tests using data providers. This now leads to an exception: PHPUnit\Framework\MockObject\Generator\NameAlreadyInUseException The name "b70551b2b2db62b6b15a9bbfcbd50614" is already in use This change mitigates the issue by using `StringUtility::getUniqueId('somePrefix')` as is already done in other places. As a sideeffect, four phpstan baseline entries can be removed. Used command(s): Build/Scripts/runTests.sh -s phpstanGenerateBaseline [1] https://github.com/sebastianbergmann/phpunit/pull/5804 Resolves: #104005 Releases: main, 12.4 Change-Id: Icc558844275c9ae9f67a0e7c20daa318f5ad6b41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84531 Tested-by: -
Thomas Hohn authored
This patch extends the access checks for modules. This is done by checking both the module identifier and potential aliases. Resolves: #103967 Releases: main, 12.4 Change-Id: Ifc534356f75244ccac81b763bd624fe13f68aa72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84468 Reviewed-by:
-
- Jun 08, 2024
-
-
Georg Ringer authored
Use ILIKE instead of LIKE for PostgreSQL as this is case insensitive and to be in sync with the ExpressionBuilder. Resolves: #103961 Releases: main, 12.4 Change-Id: I859301554642f0f163e660c6151415ff3d3ba95c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84534 Tested-by:
-
- Jun 07, 2024
-
-
Georg Ringer authored
Backport parts of #102907 to avoid exceptions because of undefined array key access. Resolves: #103997 Releases: 12.4, 11.5 Change-Id: I35e159bd8728fd84a43b58b27dc2a291fd11fe2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84525 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Charles Krüger authored
A few minor spelling mistakes and uppercase notation is changed with this patch. Releases: main, 12.4, 11.5 Resolves: #103993 Change-Id: Ie71257dcd94e008bff2fd29ca6152152019eedae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84466 Tested-by:
-
- Jun 06, 2024
-
-
Garvin Hicking authored
The directory to reference removing Documentation-GENERATED-temp breaks out of the current working directory scope and could possibly delete files in a completely unrelated directory. Also, it does not remove the actual temporary files. Resolves: #103989 Releases: main, 12.4, 11.5 Change-Id: I685a398aa0d5abee3177ab3def4e271d493d59ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84464 Tested-by:
-
Garvin Hicking authored
The use of the backtick operator inside the help output leads to an error message: Build/Scripts/runTests.sh: line 175: --: command not found on macOS (probably others, too). This patch replaces the backticks with normal quotes. Resolves: #103988 Releases: main, 12.4, 11.5 Change-Id: Ib6809dc6943a98e4d45d04f4ec02601e830518cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84462 Tested-by:
-
Andreas Kienast authored
With Chrome 125, changes in the drag&drop handling were introduced [1] that trigger a text selection when dragging nodes from the page tree toolbar. In the `dragstart` handler, the default action is now prevented. [1] https://developer.chrome.com/release-notes/125#interoperable_mousemove_default_action Resolves: #103877 Releases: 12.4, 11.5 Change-Id: Iad75db78bba3e7b5ad01a568dcab2eb770f1c4a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84483 Reviewed-by:
-
- Jun 05, 2024
-
-
Christian Kuhn authored
Constant substitution in TS parser is implemented in ConstantAwareTokenStream. It kicks in by casting the stream to string after existing constants have been set using ConstantAwareTokenStream->setFlatConstants(). To not have a "polluted" stream after setFlatConstants(), the constants are reset using setFlatConstants(null) after use. Ugly. Patch #102742 established a partial solution already by cloning the stream instead. Finish the clone approach to disallow setFlatConstants(null). Add two missing void return annotations at related places along the way. Resolves: #103982 Related: #97816 Related: #102742 Releases: main, 12.4 Change-Id: I964bb40dfa1e29b23f876ba85ad05ba2a94ca6d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84507 Tested-by:
-
Ziad Abdul Hai authored
Prevent an undefined array key warning in case a non-admin-user save his profile with disabled avatar field, for example with setup.fields.avatar.disabled=1 Resolves: #103873 Releases: main, 12.4 Change-Id: I1c91fb65b8508445928a5ec405b9447f452c1fdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84505 Tested-by:
-
Benjamin Franzke authored
Workaround a PHP issue which will produce an open_basedir restriction warning if `is_dir()` is used on a regular file when the trailing slash is provided. Resolves: #103943 Releases: main, 12.4, 11.5 Change-Id: Iaa83658113ff8abb0ab8051b519f76135effd627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84461 Tested-by:
-
Garvin Hicking authored
The TYPO3 Contribution Guide lists DDEV as an easy way to get started with a TYPO3-Core legacy-based installation. The installation itself shows a big warning for the "Trusted Host Pattern" mismatch when utilizing https:// for the installation, which many people might do. While the Contribution Guide mentions this as a sidenote, the actual warning can be improved to better reflect the reason and solution. (Note that the installation can actually continue even with this error, but may hint people at this being an installation show-stopper, so it is now stated clearer, that a working host pattern will be actually set and should be adjusted after installation is complete) Resolves: #103959 Related: #88846 Related: #86356 Releases: main, 12.4 Change-Id: I7988a7dad45b53d5b1c8314e1dfdcbc1d8feb6a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84504 Tested-by:
-
Marcin Sągol authored
It might not be clear to users how the allowed_languages field works by default when setting permissions for a backend user or group. If no languages are selected from the allowed_languages list, all languages will be available for the given user or group. To make this clearer, a description has been added to explain it straightforwardly. Resolves: #103757 Releases: main, 12.4 Change-Id: If0c0fd9c998f51a0e44617faae3365f2e02bc82e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84503 Tested-by:
-
ullio authored
Adds required CSS class `t3js-topbar-opendocs-item` to each open document item. OpendocsMenu JavaScript module counts these items to show count of open documents in badge. Resolves: #103980 Releases: 12.4 Change-Id: I57ac7b7e92c1bb268c0abc9476068616efbfec15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84500 Tested-by:
-
Christian Kuhn authored
Sometimes - for unknown reasons - a session gets lost in acceptance tests. Tests then hang in BE login waiting for BE load and fail with a timeout. We now catch this timeout and relogin, and also enable cookie debug output to increase chances to fix the real issue. Resolves: #103981 Related: #103086 Releases: main, 12.4, 11.5 Change-Id: I0b10118968933b52523bbee8f8f608db60ad884e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84501 Reviewed-by:
-
Christian Kuhn authored
Frontend TypoScript 'constants' do support conditions. But constants can not be used within conditions, just like constants in general can not be used within constants. The patch adapts the "new TS parser" ReST to clarify. Resolves: #103953 Related: #97816 Releases: main, 12.4 Change-Id: I0e21a320582f2f0edbde432fe36767540ab7993b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84460 Tested-by:
-
Garvin Hicking authored
We missed a TypoScript feature with the new parser. Function operator modifier values can use constants: foo = 42 foo := addToList({$my.constant}) The solution is two fold: Until now, the value of a function body was a single T_VALUE token. This is turned into a stream of tokens that can consist of multiple T_VALUE and T_CONSTANT tokens. This is handled in the tokenizers. Secondly, the AST builders need to deal with these token streams now, and take care available constants are hand over to ConstantAwareTokenStream before the stream is cast to string and single functions are evaluated. The BE modules *do* reflect constant substitutions in function modifier bodies, but not in an ideal way. An @todo within the responsible CommentAwareAstBuilder outlines ideas how this could be improved. Note TYPO3 v13 supports constant fallbacks here as well, this syntax feature came with #103671. This works, but is NOT supported in v12: foo := addToList({$my.constant ?? $fallback.constant}) Resolves: #102742 Related: #97816 Related: #103671 Releases: main, 12.4 Change-Id: Ib5e0872fe1ea2b78bd0a7e05caccd9874b5668d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84498 Tested-by:
-
- Jun 04, 2024
-
-
Christian Kuhn authored
There is a subtle difference between a PHP error and a dedicated thrown exception: When an object knows it should return something, but can't, because it has not been set up correctly, then the implementation is responsible of throwing a "i'm incomplete" exception: This is not an error in the class, but a wrong set up usage, and this should throw, and should not error out with a return type mismatch error. The patch changes two getters of TS parser related IdentifierFunctionLine to obey this difference and now throws in case it "has been set up incompletely". In this case, an IdentifierFunctionLine is only "complete" after at least an identifier token stream and a function name token has been set: After being fully set up, these two properties must have a value. The object knows this and the two getters now throw an exception instead of failing with a type error. Resolves: #103977 Related: #97816 Releases: main, 12.4 Change-Id: I772d774fbaae3c2ec7ff4c9abc6ef4964254259d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84496 Tested-by:
-
