- May 27, 2022
-
-
Chris Müller authored
The patch provides the following changes: - Use consistent header levels - Format code examples with the correct language - Use example.org as domain for example link - Apply takeaways from https://forge.typo3.org/issues/85035#note-8 (chapter "login process") Resolves: #97692 Related: #85035 Releases: main, 11.5 Change-Id: If6c7851c25210cf4e03fb07efeaf14973e667cb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74746 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
php-cs-fixer has the fixer `function_to_constant` which replaces PHP functions to their equivalent constants, which is added with this commit. Resolves: #97697 Releases: main Change-Id: Ibdbfab404d2a7d35698d4afd6bb265294f7c3faf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74773 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Andreas Fernandez authored
The package guzzlehttp/guzzle has been updated to 7.4.3 and 6.5.6 respectively, both fixing a security vulnerability related to cross-domain cookie leakage [1]. Since TYPO3 is not affected by this issue by default, this is handled as a public bugfix. However, 3rd party code (e.g. thru extensions) may be affected by this issue, as long `'cookies' => true` is used in requests done by Guzzle. Executed commands: composer require \ guzzlehttp/guzzle:^7.4.3 \ -W composer require \ -d typo3/sysext/core \ guzzlehttp/guzzle:^7.4.3 \ --no-update [1] https://github.com/guzzle/guzzle/security/advisories/GHSA-cwmx-hcrq-mhc3 Resolves: #97694 Releases: main, 11.5, 10.4 Change-Id: I39071c917c7ed26392f66b0ea2f774ecbceead9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74747 Tested-by:Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- May 25, 2022
-
-
Oliver Bartsch authored
If a table in recordlist only contains records which do not provide a checkbox, the "toggle all" action should be disabled as well, since using this action would have no effect. Resolves: #97685 Releases: main, 11.5 Change-Id: Id87bb5dd9df10c33acd03d0c5dbca179bb7f1cdd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74736 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
Occurred on accessing the record history for records on pid=0. Resolves: #97682 Releases: main, 11.5 Change-Id: I041fd9c2dfa8f8cfda4f89c47d320e5bfa6e7f3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74733 Tested-by:
-
Oliver Bartsch authored
Ensure to properly typecast optional parameters of throwStatus() before passing them to type hinted methods. Resolves: #97666 Releases: main, 11.5 Change-Id: Ifb6d43cffc97899cdd4ab72d48703bc3db23f0e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74735 Tested-by:
-
Oliver Klee authored
Also drop type annotations that already are present in the corresponding field in the superclass, and drop some type annotations that are redundant with the existing native type declarations. This helps resolves a bunch of new PHPStan warnings after the recent changes in the testing framework. It also helps static code analysis, and makes the code more succinct. Resolves: #97687 Releases: main, 11.5 Change-Id: I6f1b67f410f7e195b036bc5b5b528cb271a990b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74738 Tested-by:
-
Oliver Bartsch authored
When creating bookmarks to the "new" view in FormEngine, those bookmark previously did not show up in the toolbar list, because the parent page access check failed. This is now fixed by also resolving the parent page for new record bookmarks properly. Additionally the shortcut title for those use cases does now match the title, displayed in FormEngine. Resolves: #97655 Releases: main, 11.5 Change-Id: If62391bffe4126c746b6c5650d1aa9d0821f2960 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74691 Tested-by:
-
Larry Garfield authored
The code in ConjunctionValidator can be greatly simplified by taking advantage of the fact that an empty result object can be merged with a future one. That eliminates an unnecessary code path as well as phpstan warnings. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97623 Releases: main, 11.5 Change-Id: I6f10c25562044adb5cbe283255ea07e71effa9cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74638 Tested-by:
-
Helmut Hummel authored
When generating the identifier for the package artifact, not only the hash from the composer.lock must be taken into account, but also whether packages have been installed in dev mode or not. Since dev mode does not change the lock hash, it otherwise can happen that a stale DI cache with invalid set of packages is used, which obviously leads to fatal errors Releases: main, 11.5 Resolves: #97688 Change-Id: I29461c133a866fcbf16848a4540eef33aa52d450 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74739 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Simon Schaufelberger authored
GIFBUILDER processing doesn't return a processedFile Resolves: #97651 Releases: main, 11.5 Change-Id: I24964ec640636dc88b10a5433517bed0ce576ed0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74678 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- May 24, 2022
-
-
Rudy Gnodde authored
Resolves: #97686 Releases: master, 11.5 Change-Id: I0228126e4b7dd091b6eddc70bbbd8aade6142dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74737 Reviewed-by:
-
Torben Hansen authored
This patch fixes a typo in the description for BE.compressionLevel. A single `s` is missing in `_.htacces` Resolves: #97683 Releases: main, 11.5 Change-Id: I6ceab51140c8cad68d724cb13b5947d1ea38dba1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74732 Tested-by:
-
- May 23, 2022
-
-
Christian Kuhn authored
A couple of left overs from a phpunit 8 compat layer. They can be safely removed since v12 and v11 require phpunit 9. Resolves: #97680 Related: #94706 Related: #92461 Releases: main, 11.5 Change-Id: I4815c631fe2903d67a1f15591cca3a4fa6de3338 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74725 Tested-by:
-
Marcus Förster authored
Releases: main Resolves: #97675 Change-Id: Id92fd0bc9b9fe5dfdb4a771d165527debc832fc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74719 Tested-by:
-
Oliver Klee authored
The new version finds some new possible bugs and removes some incorrect ones. Used commands: > composer req --dev phpstan/phpstan:^1.7.0 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97678 Releases: main, 11.5 Change-Id: I0359ab80b0a6afc907f76bee328fb32c1e0655b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74722 Tested-by:
-
TD authored
Adds a new TypoScript option config.showWebsiteTitle. The option controls whether the website title (as defined in the site configuration) is added to the page title, which is e.g. used for the websites' title tag. Resolves: #97653 Releases: main Change-Id: I7bdde3db38f8e03023578f73e2c0968f8f40bb81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74679 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Tobias D. <tobias.doll@snk.de> Tested-by:
-
Oliver Klee authored
This update also reveals some instances where our type annotations in the tests are not specific enough. This will be tackled in a separate change. Used commands: > composer update typo3/testing-framework > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97677 Releases: main Change-Id: I19f6814a60b66f18a45be02dc9fbbb2210920308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74721 Tested-by:
-
Stefan Bürk authored
Raise phpstan to include latest phpstan bugfixes. See: https://github.com/phpstan/phpstan/releases/tag/1.6.9 Used commands: > composer req phpstan/phpstan:^1.6.9 --dev > Build/Scripts/runTests.sh -s clean ; \ Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97668 Releases: main, 11.5 Change-Id: I61298c1696b14a6e89ddc98043de13acb127c6a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74712 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- May 22, 2022
-
-
Chris Müller authored
Resolves: #97674 Releases: main Change-Id: Ib4340b50576f0b506fec5c5b16ec8ec17fe73373 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74718 Tested-by:
-
Lina Wolf authored
The text role `:ts:` may only be used for typescript, not typoscript. It does therefore not render. Releases: main Resolves: #97670 Change-Id: I29b394b701c96819088b3f5ae9154db1bb741131 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74715 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Chris Müller authored
Resolves: #97672 Releases: main Change-Id: Id23321312212e6ce331d898d588149dbf1ff1703 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74716 Tested-by:
-
- May 20, 2022
-
-
Felix Nagel authored
When using stdWrap for setting the actual parameter value, all additional information (like target, class and title) is lost. With this change the expected behavior (keeping and rendering all additional information) is restored. Using stdWrap for parameter is a useful feature for changing the value depending on page or record properties. Think of changing the detail page of a news record based on the type of the news. To ensure functionality there are two new tests. One for testing the general functionality when using a stdWrap parameter and one to make sure additional information is processed. Resolves: #80896 Resolves: #90404 Releases: main, 11.5 Change-Id: I60c5ae43d5e27071be9cf244a0857a25adb8592b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74620 Tested-by:
-
Benni Mack authored
This change reduces specialities within DataHandler: * DataHandler->username is not used, and can be removed. * Initial check in workspaceCannotEditOfflineVersion() can be moved to the caller class, using more useful log entries. * recordInfo() now fetches the full record from the DB which could then be cached separately during runtime. * Some internal methods are marked as protected, as they are trivial to re-implement and currently only used by DataHandler anyways. Resolves: #97628 Releases: main Change-Id: Ia91066914fadd9f5648d0d60de4d8bbf3c9daf21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74519 Tested-by:
-
Larry Garfield authored
These values are already nullable according to the code, so document that. Resolves: #97656 Releases: main, 11.5 Change-Id: Ic1411e565d056d29febfb6a4af6a8ab1506a8189 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74683 Tested-by:
-
Simon Schaufelberger authored
H needs to be used because the datepicker is in 24h mode and i stands for minutes with leading zero Resolves: #97650 Releases: main, 11.5 Change-Id: Id3e37fdf08f34eda8b9e2a40e877e611996c2404 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74687 Tested-by:
-
Christoph Lehmann authored
This displays the total time spend for sql queries and the total amount of sql queries in the Admin Panel. Resolves: #97493 Releases: main, 11.5 Change-Id: I4167ca6c85e6b6bb71f5b2f3682c39d44f26e6f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74449 Tested-by:
-
Torben Hansen authored
It is possible to register a dedicated icon for a plugin in ExtensionUtility::registerPlugin(). This icon is used in the plugin select field, but not for the content element preview where always a default icon is shown. With this change, a possible configured plugin icon is used in content element preview, if the icon is registered using the TYPO3 icon API. Additionally the indexed_search plugin now uses 'mimetypes-x-content-form-search' as plugin icon. Resolves: #97635 Releases: main, 11.5 Change-Id: I8e688c7e4c75f92c35f9f82f32b8434d44829e05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74650 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Larry Garfield authored
ftok() doesn't return false, but -1 on error. The $resource property may be null to indicate no lock is active, so allow that. Resolves: #97644 Releases: main, 11.5 Change-Id: I88eb20b2399c119390c7e6c34c985a87706db4d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74654 Tested-by:
-
- May 19, 2022
-
-
Sybille Peters authored
The note about jumping to a previous version of the page is obsolete, because you can switch no further than version 8.7 with the version selector and the older version is in v7.6. In any case, if someone needs the information for version 7.6 and below they must use other means anyway (e.g. use Git repository and render locally) since these older versions are no longer rendered on docs.typo3.og. Resolves: #97632 Releases: main, 11.5, 10.4 Change-Id: Iedbb482c4086ed4740410acc3c6e82f47607ec52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74646 Tested-by:
-
Stephan Großberndt authored
Use the correct middleware name 'typo3/cms-frontend/authentication' in the changelog instead of referring to a non-existing name. Releases: main, 11.5, 10.4 Resolves: #97660 Change-Id: I5ebb586689f3173e1cc2a06049fd4b4d40430972 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74685 Reviewed-by:
-
- May 17, 2022
-
-
Oliver Klee authored
This helps static analysis. Resolves: #97631 Releases: main, 11.5 Change-Id: If06aea0d310fa56333d93c99f1400db8d74706fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74645 Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Larry Garfield authored
Mostly these are due to SimpleXML not casting cleanly to strings, so making the casts explicit resolves them. Resolves: #97643 Releases: main, 11.5 Change-Id: I036ba8bf08d2a96f5f58b352b82991eeadded990 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74653 Tested-by:
-
- May 16, 2022
-
-
Oliver Klee authored
This is only possible with PHPUnit, not with Prophecy, and it is bad practice as there is no way to do type analysis on classes that do not exist. Also avoid using mocks where an `stdClass` instance does just fine. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97634 Releases: main, 11.5 Change-Id: I2a92678a60df7bd762688e3b7571b18f861340d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74648 Tested-by:
-
- May 13, 2022
-
-
Larry Garfield authored
There are several PHPStan Baseline exceptions for misuse of the ?? operator. Many of them are no longer necessary thanks to either other code evolution or PHP evolution. This patch cleans those up. Resolves: #97456 Releases: main, 11.5 Change-Id: I47c23157398e80eb63e17455f820df3a6d756724 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74375 Tested-by:
-
Oliver Klee authored
Resolves: #97425 Releases: main, 11.5 Change-Id: Ie3679f8a0f51ee2000ce45dfab1ea82bdc67c0ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74349 Tested-by:
-
Oliver Bartsch authored
Resolves: #97619 Releases: main, 11.5 Change-Id: Ib1812d04264cab9bf867891f8cc06d7dafeace99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74635 Tested-by:
-
Jochen Roth authored
Currently, only SysFolders are excluded in the SiteConfiguration overview which allows to add a SiteConfiguration to pages where it is superfluous. This has been fixed by adding doktype spacer, recycler, external link to the list of excluded doktypes in the queryBuilder statement. Resolves: #97609 Releases: main, 11.5 Change-Id: Idfb5a97c8780117b5b478c14e0d2e2946dfbca8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74604 Tested-by:
-
- May 12, 2022
-
-
Česlav Przywara authored
Also fixes a non-existing link that is generated: https://forge.typo3.org/issues/#93436 becomes https://forge.typo3.org/issues/93436 Releases: main, 11.5 Resolves: #97617 Change-Id: Ic30261223d0cbe5d48a2e88fa87713ba3a698db2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74611 Tested-by:
-
rintisch authored
The screenshots of the UI shows the word `Levels` while the text used `Layers`. Releases: main, 11.5 Resolves: #97613 Change-Id: Ib539d01496d83c6eef65683aeac306302ed5b9f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74608 Tested-by:
-
