Skip to content
Snippets Groups Projects
Commit 3669bf6d authored by Oliver Klee's avatar Oliver Klee Committed by Stefan Bürk
Browse files

[TASK] Update the testing framework 

This update also reveals some instances where our type
annotations in the tests are not specific enough.
This will be tackled in a separate change.

Used commands:

> composer update typo3/testing-framework
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #97677
Releases: main
Change-Id: I19f6814a60b66f18a45be02dc9fbbb2210920308
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74721


Tested-by: default avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
parent d438fbd5
Branches
Tags
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Build/phpstan/phpstan-baseline.neon
+ 90
− 0
View file @ 3669bf6d
......@@ -250,6 +250,16 @@ parameters:
count: 1
path: ../../typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php
-
message: "#^PHPDoc type array\\<string\\> of property TYPO3\\\\CMS\\\\Backend\\\\Tests\\\\Functional\\\\Configuration\\\\SiteConfiguration\\\\SiteConfigurationOverridesTest\\:\\:\\$testExtensionsToLoad is not covariant with PHPDoc type array\\<non\\-empty\\-string\\> of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$testExtensionsToLoad\\.$#"
count: 1
path: ../../typo3/sysext/backend/Tests/Functional/Configuration/SiteConfiguration/SiteConfigurationOverridesTest.php
-
message: "#^PHPDoc type string of property TYPO3\\\\CMS\\\\Backend\\\\Tests\\\\Functional\\\\Controller\\\\Page\\\\TreeControllerTest\\:\\:\\$backendUserFixture is not covariant with PHPDoc type non\\-empty\\-string of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$backendUserFixture\\.$#"
count: 1
path: ../../typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php
-
message: "#^Constructor of class TYPO3\\\\CMS\\\\Backend\\\\Tests\\\\Unit\\\\Form\\\\Fixtures\\\\NodeFactory\\\\NodeElements\\\\BarElement has an unused parameter \\$data\\.$#"
count: 1
......@@ -1650,11 +1660,31 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Functional/Cache/Backend/RedisBackendTest.php
-
message: "#^PHPDoc type array of property TYPO3\\\\CMS\\\\Core\\\\Tests\\\\Functional\\\\Cache\\\\Backend\\\\Typo3DatabaseBackendTest\\:\\:\\$configurationToUseInTestInstance is not covariant with PHPDoc type array\\<string, mixed\\> of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$configurationToUseInTestInstance\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php
-
message: "#^PHPDoc type array of property TYPO3\\\\CMS\\\\Core\\\\Tests\\\\Functional\\\\Cache\\\\Frontend\\\\VariableFrontendTest\\:\\:\\$configurationToUseInTestInstance is not covariant with PHPDoc type array\\<string, mixed\\> of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$configurationToUseInTestInstance\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Functional/Cache/Frontend/VariableFrontendTest.php
-
message: "#^Call to an undefined method TYPO3\\\\CMS\\\\Core\\\\Collection\\\\CollectionInterface\\:\\:add\\(\\)\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php
-
message: "#^PHPDoc type array of property TYPO3\\\\CMS\\\\Core\\\\Tests\\\\Functional\\\\Command\\\\CacheFlushCommandTest\\:\\:\\$configurationToUseInTestInstance is not covariant with PHPDoc type array\\<string, mixed\\> of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$configurationToUseInTestInstance\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Functional/Command/CacheFlushCommandTest.php
-
message: "#^PHPDoc type string of property TYPO3\\\\CMS\\\\Core\\\\Tests\\\\Functional\\\\DataHandling\\\\Regular\\\\Hooks\\\\PagesTsConfigGuardTest\\:\\:\\$backendUserFixture is not covariant with PHPDoc type non\\-empty\\-string of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$backendUserFixture\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Functional/DataHandling/Regular/Hooks/PagesTsConfigGuardTest.php
-
message: "#^Parameter \\#1 \\$iterator of method TYPO3\\\\TestIrreForeignfield\\\\Controller\\\\AbstractController\\:\\:getStructure\\(\\) expects iterable\\<TYPO3\\\\CMS\\\\Extbase\\\\DomainObject\\\\AbstractEntity\\>&Iterator, TYPO3\\\\TestIrreForeignfield\\\\Domain\\\\Model\\\\Content given\\.$#"
count: 1
......@@ -1670,6 +1700,11 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Functional/Fixtures/Frontend/PhpError.php
-
message: "#^PHPDoc type array\\<string\\> of property TYPO3\\\\CMS\\\\Core\\\\Tests\\\\Functional\\\\Mail\\\\FluidEmailTest\\:\\:\\$testExtensionsToLoad is not covariant with PHPDoc type array\\<non\\-empty\\-string\\> of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$testExtensionsToLoad\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Functional/Mail/FluidEmailTest.php
-
message: "#^Parameter \\#3 \\$compress of method TYPO3\\\\CMS\\\\Core\\\\Page\\\\PageRenderer\\:\\:addCssInlineBlock\\(\\) expects bool, null given\\.$#"
count: 1
......@@ -1885,11 +1920,26 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Http/StreamTest.php
-
message: "#^Property TYPO3\\\\TestingFramework\\\\Core\\\\Unit\\\\UnitTestCase\\:\\:\\$testFilesToDelete \\(array\\<non\\-empty\\-string\\>\\) does not accept non\\-empty\\-array\\<string\\|false\\>\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Http/StreamTest.php
-
message: "#^Parameter \\#1 \\$port of method TYPO3\\\\CMS\\\\Core\\\\Http\\\\Uri\\:\\:withPort\\(\\) expects int\\|null, true given\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Http/UriTest.php
-
message: "#^Property TYPO3\\\\TestingFramework\\\\Core\\\\Unit\\\\UnitTestCase\\:\\:\\$testFilesToDelete \\(array\\<non\\-empty\\-string\\>\\) does not accept non\\-empty\\-array\\<string\\>\\.$#"
count: 2
path: ../../typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgIconProviderTest.php
-
message: "#^Property TYPO3\\\\TestingFramework\\\\Core\\\\Unit\\\\UnitTestCase\\:\\:\\$testFilesToDelete \\(array\\<non\\-empty\\-string\\>\\) does not accept non\\-empty\\-array\\<string\\>\\.$#"
count: 2
path: ../../typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgSpriteIconProviderTest.php
-
message: "#^Parameter \\#1 \\$data of method TYPO3\\\\CMS\\\\Core\\\\LinkHandling\\\\EmailLinkHandler\\:\\:resolveHandlerData\\(\\) expects array, string given\\.$#"
count: 1
......@@ -2025,6 +2075,11 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php
-
message: "#^Property TYPO3\\\\TestingFramework\\\\Core\\\\Unit\\\\UnitTestCase\\:\\:\\$testFilesToDelete \\(array\\<non\\-empty\\-string\\>\\) does not accept non\\-empty\\-array\\<string\\>\\.$#"
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php
-
message: "#^Variable \\$driver in PHPDoc tag @var does not exist\\.$#"
count: 1
......@@ -2110,6 +2165,11 @@ parameters:
count: 1
path: ../../typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
-
message: "#^Property TYPO3\\\\TestingFramework\\\\Core\\\\Unit\\\\UnitTestCase\\:\\:\\$testFilesToDelete \\(array\\<non\\-empty\\-string\\>\\) does not accept non\\-empty\\-array\\<string\\>\\.$#"
count: 4
path: ../../typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
-
message: "#^Static method TYPO3\\\\CMS\\\\Core\\\\Utility\\\\GeneralUtility\\:\\:callUserFunction\\(\\) invoked with 4 parameters, 2\\-3 required\\.$#"
count: 1
......@@ -3825,6 +3885,11 @@ parameters:
count: 1
path: ../../typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php
-
message: "#^PHPDoc type array\\<string\\> of property TYPO3\\\\CMS\\\\Frontend\\\\Tests\\\\Functional\\\\SiteHandling\\\\EidRequestTest\\:\\:\\$testExtensionsToLoad is not covariant with PHPDoc type array\\<non\\-empty\\-string\\> of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$testExtensionsToLoad\\.$#"
count: 1
path: ../../typo3/sysext/frontend/Tests/Functional/SiteHandling/EidRequestTest.php
-
message: "#^Else branch is unreachable because previous condition is always true\\.$#"
count: 1
......@@ -4070,6 +4135,16 @@ parameters:
count: 1
path: ../../typo3/sysext/impexp/Tests/Functional/Export/ExportPageTreeViewTest.php
-
message: "#^PHPDoc type array of property TYPO3\\\\CMS\\\\Impexp\\\\Tests\\\\Functional\\\\Import\\\\PagesAndTtContentWithImagesInFilledDatabaseTest\\:\\:\\$additionalFoldersToCreate is not covariant with PHPDoc type array\\<non\\-empty\\-string\\> of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$additionalFoldersToCreate\\.$#"
count: 1
path: ../../typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php
-
message: "#^PHPDoc type array of property TYPO3\\\\CMS\\\\Impexp\\\\Tests\\\\Functional\\\\Import\\\\PagesAndTtContentWithRteImagesAndFileLinkTest\\:\\:\\$additionalFoldersToCreate is not covariant with PHPDoc type array\\<non\\-empty\\-string\\> of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$additionalFoldersToCreate\\.$#"
count: 1
path: ../../typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithRteImagesAndFileLinkTest.php
-
message: "#^Parameter \\#2 \\$all of method TYPO3\\\\CMS\\\\Impexp\\\\Import\\:\\:loadFile\\(\\) expects bool, int given\\.$#"
count: 1
......@@ -4370,6 +4445,11 @@ parameters:
count: 1
path: ../../typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php
-
message: "#^Property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$backendUserFixture \\(non\\-empty\\-string\\) does not accept string\\.$#"
count: 1
path: ../../typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php
-
message: "#^Parameter \\#2 \\$softRefEntry of method TYPO3\\\\CMS\\\\Linkvalidator\\\\Linktype\\\\ExternalLinktype\\:\\:checkLink\\(\\) expects array, null given\\.$#"
count: 2
......@@ -4430,6 +4510,11 @@ parameters:
count: 1
path: ../../typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php
-
message: "#^PHPDoc type string of property TYPO3\\\\CMS\\\\Recycler\\\\Tests\\\\Functional\\\\Recycle\\\\AbstractRecycleTestCase\\:\\:\\$backendUserFixture is not covariant with PHPDoc type non\\-empty\\-string of overridden property TYPO3\\\\TestingFramework\\\\Core\\\\Functional\\\\FunctionalTestCase\\:\\:\\$backendUserFixture\\.$#"
count: 1
path: ../../typo3/sysext/recycler/Tests/Functional/Recycle/AbstractRecycleTestCase.php
-
message: "#^Call to an undefined method TYPO3\\\\CMS\\\\Recycler\\\\Task\\\\CleanerFieldProvider\\:\\:expects\\(\\)\\.$#"
count: 1
......@@ -4480,6 +4565,11 @@ parameters:
count: 1
path: ../../typo3/sysext/scheduler/Classes/Scheduler.php
-
message: "#^PHPDoc type array of property TYPO3\\\\CMS\\\\Seo\\\\Tests\\\\Functional\\\\XmlSitemap\\\\XmlSitemapPagesWithHideIfNotTranslatedTest\\:\\:\\$configurationToUseInTestInstance is not covariant with PHPDoc type array\\<string, mixed\\> of overridden property TYPO3\\\\CMS\\\\Frontend\\\\Tests\\\\Functional\\\\SiteHandling\\\\AbstractTestCase\\:\\:\\$configurationToUseInTestInstance\\.$#"
count: 1
path: ../../typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesWithHideIfNotTranslatedTest.php
-
message: "#^If condition is always true\\.$#"
count: 1
......
composer.lock
+ 4
− 4
View file @ 3669bf6d
......@@ -8315,12 +8315,12 @@
"source": {
"type": "git",
"url": "https://github.com/TYPO3/testing-framework.git",
"reference": "85eb4fbccacdf04c26d78828b2b93d0b61db280b"
"reference": "731ab4c7be7a7ec8211c41ffd63c7dca18fb3669"
},
"dist": {
"type": "zip",
"url": "https://api.github.com/repos/TYPO3/testing-framework/zipball/85eb4fbccacdf04c26d78828b2b93d0b61db280b",
"reference": "85eb4fbccacdf04c26d78828b2b93d0b61db280b",
"url": "https://api.github.com/repos/TYPO3/testing-framework/zipball/731ab4c7be7a7ec8211c41ffd63c7dca18fb3669",
"reference": "731ab4c7be7a7ec8211c41ffd63c7dca18fb3669",
"shasum": ""
},
"require": {
......@@ -8384,7 +8384,7 @@
"issues": "https://github.com/TYPO3/testing-framework/issues",
"source": "https://github.com/TYPO3/testing-framework/tree/main"
},
"time": "2022-05-09T22:35:11+00:00"
"time": "2022-05-23T08:55:02+00:00"
}
],
"aliases": [],
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment