- Jan 17, 2018
-
-
Christian Kuhn authored
File list table needs a wrapper div to have borders and shadows to look alike tables of the list module. Change-Id: Id68f9b328c65e3d2dc59281a730bebd0430a179d Resolves: #83604 Releases: master Reviewed-on: https://review.typo3.org/55388 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Frank Naegler authored
Resolves: #83578 Related: #83580 Releases: master Change-Id: I2c97edd4bac854b33501ba571ed479bdefc288d7 Reviewed-on: https://review.typo3.org/55373 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Christian Kuhn authored
The export modules has a file size restriction that skips file exports if they are bigger than by default 1MB. This can be raised with an input field. The patch removes that input field: * Configured maximum file sizes are checked during upload already. A well configured system should expect existing files are ok and just export everything * The 1MB default size is old fashioned. Typical images are often bigger in size and resized only during FE rendering * Skipping arbitrary files in export has a negative impact on data consistency of the export. * Single files can still be excluded from export if needed * Users up until now usually had manually raised the limit to some value high enough to make all files fit Change-Id: Ib70dc48de44d215067474b4c3f6fff8988ab7712 Resolves: #83596 Releases: master Reviewed-on: https://review.typo3.org/55382 Reviewed-by:
Reiner Teubner <rteubner@me.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christian Kuhn authored
Uploading import files broke with patch for issue #81763 Fix by renaming POST array back from 'data' to 'file'. Change-Id: I8de880775e2949951ef8a3f45b0a704c2ef3ac76 Resolves: #83599 Related: #81763 Releases: master Reviewed-on: https://review.typo3.org/55385 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Christian Kuhn authored
The TYPO3 specific .t3d export format is a funny binary format and rather hard to read and decipher, even if not compressed. The XML format is at least some easy to read text file instead of a binary format and exists for quite some time in the system. Use XML as default export format by just swapping the option box entries. Change-Id: I5b25d8dc0b33158e98d1aafba27ab7669edeb725 Resolves: #83597 Releases: master Reviewed-on: https://review.typo3.org/55383 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
The 'export' module has a restriction to limit the number of exported records. The patch removes this from the interface: * The default limit is arbitrary, removing that limit declutters the interface a little bit * Users probably always did just set this to some number high enough to export everything they wanted * It was not clear what exactly is counted. At least it was not the total number of exported records ... * The error and flash messages were unclear and sometimes not shown at all * The limit could lead to data integrity issues in the export file, for example if a page links to some other page that is not exported * Presets that increased the limit still work * To prevent a breaking patch, the affected PHP method arguments deprecate some arguments instead of fully removing them in v9 Change-Id: Iadb365ff2ccd77ed38cbde81b76e37990a0c6f17 Resolves: #83592 Releases: master Reviewed-on: https://review.typo3.org/55381 Tested-by:
-
Georg Ringer authored
Avoid spamming the log in PHP 7.2 due to get_class(null) if fetching the image in ImageService->getImage() fails. Resolves: #83570 Releases: master, 8.7, 7.6 Change-Id: Icc3c78f5b747842cee89d184134ff298b8e04a3a Reviewed-on: https://review.typo3.org/55370 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Mattia D <mattia.dorigatti@brandnamic.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
- Jan 16, 2018
-
-
Andreas Fernandez authored
With #83267 a JSON response object was introduced. The patch has the side effect that any response is now an array but some usages in JavaScript were not adjusted. This patch does two things: - `FileController::fileExistsInFolderAction()` does now either return an array for falsy results OR the file object. - The JavaScript code is adjusted to check for a valid file object by requiring the `uid` property instead. Resolves: #83568 Related: #83267 Releases: master Change-Id: I9878f5f70b8af3ba8ec151a6ed514780547ec1ea Reviewed-on: https://review.typo3.org/55371 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
Stefan Neufeind authored
Since the extension is deprecated, don't activate it by default (factory-configuration). Resolves: #81852 Releases: master Change-Id: I10ecba6978daa16b43775a7adb28d723c8138ce0 Reviewed-on: https://review.typo3.org/55363 Tested-by:
-
- Jan 15, 2018
-
-
Christian Kuhn authored
Fix a case during ext:impexp FAL uid mapping where sys_file_reference end up pointing to wrong sys_file records in case new sys_file uids also already exist in import file, due to multiple mappings. Power the patch with a functional test - it fails without the change in Import.php and is ok with the change. See the test method comments for more details on what exactly is checked here. Change-Id: I472cad2652e8d6f5d30e4ebc68ff1ae93de71ea1 Resolves: #67188 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55365 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Georg Ringer authored
Only https can really secure a connection. Therefore rsaauth should be marked as deprecated. An additional report checks the usage of the extension and https. Resolves: #81852 Releases: master Change-Id: I5d12e1e7c97d55869379228b39fa5e87b2287e88 Reviewed-on: https://review.typo3.org/53458 Reviewed-by:
-
- Jan 14, 2018
-
-
Christian Kuhn authored
If path to the destination directory does not exist yet, copyDirectory() does not copy anything. Use mkdir_deep() for directories. As example, have directory 'typo3temp' and call copyDirectory() with a destination 'typo3temp/foo/bar', where 'foo' does not exist, yet. Without patch, this operation fails. Change-Id: Id8eb5d6cd30c288ca073e98d35a3025c8489c182 Resolves: #83564 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55360 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Ralf Zimmermann authored
Makes it possible to iterate through FinisherVariableProvider items. Resolves: #83396 Releases: master Change-Id: I0b778b9a6d4ede4d2df8190d6b4821903caee6a4 Reviewed-on: https://review.typo3.org/55308 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #83522 Change-Id: Ie1f9db6e3180c1d32e3d8b99e37ff88669ede86d Reviewed-on: https://review.typo3.org/55314 Reviewed-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #83521 Change-Id: I8bd477ccf2ae6fca478b758cf61654a1bec388cd Reviewed-on: https://review.typo3.org/55313 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #83520 Change-Id: Idd10aa62692198f7aa20af1492fb9670149d5ac9 Reviewed-on: https://review.typo3.org/55312 Reviewed-by:
-
- Jan 13, 2018
-
-
Nicole Cordes authored
If a scanAvailablePackages() of the PackageManager is triggered, we need to make sure all possible packagesBasePaths are taken into account. As new extensions might have been downloaded, we need to re-check those possible paths unless all were found. Resolves: #83560 Releases: master, 8.7 Change-Id: I4a65a2f384163b6a3cc3071711e80d88eaf22971 Reviewed-on: https://review.typo3.org/55356 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Nicole Cordes authored
The PackageManager needs to scan over all package location to be able to decide whether a package is available or not. Resolves: #83531 Releases: master, 8.7 Change-Id: Ib21c18a559b4c02d8efce146c8d5addf66b25f1f Reviewed-on: https://review.typo3.org/55326 Reviewed-by:
-
Wolfgang Klinger authored
UserTS disableDelete was set for sys_file_metadata globally and therefore also prevented the deletion of translated file metadata. By preventing deletion of sys_file_metadata records only for default language records, the user can remove translated ones again at will. Resolves: #83066 Relates: #71678 Releases: master, 8.7 Change-Id: I3b83a3dd63b02b94bdd34dd8f002436af14ad45d Reviewed-on: https://review.typo3.org/55340 Reviewed-by:
-
Christian Kuhn authored
The extension scanner docs has recently been moved around within core api docs. Update the link within the upgrade module accordingly. Change-Id: Id74a3fa162db63a4257a1d8d2b6b9037bd661467 Resolves: #83558 Releases: master Reviewed-on: https://review.typo3.org/55353 Tested-by:
-
Christian Kuhn authored
Apply a series of CGL whitespace fixes, mostly: * No whitespace after type cast * One space around '=' Change-Id: I6279e083a4bd867bfb70c9567c35b6bab1412043 Resolves: #83557 Releases: master Reviewed-on: https://review.typo3.org/55352 Tested-by:
-
Christian Kuhn authored
Apply various minor indentation CGL fixes, as suggested by scrutinizer-ci, mostly related to places where indentation is done with 1 or 3 spaces instead of 4. Change-Id: Ie3345c7391c0735e8074fd633dd9523616a6b82d Resolves: #83555 Releases: master Reviewed-on: https://review.typo3.org/55350 Reviewed-by:
-
Christian Kuhn authored
This cosmetical CGL change just substitutes all declare(strict_types=1); with declare(strict_types = 1); to be in line with the general 'spaces around =' rule. While that is cosmetical, it makes scrutinizer-ci a bit more happy and prevents it from creating auto-patches for these cases. Change-Id: Ic754b3fd2a0f06624909e6188ed270bd2797745c Resolves: #83554 Releases: master Reviewed-on: https://review.typo3.org/55349 Tested-by:
-
Christian Kuhn authored
Patch renames the context menu options "Export to .t3d" to "Export" and "Import from .t3d" to "Import". The technical format detail is no good additional information and also misleading since xml exports are possible, too. Change-Id: I0d5bb6b1c390a6c74f58d41b06aac935bad82ec0 Resolves: #83552 Releases: master Reviewed-on: https://review.typo3.org/55346 Tested-by:
-
Wolfgang Klinger authored
Output folder meta information (file count and total file size) next to the folder path in Filelist again. Additionally fix a typo in a condition above. Resolves: #83528 Releases: master, 8.7 Change-Id: I6969966405655d54528059ec937018078caea9d9 Reviewed-on: https://review.typo3.org/55318 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Alexander Schnitzler authored
This patch mainly converts several unit tests with heavy mocking to functional tests with real fixtures instead of 'eval()'ed classes. During that seperation two minor bugs have been fixed: - "resolveValidatorObjectName" tried to find non FQCN validators by checking for a colon, an underscore or a backslash. That way it found shorthand validators like "TYPO3.CMS.Extbase:NotEmpty" and validators without any extension reference. e.g. "NotEmpty". While that check itself is not a problem, the resolver furthermore explodes the validator name by colons, which fails for validator names without extension reference. This has been fixed by an additional elseif. - Another small bug has been fixed in the method "buildBaseValidatorConjunction". While aggregating the validator annotations, the method "parseValidatorAnnotation" is called that returns an array with the annotation information. If the information is built for a method param, the key argumentName is set. However, this is not the case for properties but following code relied on argumentName being present. argumentName is now explicitly set to null if not given. Releases: master Resolves: #83481 Change-Id: I413b85ad905c19f6ae7daef8f5d97aeeab2edb90 Reviewed-on: https://review.typo3.org/55275 Tested-by:
-
Markus Klein authored
Source: http://unicode.org/Public/UNIDATA/UnicodeData.txt Releases: master, 8.7 Resolves: #83541 Change-Id: I0ba23c774f24be120c562239c7665c8a1732cbb1 Reviewed-on: https://review.typo3.org/55334 Reviewed-by:
-
Christian Kuhn authored
The recommendation of FolderStructure having index.php and typo3/ folder as links is old fashioned, even if not using composer based instances. The config has no functional meaning in the install tool and can just be dropped. Change-Id: Ie8addd1713cadeb381a11cf9a362ac255da6e72c Resolves: #83550 Releases: master Reviewed-on: https://review.typo3.org/55343 Tested-by:
-
Christian Kuhn authored
One of the environment image tests misses an explicit fixPermissions() call on a created image resulting in potentially broken file permissions on that file. Change-Id: Ib7e9da2269aaabdd9cc815d8ff2f0d3841b45444 Resolves: #83549 Releases: master Reviewed-on: https://review.typo3.org/55342 Tested-by:
-
- Jan 12, 2018
-
-
Reiner Teubner authored
Add a new test for the function specCharsToASCII(). Resolves: #83546 Related: #20612 Releases: master Change-Id: Id255ab953ef7c1865a7db1892b9b5d5fac87c547 Reviewed-on: https://review.typo3.org/55333 Reviewed-by:
-
Anja Leichsenring authored
Add a matcher that is able to detect hits of method calls that do not comply to a minimum amount of arguments, where new arguments have been introduced or previously optional ones have been made mandatory. Resolves: #83471 Relates: #82899 Releases: master Change-Id: I96eedb06bfcd88a8927902060224b12b64f6f470 Reviewed-on: https://review.typo3.org/55268 Tested-by:
-
Tymoteusz Motylewski authored
intExplode missed an additional parameter which prevents the method from returning array with empty element. Now when doktypesToShowInNewPageDragArea is empty, PageTree API will return empty array. Resolves: #83542 Releases: master Change-Id: I0ebfaef8e1ea782580e0feda59958bb39b0ca483 Reviewed-on: https://review.typo3.org/55335 Tested-by:
-
Andreas Fernandez authored
The directory name for deprecated unit tests are named "Unit_Deprecated" for EXT:core and EXT:form, which is wrong, the tests don't get executed. This patch fixes the names to "UnitDeprecated". Resolves: #83525 Releases: master Change-Id: I2f6f3a70ae4514e58bc885416821cf2aa3340297 Reviewed-on: https://review.typo3.org/55317 Tested-by:
-
- Jan 11, 2018
-
-
Christian Kuhn authored
With the switch from npm install to yarn install we forgot to adapt the test suites. Update plan specs. Change-Id: Ibced9d53a4abf73b33e95027a61263f19cd94e56 Resolves: #83544 Related: #83038 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55336 Tested-by:
-
Andreas Fernandez authored
Resolves: #83537 Releases: master Change-Id: I8da8f31447bd2ca73aa7d7c22a929b918a085da8 Reviewed-on: https://review.typo3.org/55332 Tested-by:
-
Nicole Cordes authored
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addLLrefForTCAdescr needs a non-empty key as first parameter. Otherwise an exception is thrown but the message shows wrong information. Resolves: #83532 Releases: master Change-Id: I59c44b2b4aafcbbee679662ecab667c85f7a25dc Reviewed-on: https://review.typo3.org/55327 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jan 10, 2018
-
-
Helmut Hummel authored
Instead of duplicating default extension configuration in DefaultConfiguration.php, we now populate it after LocalConfiguration.php has been written. Benefit is that we don't duplicate configuration and that we even can have other system extensions enabled by default without having to touch anything. Resolves: #83420 Releases: master Change-Id: I4118066e986bc7bab2dcb0cc67dbd4a2d89c70a3 Reviewed-on: https://review.typo3.org/55209 Tested-by:
-
Andreas Fernandez authored
`break-all` breaks the text in the cache menu. Use `break-word` to keep whole words intact. Resolves: #83443 Releases: master, 8.7 Change-Id: I060a3cc3d3461233d93a4b08ff6cf4ec96f0edda Reviewed-on: https://review.typo3.org/55320 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Ralf Zimmermann authored
Add the missing breaking rst for issue #82210. Resolves: #83517 Related: #82210 Releases: master Change-Id: Id157cf0678912a3008705a1fbb64a2014f2fc3f3 Reviewed-on: https://review.typo3.org/55307 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Jan 09, 2018
-
-
Andreas Fernandez authored
Some values in the Application Information toolbar menu are too long any may exceed the box's width. The CSS is adjusted to break too long strings. Also, for better readability for very long values, the alignment is changed from `middle` to `top`. Resolves: #83443 Releases: master, 8.7 Change-Id: Ia85e92e086525c8f66fd8ab225160dfbdb313a73 Reviewed-on: https://review.typo3.org/55258 Tested-by:
Michael Schams <typo3.mschams@2017.schams.net> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
