- Aug 13, 2021
-
-
Stefan Bürk authored
Remove resolved scriptName with leading slash from url in PageRouter matchRequest method. This prevent to change the url to a invalid url if PageTypeSuffix Decorator with .php is used and a page slugs ends in index. Resolves: #94537 Releases: master, 10.4, 9.5 Change-Id: I5057bb6888c228a4ca5b53d363ecf1bc7a6af1c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69854 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Andreas Häfner authored
In patch #94429 inclusion of LL file has been removed accidentally. To prevent multiple inclusion of LL-file in loop, incusion is done in DataStructureIdentifierHook::__construct now. Adds new constant for LLFile. Resolves: #90784 Related: #94429 Releases: master Change-Id: I4446ed6e05b8e506279e77fae4703a817831129d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70465 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Rudy Gnodde <rudy@famouswolf.com> Reviewed-by:
-
Ralf Zimmermann authored
Form mixins were deprecated with #89742. The patch removes the code. Resolves: #94861 Releases: master Change-Id: Ic82729ae52d3f8c6ca7cd0ad8f6c97aceebc96d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70528 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benni Mack authored
When having a content element on the clipboard (normal mode) the page module dynamically shows paste icons everywhere. This change centralizes the generation of the Paste icons into JavaScript, so the inline javascript usage of "top.*" functionality to park code somewhere has been removed, and the actual items are generated in JavaScript. In addition, as this code is only affecting the page module when a tt_content element is on the clipboard, the Paste.js JS module is only loaded when appropriate, thus reducing the actual loading time for "regular" visits on the Page Module. The icon in the paste button is now loaded via a native web component, and only necessary logic is used in the Paste JS module. The outer rendering for the Page Module has been simplified, moving this functionality all into PageLayoutController, reducing cross-dependencies between the PageLayout* classes. Resolves: #94840 Releases: master Change-Id: I380df9a56bfff74684616732166f25c68bbc6dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70488 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Guido Schmechel authored
Resolves: #94357 Releases: master, 10.4 Change-Id: I8c074372c3c42b8c5a74afff7b9fb386c2f136a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69953 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Roman Büchler authored
Resolves: #94851 Releases: master Change-Id: Ied2b2e1eb3ca05da12893a1ad23784e85bda74d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70506 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Georg Ringer authored
Skip a real check of the file system for SVG files in advance in the SvgFilesSanitization wizard to avoid timeouts in e.g. the reports module. Resolves: #94801 Releases: master, 11.3, 10.4, 9.5 Change-Id: I4ed52d357effec4a8e698d5b117f024150a01beb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70448 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Aug 12, 2021
-
-
Oliver Hader authored
Resolves: #94857 Releases: master, 11.3, 10.4, 9.5 Change-Id: I7654fb4cec38d38044441e885a21676dcacf9a8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70518 Tested-by:
-
Oliver Hader authored
A new `SanitizerInitiator` is added and forwarded to `typo3/html-sanitizer`. This allows getting a full stack-trace when HTML nodes have been sanitized/modified and to debug the actual cause (initiator) much better. To receive corresponding initiator stack-traces * logging for TYPO3.HtmlSanitizer namespace needs to be enabled * TypoScript `config.debug = 1` must be set, or as a fall-back `$GLOBALS['TYPO3_CONF_VARS']['FE']['debug'] = true;` must be set * HTML sanitizer must have found and modified invalid tags/attributes Resolves: #94837 Releases: master, 11.3, 10.4, 9.5 Change-Id: I0239785d347d2c4ad6153ccb26130556399949d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70490 Tested-by:
-
Björn Jacob authored
The Form Framework ships its own YAML loader and does not consistently use the YAML loader of the TYPO3 core. The patch documents the reasons and shows when which loader is used. Additionally, some inconsistencies are fixed with this patch. Resolves: #93579 Releases: master, 10.4 Change-Id: Ia1e091a4d54e714ca31ce44aed6c61cf994fe2d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70496 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Jochen Roth authored
Running PHP8 on "Indexing Statistics" page an undefined array key warning was thrown. This is fixed by adding a null coalescing operator. Resolves: #94845 Releases: master Change-Id: If0668f528b314dd158acf29b5b744e6e4d0dc24d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70495 Tested-by:
-
Oliver Bartsch authored
This introduces a new TCA option "showNewRecordLink" for TCA type "inline". It can be used to disable the "New record" link of inline elements, without any side effects for other links/buttons. As a consequence, the "levelLinksPosition" option does not longer support the value "none", as this behaviour (disabling all level links) should be achieved by setting the link specific options to FALSE. This means, the "levelLinksPosition" options should only be used to position the links, if shown at all. A TCA migration is in place. As another side effect, the previously - undocumented - misuse of ['enabledControls']['new'] is resolved. The mentioned option does now only affect the "+" button in each records' header. Resolves: #94765 Related: #94764 Related: #92397 Related: #82489 Releases: master Change-Id: I52bd633714d5527fec8afb37e250ef1782205ed9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70315 Tested-by:
-
Simon Gilli authored
The calls to the getUpdateSuggestions() method may result in the same change is added twice to the same hash. Using array_replace_recursive() ensures the same two suggestions are merged correctly and not as array of strings like done by the former implementation. This is important for sqlite which creates multiple statements for one 'job' sometimes. Resolves: #94709 Releases: master Change-Id: I1cec5977215559b17004d0f32b01fec039f09992 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70201 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Björn Jacob authored
In #90264 the datepicker JS was moved to an external file. A new YAML configuration has been introduced. Unfortunately, a nasty spelling error sliped in which has been fixed now. Resolves: #94846 Related: #90264 Releases: master Change-Id: I02fdd858b92afebb10295f241c9b8cdf5d10108b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70498 Tested-by:
-
Nikita Hovratov authored
During development the method name getParserByKey of the SoftReferenceParserFactoy class has been changed to getSoftReferenceParser. This renames the method in some missed places. Resolves: #94853 Releases: master Change-Id: I554e613509a32c0331de34b618ce30f29815f948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70504 Tested-by:
-
Alexander Nitsche authored
Sometimes acceptance tests fail due to a failed TYPO3 backend request, which is recorded in the TYPO3 log file. Save this log file along with the Acceptance Reports folder in the gitlab-ci job artifacts. Resolves: #94843 Releases: master, 10.4, 9.5 Change-Id: I0b260c197a6a71dc23e6f9da547fc20a55fc4ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70497 Tested-by:
-
Oliver Hader authored
https://github.com/TYPO3/html-sanitizer/releases/tag/v2.0.8 composer req typo3/html-sanitizer:^2.0.8 Resolves: #94849 Releases: master, 11.3, 10.4, 9.5 Change-Id: I367343abe5b18445ddc28023ef45c65bc6d0de23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70499 Tested-by:
-
Oliver Bartsch authored
Clipboard components still used and documented the deprecated shortMD5 method. This is now fixed. Resolves: #94844 Releases: master Change-Id: Idd30ee5af7496b8ded379b862e41c364b10e0d99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70494 Reviewed-by:
-
Roman Büchler authored
Resolves: #94838 Releases: master Change-Id: I6e5c5e5dfb58c42956629ddefa85cd5f21a55884 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70486 Tested-by:
-
Oliver Bartsch authored
In case no secondary options are available, the dropdown is not longer rendered in record- and filelist, since this led to display errors. Resolves: #94834 Releases: master Change-Id: I2aa6b60b09dbb3fa4cb3b2f79b3b44a19063c2cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70483 Tested-by:
-
Nikita Hovratov authored
The concept for registration and usage of soft reference parsers received a complete overhaul. Starting with the registration, it is now possible to register soft reference parsers by dependency injection in the extension's Services.(yaml|php) file. For this, the new tag name "softreference.parser" has been introduced. One has to provide the additional attribute "parserKey" to identify the parser. This replaces the old way of registering these parsers in the $GLOBALS array. If a parser is registered with the same key in both ways, the old way takes precedence for b/w compatibility. This comes with a completely new factory service class TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserFactory. This classes' responsibilities are collecting all registered soft reference parsers and serving them to the consumer by calling the method "getSoftReferenceParser" with the desired parser key as the only argument. There is a compatibility layer for the old way of registration and for classes not implementing the new interface. Soft reference parsers now have to implement TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserInterface. The interface defines the implementation of the "parse" method. The first 4 and the last parameter stay the same as in the old method "findRef". The remaining two parameters "spKey" and "spParams" have to be set with the "setParserKey" method, if they are needed. The key can be retrieved by using the "getParserKey" method. The different parser implementations in the old class TYPO3\CMS\Core\Database\SoftReferenceIndex have been extracted and moved into dedicated classes in the TYPO3\CMS\Core\DataHandling\SoftReference namespace. Missing tests for parsers other than "typolink" and "typolink_tag" are added. The method makeTokenID of SoftReferenceIndex has been moved into TYPO3\CMS\Core\DataHandling\SoftReference\AbstractSoftReferenceParser. A parser can extend this abstract class, if this method is needed. The methods of BackendUtility "softRefParserObj" and "explodeSoftRefParserList" are now deprecated and the replacement TYPO3\CMS\Core\DataHandling\SoftReference\SoftReferenceParserFactory should be used instead. Resolves: #94687 Resolves: #94741 Releases: master Change-Id: I460bfdd4478194fa4b4111fc44871f7225c6c084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70177 Tested-by:
-
Björn Jacob authored
Some remarks regarding the overrideConfiguration parameter have been documented. Resolves: #89933 Releases: master, 10.4 Change-Id: Iabce22db2257fc85a415d1c7d74d2a9195586ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70479 Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
-
Christian Eßl authored
Before this patch, the DatePickerViewHelper of EXT:form would always render its datepicker JavaScript inline. The DatePickerViewHelper now includes an external JS file for the initialization which is not utilizing any dynamically generated parts anymore. Resolves: #90264 Releases: master Change-Id: I1f72690d41121dc0cd48a2db55de883fe84589c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63263 Tested-by:
-
Wouter Wolters authored
Also fix method call to flushData with an array as arguments which should be a string. Resolves: #94789 Releases: master Change-Id: I19ef0f8d9b0c008b4036a2e08b674e71082cba84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70406 Tested-by:
Roman Büchler <info@buechler.pro> Tested-by:
-
Benni Mack authored
The workspaces module has a better style and some improvements for editors and administrators: * Editors now get feedback if an AJAX call shows no results * Editors + Administrators now switch workspace via a selector, very helpful when having more than a couple of workspaces * Administrators can now edit a workspace record directly from the module The change cleans up a lot of unused code in the main workspaces module and brings a few UX improvements within the module. * Dropdowns instead of tabs (good when having a lot of workspaces) * Language + Depth + Action selection is now rendered via Controller+Action instead of waiting for a first AJAX round trip * Properly using "moduleData" from "uc" to store information * Solved issues related to language icon rendering * Removed unused inline settings * Consistent usage of Persistent JS module accessing BE_Users' UC * nProgress for showing progress of loading AJAX requests Next steps in this area: * Hand in the first payload as JSON to avoid AJAX call on initial page load * Remove leftover inline JavaScript Resolves: #94819 Releases: master Change-Id: Ie533656a14af56dad4a4039fcbc9b08bde693500 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70452 Tested-by:
-
Jochen Roth authored
The custom backend logo could break the layout if not properly scaled. This issue is fixed by setting max-width and max-height for the image. Resolves: #94778 Releases: master Change-Id: I98221c721e8f9d7a7a648807ce31c0e9a00390a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70397 Tested-by:
-
Wouter Wolters authored
Main changes are: * Use assertArrayHasKey/assertArrayNotHasKey instead of array_key_exists. * Fix misordered assertEquals/assertNotEquals arguments. * Use assertCount instead of assertEquals and count() method. Resolves: #94751 Releases: master Change-Id: Iaa0dbb4744bf41f43f4700714ed47910feaab081 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70292 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christoph Schwob authored
The shortcut link type is invalid and must not be used, see e.g. https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types Resolves: #94821 Releases: master Change-Id: I5b3e5cf594ce5deedafd8b6c66d230a64b22ba58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70454 Tested-by:
-
Wouter Wolters authored
The function array_key_exists should be used instead. Resolves: #94792 Releases: master Change-Id: I19ca8fd7b003ba796d3a963d4fa0c6e7d3cdf061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70408 Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Benni Mack authored
This change falls back for the checksum of a shorter md5 hash sum in order to avoid re-processing all existing processed files. Resolves: #94832 Related: #94684 Releases: master Change-Id: Id23128a2b6466e2daa33c97d56aba24c2a1052fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70478 Reviewed-by:
-
Wouter Wolters authored
The function `setMethods` in the MockBuilder class of PHPunit is deprecated. Use `onlyMethods` or `addMethods` instead. Resolves: #94750 Releases: master Change-Id: I08728a7a3c8342c5f7f47146fa907d5ae4e58c9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70291 Tested-by:
Marvin Dosse <marvindosse@gmail.com> Tested-by:
-
Björn Jacob authored
This patch adds a note about the final "nature" of the Redirect finisher. Resolves: #91381 Releases: master, 10.4 Change-Id: I63eab923ab7d63a977cee955bf51a6aac5363f19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70474 Tested-by:
-
Alexander Nitsche authored
This patch serves as a basis for further improving the UX and new features for import / export. * Better separation between controllers and worker services * Refactor code & streamline wording * More strict typing and some PHP 8 related fixes * Streamline exception handling * Support full import configuration in CLI command impexp:import * Functional tests with increased coverage and less mocking * A set of acceptance tests for the backend interface * Minor bug fixes Note: The output of the extension has not been changed in any way, e.g. the format of the export file remains the same. Only the internal processes have been optimized. Resolves: #94772 Releases: master Change-Id: I4df66a6f615e07d6d9767723a12a769aedeb341b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70332 Tested-by:
-
Georg Ringer authored
Use the latest version which gets full support. composer req egulias/email-validator:^3.1 composer req egulias/email-validator:^3.1 -d typo3/sysext/core --no-update Resolves: #94830 Releases: master Change-Id: I6336a15d28401e364d343eb9c2a4d50708b520a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70464 Tested-by:
-
Andreas Fernandez authored
The Core Updater and Reports module were modified to render correct information about non-community supported TYPO3 releases (aka ELTS) with while no ELTS was released yet, in contrast to the Core Updater. The missing case is added with this patch. Resolves: #94827 Related: #94745 Releases: master, 10.4, 9.5 Change-Id: Ib4d8791478b89ad7e9b92930d882a98c76b809a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70462 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Andreas Fernandez authored
The method GeneralUtility::shortMD5() generates an MD5 hash and trims it to a configurable length, where 10 characters is the default. This increases the probability of conflicts whereever this method is used, either as hash stored in the database or as id decorator in DOM. Due to the issues this method brings, it is marked as deprecated now. Resolves: #94684 Releases: master Change-Id: I599211196da8ffd737643d29ed68dc6d0c0f2ae9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70176 Tested-by:
-
Benni Mack authored
The replacement for fsMod comes with a bad side-effect when using the topbar. This change ensures that a "mount" can also be handed in as "null" value. Resolves: #94828 Related: #94762 Releases: master Change-Id: I3e8c7ba7a83384297d8af52807be11e7e4115d59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70463 Tested-by:
-
Oliver Bartsch authored
Bootstrap 5.1.0, we updated to in #94752, introduced a `.vr` (vertical rule) class. This collided with our access module related styles, since we also use a `.vr` class for the legend here. To resolve the collision, our own implementation, which is only used in the access module, is now prefixed with `t3`. Resolves: #94826 Related: #94752 Releases: master Change-Id: I493baa3d0af41b78f42c9e73c9c121b29f417edd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70456 Tested-by:
-
- Aug 11, 2021
-
-
Oliver Hader authored
JavaScript object :js:`top.fsMod` managing the "state" for page-tree and file-tree related contexts in the backend user-interface like this: * `top.fsMod.recentIds.web` contained the current ("recent") page or file related identifier details were shown for * `top.fsMod.navFrameHighlightedID.web` contained the currently selected identifier that was highlighted in page-tree or file-tree * `top.fsMod.currentBank` contained the current mount point or file mount ("bank") used in page-tree or file-tree To get rid of inline JavaScript and reduce usage of JavaScript `top.*`, mentioned `top.fsMod` has been deprecated and replaced by new component `ModuleStateStorage`. Reading data from `top.fsMod` is still possible as a fall-back. Resolves: #94762 Releases: master Change-Id: I9e02a1e4c59ad3a007f5244197c1cdaa2a31ce22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67680 Tested-by: -
Oliver Bartsch authored
This patch moves the "normal" clipboard actions, such as copy and cut, into the secondary dropdown in recordlist and filelist. This means, when in "normal" clipboard mode, the actions are accessible no matter if the clipboard itself is shown or not. The clipboard related actions are divided by a horizontal line in the dropdown. Moving them into the dropdown also means, no superfluous "empty" icons are necessary when clipboard state changes, e.g. from "normal" to "multiple". Resolves: #94824 Releases: master Change-Id: I57666fe880cda9283d649a77f3a3b1bd44206e8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70455 Tested-by:
-
