- Apr 23, 2024
-
-
Benni Mack authored
Change-Id: I0de3c394a9e37ca840c3d0aa6f6df745bca8ac3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83992 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
To allow the use of "empty" attributes, such as `download` in the CKeditor, the RTEHtmlParser does now keep such attributes while processing. Resolves: #103698 Releases: main, 12.4 Change-Id: I331066c0abaa604ba68c19f0013b5a077fe8f5f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83953 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
The rootline calculation has been moved around with various patches in v12 & v13. Refactor some related tests and move them to a more appropriate place. This also avoids another TSFE access in tests. Resolves: #103701 Related: #102856 Related: #102715 Related: #103410 Releases: main Change-Id: I0da5f0484ce90eab3909d1c202a13ce79250b0bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83956 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Nikita Hovratov authored
It is possible that TCA items array is not set in DataHandler if 1. items is defined through types/*/columnsOverrides 2. DataHandler is triggered with context of another record type (e.g. by a translation request) This patch ensures we are always dealing with an array for items. Also, when passing it as parameter to `ItemProcessingService->getProcessingItems`. Resolves: #103472 Releases: main, 12.4 Change-Id: I364841982b7c2913e339bf5a504d811b3e050049 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83575 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save chart.js@^4.4.2 npm run build Resolves: #103652 Releases: main, 12.4 Change-Id: Iddbfb5be5f998c7b9d693dac94fee88a1f242edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83851 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.0.4 npm run build Resolves: #103651 Releases: main, 12.4 Change-Id: I56b52fdff9031eec2cabfaeb968469a20fa72bb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83850 Reviewed-by: -
Andreas Kienast authored
Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.7.0 \ @typescript-eslint/parser@^7.7.0 \ @typescript-eslint/typescript-estree@^7.7.0 \ eslint-plugin-wc@^2.1.0 \ sass@^1.75.0 \ sharp@^0.33.3 \ terser@^5.30.3 \ typescript@^5.4.5 npm run build Resolves: #103653 Releases: main, 12.4 Change-Id: I96bb9e96d12182adc33b5fafb52d53a4fecf6806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83872 Tested-by: -
Andreas Kienast authored
The "No results found" alert is rendered in a flex-row container, which caused a rendering bug where the alert box was stretched to a height of 100%, but its width is limited to its content. Use flex children modifiers to ensure correct positioning. Resolves: #103662 Releases: main, 12.4 Change-Id: I5b17950ca381fda841cd3a901d9f5e1a70e5562d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83919 Reviewed-by:
-
Chris Müller authored
Resolves: #103675 Releases: main Change-Id: Id576952b1390d5727643eb6c535ce56c50a20831 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83935 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Apr 22, 2024
-
-
Sybille Peters authored
The TSconfig configuration option mod.linkvalidator.searchFields is documented in the documentation. Previously, it was only possible to check within fields, if at least one softref was configured. This was changed to include fields with the type "link" (see LinkAnalyzer class). This change updates the documentation to reflect that. Resolves: #103477 Related: #83835 Releases: main, 12.4 Change-Id: I83ceafca206b2b1821e622bc36867eb13a9a5984 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83584 Tested-by:
-
Andreas Kienast authored
In order to streamline the backend UI and to re-use introduced web components, the "Add widget" wizard in the dashboard module now utilizes the `@typo3/backend/new-record-wizard` module that is already known from the Content Element creation wizard. As a small quality-of-life change, the modal title now includes the name of the dashboard as well. Resolves: #103697 Releases: main Change-Id: I58f069e5d3f57484cba8e020f51ab82cf923d25a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83937 Reviewed-by:
-
Andreas Kienast authored
With patches #102679 and arguably #103351, the image processing got refactored at multiple locations with good intentions. However, this triggers a bug in case `fileadmin/` is symlinked as it removes original files from `fileadmin/` due to incomplete checks. The class `LocalCropScaleMaskHelper` compares two paths to check whether further processing needs to be done. One part of the condition is the path "as-is", the other one is the real path with symlinks being resolved, leading to a negative result albeit both paths point to the exact same file. Another condition to trigger this bug is to render images in the frontend that don't need processing at all, e.g. because their dimensions are small enough. This patch converts the original file name in `LocalCropScaleMaskHelper` to a real path as well to have a successful comparison in symlink scenarios. Resolves: #103648 Releases: main Change-Id: I81e7f9d3e8951a0a0f18fe2838925f272659028e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83846 Reviewed-by:
-
Benjamin Franzke authored
A first set of extensions is converted to the new set infrastructure provided by #103437, #103439 and #103522. Resolves: #103556 Related: #103437 Related: #103439 Related: #103522 Releases: main Change-Id: I826cc661d726dbf54ca2b46e115b17b8dedd05f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83526 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Andreas Kienast authored
Executed commands: npm install --save \ lit@^3.1.3 \ lit-element@^4.0.5 \ lit-html@^3.1.3 npm run build Resolves: #103654 Releases: main, 12.4 Change-Id: Id250be2076f29d095cffed34bffe3f882feb223d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83874 Reviewed-by:Fabien Udriot <fudriot@omic.ch> Tested-by:
-
Willi Wehmeier authored
Add accessible aria-labels to the record icon located in the docheader component on the upper right. Additionally the record icon on the bottom right below the edit record form has got an aria-label now. Resolves: #103636 Releases: main, 12.4 Change-Id: I02a473e954f74c1b9fe8da765ca562a8a4ded290 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83834 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benjamin Franzke authored
The description has been forgotten to be added in #103437. Releases: main Resolves: #103630 Related: #103437 Change-Id: Ie254e6bd8b0fc35ba2a2ea2ca03b3f0383317c47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83949 Reviewed-by:
-
Andreas Kienast authored
The component `@typo3/backend/new-content-element-wizard` is primarily used to render a wizard-like UI for selecting a content element for creation. To make the component usable in other places as well, it get's renamed to `@typo3/backend/new-record-wizard`. Resolves: #103683 Releases: main Change-Id: I9ad19d95fd0c8aa1efb60c335726dac57eb7c54c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83936 Reviewed-by:
-
Benjamin Franzke authored
TypoScript constants expressions have been extended to support a null coalescing operator (`??`) as a way for providing a migration path from a legacy constant name to a newer name, while providing full backwards compatibility for the legacy constant name, if still defined. Resolves: #103671 Related: #97816 Releases: main Change-Id: I959b07deb40a9a5582599d5c3eee96da831e8149 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83912 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
- Apr 21, 2024
-
-
Chris Müller authored
When providing a custom submodule for the admin panel with JavaScript, the script tag does not have a nonce attribute attached. The $attributes argument of the getAdditionalResourcesForModules() method holds a "useNonce" configuration, which is now also passed to getAdditionalResourcesForModules(), like for other calls in this method. Resolves: #103673 Releases: main, 12.4 Change-Id: I135a263734b7273c2065429185f1dd7287bd19a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83927 Tested-by:
-
Oliver Bartsch authored
This extends the PAGEVIEW content object to provide not only the page record, but the full Page Information object, which among others contains the page record, the rootline and additionally also the Page Layout object. Resolves: #103570 Releases: main Change-Id: I904b91f7427e0bcd27c74f3fb3a92a7e320dff8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83708 Reviewed-by:
Lisa Kreitz <lisamariakreitz@web.de> Tested-by:
-
Stefan Bürk authored
The TYPO3 system extension `redirects` now fully supports the setting of relative links as the `target` URL, which is a documented feature. Previously, an issue arose when attempting to use path links with leading slashes as URLs. This issue has been addressed in #101083, marking the initial step toward resolving the problem of relative target links. Additionally, the fix now allows for linking to arbitrary resources, even those that do not currently exist in the File Abstraction Layer (FAL). The class `TYPO3\CMS\Core\LinkHandling\LegacyLinkNotationConverter` has been changed to limit the handling of arbitrary resources to the smallest scope to reuse existing code and to use them as `LinkService::TYPE_URL` links. The superflous outer catch block has been removed to remove dead code. In addition, a test for coverage has been added that covers DataHandler and the lower LinkHandling layer. Resolves: #103387 Related: #101083 Releases: main, 12.4 Change-Id: I51cad29e5551824a0ad8d4528aa43cff7e0f9da7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83444 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Apr 20, 2024
-
-
Simon Schaufelberger authored
Place the search icon on the right side of the input field. Resolves: #103404 Releases: main Change-Id: I7a0ed1ab77273ad300b406b8c356b8e7f7851474 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83571 Reviewed-by:
-
Chris Müller authored
The main key is not "RTE" in YAML, but "editor". Resolves: #103678 Releases: main, 12.4 Change-Id: I3c09ac3f0071be70ba3fb6c130653b8b75dc98b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83931 Tested-by:
-
- Apr 19, 2024
-
-
Chris Müller authored
This patch streamlines some spellings, break long code lines, so so they are visible without horizontal scrolling and adds more context to the RTE configuration examples. Resolves: #103677 Releases: main, 12.4 Change-Id: I2366888a29b90ee59d76f1b8f6876eb600b730d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83930 Tested-by:
-
Andreas Kienast authored
This commit removes the import of `@typo3/backend/tabs.js` in the "New Content Element" wizard for two reasons: 1. the module is not required in this scope 2. the import is apparently defunct, no request is made for that file Resolves: #103684 Releases: main, 12.4 Change-Id: I1f9af422f6c2b14590b96a058bc2ed088d0853d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83938 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Oliver Bartsch authored
When resolving the first and last inline elements in the `FilesControlContainer` and `InlineControlContainer`, it is now properly checked, whether any children exist at all, preventing possible type errors. Additionally a fallback is added to prevent further warnings in the containers while trying to iterate over the children. Resolves: #103646 Releases: main, 12.4 Change-Id: I6f46ee5dc6d5553f3bd43c12447ef2390e1f941f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83844 Reviewed-by:
Marcin Sągol <marcin@soee.pl> Tested-by:
-
Oliver Bartsch authored
All pages rendered in the first column of the Localization Overview now display the correct record icon, which is wrapped with the context menu. Resolves: #103587 Releases: main, 12.4 Change-Id: I51d2ce07b91a47d01351f7c4fabac4868286e92d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83913 Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Torben Hansen authored
Initializing the variable `$nativeDateTimeFieldEmptyValue` to an empty string in the function `checkValueForDatetime` is superfluous, since the variable is initialized again in the following if-condition and only used inside the condition code. The initialization to an empty string can therefore safely be removed. Resolves: #103643 Releases: main Change-Id: Ifd845228dfb2f5eec2f75c4232602921d9dc964b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83840 Reviewed-by:
-
Stefan Bürk authored
Doctrine DBAL 4.x has been introduced with #102875 and required adoption of breaking changes - which had been done. This included changes of children structures in classes, for example `\Doctrine\DBAL\Schema\Table` no longer returns associative array for `getColumns()` and `getIndexes()`. TYPO3 builds a virtual database schema reading extension `ext_tables.sql` files combined with TCA based default schema definitions to provide the Database Analyzer flow. The collection process build up partly table structures, and having tables multiple time which needs to be merged at some point to get the final virtual structure. With change #103015 this merge process has been moved to an earlier point, overseeing that columns and indexes are no longer associative arrays and using `array_merge()` is no longer suitable for them. In cases, where an extensions change or overrides the table definition of a table this merge process will throw a Doctrine DBAL `ColumnAlreadyExists` exception, because columns and indexes of multiple table parts are not correctly merged anymore. This change introduces two helper method as sidekicks for method `SchemaMigrator::mergeTableDefinitions()`, to merge table columns and indexes correctly and guard it with the added test. Note: Foreign keys constraints are still associative, and the TYPO3 does not support unique constraints at all within `ext_tables.sql` files. Resolves: #103666 Related: #103015 Related: #102875 Releases: main Change-Id: I9b5bca0f4faab198c3aba1c70d249ac08d07d2db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83934 Tested-by:
-
Christian Kuhn authored
There is a relatively obscure and not well known TCA config property for type='select': 'allowNonIdValues'. It can be used in scenarios with 'foreign_table' relations, where select stores the uids of selected records as CSV list: It allows additional items next to "true" relations, for instance items from a static 'items' list. To keep "true" relations and "additional static values" apart, those static values must be some string that can not be interpreted as an integer uid. This only works when select stores selections as CSV list: When using an MM table, relation uids are forced to be integers. This is documented, too. RelationHandler still handles 'allowNonIdValues' in its MM related readMM() method, which is obsolete code since that can not work. The patch clean this up and simplifies readMM() a bit along the way. Resolves: #103676 Releases: main Change-Id: I5f760f4c111ce5ae7a1cc3c9412b8900e4ac82d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83929 Tested-by:
-
Christian Kuhn authored
Extend the functional RootlineUtilityTest with more scenarios for resolving category MM, and a "casual" inline relation. Resolves: #103680 Releases: main Change-Id: Ic6e5f9cd604582853431be9415c0fb68b4a41b3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83933 Tested-by:
-
Nikita Hovratov authored
Also adjust variable name along the way. Resolves: #103679 Related: #103667 Releases: main Change-Id: I345dabbd388eaac9e5a56af6b70e249c4bac0feb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83932 Tested-by:
-
Christian Kuhn authored
There is no point to trim() value arrays that have been created with GU::trimExplode() just the line before. Clean up the loop a bit along the way. Resolves: #103674 Releases: main Change-Id: Ia5580b292b1a44a0291468b35bc1e5ca5b2f9823 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83928 Tested-by:
-
Christian Rath-Ulrich authored
Add record titles to the record icon alt text. To make the alt text for record icons helpful, the title and type of the record is now added to the existing id=x. To implement this also for the pagetree, the method BackendUtility::titleAttribForPages() has got a new parameter to return the value unescaped. The JsonResponse in the TreeController already escapes the data and additionally the TemplateResult from lit also does escaping. Additionally BackendUtility::getRecordIconAltText() received a new parameter to make it possible to not escape string values. This is necessary to prevent values to get double encoded when used in the fluid context. Resolves: #102472 Releases: main, 12.4 Change-Id: I2476baccc4caf1ffaf27bbb3d5681cd53aea6052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81883 Reviewed-by:
-
Nikita Hovratov authored
New Content Element Wizards are retrieved from both normal Content Types (CType) and Plugin sub-types (list_type). For the latter the bool parameter `$isPluginSubType` has to be set to `true`. Tests are added to ensure correct functionality. Resolves: #103667 Related: #102834 Releases: main Change-Id: Ib1b63b77f5c66edbde7622d4f8324fcfb82cdf53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83923 Tested-by:
-
Oliver Bartsch authored
Using `options.folderTree.altElementBrowserMountPoints` it's possible to add additional mount points to the file / folder tree. Adding such entries does now properly work by adding the missing `identifier` key, which is required to add those entries to a storage in `StoragePermissionAspect`. Additionally, null coalescing operators are added at two places to prevent undefined array key errors. Resolves: #103609 Releases: main, 12.4 Change-Id: I275f51b5bb2d2a1583393a9e782366092d4f558a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83841 Tested-by:
-
- Apr 18, 2024
-
-
Christian Weiske authored
Feature #89650 added support for newlines in TCA field descriptions, but palette descriptions were forgotten. This patch makes newlines in palette descriptions visible in the same way. Resolves: #103659 Related: #89650 Releases: main, 12.4 Change-Id: Ib505f476eb0f3efd0bf75bee7550b9e203ccda2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83915 Reviewed-by:
-
Jasmina Ließmann authored
Resolves: #103664 Releases: main Change-Id: I310eee5d304821d5f1b5ba210645f5ed2b4a85d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83921 Reviewed-by:
-
Christian Kuhn authored
Calculation of reference index for workspace relations has a nasty bug in getListOfActiveWorkspaces(): It always returns only the first workspace id when there are multiple. This isn't good in v12 since it creates broken or missing index entries with MM. It is worse in v13, since refactorings of the class use the method for some additional operations. The patch fixes the broken helper method. Resolves: #103655 Related: #96067 Related: #103661 Releases: main, 12.4 Change-Id: I989b22f9c25b22f52030c3dbce742074d2e09f97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83875 Tested-by:
-
Jasmina Ließmann authored
In the "Indexing" backend module, words can have various informations, such as frequency and flags. The flags are now displayed as badges and their labels have been updated. Resolves: #103660 Releases: main Change-Id: I73b30e5201619dc2f1cd0831a23d017c5ca7065a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83916 Tested-by:
-
