[TASK] Show word flags as badges in EXT:indexed_search backend module

In the "Indexing" backend module, words can have various informations,
such as frequency and flags. The flags are now displayed as badges and
their labels have been updated.

Resolves: #103660
Releases: main
Change-Id: I73b30e5201619dc2f1cd0831a23d017c5ca7065a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83916


Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jasmina Ließmann <minapokhalo+typo3@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Jasmina Ließmann <minapokhalo+typo3@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>

typo3/sysext/indexed_search/Classes/ViewHelpers/Format/FlagValueViewHelper.php

@@ -17,6 +17,7 @@ declare(strict_types=1);
 
 namespace TYPO3\CMS\IndexedSearch\ViewHelpers\Format;
 
+use TYPO3\CMS\Core\Localization\LanguageService;
 use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractViewHelper;
 use TYPO3Fluid\Fluid\Core\ViewHelper\Traits\CompileWithRenderStatic;
@@ -28,6 +29,8 @@ final class FlagValueViewHelper extends AbstractViewHelper
 {
     use CompileWithRenderStatic;
 
+    protected $escapeOutput = false;
+
     public function initializeArguments(): void
     {
         $this->registerArgument('flags', 'int', '', true);
@@ -38,14 +41,29 @@ final class FlagValueViewHelper extends AbstractViewHelper
      */
     public static function renderStatic(array $arguments, \Closure $renderChildrenClosure, RenderingContextInterface $renderingContext): string
     {
-        $flags = (int)$arguments['flags'];
-
-        if ($flags > 0) {
-            $content = ($flags & 128 ? '<title>' : '')
-                . ($flags & 64 ? '<meta/keywords>' : '')
-                . ($flags & 32 ? '<meta/description>' : '');
-            return $content;
+        $flags = (int)($arguments['flags'] ?? 0);
+        $languageService = self::getLanguageService();
+        $content = [];
+        if ($flags & 128) {
+            $content[] = '<span class="badge badge-secondary">'
+                . htmlspecialchars($languageService->sL('LLL:EXT:indexed_search/Resources/Private/Language/locallang.xlf:administration.flag.128'))
+                . '</span>';
+        }
+        if ($flags & 64) {
+            $content[] = '<span class="badge badge-secondary">'
+                . htmlspecialchars($languageService->sL('LLL:EXT:indexed_search/Resources/Private/Language/locallang.xlf:administration.flag.64'))
+                . '</span>';
+        }
+        if ($flags & 32) {
+            $content[] = '<span class="badge badge-secondary">'
+                . htmlspecialchars($languageService->sL('LLL:EXT:indexed_search/Resources/Private/Language/locallang.xlf:administration.flag.32'))
+                . '</span>';
         }
-        return '';
+        return implode(' ', $content);
+    }
+
+    protected static function getLanguageService(): LanguageService
+    {
+        return $GLOBALS['LANG'];
     }
 }

typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf

@@ -456,6 +456,15 @@
 			<trans-unit id="error.noTypoScript" resname="error.noTypoScript">
 				<source>Error: Please check that TypoScript for the Indexed Search plugin is included.</source>
 			</trans-unit>
+			<trans-unit id="administration.flag.32" resname="administration.flag.32">
+				<source>description</source>
+			</trans-unit>
+			<trans-unit id="administration.flag.64" resname="administration.flag.64">
+				<source>keyword</source>
+			</trans-unit>
+			<trans-unit id="administration.flag.128" resname="administration.flag.128">
+				<source>title</source>
+			</trans-unit>
 		</body>
 	</file>
 </xliff>

typo3/sysext/indexed_search/Resources/Private/Templates/Administration/StatisticDetails.html

@@ -104,7 +104,7 @@
                                 <td>{word.freq}</td>
                                 <td>
                                     <f:if condition="{word.flags} > 0">
-                                        {is:format.flagValue(flags:word.flags)} ({word.flags})
+                                        {is:format.flagValue(flags:word.flags)}
                                     </f:if>
                                 </td>
                                 <td class="col-control nowrap">