- Jun 21, 2024
-
-
Stefan Bürk authored
This change streamlines the `SchemaMigrator`, mainly moving code from the `parseCreateTableStatements()` method into dedicated methods. Divide and conquer. Acts as preparation for better schema migration and side effecet free test refactoring. Resolves: #104180 Releases: main Change-Id: I150ee9d83836c8e079c94682c0179f87972f2c7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84827 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Markus Hofmann <typo3@calien.de> Tested-by:
-
Sybille Peters authored
In some cases, it is helpful to have more context when editing records from the list of broken links. Previously, only the field which contains the broken link was opened in the edit form. A new button is introduced, opening the edit form with the full record. Resolves: #103493 Releases: main Change-Id: Ia8800c875812ebe780834b10eeacad4e08bc4acd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83614 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Benjamin Kott authored
Using the forced primary link colors in dark mode on dark backgrounds generates insufficient contrast. In addition, we let the general module link handler handle the switch to the module. Resolves: #104175 Related: #104129 Releases: main Change-Id: I4ead28801d66ffee2ffcb13766be115c25601b36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84821 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Garvin Hicking authored
Internally, all allowedAspectRatios will replace a "." character with "_" to prevent problems with Fluid variable key access. The lead to a situation that the backend was unable to reference the current selectedRatio, because the comparison was not performed on the "fixed" key name. This patch now uses a central "fix" method Ratio::prepareAspectRatioId in both the value object preparation as well as the configuration instantiation. The EXT:styleguide imageManipulation element 'crop_3' has been enhanced to utilize such an allowedAspectRatio for easier re- production. This workaround should be addressed as a breaking change in TYPO3v14, a note has been added. Resolves: #103047 Releases: main, 12.4 Change-Id: I8999b5d54627cda7044662ca5da17f4886a700e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84718 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
Not globally setting backupGlobals=true speeds up unit tests quite significantly. We can do this with deprecated unit tests without further issues already. Resolves: #104177 Releases: main Change-Id: I4566b5113400563254041a35819ab34efa642313 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84831 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Georg Ringer authored
The view "List of indexed pages" lists all indexed pages with the page arguments used during indexing. To avoid errors in rendering those, the viewhelper `f:format.json` is used. Resolves: #99125 Releases: main, 12.4 Change-Id: I91038cef9c76d884c2c484925ecef4a70070e153 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84812 Tested-by:
-
Anja Leichsenring authored
The functional test setup allows for easy access to registered services via `$this->get` and will not consider any other possible treatments to classes like e.g. xclassing when running tests. Thus, the usage of `$this->get` for services and otherwise just `new` is preferred over GeneralUtility::makeInstance(). Resolves: #104174 Related: #103902 Releases: main Change-Id: I8dc439b73dbc83ea7c242d44009199b16a96d356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84818 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Peter Kraume authored
Using constants in the LinkHandler TSConfig does not work in the redirects module. Resolves: #103205 Releases: main, 12.4, 11.5 Change-Id: I29dda248c5e80e077d53c8ecead9fb29fd041f76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83140 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Sybille Peters authored
The class EditableRestriction is used in EXT:linkvalidator to apply permission restrictions to database queries for current (non-admin) BE user. In case of table sys_file_reference, the value for $GLOBALS['TCA'][$table]['ctrl']['type'] might be "uid_local:type". In that case, the class EditableRestriction tried to access the TCA configuration for this field via $GLOBALS['TCA']['sys_file_reference'] ['columns']['uid_local:type']['config'] when in fact this will be empty (and the type refers to the table sys_file). We now check if the resulting array is empty and skip the check if that is the case. Resolves: #103559 Related: #83835 Releases: main, 12.4, 11.5 Change-Id: Idbe653ef9f1c21c077fcb79c03212e606cc71830 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83698 Tested-by:
-
Jasmina Ließmann authored
The two submodules "Check Links" and "Report" of backend module "Check Links" have been merged into one view. Language keys that are no longer used have been deleted in the process. If no page has been selected in the page tree, a corresponding info box now appears. Further improvements to this backend module will be made in further patches. Resolves: #104145 Releases: main Change-Id: Ic9331b6e58bf5986bc0e84416276faaec149e575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84702 Reviewed-by:
-
Jasmina Ließmann authored
The redirects overview table has been revised to improve the UX. Previously, the table fields took up as much space as their content allowed. Redirects with a long source and/or destination path stretched the table rows, which caused unwanted horizontal scrolling. The patch now fixes this and sets a maximum width for these fields. Furthermore, the "Status Code" and "Protected" fields are now also managed as separate table columns. The record icon is now placed first after the multi-record selection checkbox, as with other tables used in the system. Further actions, such as viewing the redirect and resetting the hit counter, have been moved to a separate button group. Resolves: #104166 Related: #93912 Releases: main Change-Id: I5844e1e95ea9f3b1e9a2b06ca91dce9db3cf495e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84805 Reviewed-by:
-
Christian Kuhn authored
Recent phpunit versions improved memory handling a lot, core tests no longer need to unset test case properties manually. The patch improves a couple of tests to get rid of manual unset() in tearDown() by either simply removing the calls, or by refactoring class properties away altogether, which reduces mental load when reading tests. Resolves: #104176 Releases: main Change-Id: I2717799a56c1298db2d6b5b36af4d262376b188e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84819 Reviewed-by:
-
Oliver Bartsch authored
Using the multi record selection, it's possible to change the state of checkboxes via multiple ways, e.g. by clicking on the table row. The central functionality for changing the connected checkbox state now also considers the disabled attribute and therefore only changes the checked state in case the checkbox is not disabled. Additionally, next to the custom event, which is triggered on checkbox state changes, the multi record selection now also dispatches the standard "change" event. FormEngine validation for example is listening on this event to mark the field as changed. The JS component is also migrated to a proper custom element (web component). Resolves: #104142 Releases: main, 12.4 Change-Id: I9854709ee624d88821757fff3baf38c892e5f11d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84749 Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
-
Christian Rath-Ulrich authored
This commit fixes a minor issue where the header tag in PaletteAndSingleContainer was incorrectly set as h4. The tag has been changed to h3 for better readability and semantics. Simultaneously, visually hidden headers were also added to tabs to improve accessibility. Resolves: #104021 Releases: main, 12.4 Change-Id: Ic2301eabb23d1d17169056ec8e9ec40a5824c52c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84545 Reviewed-by:
-
Leon Dietsch authored
When switching between cropVariants with multiple coverAreas, all of the previous coverAreas are properly removed, only showing those that belong to a specific cropVariant. See details and screenshots in the related ticket. (A new styleguide TCA element crop_9 is also added to showcase multiple coverAreas in multiple cropVariants) Resolves: #103389 Releases: main, 12.4 Change-Id: I7649aa0fe5bc01939326119b24dbdafd5f09a708 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84489 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
-
Garvin Hicking authored
When filtering the page tree with characters that have special meaning for a regular expression (for example, ")" or "(" or "?" and some others), the filtering would return a "Page Tree error". JavaScript does not have something like "preg_quote", so this uses the escape string provided by the MDN with fixed special characters. Resolves: #104092 Releases: main, 12.4, 11.5 Change-Id: I4a29c62eaca8b7643c8ef78dda1d8337b3e1e53a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84785 Tested-by: -
Benni Mack authored
This change allows to explicitly set includeRecordsWithoutDefaultTranslation = 0 in TypoScript. Resolves: #93881 Releases: main, 12.4 Change-Id: Ieef59efa320f401345c0c40c2514f988bd1d6715 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84798 Tested-by:
-
Georg Ringer authored
Add the configuration example to the full demo of list properties. Resolves: #100852 Releases: main, 12.4 Change-Id: I77afff52cd51d0c527e6f4a9b569accc3e60dab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84790 Tested-by:
Stephan grass <grass@mai-multimedia.de> Tested-by:
-
Benni Mack authored
This change * simplifies allowTags and denyTags in lib.parseFunc by comparing with in_array rather than "inList()" for EVERY tag! * Remove superfluous if() statements - GeneralUtility::get_tag_attributes always returns an array - substr does not return "false" but an empty string since PHP 8.0 Resolves: #104170 Releases: main Change-Id: I1980ab3b8ea6fd4a836782475dd4c61b07f50ed3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84814 Tested-by:
-
Marcin Sągol authored
Adjust request token header name to match the value defined in RequestToken::HEADER_NAME. Fix code example. Releases: main, 12.4 Resolves: #104167 Change-Id: I8e78c0385962b8bdc085a6cc2896794930a96238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84813 Tested-by:
-
Christian Kuhn authored
A missing whitespace makes a code block being eaten away by doc rendering. Resolves: #104169 Related: #104153 Releases: main Change-Id: I0f9516c6de08c3b1625582debc3c65120ea5fe03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84815 Tested-by:
-
Georg Ringer authored
The IP anonymization task uses its own configuration and doesn't allow a fallback to the configuration defined in the settings. Therefore the misleading text is removed. Resolves: #97161 Releases: main, 12.4 Change-Id: If569c0ee75fd58ed2e069387776e9c15f7b41d18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84811 Tested-by:
-
Jonathan Kieling authored
the array of translation files was not sorted by key descending. Resolves: #95212 Releases: main, 12.4 Change-Id: Ieb9d98af33cbe0d1a5ef34cb2993a247d0821031 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84787 Tested-by:
-
- Jun 20, 2024
-
-
Garvin Hicking authored
The `PackageArtifactBuilder` takes care of publishing `Resources/Public/...` directories of installed TYPO3 extensions into the public directory. In case this publishing fails, now a warning message is presented, so that action can be taken. Now also an info message is shown, when an extension does not have a Resources/Public directory. This message is only shown with increased verbosity, since this can be intentionally like so. Further cleanup is preformed and code that does not apply any more since composer installers v5 is required, is removed. Last but not least, asset publishing is now decoupled into a dedicated method, that receives installed packages as input and returns resulting messages as output. Future refactoring of the publishing code into a distinct class is kept for a future change. Resolves: #103898 Releases: main, 12.4 Change-Id: I6636a024490a0cb3c5e77f6f935f63094035d489 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84383 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Christian Weiske authored
When a scheduler task throws an exception, an error is logged. The log message does not tell us the reason for the failure: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 2 Up to TYPO3 v10, this message did include more information: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 2, > Code: 56, OpenSSL SSL_read: Connection reset by peer, errno 104 This behavior was changed (probably unintentional) with patch "[BUGFIX] Make logger usage PSR-3 compliant" https://review.typo3.org/c/Packages/TYPO3.CMS/+/69425 Besides the task class and UID, the log message now contains the exception code, message, file and line. Example: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 6, > Code: 500, "FailTask fail message" > in /var/www/typo3/vendor/[...]/Classes/Command/FailTask.php#19 Resolves: #103799 Related: #94356 Releases: main, 12.4 Change-Id: I179f059e551966944288b6fda6f2a26a4daace3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84152 Tested-by:
-
Kevin Appelt authored
Resolves: #104097 Related: #101621 Releases: main Change-Id: Ib7265a64477dd99f4c511eb859e7e4859564c3cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84700 Tested-by:
-
Christian Kuhn authored
phpunit 11.2.5 comes with further memory consumption improvements that obsolete some hacks we've had in typo3/testing-framework. Raise both. > composer u sebastian/exporter > composer req --dev phpunit/phpunit:^11.2.5 > composer u typo3/testing-framework Resolves: #104164 Releases: main, 12.4 Change-Id: Ib1c9d55833f7a950f98e2f902f8864eae289a6c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84800 Tested-by:
-
Georg Ringer authored
The CategoryCollection might be called without an existing category uid which must not lead to an exception to notices. Resolves: #99989 Releases: main, 12.4 Change-Id: I6c0bb34d9f5b460f73b8c2933994d94b54d8f01f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84624 Reviewed-by:
-
Jasmina Ließmann authored
Several minor adjustments have been made to the toolbar items to improve the UX and accessibility. This includes, among other things, the following: * Setting a correct heading hierarchy and adding some role attributes. * When a bookmark has been assigned to a group, the section with the remaining ungrouped bookmarks now displays a corresponding heading. * The form for editing bookmarks now has form labels and static input labels have been replaced. * When no documents are currently open or have been used recently, the section headings are now displayed with corresponding info texts. * Links to perform actions are now displayed in button style. Resolves: #104129 Releases: main Change-Id: I43030a078df4424f1a99c2020b347cfce498c949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84738 Tested-by:
-
Mathias Brodala authored
Releases: main, 12.4 Resolves: #103984 Change-Id: I8c105e3c3cdb37991e91015d8929d022224d8dea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84510 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Andreas Kienast authored
Resolves: #104080 Releases: main Change-Id: I83b5f8dfabb32b584300066ea52a97b5917ca6c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84677 Tested-by:
-
Jasmina Ließmann authored
If a user does not have access to the module or no page is selected when using the module, a corresponding info box will now be displayed. Resolves: #104148 Releases: main, 12.4 Change-Id: I3603063ce84f3db8ce5dae508df3b44f59fa94a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84778 Reviewed-by:
-
Oliver Bartsch authored
The URL path to the extensionmanager backend module is now "/module/tools/extensionmanager" to be in line with the other "admin tools" backend modules. The module identifier is also changed and a corresponding alias is added. Resolves: #104156 Releases: main Change-Id: I140496dcabc29f09b28d276a84a8a96676058898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84792 Reviewed-by:
-
Georg Ringer authored
If the permissions are already ok, better return an OK FlashMessage instead of throwing an exception. Resolves: #103728 Releases: main, 12.4 Change-Id: I280b1de894dcb78bc222ff1f585ff37627408e5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84575 Reviewed-by:
-
Georg Ringer authored
As twitter has been renamed to X, the labels in the page settings are adopted too. As the meta tags itself are still using twitter, also the database fields keep their name. Resolves: #103224 Releases: main, 12.4 Change-Id: I1cf5d5f3a0fd64ba1a3402f88b9e460c32ab4ead Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84789 Tested-by:
-
Georg Ringer authored
As the editor doesn't know anything about the name "colPos" the text is changed. Resolves: #99014 Releases: main, 12.4 Change-Id: I758f53896b3a16f8d8b9ac94c9290ac9cebf9d21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84527 Reviewed-by:
-
Georg Ringer authored
Implement what is already commented by removing all restrictions when comparing given username with all existing usernames. Even the username of a deleted or disabled user must not be reused. Resolves: #100729 Releases: main, 12.4 Change-Id: I85c314b2c4f6c8539e344e64371c631f29ab9db0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84783 Tested-by:
-
Christian Kuhn authored
The patch adds an important.rst explaining details around MySQL / MariaDB "row size too large" and options to handle it. Resolves: #104153 Related: #101553 Releases: main Change-Id: I8727982e144ddefdeea3bb9c8c06179d2b414390 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84784 Reviewed-by:
-
Benni Mack authored
The URL path to the form backend module is now named "/module/manage/forms" instead of "/module/web/FormFormbuilder" which was just a leftover from the pre-routing logic in Extbase modules. Resolves: #95093 Releases: main Change-Id: I9509ed13b9e34a12ecf89e63aca8c90dfbc2365e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84788 Tested-by:
-
- Jun 19, 2024
-
-
Sascha Egerer authored
The ContentObjectRenderer catches \Exception's that occur during the rendering of a content element. However, since PHP 7, there is a \TypeError exception that occurs, for example, if the given type does not match the declared type. Because \TypeError is not a subtype of \Exception, these errors are not caught in the production context, and instead of not rendering a single content element, the whole page is not rendered. Since all types of \Throwable are essentially errors that will interrupt the rendering process, the catch block must accommodate all of these, not just implementations of \Exception. Resolves: #102044 Releases: main, 12.4, 11.5 Change-Id: If6218f013caf21d7fcd2c0d0d5b6b51c3bf9963e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81573 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
