- Feb 15, 2022
-
-
Oliver Bartsch authored
Since #96797, the Module object is added to the PSR-7 Request, in case a TYPO3 backend module is requested. To further support autocompletion, the Module definition is now added to the .phpstorm.meta.php file. Resolves: #96905 Related: #96797 Releases: main Change-Id: Id323f27dbe59a386cf38ba73ee75bd07abb11532 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73521 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
This change moves the logic for calculating the max time for caching a frontend page into a separate class. In addition, the existing hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['get_cache_timeout'] is removed in favor of a new "ModifyCacheLifetimeForPageEvent". Resolves: #96879 Releases: main Change-Id: I4b3a7f3a2aa1cb0307ed021bb5344edfeab11e91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73475 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
This removes the no longer evaluated option `uploadfolder` from ext_emconf.php files. Additionally, `clearCacheOnLoad => 0` is removed, since this is the default. Resolves: #96898 Releases: main, 11.5 Change-Id: I99379d6066e53abd67fd8e6a1f32638b597ea1c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73512 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benjamin Franzke authored
All static RequireJS calls (static string argument) are migrated to native ES6 modules. Excluded is CodeMirrorElement which still needs RequireJS to be available for loading CodeMirror and it's modules. CodeMirror migration to ES6 will be a separate step by upgrading from v5 to v6. Manual modifications in Form/Element/AbstractFormElement.php to keep JavaScriptModule flags for registerCustomEvaluation call-conversions. Also JavaScriptRenderer.php to is patched always include the EXT:core importmap whenever the JavaScriptItemHandler is used (required for the dependency to "JavaScriptItemProcessor.js"). All other changes have been performed with the following commands: git grep -l "loadRequireJsModule('TYPO3/CMS" | \ grep -v /Documentation/Changelog | \ grep -v ActionMenuViewHelper.php | \ xargs sed -i '/CodeMirrorElement/!'"s/->loadRequireJsModule('\\(TYPO3\/CMS\/[^']*\\)')/->loadJavaScriptModule('\\1.js')/g" git grep -l "JavaScriptModuleInstruction::forRequireJS('TYPO3/CMS" | \ grep -v /Documentation/Changelog | \ grep -v JavaScriptRendererTest.php | \ xargs sed -i '/CodeMirrorElement/!'"s/JavaScriptModuleInstruction::forRequireJS('\\(TYPO3\/CMS\/[^']*\\)'/JavaScriptModuleInstruction::create('\\1.js'/g" git grep -l "JavaScriptModuleInstruction::forRequireJS($" | \ grep -v /Documentation/Changelog | \ grep -v Form/Element/AbstractFormElement.php | \ xargs sed -i -e '/CodeMirrorElement/!s/::forRequireJS/::create/' -e "s/^\([ ]*\)'\\(TYPO3\/CMS\/[^']*\\)'/\\1'\\2.js'/g" sed -i "s/'\\(TYPO3\/CMS\/[^']*\\)'/'\\1.js'/g" typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php # Same migration as already started in #96607 git grep -l includeRequireJsModules= | \ grep -v /Documentation/Changelog/ | \ grep -v PageRendererViewHelper.php | \ xargs sed -i \ -e 's/includeRequireJsModules=/includeJavaScriptModules=/' \ -e "s/\\([0-9]: *'TYPO3\\/CMS\\/.*\\)'/\\1.js'/g" Resolves: #96570 Related: #96323 Related: #96607 Releases: main Change-Id: Idc81d6b4d58168f0bfafc3e9e4ad46fa1e5f27e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73027 Tested-by: -
Susi Moog authored
If l10n_source points to a deleted or non-existing record the translation wizard failed in free mode with a 500 error, because determining the source languages fail and no fallback was implemented. Instead of failing, the behaviour was adjusted to handle l10n_source pointing to erroneous records similarly to an empty column and offering all available language as option for the translation - as in fact the source cannot be reliably determined. Resolves: #96838 Releases: main, 11.5 Change-Id: Iec7f4a1dba6b93c5185fec7863b1deaa175b0279 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73433 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Christian Kuhn authored
Change-Id: I31ec2d1ab4872f5ab6df354c4e808b451ac1ce71 Resolves: #96897 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73498 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Georg Ringer authored
Remove the overhead of using extbase to get all workspace records and fetch them directly. Resolves: #96896 Releases: main Change-Id: I6ff28ad661533c7804d576e17e979b55c96c0a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73497 Tested-by:
-
- Feb 14, 2022
-
-
Benni Mack authored
This change is a pre-patch for introducing https://review.typo3.org/c/Packages/TYPO3.CMS/+/73339 to allow to reduce the calls to $pObj by using inheritance for all controllers related to TypoScript parsing in "Web > Info" Resolves: #96894 Releases: main Change-Id: Ifb78f415e7168b14462063c2b761503ab4d90615 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73496 Tested-by:
-
Christian Kuhn authored
With all casual deprecation removals being done, the ReST file can receive some final touch. Resolves: #96107 Releases: main Change-Id: I1bfdd7a569084eab3e778e9bfc544da64d19186b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73495 Tested-by:
-
Benni Mack authored
TSFE contains a lot of functionality which is rather related to other places. One of them is the protected method "determineIdIsHidden" which is now transferred to PageRepository where all other methods related to this logic is kept. Resolves: #96886 Releases: main Change-Id: I5213ae5f899fcdf9a39046021d40f2ed9005adac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73486 Tested-by:
-
Imko Schumacher authored
Tokens in an encoded URL (where '=' is '%3D') now get anonymized. Resolves: #96858 Releases: main, 11.5 Change-Id: If07d122b2a5b89cb66fef3fff0790004c5d07eb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73456 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Benni Mack authored
This change cleans up some functionality regarding TSFE when SiteHandling was introduced in TYPO3 v9: * TSFE->id is always an integer now * TSFE->contentPid and TSFE->requestedId now as well * TSFE->site is always of type Site (not SiteInterface) anymore * Some TSFE related methods now need the PSR-7 request (as defined before already) Other places such as $TSFE->type will be worked on separately. Resolves: #96880 Releases: main Change-Id: Icfcd8b50225a3dae94b72f40d79d5117df3ae4a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73477 Tested-by:
-
Christian Kuhn authored
With #96831 being done, a last deprecated set of functional tests can be merged into the default functional test suite. Resolves: #96888 Related: #96831 Releases: main Change-Id: Id0bbf805979e693e56721081abd7759b129bf624 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73487 Tested-by:
-
Christian Kuhn authored
* mbstring: This is one of the most common extensions, often compiled directly into default packages, or available as additional package. While the symfony polyfill package adds the most common functions, it is not complete and we're already working around possible non-existance in a couple of places. The native functions are quicker and it should be fair to require mbstring in a modern PHP 8.1 build. * intl: We really need this package to finally solve various sorting and date issues in the system. The symfony polyfills are partially stubs only that implement only a small set of features for english-only. This extension is the only way to finally drop dependencies to the nasty locales, which is a far bigger burden on systems than requiring intl. $ composer req ext-mbstring $ composer req ext-mbstring -d typo3/sysext/core --no-update $ composer req ext-intl $ composer req ext-intl -d typo3/sysext/core --no-update $ composer rem symfony/polyfill-mbstring $ composer rem symfony/polyfill-mbstring -d typo3/sysext/core --no-update $ composer rem symfony/polyfill-mbstring -d typo3/sysext/frontend --no-update $ composer rem symfony/polyfill-intl-icu $ composer rem symfony/polyfill-intl-icu -d typo3/sysext/core --no-update $ composer rem symfony/polyfill-intl-idn $ composer rem symfony/polyfill-intl-idn -d typo3/sysext/core --no-update $ composer rem symfony/polyfill-intl-normalizer $ composer rem symfony/polyfill-intl-normalizer -d typo3/sysext/core --no-update Change-Id: I91bbd65862ceef7504563df71959e705666fb74a Resolves: #96889 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73492 Tested-by:
-
Georg Ringer authored
During the rework of #96745 the fluid variable `showWorkspaceSelector` was set too late to be used in the view. Resolves: #96892 Related: #96745 Releases: main Change-Id: Ifc95ff9f69ff9d48d117ef02793aec5e3ca144ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73493 Tested-by:
-
Oliver Hader authored
This change drops the fall-back behavior of `parseFunc.htmlSanitize` and drops the feature flag `security.frontend.htmlSanitizeParseFuncDefault`. Both were introduced as a follow-up to TYPO3-CORE-SA-2021-013, to relax HTML sanitization for a temporary migration period. Resolves: #96831 Releases: main Change-Id: I08c8f3c65c0695bc7c455ea8c527d0b273c5e056 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73425 Tested-by:
-
Markus Klein authored
Ensure the "new record" page position selector works on the root page (pid 0). Resolves: #96883 Releases: main, 11.5 Change-Id: I25681e5b0a2608dde3ca47180f443820cd7ff5bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73481 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Susi Moog authored
* Migrate most test fixtures from .xml to .csv. Some special cases are left out, those will receive dedicated patches. * Streamline assertCSVDataSet() and importCSVDataSet() usage to __DIR__ relative paths. Resolves: #96856 Releases: main, 11.5 Change-Id: I747aafa03c031aa655c8f2a9ab71027ee2accddc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73454 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Benni Mack authored
This change enables UserAuthentication objects to use the PSR-7 Request Payload instead of the superglobals $_GET/$_POST Resolves: #96881 Releases: main Change-Id: I351158574c70e047070af54c52f5489a6c81f0db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73480 Tested-by:
-
Andreas Fernandez authored
If the modal component starts an AJAX request that results in a non-okayish response (>= 400), the underlying fetch() throws an error that is now caught. If the response sends an optional body, it is rendered in the modal. If an empty body is received, a fallback text explaining the issue is rendered instead. Resolves: #96852 Releases: main, 11.5 Change-Id: I986c0b92d742fa76b773dd3f3a976a05a3f6b546 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73448 Tested-by:
-
Oliver Bartsch authored
To overwrite the bootstrap styles of the striped table in the extension manager list, our custom styles must be defined more explicit. Resolves: #96865 Related: #93119 Releases: main, 11.5 Change-Id: I9804eef64ad8c71d7f449bf1212c15ee589ca95d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73474 Tested-by:
-
Benni Mack authored
This change is a pre-patch for introducing https://review.typo3.org/c/Packages/TYPO3.CMS/+/73339 to allow to reduce the calls to $pObj by using inheritance for all controllers related to TypoScript parsing in "Web > Template" Resolves: #96877 Releases: main Change-Id: I890f3cd30f1e04d4208732dd1503dee12ada0250 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73473 Tested-by:
-
Torben Hansen authored
* Use constructor property promotion where appropriate * Use typed properties * Remove doc comments for functions with a PHP return type where applicable * Remove doc comments for typed properties where applicable * Remove doc comments for constructors where applicable * Setters must return void Applicable is, if a doc comment has only been used for type hinting or if the property or function is self explaining. Resolves: #96860 Releases: main Change-Id: Ib6df59c913a6798f4ddf504bb3bb6f6becb901ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73457 Tested-by:
-
Christian Kuhn authored
We missed adding 'tabs JS' to 'User Settings' module with #96776, tab position is no longer stored. Add it. Resolves: #96876 Related: #96776 Releases: main Change-Id: Ie2b1d7a7c4392bf6b9a3265c9809430ebc4a30d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73471 Tested-by:
-
Oliver Bartsch authored
Prior to #96777, the preview url for tor "view" button was created using BackendUtility::getPreviewUrl), which threw an exception, in case no link could be created. With the change to use the PreviewUriBuilder directly, no such exception is thrown, but buildUri() just returns NULL. This then lead an invalid link exception, in the EditDocumentController, since a LinkButton has to provide a target. This is now fixed by removing the try/catch and just checking the generated preview uri for not being empty. The same is done at the other places, which got adjusted in the related patch. Resolves: #96875 Related: #96777 Releases: main Change-Id: I9041a76a9c89eaf932cf002b26c224f0d97950f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73470 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Georg Ringer authored
Fix a notice which happens if the exclude configuration of the field `hidden` of tt_content is removed. Resolves: #96873 Releases: main, 11.5 Change-Id: I94a0ff88a936f403dcd8000f691ae5334863d07f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73468 Tested-by:
-
Benjamin Franzke authored
Cache busting parameters need to be added to any JavaScript resource to force browsers to re-download these files after updates. JavaScriptItemHandler.js changed between TYPO3 v11.5.3 and v11.5.4 and therefore needs to be updated by browsers. The same fix is applied to requirejs-loader.js as this file changed between v11 and v12. A micro optimization is made by avoiding that JavaScriptRenderer is created twice during PageRenderer creation. Resolves: #96663 Resolves: #96606 Related: #96003 Releases: main, 11.5 Change-Id: I04207a46e6d44d3e0b4e633bce7fca22761aa60e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73184 Tested-by:
-
Andreas Fernandez authored
The module Backend/Tabs used for advanced tab handling now doesn't use jQuery anymore. Additionally, the following changes were made: * removed unused method `getTimestamp()` * removed global tab state persistence state * only register event listener if tab state should be saved Resolves: #96857 Releases: main Change-Id: If83044ece674cb240e9f0c4c3bc2ccd190fbea27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73455 Tested-by:
-
Benjamin Franzke authored
[TASK] Revert "[TASK] Ensure requirejs-loader.js and JavaScriptItemHandler.js are cache invalidatable" This reverts commit 425f94f5. Reason for revert: It would have been better to use getStreamlinedFileName() directly instead of changing the processJsFile() method. Also JavaScriptRenderer is reinitialized in reset(), therefore the initialization needs to be done again there. Last but not least this fix should also be backported to v11 as JavaScriptHandler changed between v11.5.3 and v11.5.4 and therefore a cache-bust hash is required as well. In order to fix this in a clean way, this patch is reverted and will be replaced by a new one. Releases: main Resolves: #96664 Reverts: #96606 Change-Id: Iab2095823f32eecb972589b3c13a3e38c1f1709b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73161 Tested-by:
-
Oliver Hader authored
Email processing in <f:link.email> view helper has been changed to be based on typolink recently. In order to allow (internal) markup in spamProtectEmailAddresses_atSubst or ~_lastDotSubst it has to be ensured that only the input parameter (the email address) is considered as user input and thus encoded for HTML. Resolves: #96723 Releases: main, 11.5 Change-Id: I199ab6471d44508b0a3a4338ea1650d7eb7345df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73363 Reviewed-by:
-
Peter Kraume authored
Resolves: #96872 Releases: main, 11.5 Change-Id: I5fdfca4bcf0b01d6d0103e8e4e8b1c6c011edc3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73465 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
linawolf authored
Resolves: #96864 Releases: main Change-Id: If904301349efb7e3308cea787b6fb798a7932d80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73461 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Feb 13, 2022
-
-
Benjamin Franzke authored
Dynamic JavaScript imports require their respective importmap configurations to be loaded, therefore it is now allowed to tag import configurations in order to be loaded when a certain dispatcher is added to the current response. This patch adds tags for the currently used dynamic imports. The tags are added via includeTaggedImports and might be side-loaded via the ResolveJavaScriptImportEvent. Notes: * In the pageRenderer->loadRequireJsModule we currently transparently load all configurations in backend context, but once we switch all these calls to loadJavaScriptModule(), we need to be very explicit about all the required importmaps. This patch prepares for that. * The EventDispatcher is an optional dependency for the ImportMap class as the events and tags are not required in the InstallTool importmap. Resolves: #96710 Related: #96323 Releases: main Change-Id: I7b9eb0cb0a26b90ae217435c15c04238ffe4baa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73145 Tested-by:
-
- Feb 12, 2022
-
-
Stefan Bürk authored
Streamlining RecordListController with #96784 simplified determiniation, if clipboard should be displayed or not. This introduced a bug where it is now always enabled. This patch changes this simplifying so clipboard can be controlled over parameters again and is not always shown. Resolves: #96854 Related: #96784 Releases: main Change-Id: I84a46d5aaa6338ccdce8af5d45fdce8b1b272528 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73450 Tested-by:
-
Christian Kuhn authored
The core related caches have been renamed from 'cache_foo' to 'foo' in v10 already, together with a deprecation fallback. This fallback was planned for removal in v11 already, but has been prolonged to v12 to ease extension usage that want to stay compatible with two core versions. That fallback is now removed and a note is added to the main 'deprecation removal' ReST file. Resolves: #96836 Related: #96107 Related: #88366 Related: #94412 Releases: main Change-Id: I0560a7bc924d0a3a0224a3b013ccd09d712ecdef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73430 Tested-by:
-
Torben Hansen authored
Some extbase classes related to FAL have been added back in 2012 with the doc comment, that classes are experimental and subject to change. Since the classes are actively used in the TYPO3 core for nearly 10 years now and are marked as @internal, the comments about the experimental state can savely be removed. Resolves: #96855 Releases: main Change-Id: Ifb98fac3289feeb0a4fa0f2468b50512158340d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73451 Tested-by:
-
Christian Kuhn authored
Casual "pre-merge" patches (pushing a patch) to CI gives us two stages: An "early" stage checking CGL and composer basics, plus the "main" stage checking everything else. The goal with this approach is to return early on simple errors like CGL violations without wasting additional ressources on other things when those pre-conditions fail. In practice, an early "cgl broken" pipeline shadowes possible further issues and extends runtime of single builds since 'main' is only run after 'early' has been successful. The patch merges all "pre-merge" jobs into one stage. This means more jobs are executed in parallel, but we hope the infrastructure can cope with that. If that works out, CI should answer more quickly on single patches. Resolves: #96841 Releases: main, 11.5 Change-Id: I986992f486b05845621f35228ae01b673368ba95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73436 Tested-by:
-
Oliver Bartsch authored
Use the PSR-7 request instead of Superglobals. Resolves: #96840 Releases: main Change-Id: Iec2e1299584b09aa1967a93c320d87967fd85a80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73435 Tested-by:
-
Christian Kuhn authored
There are a couple of functional tests marked "incomplete" since 2019. Tests that have been skipped for so long are probably broken anyway and do not add value. Remove them. Resolves: #96839 Releases: main, 11.5 Change-Id: I503339d9a4b30a32b7d1a1fbc1bd9832fe289952 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73434 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Anja Leichsenring authored
Set all missing files to declare(strict_types=1); Resolves: #96847 Releases: main Change-Id: Ic4ba42f904702357b4b52c13abdfe920a84fdb68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73442 Tested-by:
-
