- Feb 15, 2021
-
-
Jochen Roth authored
Check for user in /etc/passwd, if it does not exist create a temporary passwd to get values from. Resolves: #93372 Releases: master, 10.4, 9.5 Change-Id: I60c9d2a10a0da155354546d57c823961bc39f014 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67539 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
Plus: No variable fallback magick in docker-compose.yml, this belongs to runTests.sh Change-Id: I9ec8d1ecba695061155807fd44d0a3cb3f342cfd Resolves: #93514 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67919 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Andreas Fernandez authored
This patch refactors the client-side rendering of FlexForm sections. Now, there are two modules in place: - FlexFormSectionContainer This module handles the "outer" part of a section, e.g. to toggle all containers or to revalidate FormEngine if a container is removed. - FlexFormContainerContainer The FlexFormContainerContainer represents an individual container being a child of a section. In order to streamline the UI, the look & feel has been changed to be more similar to IRRE. Resolves: #93453 Releases: master Change-Id: Ica373a6dbed4b470725267eac221bf839b23ec0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67589 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Richard Haeser authored
Verify the output of TypoScript settings config.pageTitleFirst and config.pageTitleSeparator Resolves: #93414 Releases: master, 10.4 Change-Id: Ib5f2c25aa15ce2f1689ded2c245499663e5a0429 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67632 Tested-by:
-
Martin Kutschker authored
The system news slider implements the ARIA pattern "carousel" except for the omission of aria-roledescription which has no support in current screen readers. Additionally the contrast of the slider controls has been increased and the click size does not shrink on small screens. Resolves: #93259 Releases: master Change-Id: Ia718184f9b4188c57c08d63f34bb05d80be37ced Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67456 Tested-by:
-
Andreas Fernandez authored
Passing jQuery objects to the methods `show()` and `hide()` of the module `TYPO3/CMS/Backend/Tooltip` has been marked as deprecated. The methods now check whether a NodeList or an HTMLElement is passed and handles the tooltip actions accordingly. If a jQuery object is passed, the old behavior is kept and a deprecation is logged in the browser's console. Resolves: #93506 Releases: master Change-Id: I680ae542f616627d3e22262c33cf126abc889d80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67915 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
-
Martin Kutschker authored
Clean up CSS by removing vendor prefixes that are handled by autoprefixer. The commit also removes SCSS mixins that add vendor prefixes. Releases: master Resolves: #93510 Change-Id: I949671211f5771524863df2062f6554a78b53caf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67918 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
-
- Feb 13, 2021
-
-
Andreas Fernandez authored
Executed command: yarn add --dev @types/bootstrap Resolves: #93595 Releases: master Change-Id: I24ab01d3e1ef9d621ff1531a5d99a48ee67abb18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67914 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Feb 12, 2021
-
-
Benjamin Franzke authored
Avoid JavaScript based offset and height calculations. Position sticky can do that in all supported browsers for us. .module-docheader is additionally adapted to use display:flex in order for the docheader-bar margins to be contained within. (to preserve the position:fixed behaviour, which did the same). While at it, we also avoid jQuery usage within DocumentHeader.ts Releases: master Resolves: #93489 Change-Id: I8c42500c3fb608c7ee8bcfeca0578383814efcb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67691 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
This beta fixes various issues related to positioning of tooltips and popovers. See https://blog.getbootstrap.com/2021/02/10/bootstrap-5-beta-2/ Commands used: > yarn upgrade bootstrap@^5.0.0-beta2 > grunt build Resolves: #93487 Releases: master Change-Id: Ia320d925eec51a6cdd0fa73398a1a0e4ed70e524 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67688 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- Feb 11, 2021
-
-
Benjamin Franzke authored
Do not use global state by looking up the CacheManager from GeneralUtility, when we can actually inject the required cache. The core cache is available from early bootstrap, therefore we do not need to wait for CacheManager to be available, and can inject it right away. Releases: master Resolves: #93440 Change-Id: I5c760acc2a1bdcc740fa3210450167e6bed7e235 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67647 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Richard Haeser authored
Even when the page record is not translated, a hreflang tag should be rendered for languages with a fallback. Resolves: #89462 Resolves: #88020 Releases: master, 10.4 Change-Id: I12e17efd32043881e21ba631968872a90b22260c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67574 Tested-by:
-
Christian Kuhn authored
Brings a minor gfx fix and a massive memory footprint reduction for functional tests: As example master chunk 1/10 is down from 643MB to 145MB. composer req --dev typo3/testing-framework:^6.6.2 Change-Id: Ie9bc46a0c02f90d99e1d3b13e1e76640233433d9 Resolves: #93493 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67852 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Jonas Eberle authored
This fixes step indicators and button margins in the modal footer. Resolves: #93168 Releases: master Change-Id: Ic5e14389dfa4942645c6dc18b4a6355886209515 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67393 Tested-by:
-
Christian Kuhn authored
The EnhancerLinkGeneratorTest and EnhancerSiteGeneratorTest have 524 and 460 tests. Hack these into smaller parts using multiple files to be better digestible by the test splitter script. Resolves: #93490 Releases: master Change-Id: I2b926ed85211d8e19b6509f642e10cf24a5b44cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67732 Tested-by:
-
Oliver Bartsch authored
The content fetcher did not consider delete placeholders. This task was done using a method in GridColumnItem which was used in the templates directly. Because defLangBinding is more complex, three additional calls to this method would be needed. Since such records shouldn't even be passed to the view at all, this check is now directly added into the content fetcher. This means that no elements with a delete placeholder are fetched anymore, making the getter and the calls in the templates superfluous. Therefore, the getter along with its single usage is removed. Resolves: #93332 Releases: master, 10.4 Change-Id: I5f214bc8f94ffe571289f7c62849590ca9931ea4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67492 Tested-by:
-
Oliver Bartsch authored
Passing a current page number which exceeds the maximum number of pages to the paginator is now silently resolved by using the last available page as the current page. This is done to prevent empty results, since such value can be passed unintentionally by a user. For example in case some internal state changed after the view was initially rendered or the view does not perform checks on this value at all. The later will now be prevented at least in core by adding the "max" attribute to all core paginations which previously missed it. Resolves: #93351 Releases: master, 10.4 Change-Id: I56fa1bd0ea62b7ddf7ea049819efc403fdf70d10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67509 Tested-by:
-
Christian Kuhn authored
The styleguide extension generator creates a site configuration for its page tree for a while already. The manual creation of a site is not needed in acceptance PageTreeFilterCest. Resolves: #93488 Releases: master, 10.4 Change-Id: Iaaafd2d07589d1fcc370a4c22024e34d1182af35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67689 Tested-by:
-
Oliver Bartsch authored
Page access failure log entries emitted by the TypoScriptFrontendController previously only included the same basic information, also shown to the user in the frontend. With this information it was nearly impossible for integrators to debug such errors further, making the whole entry log more or less superfluous. Therefore, all log entries for page access failures now include the requested URL and the requested page ID. Resolves: #93444 Releases: master Change-Id: Ie93399cf78b8af29f8ff7d3474fd6f0dac14e438 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67649 Tested-by:
-
- Feb 10, 2021
-
-
Benni Mack authored
Now that jQuery has gone and TypeScript is in place for Tree components, the next step is to consolidate and sort out re-usability. This change prepares the way for allowing multiple trees in the navigation component area (for FileStorageTree). * ContextMenu allows int+number (which is correct) * ContextMenu has all information from the TreeNode (and not the SVG element) - less Markup! * KeyTypeEnums are used throughout SvgTree * Centralized place for error notifications, removing duplicate code * tree.settings.isDragAnDrop is removed in favor of tree.settings.allowDragMove (which already exists) * Unused properties in TreeNode are removed * Since we are now in "TS module land", PageTreeToolbar.ts is removed because the class is only used in the PageTreeElement, so it does not need to be exposed anymore. Resolves: #93481 Releases: master Change-Id: Ia9bff532132dba5aea85352d7e510f6a7f9459c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67683 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
6.6.1 for master & v10 4.15.3 for v9 Brings a bugfix to make the test splitter deterministic. composer req --dev typo3/testing-framework:^6.6.1 Change-Id: Iec61eb2d6a62a0c344c712d0577aa82adf04e7f5 Resolves: #93485 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67684 Tested-by:
-
Benni Mack authored
This change splits up Drag+Drop handling in general for SVG-based trees into PageTree specific logic, and common usages. This makes Drag+Drop functionality usable in more places than just the PageTree In addition, all usages of jQuery are removed and proper types were added instead of using "any". Resolves: #93478 Releases: master Change-Id: Ibb17cdd718424760676899b7746cb0828e06fc7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67682 Tested-by:
-
Oliver Bartsch authored
The RedirectService is using typolink to build links to the defined target, e.g. a page. In case the redirect target is an access restricted page and the user is unauthorized, typolink did not build this link and therefore the request resulted in a 404 response. Since unauthorized requests to an access restricted page should always return a 403 status code, the `linkAccessRestrictedPages` option is now set in the typolink configuration. Therefore, the link will be built even if the user is unauthorized and then redirects to the target page where the correct 403 status code is returned. Resolves: #91879 Releases: master, 10.4 Change-Id: Ib82595abb12fae2c5629920d02b08e5e3144301b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67498 Tested-by:
-
Oliver Bartsch authored
If a non-admin does not have permissions to access a specific CType, disallowed via AD mode, the header icons, e.g. edit or delete, are now not longer displayed in the page module (fluid based) to prevent error messages in FormEngine. Therefore, recordEditAccessInternals is used, which was also the case in PageLayoutView and furthermore already includes the language access check. Resolves: #93411 Releases: master, 10.4 Change-Id: I6239cd1ace2f354386b5e6f11613f45b42342800 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67631 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Georg Ringer authored
The input type of the configuration `MAIL/transport_smtp_password` should be set to `password` instead of `text`. Resolves: #93231 Releases: master, 10.4 Change-Id: Id7938197a029fbf89ed060cdae35db58fc8a419c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67676 Tested-by:
-
Christian Eßl authored
When a shortcut page is used for a translated page, but its parent is not of type shortcut, the generated link would always use the current language of the frontend context instead of the actual required language set in _PAGES_OVERLAY_REQUESTEDLANGUAGE. Resolves: #89871 Related: #81657 Related: #86595 Related: #19114 Releases: master, 10.4 Change-Id: Iaa4e682e2bd79852b5e586b1764fd42ae8676644 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62552 Tested-by:
-
Georg Ringer authored
By fixing a typo, the field quoting also works for `leftjoin` and `rightjoin`. Resolves: #93449 Releases: master, 10.4, 9.5 Change-Id: I65c08d17f7f41a505fc4e23fbafd775469e9a13a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67672 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Reviewed-by:
-
- Feb 09, 2021
-
-
Benjamin Franzke authored
Align the search input to the toolbar icons. Releases: master Resolves: #93476 Related: #93474 Change-Id: I50c8344f2370c32980db247e63fadd3a2f67287c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67679 Tested-by:
-
Benni Mack authored
The PageTree toolbar now displays both menu areas ("main menu" and "submenu") all the time and removes the submenu toggles / buttons. This is a request from various UX developers to: * remove buttons for toggling if there is enough space * decouple buttons from the click / drag functionality (some had borders, some did not) * not hide the filter in a submenu (unclear that the left buttons are menu toggles) In itself, the loading area is now clearer (via simpler CSS), and the TypeScript/JS code gains simplicity for building the menu. Resolves: #93474 Releases: master Change-Id: Ie3767e247f28418af949b39b39919e50f13cc48f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67677 Tested-by: -
Benni Mack authored
This change migrates all left-over components of * SvgTree * SelectTree (a.k.a. CategoryTree) * and PageTree to TypeScript adding types in various places to make the code less error-prone. Resolves: #87678 Resolves: #85400 Releases: master Change-Id: Ibb4024d365857c44018a7a201c1cf75baa48179a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67662 Tested-by:
-
Ute Flierl authored
SVG with inline styles are not loaded when the Content-Security-Policy header contains the widely used setting "style-src 'self';" because the browser has to reject interpreting the style attribute. In this case a black rectangle is displayed. Using attributes instead of styles is compliant with CSP "style-src 'self';" and the svgs can be displayed. Releases: master, 10.4 Resolves: #91216 Change-Id: I1679a2004f1fc868231318249a267cbba62c540f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64331 Tested-by:
-
Richard Haeser authored
Make sure that the first root node is selected before the tests are executed. Resolves: #93471 Releases: master, 10.4 Change-Id: I8d2b973a8d7e0a6f94db39967b8710474502335b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67673 Tested-by:
-
Benjamin Franzke authored
Based on the configuration syntax of the Symfony Console feature https://github.com/symfony/symfony/pull/39851 …but implemented differently, using a registry pattern rather then a lazy-object pattern (like symfony does). Main motiviation for the registry pattern is following: Symfony LazyCommand wrappers add quite some complexity only for the sake of the list command, we already got lazy commands (in terms of execution) as our CommandRegistry implements the ConfigurationLoaderInterface that has been introduced by 2017 to add support for lazy commands. Now, that means we already got a registry for lazy commands, so it is logical to add lazy description handling there as well. We want to assure that the command list will never instantiate any commands. This is in constrast to the Symfony core LazyCommand approach, where legacy commands, that do not provide a compile time description, would still be instantiated during console command list. Also commands that return false in `isEnabled()` are now listed. That means enabled state is only evaluated during runtime. Therefore the special `dumpautoload` command is transformed into a lowlevel command in order to be hidden dependending on being run in composer-mode or not. Releases: master Resolves: #93174 Change-Id: Ifa68404cc81c64a335be30f2263a7eb17de0624d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67635 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
- Feb 08, 2021
-
-
Benni Mack authored
Because TYPO3 Backend is based on the symfony/routing components, it is now possible to also limit a route to only e.g. a POST request by defining allowed methods in the route registration. This allows for more secure route behaviour, e.g. routes that update the system, should semantically using POST requests. Similarly this way, future non-HTML-routes in the TYPO3 Backend could be set up (e.g. for REST APIs), utilizing the BE routing directly. For the time being, the password-forgot form is now only allowed for POST methods, effectively hardening this feature. Resolves: #93455 Releases: master Change-Id: I1c89f592ce17dfcd8a7e7674945c97c7c39969ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67655 Tested-by:
-
Benjamin Franzke authored
renderElement() was added in patchset 2 of #93446. The code was then refactored to use renderHTML, but the method was forgotten to be removed in the final patchset. Now, the intention of the mentioned patchset 2 was to render nodes directly to the DOM in PageTreeDragHandler, instead of rendering to a temporary element, just to export and re-import as HTML string with jQuery/innerHTML. Therefore PageTreeDragHandler is now refactored to a new, (internal) method renderNodes() which allows the returned nodes to be directly attached to the document. Also, while at it, all other lit-helper methods are marked as internal as well, as they are still subject to change: * `renderHTML()` is only needed when mixing traditional jQuery rendering and lit-html (same as for the new `renderNodes()`.) * The `icon()` method could likely be replaced by a custom <typo3-backend-icon> component * `lll()` is only of use for globally available language identifiers (which are added via inline JS) So this is also likely to change when more backend modules start to use lit-html/LitElement. Resolves: #93464 Related: #93446 Releases: master Change-Id: I61ab778e28e32b75b6e7965b75259beedbb10ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67663 Tested-by:
-
Anja Leichsenring authored
* Acceptance tests in nightly run can use just one out of our supported databases, that should be enough. * Some reorderings to reflect order in gitlab-ci better * Minor issues and cleanups Releases: master Resolves: #93456 Change-Id: I67355f139e24ec9c287ab3b753059a342b387700 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67660 Tested-by:
-
Benjamin Franzke authored
This wizard-backendlayout icon has been added in #72853 as icon for the backend layout wizard, but was later forgotten to be removed when the backend layout wizard was rewritten into an own renderType in TYPO3 v8 (#75497). The rewrite dropped usage of the icon. Resolves: #93465 Related: #75497 Releases: master Change-Id: I51593a4915fdaa0b5aa06bc663e6dc46e9ec9a6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67664 Tested-by:
-
Benni Mack authored
The Backend LoginRefresh password field now also contains "autocomplete=current-password" just like the login-form. Sidenote: The attribute (also for the username) must be added manually via jQuery as there is a strange bug not allowing "autocomplete". In addition, it fixes a typo for the rsa-encryption to be proper english, and not needing a special handling for LoginRefresh.js anymore. Resolves: #93448 Releases: master Change-Id: Iedf306380a4dbfb5ec31c37f932f8d3b64daf366 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67654 Tested-by:
-
Benni Mack authored
The PageTree components for the navigation area consists of: * PageTreeElement (container for rendering the navigation area w. toolbar + dragdrop + tree) * PageTreeToolbar (uses DnD for creating new items) * PageTree (JS, subclass of SvgTree) * PageTreeDragDrop This patch aims to rework the "PageTreeDragDrop" javascript file by moving separate logic into separate classes (as much as possible) and into a more stable API, being a first part. PageTreeDragDrop is a mixed code class currently, and is now split up in various separate classes: * DragDropHandler (interface) * ToolbarDragHandler -> used as the Toolbar Draggable Handler for new pages * PageTreeNodeDragHandler => used for moving/copying and deleting existing pages/nodes * PageTreeDragDrop now acts as a simple wrapper for d3-drag but still has some shared state For Future Reference: It is still up to decide on how to further decouple the code. Idea 1: Putting the d3-drag initialization into the right place and avoiding cross-dependencies. In general "initializeDragForNode" would also be handled via events, and all options / settings would be moved into the PageTreeDragDrop class. Ideally the PageTreeDragDrop contains the status of the current drag+drop action (position, node etc), so the PageTree would not know of anything itself. Idea 2: Another possibility is to use the current "PageTreeDragDrop" as a generic "TreeDragDropManager" because it does not contain any Page-Tree specific code anymore, but could be carried on later-on. The current change is already a good step as it moves all code to TypeScript and minimizes injection via constructors (except for the Tree itself). Resolves: #93446 Releases: master Change-Id: Ibd7a067c1e6a821b138a8cc2971ec8133392b600 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67650 Tested-by:
-
- Feb 06, 2021
-
-
Oliver Bartsch authored
BackendController::generateJavascript() creates the top.fsMod object to provide frameset modules an easy way of storing their state. The FileList module e.g. stores the current folder identifier. Therefore, after switching back to the FileList module, the previously selected folder is used. This behaviour is now restored by replacing the "instanceof" check, which always evaluated to FALSE, with a typeof check. It's furthermore now ensured that the id will always be set, even if recentIds is not yet an object. Resolves: #92811 Releases: master, 10.4 Change-Id: I36227775bfadfca4d43a719b1508f78976b6e342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67628 Tested-by:
-
