- Dec 01, 2022
-
-
Stefan Bürk authored
doctrine/dbal 2.x version has reached EOL, which means that there will be no new version in this version range. Sadly, doctrine/dbal triggers a deprecation warning in PHP8.2 which will not be fixed upstream. Raising that dependency is out of the scope for TYPO3 v11. This issue is mitigated by adding the well-known composer dependency `cweagans/composer-patches` as dev dependency. Additionally, a corresponding composer patch targeting the PHP8.2 variable interpolation deprecation warning is applied in CI for testing purpose. UpgradeCest acceptance tests is adjusted to execute some steps only for appropriate dbms/drivers, as they are not targeting the newer versions. This change: * Adds composer patcher `cweagans/composer-patches` * Adds composer patch for doctrine/dbal variable interpolation issue in postgres platform class * re-arranging pre-merge and nightly tests * Ensures to execute some acceptance and functional tests against MariaDB 10.6 (LTS) * Adds a little workaround (ignore-platform-reqs) for composer install min and max with PHP8.2 in `Build/Scripts/runTests.sh` and docker-compose.yml Used command(s): > composer2-74 config --no-plugins --no-interaction \ allow-plugins.cweagans/composer-patches true > composer2-74 config --no-plugins --no-interaction \ extra.composer-exit-on-patch-failure true > composer2-74 config --no-plugins --no-interaction \ extra.patches-file "Build/patches/patches.json" > composer2-74 require --dev \ "cweagans/composer-patches":"^1.7.1" Resolves: #99173 Releases: 11.5 Change-Id: If7abd9e66c409c5417343658fe789ee38b35f082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76011 Reviewed-by:Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Nov 28, 2022
-
-
Nikita Hovratov authored
Resolves: #99207 Releases: main, 11.5 Change-Id: I222a861578a7b1b683b7922bcdf55776b96b4648 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76781 Tested-by:
-
- Nov 27, 2022
-
-
Stefan Bürk authored
Guard invalid array key access in LanguageServices, also it relates to an invalid xliff translation identifier. However, the PHP warning should be guarded properly. Resolves: #99190 Resolves: #98713 Releases: 11.5 Change-Id: Ied1894b4863804cfda4840379c0472cf3807a4d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76838 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
- Nov 25, 2022
-
-
Christoph Lehmann authored
With this the list of grouped sql queries is much shorter and better understandable. Resolves: #99187 Releases: main,11.5 Change-Id: Id78568bbe987d8047860f32d58c79644436671d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76780 Tested-by:
-
Andreas Fernandez authored
It doesn't make much sense to keep the shortcut menu open once an entry is opened, therefore it will be closed now. Resolves: #99164 Releases: main, 11.5 Change-Id: I559f59feeb72c48fda6bb73748f89481a18e760a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76817 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Nov 23, 2022
-
-
J. Peter M. Schuler authored
While the assumption that sys_language_uid 0 is enabled is probably always true, there are scenarios where this isn't the case (e.g. disabling sys_language_uid 0 for different default languages on different sites while still allowing cross-domain-links in the correct language). In PHP 7.4 the LanguageMenuProcessor did a graceful fallback to nothing, in PHP 8.1 calling a LanguageMenuProcessor with disabled base language results in an exception `Trying to access array offset on value of type null` Resolves: #99156 Releases: main, 11.5 Change-Id: I443e94f6dd45d7462f5925ff014a5bfc0df40ef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76779 Tested-by:
-
Chris Müller authored
Resolves: #99151 Releases: main, 11.5 Change-Id: Ibddea0cd6b4f869632899b7887f573bb7a6856b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76778 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99158 Releases: main, 11.5 Change-Id: I7cc2760f7f7ec4f329e8ec2dac127da3b2ba9648 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76777 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99154 Releases: main, 11.5 Change-Id: Iff01454dffb3afc0ebd4dff440467c0170d05934 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76776 Tested-by:
-
- Nov 22, 2022
-
-
J. Peter M. Schuler authored
Resolves: #99159 Releases: main, 11.5 Change-Id: I7a130b7471528dbd0a7e98257f119def8bb648ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76775 Reviewed-by:
-
Georg Ringer authored
The ViewHelper `f:format.nl2br` must be applied after `f:format.htmlspecialchars()`. Resolves: #99160 Releases: main, 11.5 Change-Id: If20a25cf86479fa8d8e533fc5d820dc6931c3a5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76774 Tested-by:
-
Markus Klein authored
If `FE|checkFeUserPid` is set, the storagePids must evaluate to an empty set instead of the pid "0". Resolves: #95119 Releases: main, 11.5 Change-Id: If749d465f6e4d474794f0818de7c67bf36d5475b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76773 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Nov 21, 2022
-
-
Nikita Hovratov authored
IconRegistry->detectIconProvider() may receive a null value for the $iconReference parameter. E.g. in IconRegistry->registerModuleIcons(). Therefore, a cast to string is needed for strtolower. Resolves: #99152 Releases: main, 11.5 Change-Id: Ia45c8a52ff12fa4d988977e1265b204df8217d2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76756 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Nov 20, 2022
-
-
Christian Kuhn authored
The test does not make sense and is skipped for a while already. Remove it. Resolves: #97112 Releases: main, 11.5 Change-Id: If00b0b607263531359393cff7793624a12b878bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76743 Tested-by:
-
Oliver Bartsch authored
The default duplication behaviour action for the file upload is now properly assigned to the view again. Resolves: #97357 Releases: main, 11.5 Change-Id: Id472dff8154dd4263827863a118f5da4390a7924 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76744 Tested-by:
-
- Nov 19, 2022
-
-
Roman Büchler authored
This allows to use the mask property from the TypoScript imgResource function again. Resolves: #96116 Releases: main, 11.5 Change-Id: Ia069a687e98a91437959e1bbd4efc5d59fb2017c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76708 Tested-by:
-
Oliver Klee authored
Resolves: #99136 Releases: main, 11.5 Change-Id: I7851afb5f6417bb538895768fe4ae35d8b75d0b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76678 Tested-by:
-
Oliver Klee authored
This helps PHPStan better analyse code that uses this method. Resolves: #99133 Releases: main, 11.5 Change-Id: Ia6da1e1f25a9bfd0f493b2c1e244d79aab865c56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76677 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99134 Releases: main, 11.5 Change-Id: I4ec448a0d06f5614cdc35e7f695c692e4080fbc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76676 Tested-by:
-
Christian Kuhn authored
Resolves: #99138 Related: #96116 Releases: main, 11.5 Change-Id: I303c6cb4c0cbf9b278f66a34cd49345c18ea2a1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76675 Tested-by:
-
- Nov 18, 2022
-
-
Oliver Klee authored
The FAL-related Extbase models are documented in the "TYPO3 Explained" documentation, and they are the recommended way to use FAL in an Extbase context. So the following classes are not marked as `@internal` anymore in order to not send mixed signals to extension developers: - TYPO3\CMS\Extbase\Domain\Model\File - TYPO3\CMS\Extbase\Domain\Model\FileReference - TYPO3\CMS\Extbase\Domain\Model\Folder There is no point in forcing extension authors to re-implement those classes (and duplicating the code from the Core) when the Core implementation is stable now and has proven to work fine. Some history for what has happened: Those classes started out marked as experimental (when they were indeed still experimental). Then, in a cleanup bulk change in 3888dae8f3f71c3f5e1db1c00bcbfe7d0d8fed2e5966e6533c9353b6d7485f32, the classes were converted to use the `@internal` annotation, even though at least the three FAL Extbase models should have been made public API instead by that time. This is where the usage of the FAL models is documented in "TYPO3 Explained": https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Fal/UsingFal/Frontend.html Change-Id: I5e5dfcf292eabd57a080bed29572b7c1eecd9286 Resolves: #99126 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76674 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Nov 17, 2022
-
-
Ingo Fabbri authored
With `fallbackType` set to strict, only translated content is rendered. In AbstractMenuContentObject->sectionIndex content is fetched and overlayed. Once there is an element untranslated, the record overlay will return a $row = `null`. To mitigate, move all left over access to $row inside the guarded if-block. Resolves: #98043 Releases: main, 11.5 Change-Id: If4baf0fb88292cb8c6814539cf7efa610ae850f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76673 Tested-by:
-
Oliver Klee authored
Passing no action name is a perfectly fine use case as this allows to conveniently redirect from a controller action to any page. Making this explicit in the type annotations allows extension authors to use this pattern without type checkers like PHPStan creating a warnings about this. Resolves: #99110 Releases: main, 11.5 Change-Id: I12cded81cbe20f7f2f626cf71ab92532d9037ee9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76655 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Matthias Vogel authored
Releases: main, 11.5 Resolves: #99115 Change-Id: I7860824c5377896f94f2ee34b281bf69bae251a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76672 Tested-by:
-
Oliver Klee authored
Extbase controllers that call a never-returning method do not need a return statement after that call in order to avoid calling the rest of the action method. The new annotations ensure that PHPStan becomes aware of this control flow. > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99109 Releases: main, 11.5 Change-Id: I9b9d308440966c71051fe993abd31f23b13c82e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76653 Tested-by:
-
- Nov 16, 2022
-
-
J. Peter M. Schuler authored
Resolves: #99106 Releases: main, 11.5 Change-Id: Iabddf0b2f1c98db6e3e07f26162257f696d6fd9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76616 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99107 Releases: main, 11.5 Change-Id: If5e9d1acf81bf2913405e18cc38f2a7ad5ee62cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76615 Tested-by:
-
- Nov 15, 2022
-
-
Oliver Hader authored
* actually use `array_filter` internally * allow using `array_filter` modes `ARRAY_FILTER_USE_KEY` and `ARRAY_FILTER_USE_BOTH` Resolves: #99071 Releases: main, 11.5 Change-Id: I1b95ae0a7551250125a9eeabbd0ee7e66e25a6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76635 Tested-by:
-
Chris Müller authored
Resolves: #99085 Releases: main, 11.5 Change-Id: Ie3b337b93f43fb2c41d76427f29d793b57e9232b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76633 Tested-by:
-
Chris Müller authored
Resolves: #99037 Releases: main, 11.5 Change-Id: I86cf8b64c198d1707dc3c5f385c6ee19ffa5960c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76632 Tested-by:
-
Benni Mack authored
Change-Id: I7d30b077af9795dfc335a7f9941aba977dd5377e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76604 Tested-by:
-
Benni Mack authored
Change-Id: I357a4d7f4f74c94ad91aa3837b15b83231de4132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76603 Tested-by:
-
Christian Kuhn authored
Resolves: #99088 Releases: main, 11.5 Change-Id: I67f799fdca4d736c36775d50b5ac753eba93ba52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76614 Tested-by:
-
- Nov 14, 2022
-
-
Benni Mack authored
BackendUtility::getPossibleWorkspaceVersionIdsOfLiveRecordIds() is added to check for workspace versions within FormEngine foreign_field logic to first fetch a list of all records that have a versioned record within the workspace, and only apply BackendUtility::workspaceOL() for these cases. Without the patch, each live record triggers a database query to resolve a possible workspace overlay. With the patch, one query is done to see which records have workspace overlays, only those are queried for overlays. This reduces the number of performed queries a lot, since typically only a small number of records are overlaid. This only affects editing records in a workspace. Resolves: #99007 Releases: main, 11.5 Change-Id: Ia7c47e5de0082ca0ff2c68b30d9ff1bc5312981b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76613 Tested-by:
-
Benni Mack authored
This reverts commit 551f540f. Reason for revert: A regression was introduced Change-Id: I7aee1dec8f4197305156f204db27c6f0704762c2 Resolves: #99077 Reverts: #93457 Releases: 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76612 Tested-by:
-
- Nov 12, 2022
-
-
Oliver Klee authored
With the class in the general `EventDispatcher` namespace, extensions can now use this class for their tests. Also add unit tests for the moved class. Resolves: #99070 Releases: main, 11.5 Change-Id: I69b94f50f68dcacfe036e8eb489ba6b82fbb585a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76570 Tested-by:
-
Andreas Fernandez authored
The date-time-picker component now checks properly if the backend user's language could not get fetched from its UC by checking loose for a falsy value. Resolves: #99067 Releases: main, 11.5 Change-Id: I3ba104afde2321480099e96beff6ab77ecb126a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76568 Tested-by:
-
Andreas Fernandez authored
This patch updates `moment-timezone`, having a fixed vulnerability, along with the related `moment` library. Executed commands: yarn add \ moment@^2.29.4 \ moment-timezone@^0.5.35 grunt build Resolves: #99061 Releases: main, 11.5, 10.4 Change-Id: I36376bad194aa63dda0146c8bc0f481b932dc89d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76557 Tested-by: -
linawolf authored
Solves https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-ViewHelper/issues/50 Occurences of `:ts:` are adressed in https://forge.typo3.org/issues/99068 Resolves: #99069 Releases: main, 11.5 Change-Id: I49a42ba29017081d338bec815e3b2c5f14bf7a68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76501 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
linawolf authored
Replace `:ts:` with ``:typoscript:` in ViewHelper class comments. `:ts` does not render properly, see for example https://docs.typo3.org/other/typo3/view-helper-reference/main/en-us/typo3/fluid/latest/CObject.html Resolves: #99068 Releases: main, 11.5 Change-Id: Idfac843859a5e9054e6e48f29b19616b2b956dac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76500 Tested-by:
-
