- Feb 20, 2022
-
-
Stefan Bürk authored
Raise development dependency "php-webdriver/webdriver" to a version which includes officially PHP8.1 fixes and opens for up for "Symfony 6 components" installation on main. used command: > composer req php-webdriver/webdriver:"^1.12.0" --dev Resolves: #96979 Releases: main, 11.5 Change-Id: I1ca15e0473e179c89c39fa2aa46073f3d09a2687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73621 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benjamin Franzke authored
Since #94084 all module URLs are automatically framed by the TYPO3 main controller whenever they are opened in a Sec-Fetch-Dest aware request. Use a non-module route for the popup window in order to avoid the automatic re-framing. Also hide the back-button in the popup window, as it would cause the entire backend to be opened in the popup. The shortcut button will link to the module-based detail-action in order to show in regular module context. Releases: main, 11.5 Resolves: #95361 Resolves: #86099 Related: #94084 Change-Id: I0bae3e502fa58f4b2bee804c5ed12b0fc2030d20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73608 Tested-by:
-
Christian Kuhn authored
Recent pdo_sqlsrv 5.10.0 force SSL enabled connections with valid certificates. We can't supply these in CI right now. The patch removes active functional testing with this DBMS on CI, but keeps the rest of the infrastructure in runTests.sh and friends. This is a quick fix to get v11 and v10 green again. We could pick this up again if we find a solution for the certificate issue. Resolves: #96974 Releases: 11.5, 10.4 Change-Id: I0af99c52ae447ae6974d21236a862179e9b40dd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73613 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Nikita Hovratov authored
This answers the question, why we check for 2 fields. Resolves: #96970 Releases: main, 11.5 Change-Id: Id2f74fe1362569765b0c030f810d5e208a15ad8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73547 Tested-by:
-
Nikita Hovratov authored
The fieldControl to add a button to open the tableWizard has been removed in a previous optimization. Resolves: #96971 Related: #95036 Releases: main, 11.5 Change-Id: Ib1f8c5ff29071778ed098cabab8bdf22422822e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73546 Tested-by:
-
Nikita Hovratov authored
Resolves: #96969 Releases: main, 11.5 Change-Id: I2dbd46db484c66bdea05d513f2b7e5c77f6f16bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73545 Tested-by:
-
- Feb 19, 2022
-
-
Benjamin Franzke authored
BackendUserAuthentication isn't an injectable service, therefore the (unused) dependency injection is dropped and $GLOBALS['BE_USER'] usage is moved to be scoped by the isBackend() check. Also fix the same DI-anti-pattern in CategoryPermissionsAspect. No user facing error is currently known for this case, as the ModifyTreeDataEvent is only executed in backend context, so this is just to streamline both aspects. Releases: main, 11.5 Resolves: #96960 Change-Id: I7b9f49ef82eeffcf369f471b5d031311aa5007b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73544 Tested-by:
-
- Feb 18, 2022
-
-
Georg Ringer authored
Avoid exceptions when creating inline relations if the parent record is not yet persisted. Resolves: #96900 Releases: main, 11.5 Change-Id: I383fd37efa8bec09333ee61156be1add99fd6e56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73602 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Franzke authored
* Avoid scrollIntoView which is no longer needed since #96947 * Do not catch exceptions on tab-click in ElementsBasicInputRangeCest which has been introduced in #93629, but actually didn't catch the documented case where the tab was already active (no exception in that case). It was actually only triggered when the tab was scrolled away. Again no longer needed due to #96947. Resolves: #96951 Related: #96947 Related: #93629 Releases: main, 11.5 Change-Id: I787960ea5dd8a6c946e090d90c4c9d2ecb950e68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73586 Tested-by:
-
Oliver Bartsch authored
Some code examples for the ShortcutButton "routeIdentifier" property, introduced in #93093, used the non existing "web_view" identifier. Using this code example will therefore lead to a RouteNotFoundException exception. This is now fixed by using the correct identifier for the viewpage module. Resolves: #96945 Related: #93093 Releases: main, 11.5 Change-Id: Icf0a7cd476328661a630f24655ec53fe34b78745 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73543 Tested-by:
-
Oliver Bartsch authored
The option to disable the column selector in the filelist is located under the top-level key "options". Resolves: #96959 Related: #84184 Releases: main, 11.5 Change-Id: I97d09e17a19953ef20e9f3108c053d323f2a4507 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73542 Tested-by:
-
- Feb 17, 2022
-
-
ochorocho authored
Releases: main, 11.5 Resolves: #96943 Change-Id: I1934c621ab87ba46387860050124d8c55210a81c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73540 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benjamin Franzke authored
With #90879 useOrOverridePlaceholder fields have been adapted to autofocus the related field when the related checkbox (e.g in sys_file_references) are triggered in FormEngine.toggleCheckboxField. This has the side effect that input fields whose checkbox is preselected are autofocused on initial page load, when FormEngine.toggleCheckboxField() is called from FormEngine.initializeNullWithPlaceholderCheckboxes. This caused the browser to scroll to these fields. The autofocus is now changed to not be triggered on initial pageload, only when FormEngine.toggleCheckboxField() is used due to user input. This also had the effect that acceptance tests failed randomly as automated tab-clicks didn't work (for example in #93629), when the formengine iframe was scrolled all the way to the last useOrOverridePlaceholder field, rendering the tab-selection invisible. Releases: main, 11.5 Resolves: #96947 Related: #90879 Related: #93629 Change-Id: Ie880595079e60421556994b14af0b94bba67b73c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73580 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Stefan Bürk authored
'ext:redirect' now clusters the redirect cache into dedicated parts per domain, which reduces the data amount needed to load on redirect handling in the frontend to the absolute minimum. On the other hand, when rebuilding a cache this is narrowed down to the related domain, thus avoiding retrieving and caching all redirects, which may reduce the processing time in the backend on changing redirects or auto redirects creation on page updates. This works around some flaws for some instances and use cases, but do not harm on smaller instances with lower redirects count. * read and write redirect cache by domain based identifier * removed one array level from cached information and reduced one array key level in redirect matching code * cache identifier for domain entries are build using 'sha1()' * combined with early redirects introduced with #96480 this reduces the loaded data even more, as it is done in chunks * adjusted unit tests to reflect two redirect cache service calls, one for the domain and one for wildcard "*". * rebuilding cache through datahandler hook now rebuilds only for the related 'source_host', thus avoiding rebuild of all redirects for every change. This may still be further improved for multi record operations with the same domain. A 'rebuildAll()' fallback stayed as a last defense to cover cases where specific source_host cannot be determined. Resolves: #96617 Releases: main, 11.5 Change-Id: Id335017cf890dca7c57e892a2561c3555348a668 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73541 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
dev-rke authored
FlexFormSectionContainer raises an exception when title is not defined. Releases: main, 11.5 Resolves: #96936 Change-Id: I0ad1a432f11bb2cc36f718ca25f430cf91d94417 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73538 Tested-by:
-
Elias Häußler authored
Resolves: #96942 Related: #93023 Releases: main, 11.5 Change-Id: I7352a53e03162b24a7e931244e02de5067cc02eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73539 Tested-by:
-
- Feb 16, 2022
-
-
Oliver Bartsch authored
The StandardContentPreviewRenderer runs through a list of fields, whose value should be processed and displayed in the footer. Some of those field values might be a reference to a foreign table, e.g. in the "fe_group" field. Due to changes in getProcessedValue(), it's necessary to provide the records' uid, to be able to resolve values of fields with a "foreign_table" configuration. Resolves: #96920 Releases: main, 11.5 Change-Id: I0d8739710e478a7cb264be1d5b90b70af31de964 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73537 Tested-by:
-
Oliver Bartsch authored
The new content element wizard is using default values to define on which colPos or in which language the new element should be created. Using TSconfig it is also possible to define custom default values, most commonly the "CType". The user defined values should however never overwrite the dynamically generated values from the UI. Therefore, the dynamic values do now always overwrite the user defined values, like it's already done on preparing the data map (In case "saveAndClose" is used). Resolves: #96914 Releases: main, 11.5 Change-Id: I8f2bbf2589715c63a54bc19380f98483a12d028c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73536 Tested-by:
-
Oliver Bartsch authored
A JavaScript exception is fixed by replacing the invalid "auto" option for the "size" attribute of the custom "typo3-backend-icon" element with "small". Resolves: #96915 Related: #95353 Releases: main, 11.5 Change-Id: I765a79d4d32e93175a0c5f271b203ba39e607b36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73556 Tested-by:
-
- Feb 15, 2022
-
-
Oliver Bartsch authored
Resolves: #96913 Releases: main, 11.5 Change-Id: Idf1b2d34d9c4373f52f5d8cbae84d83d2d5bfbd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73535 Tested-by:
-
Benni Mack authored
When previewing the frontend for a specific usergroup (ADMCMD_simUser) or previewing a page in the future (ADMCMD_simTime) the GET parameters are now continued to be used when browsing the frontend. This solves issues when a user-restricted page or a page visible in the future has a form on it, and the GET parameters are kept. Resolves: #94974 Resolves: #96491 Releases: main, 11.5 Change-Id: I0a79749648c0235f0a959a416408540fab2fb4b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73534 Tested-by:
-
Benni Mack authored
With the change https://review.typo3.org/c/Packages/TYPO3.CMS/+/50811/ the link markers in the label file were removed. Resolves: #96910 Related: #52286 Releases: main, 11.5 Change-Id: I59a45d2c4f43c84087c7c964ce4460f6c7eb49e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73533 Tested-by:
-
Oliver Bartsch authored
This removes the no longer evaluated option `uploadfolder` from ext_emconf.php files. Additionally, `clearCacheOnLoad => 0` is removed, since this is the default. Resolves: #96898 Releases: main, 11.5 Change-Id: I99379d6066e53abd67fd8e6a1f32638b597ea1c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73520 Tested-by:
-
Susi Moog authored
If l10n_source points to a deleted or non-existing record the translation wizard failed in free mode with a 500 error, because determining the source languages fail and no fallback was implemented. Instead of failing, the behaviour was adjusted to handle l10n_source pointing to erroneous records similarly to an empty column and offering all available language as option for the translation - as in fact the source cannot be reliably determined. Resolves: #96838 Releases: main, 11.5 Change-Id: Iec7f4a1dba6b93c5185fec7863b1deaa175b0279 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73532 Tested-by:
-
Christian Kuhn authored
Change-Id: I31ec2d1ab4872f5ab6df354c4e808b451ac1ce71 Resolves: #96897 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73513 Tested-by:
-
- Feb 14, 2022
-
-
Imko Schumacher authored
Tokens in an encoded URL (where '=' is '%3D') now get anonymized. Resolves: #96858 Releases: main, 11.5 Change-Id: If07d122b2a5b89cb66fef3fff0790004c5d07eb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73399 Tested-by:
-
Markus Klein authored
Ensure the "new record" page position selector works on the root page (pid 0). Resolves: #96883 Releases: main, 11.5 Change-Id: I25681e5b0a2608dde3ca47180f443820cd7ff5bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73398 Tested-by:
-
Susi Moog authored
* Migrate most test fixtures from .xml to .csv. Some special cases are left out, those will receive dedicated patches. * Streamline assertCSVDataSet() and importCSVDataSet() usage to __DIR__ relative paths. Resolves: #96856 Releases: main, 11.5 Change-Id: I747aafa03c031aa655c8f2a9ab71027ee2accddc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73484 Tested-by:
-
Andreas Fernandez authored
If the modal component starts an AJAX request that results in a non-okayish response (>= 400), the underlying fetch() throws an error that is now caught. If the response sends an optional body, it is rendered in the modal. If an empty body is received, a fallback text explaining the issue is rendered instead. Resolves: #96852 Releases: main, 11.5 Change-Id: I986c0b92d742fa76b773dd3f3a976a05a3f6b546 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73478 Tested-by:
-
Oliver Bartsch authored
To overwrite the bootstrap styles of the striped table in the extension manager list, our custom styles must be defined more explicit. Resolves: #96865 Related: #93119 Releases: main, 11.5 Change-Id: I9804eef64ad8c71d7f449bf1212c15ee589ca95d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73476 Tested-by:
-
Georg Ringer authored
Fix a notice which happens if the exclude configuration of the field `hidden` of tt_content is removed. Resolves: #96873 Releases: main, 11.5 Change-Id: I94a0ff88a936f403dcd8000f691ae5334863d07f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73397 Tested-by:
-
Benjamin Franzke authored
Cache busting parameters need to be added to any JavaScript resource to force browsers to re-download these files after updates. JavaScriptItemHandler.js changed between TYPO3 v11.5.3 and v11.5.4 and therefore needs to be updated by browsers. The same fix is applied to requirejs-loader.js as this file changed between v11 and v12. A micro optimization is made by avoiding that JavaScriptRenderer is created twice during PageRenderer creation. Resolves: #96663 Resolves: #96606 Related: #96003 Releases: main, 11.5 Change-Id: I04207a46e6d44d3e0b4e633bce7fca22761aa60e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73185 Tested-by:
-
Oliver Hader authored
Email processing in <f:link.email> view helper has been changed to be based on typolink recently. In order to allow (internal) markup in spamProtectEmailAddresses_atSubst or ~_lastDotSubst it has to be ensured that only the input parameter (the email address) is considered as user input and thus encoded for HTML. Resolves: #96723 Releases: main, 11.5 Change-Id: I199ab6471d44508b0a3a4338ea1650d7eb7345df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73364 Reviewed-by:
-
Peter Kraume authored
Resolves: #96872 Releases: main, 11.5 Change-Id: I5fdfca4bcf0b01d6d0103e8e4e8b1c6c011edc3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73396 Tested-by:
-
- Feb 12, 2022
-
-
Christian Kuhn authored
Casual "pre-merge" patches (pushing a patch) to CI gives us two stages: An "early" stage checking CGL and composer basics, plus the "main" stage checking everything else. The goal with this approach is to return early on simple errors like CGL violations without wasting additional ressources on other things when those pre-conditions fail. In practice, an early "cgl broken" pipeline shadowes possible further issues and extends runtime of single builds since 'main' is only run after 'early' has been successful. The patch merges all "pre-merge" jobs into one stage. This means more jobs are executed in parallel, but we hope the infrastructure can cope with that. If that works out, CI should answer more quickly on single patches. Resolves: #96841 Releases: main, 11.5 Change-Id: I986992f486b05845621f35228ae01b673368ba95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73452 Tested-by:
-
Christian Kuhn authored
There are a couple of functional tests marked "incomplete" since 2019. Tests that have been skipped for so long are probably broken anyway and do not add value. Remove them. Resolves: #96839 Releases: main, 11.5 Change-Id: I503339d9a4b30a32b7d1a1fbc1bd9832fe289952 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73453 Tested-by:
-
Christian Kuhn authored
Our LICENSE.txt files contain a custom header mentioning details of a 3rd party library. The patch resets LICENSE.txt files to the default GPLv2 version [1] and moves the 3rd party credits to the backend about module, which already lists other credits. This obeys the authors whish to set a link to his work. The default LICENSE.txt files have the additional advantage that services like github should recognize the project as GPLv2 licensed project. [1] https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt Resolves: #96837 Releases: main, 11.5, 10.4 Change-Id: I63a4cd286ea3714667688d12347034b9ae67f276 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73395 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Feb 11, 2022
-
-
Benni Mack authored
This issue solves a few phpstan related errors. Resolves: #96834 Releases: main, 11.5 Change-Id: I4b6c9d6ef618c5a791e0e40b10ef2d2e81bdd27e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73431 Tested-by:
-
Chris Müller authored
Resolves: #96833 Releases: main, 11.5 Change-Id: I69a3a15e9ca694456fcaf24abeef84318d9e5d6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73429 Tested-by:
-
Oliver Bartsch authored
In case the "f:format.html" ViewHelper is called in the install tool or via CLI, the request might miss the application type attribute. This led to an exception on checking the application type. This is now fixed by checking the request before calling the static ApplicationType check. Resolves: #96788 Releases: main, 11.5 Change-Id: I1e48a3556d510d2af82d4f95828d44c182db0663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73423 Tested-by:
-
