- May 29, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #91535 Related: #91473 Change-Id: I98db08e8fef297b47bd11fed13d3fe91af3ba1cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64382 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Alexander Schnitzler authored
The method is removed in favor of PHP's native hex2bin() function. Releases: master Resolves: #91529 Related: #91473 Change-Id: Ife685202e8210b3db872ff9989c5b94e351e29e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64378 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
The following deprecated methods are now removed: - \TYPO3\CMS\Core\Utility\GeneralUtility::compressIPv6 - \TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory - \TYPO3\CMS\Core\Utility\GeneralUtility::getApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::idnaEncode - \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Hex2Bin - \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Bin2Hex - \TYPO3\CMS\Core\Utility\GeneralUtility::isRunningOnCgiServerApi - \TYPO3\CMS\Core\Utility\GeneralUtility::linkThisUrl - \TYPO3\CMS\Core\Utility\GeneralUtility::milliseconds - \TYPO3\CMS\Core\Utility\GeneralUtility::presetApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::resetApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::verifyFilenameAgainstDenyPattern In addition, makeInstanceService requires the third parameter to be array instead of string or array. The method "getUrl()" now only accepts one argument. In addition, the testing framework is raised to 6.3.1 to not use the unneeded methods anymore. Resolves: #91513 Releases: master Change-Id: I124b6f531fed61a93f5ed03391e1d4b6cf7a08ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64593 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- May 28, 2020
-
-
Benni Mack authored
The following previously deprecate static methods are now removed: - TYPO3\CMS\Backend\Utility\BackendUtility::getRawPagesTSconfig() - TYPO3\CMS\Backend\Utility\BackendUtility::editOnClick() - TYPO3\CMS\Backend\Utility\BackendUtility::getViewDomain() - TYPO3\CMS\Backend\Utility\BackendUtility::getBackendScript() - TYPO3\CMS\Backend\Utility\BackendUtility::TYPO3_copyRightNotice() Resolves: #91481 Releases: master Change-Id: I8943f2e14ce1dbcb1195fffef5afe329b5f3ab79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64585 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- May 13, 2020
-
-
Markus Klein authored
Some methods have been added for this matcher, which are actually not deprecated/removed as a whole. Only the usage of those methods has been adjusted. The extension scanner is not capable of detecting such usages only, hence there is no sense in reporting every usage of those functions, albeit these usages might be valid. The matcher entries are removed therefore. Resolves: #91355 Releases: master Change-Id: I9da87ecb320f65d4fe5df168d788bb2ba8547f84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64451 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Apr 12, 2020
-
-
Benni Mack authored
Some methods in GeneralUtility nowadays are wrappers to native PHP methods. We encourage people to use the PHP API directly. * GeneralUtility::IPv6Hex2Bin() * GeneralUtility::IPv6Bin2Hex() * GeneralUtility::compressIPv6() * GeneralUtility::milliseconds() In addition, these methods are unused by Core * GeneralUtility::linkThisUrl() * GeneralUtility::flushDirectory() Reasoning: In order to make our code less coupled, TYPO3 Core should use native PHP where it makes sense, instead of relying on GeneralUtility in all places. Resolves: #91001 Releases: master Change-Id: I9e3a2f4a4bb42facad2d79f959b36482dba23ec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64091 Tested-by:
-
- Mar 23, 2020
-
-
Benni Mack authored
This change targets a couple of things: - The global constant "FILE_DENY_PATTERN_DEFAULT" is moved to a class constant - The global constant "PHP_EXTENSIONS_DEFAULT" which is not in use anymore, is removed. - The security aspect of checking against the fileDenyPattern is extracted into its own Class where - The fileDenyPattern can never be empty, but only be set via DefaultConfiguration. This makes it easier to test this functionality, a single object is taking over the responsibility, and the logic is now in one place. Also, the non-usage of the global constant makes life easier. Resolves: #90147 Releases: master Change-Id: I9db0d6fc3b10f75a3735017cb9ac0d9bfd4ff02b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62843 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Mar 21, 2020
-
-
Benni Mack authored
"GeneralUtility::isRunningOnCgiServerApi()" is now deprecated in favor of "Environment::isRunningOnCgiServer()". Resolves: #90800 Releases: master Change-Id: Ib9e9e38d0e53ca00f3c58eb3255943d57cf7c0e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63680 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
- Jan 30, 2020
-
-
Benni Mack authored
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
-
- Nov 25, 2019
-
-
Benni Mack authored
The BackendUtility::getCopyRightNotice() is ugly, and can only be used in Backend context (not install tool). A new PHP class "Typo3Copyright" in EXT:core encapsulates this information so it can be used in other places as well. The old method is marked as deprecated. Resolves: #89756 Releases: master Change-Id: I5d793138324b315f4ad4873687f85b84120e271a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62420 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Nov 21, 2019
-
-
Benni Mack authored
This change introduces two new API classes relevant for PageTSconfig: - PageTsConfigLoader - PageTsConfigParser The loader class collects all PageTS found in a rootline, which was previously available in two places - BackendUtility and TSFE, although they were similar, they were not the same and error-prone in the past. The previous "TsConfigParser" class had an unusal dependency to the BackendConditionMatcher only, which did not even allow to send in custom arguments. The TSFE part is now also evaluating TSconfig conditions properly, which was not the case in the past. This part is also now cached properly. The TSconfig inclusion ("include from the list of TSconfig inclusions") functionality is now built into the Info module. In addition, the hard-coded "ConditionMatcher" is now seamlessly injected into the parsing process, allowing - Decoupling of Logic and Implementation of parsing in different contexts - Making the ConditionMatcher extensible by having a new ConditionMatcherInterface In the next steps: - the UserTsConfig parsing can be applied separately and split from BE_USER - ConditionMatcher Interface can be used properly - TypoScriptParser can be split up - BackendUtility can be cleaned up further. The following functionality is deprecated: - TYPO3\CMS\Core\Configuration\TsConfigParser - TYPO3\CMS\Backend\Utility\BackendUtility::getRawPagesTSconfig() Resolves: #89718 Releases: master Change-Id: Ibd0a2d086d7e5166f16213fa4aadffd41ecb645c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62349 Tested-by:
-
- Nov 13, 2019
-
-
Benni Mack authored
The application context is stored in the Environment class since TYPO3 v9, which is the correct place instead of GeneralUtility::getApplicationContext(). Resolves: #89631 Releases: master Change-Id: I55de17ef3b9cbd0962a2c604913c736bd52ac6d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62247 Tested-by:
-
- Aug 29, 2019
-
-
Alexander Schnitzler authored
As Extbase does no longer guess class names from extension keys and vendor names, method ExtensionUtility::configurePlugin does no longer accept providing a vendor name. The same applies as well for parameter $extensionName of method ExtensionUtility::registerPlugin. The vendor information is not used at all and must be ommitted in the future. The former syntax \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin( 'TYPO3.CMS.Form', 'Formframework', 'Form', 'content-form', ); has to be converted to \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin( 'Form', 'Formframework', 'Form', 'content-form', ); Releases: master Resolves: #88995 Change-Id: I247df236d41c24a6ce5f58164f127671237ddf28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61522 Tested-by:Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
-
- Jul 29, 2019
-
-
Andreas Fernandez authored
Resolves: #88855 Related: #88787 Releases: master Change-Id: I3578c36fac2a6bb57704d41ccfa60a6dbd4727b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61386 Tested-by:
-
- Jun 25, 2019
-
-
Benni Mack authored
The functionality to set a custom TCEMAIN.previewDomain via PageTS is not in use anymore as SiteHandling is using the proper domain anyway already. Conceptually this does not work anymore, as the base (domain + path prefix) determines Language + Site / PageTree entry point. Setting this to something else via TCEMAIN.previewDomain would not work anyways, so this hack is removed, as we now can safely determine the full (speaking) URL with Site Handling. In addition, the method BackendUtility::getViewDomain() is now deprecated. Resolves: #88499 Releases: master Change-Id: Id88c16e2e86ccce8a2e7be02af0e2a39802624c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60773 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
- Jun 17, 2019
-
-
Benni Mack authored
Locales resolves the user-defined TYPO3-languages and its dependencies via TYPO3_CONF_VARS, which are only finally available when all extensions' ext_localconf.php is included. For this reason, Locales::initialize() can be deprecated and moved into the regular constructor, but then the Bootstrap should not do the initialization anymore, which happens at the point now, when Locales first gets initialized (which happens in Frontend within TSFE and PageRenderer and in Backend within $LANG). For this reason, it is removed from Bootstrap, where it was first placed in TYPO3 4.6 when no proper bootstrap set up was given. Resolves: #88569 Releases: master Change-Id: Ife2e248412c1b206abffcdd21df0d01e44834cea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61046 Tested-by:
-
Alexander Schnitzler authored
This patch removes the automatical registration of two types of validators. - model validators - type validators Model validators are those validators that follow a specific namespace and class naming derived from domain models. Given a model \Vendor\Extension\Domain\Model\Foo, extbase searched for a valiator \Vendor\Extension\Domain\Validator\FooValidator. If it existed, it had been registered automatically and could not be disabled at all. Type validators are similiar to model validators. Given a non model action parameter or model property like int, string, float, DateTime and such, extbase searched for validators in the namespace TYPO3\CMS\Extbase\Validation\Validator. There is a TYPO3\CMS\Extbase\Validation\Validator\StringValidator for example which had been registered for string type params and properties. Said validators could not be disabled at all. There are several reasons why the automatic registration has been removed: - First of all, this behaviour led to an unknown amount of actual registered validators. Developers that are new or simply not familiar with the concept of validation magic could easily become frustrated. - Then there is the problem that validation takes place, no matter if it was needed or wanted. A domain validator, which looked quite handy in the first place, had to be reduced to the validation logic that would fit all cases where according objects had been passed into methods. No matter the context. The context however matters a lot. One might want to have different validation rules depending on if objects are created, updated or deleted. This distinction was impossible and therefore model validators could be a burden. - Last but not least, the automatic registration is a problem when introducing validation groups. Validation groups cover the context aspect mentioned earlier. By grouping validations one can create and register different validators and apply them given by contexts like create, update, delete and such. Releases: master Resolves: #87957 Change-Id: If8f590a1bedb428c8884cd61828d8cc671ee92e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60298 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
- Jun 14, 2019
-
-
Georg Ringer authored
The following methods of `\TYPO3\CMS\Core\Utility\VersionNumberUtility` are unused and can be deprecated: - `splitVersionRange` - `raiseVersionNumber` - `convertIntegerToVersionNumber` Resolves: #88554 Releases: master Change-Id: I28378a39d7cae4d2ae09cfb6a85c5d294565a2f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60997 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- May 15, 2019
-
-
Benni Mack authored
This change removes the compatibility layer of Site Handling, called "PseudoSite" handling. Any TypoScript-related Language properties are removed. - config.sys_language_uid - config.sys_language_mode - config.sys_language_overlay - config.locale_all - config.language - config.typolinkEnableLinksAcrossDomains - typolink.useCacheHash The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_tstemplate.php']['linkData-PostProc'] is removed. In addition, all tests related to PseudoSite and linking without SiteHandling are removed, linking to pages without a site will not be linked anymore. Adding `useCacheHash` to typolink triggers a "this does not do anything anymore" deprecation message. Further related removals (old "pageNotFound" handling and "useCacheHash" in all viewhelpers), are removed separately. Resolves: #88363 Releases: master Change-Id: I14f2f854e69c98df7fab8b14f92f1ec2440a15a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59366 Tested-by:
-
- Mar 16, 2019
-
-
Benni Mack authored
It is safe to use idn_to_ascii() these days due to symfony's polyfill functionality. This allows us to remove the dependency "algo26-matthias/idna-convert". Also, all other places now use the native idn_to_ascii() call, which could speed up performance. The wrapper call GeneralUtility::idnaEncode() can then safely be deprecated. used composer command: composer remove algo26-matthias/idna-convert Resolves: #87894 Releases: master Change-Id: I85aa6f39b8ff5ac171cd73218ed1144a56d9f724 Reviewed-on: https://review.typo3.org/c/60234 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
- Feb 23, 2019
-
-
Alexander Schnitzler authored
Method \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility::hex2bin has been deprecated. As of PHP 5.4, a native function hex2bin exists, which should be used instead. Releases: master Resolves: #87613 Change-Id: I19cfade0584762148a611713412889bec4895200 Reviewed-on: https://review.typo3.org/c/59603 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Feb 05, 2019
-
-
Alexander Schnitzler authored
ObjectAccess had two kinds of runtime reflection calls: 1) To gather data about object properties and methods 2) To make non public properties accessible The first one is tackled by using class schema instances and by using the property accessor of symfony/property-access. The latter is tackled by deprecating all method arguments that trigger reflection to make properties accessible. In the future, gettable/settable properties need to be either public or have a getter (get*/has*/is*) or setter. Releases: master Resolves: #87332 Change-Id: I6ecef81de7aa4cc1244166d683874a1a87ac6bb7 Reviewed-on: https://review.typo3.org/59331 Reviewed-by:
André Schließer <andy.schliesser@gmail.com> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
- Feb 01, 2019
-
-
Alexander Schnitzler authored
The following methods used controller aliases: - \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin - \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule This means, that while configuring plugins or modules, a list of controllers (and their actions) had to be provided, so they could be registered as available controllers for said plugin or module. The controller name used for the registration, was kind of an alias for that controller. It was the class name without the namespace and without the "Controller" suffix. By a certain convention a proper class name could be derived from that alias. All this was necessary back then when TYPO3 didn't have a proper autoloader and when the class location was derived from the class name. These circumstances do not exist any more and since it's only important that a controller class exists, the registration of plugins must now use the fully qualified controller class name as array key. The former syntax \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin( 'TYPO3.CMS.IndexedSearch', 'Pi2', ['Search' => 'form,search,noTypoScript'], ['Search' => 'form,search'] ); has to be converted to \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin( 'IndexedSearch', 'Pi2', [ \TYPO3\CMS\IndexedSearch\Controller\SearchController::class => 'form,search,noTypoScript' ], [ \TYPO3\CMS\IndexedSearch\Controller\SearchController::class => 'form,search' ] ); Please note, that not only the controller configuration changed. The vendor `TYPO3.CMS` in `TYPO3.CMS.IndexedSearch`, must no longer be set. Instead, the vendor will be evaluated by looking at the controller namespace. Releases: master Resolves: #87550 Change-Id: If47d087836c4345a8180dae3d4e4b8cd384e684c Reviewed-on: https://review.typo3.org/59566 Tested-by:Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- Jan 04, 2019
-
-
Benni Mack authored
Various methods within ExtensionManagementUtility that was previously deprecated have been removed. Resolves: #87311 Releases: master Change-Id: I38e557f46492cc2b3c14f97882266efa673d7349 Reviewed-on: https://review.typo3.org/59311 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
-
- Dec 22, 2018
-
-
Benni Mack authored
Removes the legary sys_domain table and handling. Resolves: #87276 Releases: master Change-Id: If2a5eeb1ebcc113c8b00162f4c02ea3a58edcefe Reviewed-on: https://review.typo3.org/59233 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Alexander Schnitzler authored
* public static method in ActionController * public method in Argument * public method in Arguments * class AbstractValidatorTestcase * legacy location of settings.view.formatToPageTypeMapping Releases: master Resolves: #87268 Change-Id: Ieacc247e2ee85b088c01ae9d6d79691df319b333 Reviewed-on: https://review.typo3.org/59273 Reviewed-by:
-
- Dec 20, 2018
-
-
Benni Mack authored
The following code related to TSFE has been removed: PHP classes: * TYPO3\CMS\Core\PageTitle\AltPageTitleProvider * TYPO3\CMS\Frontend\Page\ExternalPageUrlHandler * TYPO3\CMS\Frontend\Page\PageGenerator * TYPO3\CMS\Frontend\Page\EidUtility PHP interfaces: * TYPO3\CMS\Frontend\Http\UrlHandlerInterface Methods that have been marked as protected * tempPageCacheContent() * realPageCacheContent() * setPageCacheContent() * clearPageCacheContent_pidList() * setSysLastChanged() * contentStrReplace() Dropped TSFE methods * mergingWithGetVars() * connectToDB() * initFEuser() * checkAlternativeIdMethods() * initializeBackendUser() * getPageShortcut() * pageUnavailableAndExit() * pageNotFoundAndExit() * checkPageUnavailableHandler() * pageUnavailableHandler() * pageNotFoundHandler() * pageErrorHandler() * makeCacheHash() * initTemplate() * handleDataSubmission() * initializeRedirectUrlHandlers() * redirectToExternalUrl() * checkPageForMountpointRedirect() * checkPageForShortcutRedirect() * redirectToCurrentPage() * processOutput() * sendCacheHeaders() * sendHttpHeadersDirectly() * storeSessionData() * previewInfo() * hook_eofe() * addTempContentHttpHeaders() * setCSS() * getUniqueId() * readLLfile() * getLLL() * initLLvars() * convPOSTCharset() * convertCharsetRecursivelyToUtf8() * domainNameMatchesCurrentRequest() * getDomainDataForPid() * getDomainNameForPid() Dropped TSFE properties * activeUrlHandlers * page_cache_reg1 * siteScript * loginUser * gr_list * beUserLogin * workspacePreview * ADMCMD_preview_BEUSER_uid * showHiddenPage * showHiddenRecords * debug * MP_defaults * sys_language_uid * sys_language_mode * sys_language_content * sys_language_contentOL * altPageTitle * lang TSFE Properties now marked as protected * loginAllowedInBranch * loginAllowedInBranch_mode * cacheTimeOutDefault * cacheContentFlag * cacheExpires * isClientCachable * no_cacheBeforePageGen * tempContent * pagesTSconfig * pageCacheTags * uniqueCounter * uniqueString * pageAccessFailureHistory TSFE Method Signature changes * calculateLinkVars now 1st parameter is required * preparePageContentGeneration now 1st parameter is required 4th Parameter of TSFE->__construct() now unused Removed TypoScript * config.typolinkCheckRootline * config.titleTagFunction * config.USERUID_substToken * config.USERNAME_substToken Hooks $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-PostProc'] Database fields: * index_phash.data_page_reg1 Resolves: #87235 Releases: master Change-Id: Id95bb0ccb30852fd115fb9da7754fa2e64374a41 Reviewed-on: https://review.typo3.org/59226 Tested-by:
-
Christian Kuhn authored
Resolves: #87234 Releases: master Change-Id: I07eb0387b8ad1921f715637a5a48581f3eaf9c42 Reviewed-on: https://review.typo3.org/59230 Tested-by:
-
- Dec 19, 2018
-
-
Benjamin Franzke authored
Remove code that is not needed due to the static bootstrap and PSR-15 refactoring during v9 phase. All deprecated methods and state is removed from the Bootstrap class, which includes the Bootstrap instance itself. Bootstrap is provided as statically invoked utility now. The Bootstrap instance was deprecated implictly due to the deprecation of getInstance() (combined with the protected constructor). We therefore remove the constructor and all (now unused) class properties and the method-chaining (which was only useful to reduce calls to the getInstance() method). Releases: master Resolves: #87202 Change-Id: Ie97e824294a03d8de88430772fdab4adaf7e3f1f Reviewed-on: https://review.typo3.org/59196 Tested-by:
-
Christian Kuhn authored
Removed classes: TYPO3\CMS\Core\Crypto\PasswordHashing\AbstractComposedSalt Removed interfaces: TYPO3\CMS\Core\Crypto\PasswordHashing\ComposedPasswordHashInterface TYPO3\CMS\Core\Crypto\PasswordHashing\ExtensionManagerConfigurationUtility TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordService TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordsUtility Removed class aliases: TYPO3\CMS\Saltedpasswords\Salt\AbstractSalt TYPO3\CMS\Saltedpasswords\Salt\AbstractComposedSalt TYPO3\CMS\Saltedpasswords\Salt\Argon2iSalt TYPO3\CMS\Saltedpasswords\Salt\BcryptSalt TYPO3\CMS\Saltedpasswords\Salt\BlowfishSalt TYPO3\CMS\Saltedpasswords\Salt\ComposedSaltInterface TYPO3\CMS\Saltedpasswords\Salt\Md5Salt TYPO3\CMS\Saltedpasswords\Salt\SaltFactory TYPO3\CMS\Saltedpasswords\Salt\SaltInterface TYPO3\CMS\Saltedpasswords\Salt\Pbkdf2Salt TYPO3\CMS\Saltedpasswords\Salt\PhpassSalt TYPO3\CMS\Saltedpasswords\SaltedPasswordsService TYPO3\CMS\Saltedpasswords\Utility\ExensionManagerConfigurationUtility TYPO3\CMS\Saltedpasswords\Utility\SaltedPasswordsUtility Removed methods: TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->getOptions() TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->setOptions() TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->getOptions() TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->setOptions() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMaxHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMinHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSaltLength() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSetting() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMaxHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMinHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSetting() TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSaltLength() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMaxHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMinHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSaltLength() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSetting() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMaxHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMinHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMaxHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMinHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSaltLength() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSetting() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMaxHashCount() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMinHashCount() Protected methods: TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->isValidSalt() TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->base64Encode() TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->isValidSalt() TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->base64Encode() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->isValidSalt() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Encode() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Decode() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->isValidSalt() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->base64Encode() Removed static methods: TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::determineSaltingHashingMethod() TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::getSaltingInstance() TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::setPreferredHashingMethod() Second method argument dropped: TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->getHashedPassword() TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getHashedPassword() TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashedPassword() TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashedPassword() Ignored options: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/saltedpasswords']['saltMethods'] Dropped constants: TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::ITOA64 TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::HASH_COUNT TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MAX_HASH_COUNT TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MIN_HASH_COUNT TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash::ITOA64 TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::ITOA64 TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::HASH_COUNT TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MAX_HASH_COUNT TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MIN_HASH_COUNT TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::ITOA64 TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::HASH_COUNT TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MAX_HASH_COUNT TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MIN_HASH_COUNT Removed language file aliases: EXT:saltedpasswords/Resources/Private/Language/locallang.xlf EXT:saltedpasswords/Resources/Private/Language/locallang_em.xlf Change-Id: Ia6a18209f104ca1abc6981508fb8b640ef2eb1a3 Resolves: #87203 Releases: master Reviewed-on: https://review.typo3.org/59197 Reviewed-by:
-
Christian Kuhn authored
Removes most deprecated code from BackendUtility, except a method that has bigger cross dependencies to other deprecated code. Removed methods: TYPO3\CMS\Backend\Utility\BackendUtility::deleteClause() TYPO3\CMS\Backend\Utility\BackendUtility::getOriginalTranslationTable() TYPO3\CMS\Backend\Utility\BackendUtility::getTCAtypes() TYPO3\CMS\Backend\Utility\BackendUtility::storeHash() TYPO3\CMS\Backend\Utility\BackendUtility::getHash() TYPO3\CMS\Backend\Utility\BackendUtility::getListGroupNames() TYPO3\CMS\Backend\Utility\BackendUtility::getModTSconfig() TYPO3\CMS\Backend\Utility\BackendUtility::unsetMenuItems() TYPO3\CMS\Backend\Utility\BackendUtility::getModuleUrl() TYPO3\CMS\Backend\Utility\BackendUtility::getPidForModTSconfig() TYPO3\CMS\Backend\Utility\BackendUtility::getDomainStartPage() TYPO3\CMS\Backend\Utility\BackendUtility::shortcutExists() Method signatures: TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfig() - Second and third argument dropped Other notes: Overriding page TSconfig on user TSconfig level with the 'mod.' prefix is dropped, used 'page.mod' instead. Resolves: #87206 Releases: master Change-Id: Ib4102bfc24a99a22891deb46d4b1bb227ffd3936 Reviewed-on: https://review.typo3.org/59203 Tested-by:
-
- Dec 18, 2018
-
-
Christian Kuhn authored
Resolves: #87205 Releases: master, 9.5 Change-Id: Idb22d2178bbd20982d4876b5dff45b06dea4100d Reviewed-on: https://review.typo3.org/59199 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Benni Mack authored
The following previously deprecated PHP classes are now removed: - TYPO3\CMS\Core\Encoder\JavaScriptEncoder - TYPO3\CMS\Core\Resources\Utility\BackendUtility - TYPO3\CMS\Core\Utility\ClientUtility - TYPO3\CMS\Core\Utility\PhpOptionsUtility Resolves: #87201 Releases: master Change-Id: I0b1896692ebf1f15948a9a3661fdc10ab6f019ff Reviewed-on: https://review.typo3.org/59195 Reviewed-by:
-
- Sep 27, 2018
-
-
Benni Mack authored
The functionality of _GETset() is really broken by design when thinking about having a non-global state. On top $TSFE->mergingWithGetVars(), which was mainly used in RealURL, is deprecated, as this needs to go within a PSR-15 middlware (I actually did that in a fork already for realurl v1). Resolves: #86389 Releases: master Change-Id: I7081ed48131237f9d1b0da6a4ddf252a34a02072 Reviewed-on: https://review.typo3.org/58344 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Sep 01, 2018
-
-
Anja authored
Change-Id: I95be0b5c33b9f028d28de7be64a7d18f9554ff78 Resolves: #86075 Releases: master Reviewed-on: https://review.typo3.org/58118 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Aug 23, 2018
-
-
Helmut Hummel authored
Deprecations that trigger an error in early bootstrap lead to the situation that code that is using this (mostly declared) internal API will likely fail due to these errors, as they are not caught by the regular error handling, which is initialized later on. Userland code using this API will notice the depreaction even without those errors triggered. Therefore remove those deprecations errors in most places again so that tools like TYPO3 Console will be able to stay compatible with older TYPO3 versions as well. Also protect some methods straight away and add a deprecation layer for them. Resolves: #85944 Releases: master Change-Id: I97485dfd947028cf02ff62b17b453d2f174a531a Reviewed-on: https://review.typo3.org/58003 Reviewed-by:
-
- Aug 18, 2018
-
-
Benni Mack authored
Core provides various places to either retrieve the pageId of a sys_domain record, or to find out the root page ID given a request (previously domain + path). However, due to the inclusion of symfony/routing, the detection can now be handled by this new component. For this purpose, a new class LegacyDomainResolver is introduced (internal) which utilizes symfony/routing under the hood and does proper caching. This way, the following methods can be deprecated: - TypoScriptFrontendController->domainNameMatchesCurrentRequest() - TypoScriptFrontendController->getDomainDataForPid() - BackendUtility::getDomainStartPage() - BackendUtility::firstDomainRecord() This is a precursor for fetching all sys_domain data, to minimize the efforts later-on to wrap the LegacyDomainResolver into a proper Router, and also to build pseudo-sites on top. Resolves: #85892 Releases: master Change-Id: I831d33ac06f090cbe4d2a16e592549739489f99a Reviewed-on: https://review.typo3.org/57949 Tested-by:
-
- Aug 17, 2018
-
-
Benni Mack authored
The static class PageGenerator is a list of static methods previouly found in "pagegen.php", which has now been moved within the RequestHandler which is now fully responsible for turning a request object with support from TSFE and PageRenderer into a response object. This removes one further dependency built around a legacy class and enjoys the concept that RequestHandler+TSFE now share the responsibility for building $TSFE->content. This also means that all tests can now be built without having to use any global variables or some special Singleton functionality but with a clean structure in mind. Resolves: #85884 Related: #85822 Releases: master Change-Id: I298795ea485f3c9850af23c0c5e69a3a6d43df99 Reviewed-on: https://review.typo3.org/57941 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
- Aug 16, 2018
-
-
Benni Mack authored
EidUtility is a poor-mans middleware functionality with lots of side-effects, and is marked as deprecated. On top, the following methods in TypoScriptFrontendController are deprecated: - initFEuser() - storeSessionData() - previewInfo() - hook_eofe() - addTempContentHttpHeaders() - sendCacheHeaders() Additionally, the PreviewInfo Hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_previewInfo'] is deprecated, as the eofe hook solves the same issues. Resolves: #85878 Releases: master Change-Id: I49cdb8c9c0b3cdf08fa90ce54cc5e570cfd13dce Reviewed-on: https://review.typo3.org/57876 Tested-by:
-
