- May 29, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #91535 Related: #91473 Change-Id: I98db08e8fef297b47bd11fed13d3fe91af3ba1cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64382 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Benni Mack authored
The global variable 'LOCAL_LANG' is now removed, as all labels should always be fetched via LanguageService. In addition, the following methods have been removed: * Locales::initialize() * LanguageService->getLabelsWithPrefix() The following public methods and properties have now changed their visibility to protected * LanguageService->LL_files_cache * LanguageService->LL_labels_cache * LanguageService->debugLL() * LanguageService->getLLL() The method LanguageService->includeLLFile() now only expects one argument Resolves: #91475 Related: #91473 Releases: master Change-Id: I617a2c11e5b1b052b5e0137e274d1f2aeb7b3b12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64595 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
The Permission handling within DataHandler has been migrated into PagePermissionAssembler in TYPO3 v10. All other previously deprecated code within DataHandler is also removed. The following previously deprecated code is now removed: * DataHandler->assemblePermissions() * DataHandler->setTSconfigPermissions() * DataHandler->process_uploads() * DataHandler->pMap * DataHandler->defaultPermissions Resolves: #91480 Releases: master Change-Id: Ia52dc8c2fa042458272b49608c5b318e19e73735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64599 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Alexander Schnitzler authored
The class AbstractController is removed in favor of ActionController within Extbase, where all extension controllers should inherit from. Releases: master Resolves: #91527 Related: #91473 Change-Id: Ia32630d04b545b24a18a4a999b1a28c6f2661504 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64377 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Alexander Schnitzler authored
The method is removed in favor of PHP's native hex2bin() function. Releases: master Resolves: #91529 Related: #91473 Change-Id: Ife685202e8210b3db872ff9989c5b94e351e29e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64378 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
Since TYPO3 v10 the god-object TSFE is now built with everything that is mandatory for rendering the Frontend: * Context * Site * SiteLanguage * PageArguments * FrontendUser The ultimate goal is to make TSFE be built without any global logic in the future, so it can be re-used and simulated in the backend as well, if needed. Also, the goal is to reduce the access to the global object, relying on other factors instead. Resolves: #91511 Related: #91473 Releases: master Change-Id: Ic237b43be1e98e18477f2de1d63cb80a1c2ab241 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64592 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benni Mack authored
The following deprecated methods are now removed: - \TYPO3\CMS\Core\Utility\GeneralUtility::compressIPv6 - \TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory - \TYPO3\CMS\Core\Utility\GeneralUtility::getApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::idnaEncode - \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Hex2Bin - \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Bin2Hex - \TYPO3\CMS\Core\Utility\GeneralUtility::isRunningOnCgiServerApi - \TYPO3\CMS\Core\Utility\GeneralUtility::linkThisUrl - \TYPO3\CMS\Core\Utility\GeneralUtility::milliseconds - \TYPO3\CMS\Core\Utility\GeneralUtility::presetApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::resetApplicationContext - \TYPO3\CMS\Core\Utility\GeneralUtility::verifyFilenameAgainstDenyPattern In addition, makeInstanceService requires the third parameter to be array instead of string or array. The method "getUrl()" now only accepts one argument. In addition, the testing framework is raised to 6.3.1 to not use the unneeded methods anymore. Resolves: #91513 Releases: master Change-Id: I124b6f531fed61a93f5ed03391e1d4b6cf7a08ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64593 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benni Mack authored
One of the marker-based legacy class DocumentTemplate is now removed for TYPO3 v11. In addition, some tests regarding the extension scanner now use a different class for testing purposes. Resolves: #91514 Releases: master Change-Id: Id2de0949032be6211f2d0f35bfb79c8fc893ad33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64594 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- May 28, 2020
-
-
Benni Mack authored
The following previously deprecate static methods are now removed: - TYPO3\CMS\Backend\Utility\BackendUtility::getRawPagesTSconfig() - TYPO3\CMS\Backend\Utility\BackendUtility::editOnClick() - TYPO3\CMS\Backend\Utility\BackendUtility::getViewDomain() - TYPO3\CMS\Backend\Utility\BackendUtility::getBackendScript() - TYPO3\CMS\Backend\Utility\BackendUtility::TYPO3_copyRightNotice() Resolves: #91481 Releases: master Change-Id: I8943f2e14ce1dbcb1195fffef5afe329b5f3ab79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64585 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- May 26, 2020
-
-
Benni Mack authored
This change removes the unneeded public constants - FILE_DENY_PATTERN_DEFAULT - PHP_EXTENSIONS_DEFAULT - TYPO3_copyright_year - TYPO3_URL_DONATE - TYPO3_URL_EXCEPTION - TYPO3_URL_GENERAL - TYPO3_URL_LICENSE - TYPO3_URL_WIKI_OPCODECACHE as well as the runtimeActivatedPackages feature, all of which have been marked as deprecated in TYPO3 v10. Resolves: #91477 Related: #91473 Releases: master Change-Id: I8e98509e2842d7fb116f44c31d4c10957b73a2ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64584 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change removes deprecated hooks and methods from TSFE related to output: * TSFE->isOutputting() * TSFE->processContentForOutput() * TSFE->settingLocale() * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_eofe'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['pageIndexing'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-contentStrReplace'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-output'] Resolves: #91476 Releases: master Change-Id: I2711924dce00ad2cd1ec9a236d8fde9da0105a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64583 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benni Mack authored
This change removes all triggers ("SlotReplacement classes") to Signals that were used until TYPO3 v10 LTS. The SignalSlot Dispatcher still stay for the time being, but it is unused in TYPO3 Core now. Resolves: #91474 Related: #91473 Releases: master Change-Id: I08867cb5837f605e52a067457a91f40288556fab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64578 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- May 13, 2020
-
-
Markus Klein authored
Some methods have been added for this matcher, which are actually not deprecated/removed as a whole. Only the usage of those methods has been adjusted. The extension scanner is not capable of detecting such usages only, hence there is no sense in reporting every usage of those functions, albeit these usages might be valid. The matcher entries are removed therefore. Resolves: #91355 Releases: master Change-Id: I9da87ecb320f65d4fe5df168d788bb2ba8547f84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64451 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- May 11, 2020
-
-
Benni Mack authored
The global object $GLOBALS[TYPO3_REQUEST] holding the current PSR-7 request object was introduced in TYPO3 v9.2. However, it was also marked as deprecated as we thought we were able to remove all usages again by the end of TYPO3 v9.5 development, which shows that we have more problems in various areas like hooks and Extbase where we heavily rely on this object. For this reason, it is kept but the original Feature RST still contains the information that it is considered bad practice. Removing the deprecation will result in better result for the ExtensionScanner. Resolves: #91347 Releases: master, 9.5 Change-Id: I97bb16cf7f4e7149c5c3a3528a015701f60c2628 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64439 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Apr 18, 2020
-
-
Anja Leichsenring authored
The changelog files for the version 10.4 must leave the master folder now and move to their final home in 10.4. Resolves: #91106 Releases: master Change-Id: Ia2a97ef805653c2179426da9c228b052b6801472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64226 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
Richard Haeser <richard@maxserv.com>
-
- Apr 16, 2020
-
-
Susanne Moog authored
The interfaces of the dashboard have been moved out of the interfaces folder to be consistent with the overall TYPO3 structure. Additionally, the superfluous button utility has been removed. Releases: master Resolves: #91066 Change-Id: Iaad0c1d8d046b467ee44d8cbbe32f8803c737fae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64201 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Richard Haeser <richard@maxserv.com>
-
- Apr 14, 2020
-
-
Benni Mack authored
The option to register packages during runtime was a work-around to dynamically modify the "extList". Using this feature has certain limitations: * Runtime-activated Extensions cannot add their DI configuration * Runtime-activated Extensions make every (!) single TYPO3 request much slower just like back in 6.2.0 times The usecases from people using this functionality was to enable e.g. extensions such as "devlog", "mask"/"mask_export" or "extensionbuilder" only on development systems. Nowadays, it is recommended - if this functionality is needed - to use TYPO3 Console and Composer Mode (with require-dev) to achieve a similar behaviour. This also ensures a clear state of available extensions, and to build a proper class map / autoloading mechansims of extensions in use. Runtime-activated extensions also prohibit to continue to work on a smoother integration between composer-mode and non-composer mode in the future. Resolves: #91030 Releases: master Change-Id: If4344cd081e8f60f30c9a0fb4d0cb9c308bbfb66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64166 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
PSR-15 and Request/Response handling has been proven to be a worthy replacement for most logic related for outputting content in the TYPO3 Frontend. In order to thin out TSFE in future TYPO3 versions, various hooks have been deprecated as they can also be used with proper PSR-15 middlewares. * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['pageIndexing'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['isOutputting'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-contentStrReplace'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['contentPostProc-output'] The following methods are marked as deprecated as well: * $TSFE->isOutputting() * $TSFE->processContentForOutput() Resolves: #91012 Releases: master Change-Id: I455f110f7f3e774de9d8ccd4adfcbd1ed5538cec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64118 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Apr 12, 2020
-
-
Benni Mack authored
Some methods in GeneralUtility nowadays are wrappers to native PHP methods. We encourage people to use the PHP API directly. * GeneralUtility::IPv6Hex2Bin() * GeneralUtility::IPv6Bin2Hex() * GeneralUtility::compressIPv6() * GeneralUtility::milliseconds() In addition, these methods are unused by Core * GeneralUtility::linkThisUrl() * GeneralUtility::flushDirectory() Reasoning: In order to make our code less coupled, TYPO3 Core should use native PHP where it makes sense, instead of relying on GeneralUtility in all places. Resolves: #91001 Releases: master Change-Id: I9e3a2f4a4bb42facad2d79f959b36482dba23ec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64091 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Daniel Siepmann authored
Provide concrete classes that will be instantiated multiple times with different options. E.g. provide an RssWidget implementation, that can be used multiple times with different rss feed urls. Split configuration for UI (title, icon, …) from concrete implementation. A new WidgetConfigurationInterface is in place and used. Resolves: #90660 Resolves: #90852 Releases: master Change-Id: I194615164b7d3d1cbd63751ddfd1f66f71db64cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63563 Tested-by:
Koen Wouters <koen.wouters@maxserv.com> Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Susanne Moog <look@susi.dev>
-
- Apr 08, 2020
-
-
Benni Mack authored
The master $GLOBALS[LANG] object should have a more streamlined API and some methods and public properties are now deprecated, in order to make this API much more stateless. Resolves: #90964 Releases: master Change-Id: I201cf1b7300e385e3b87ab282290aae8e27041da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64056 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- Apr 06, 2020
-
-
Benni Mack authored
In times of PSR-7, TYPO3's RequestFactory API and the underlying Guzzle HTTP library, the wrapper method GeneralUtility::getUrl() is merely a lazy short-hand method for fetching the contents. It is recommended to use TYPO3's RequestFactory API for fetching remote URLs. For now, however, the additional arguments (sending alternative headers, only fetching HEAD requests and return headers or headers + content, fetching a report of what happened) are deprecated, as they have proven to be inflexible nowadays. Resolves: #90956 Releases: master Change-Id: Ic7631ccf61000d0853007cf9278db6e1bab09335 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64012 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- Apr 04, 2020
-
-
Andreas Fernandez authored
The patch for #88720 added a new entry in MethodArgumentRequiredMatcher to cover changes in the class AspectFactory. The entry misses the affected method name which broke the extension scanner. This patch declares the missing affected method. Resolves: #90950 Related: #88720 Releases: master, 9.5 Change-Id: Id7df9b3f75eef0bb67781d0b67e68dad330da495 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64075 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
The following hooks within ContentObjectRenderer have been marked as deprecated: * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['cObjTypeAndClass'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['cObjTypeAndClassDefault'] Both concepts have been superseded in TYPO3 v6 with custom cObjects via $GLOBALS['TYPO3_CONF_VARS']['FE']['ContentObjects'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['extLinkATagParamsHandler'] * cObj->extLinkATagParams() is now also marked as internal, as it serves no purpose anymore once the hook gets removed. In addition * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['typolinkLinkHandler'] is deprecated since the initial addition of LinkHandler APIs in TYPO3 v8. Resolves: #90937 Releases: master Change-Id: Iaa1ea741f0bfef472f51a8067d5cea2f9ffcb774 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64055 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <look@susi.dev>
-
- Apr 02, 2020
-
-
Oliver Hader authored
When a slug is unique in site, we need to check whether the slug found in the database is part of the current site, otherwise it must be discarded. Resolves: #88720 Releases: master, 9.5 Change-Id: I469d7b853f75eec09463bb809b795c4732753cff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61585 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Mar 30, 2020
-
-
Benni Mack authored
The methods within ContentObjectRenderer are only needed for rendering an IMAGE <img> tag and are moved to the right place in order to make cObj less fat: - cImage() - getBorderAttr() - getImageTagTemplate() - getImageSourceCollection() - linkWrap() - getAltParam() "imageLinkWrap()" is marked as internal for the time being, in order to refactor this code in TYPO3 v11. Resolves: #90861 Releases: master Change-Id: I4c11a5b3df393dbe63ad7401869d0faaa61b2418 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63949 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Mar 23, 2020
-
-
Benni Mack authored
This change targets a couple of things: - The global constant "FILE_DENY_PATTERN_DEFAULT" is moved to a class constant - The global constant "PHP_EXTENSIONS_DEFAULT" which is not in use anymore, is removed. - The security aspect of checking against the fileDenyPattern is extracted into its own Class where - The fileDenyPattern can never be empty, but only be set via DefaultConfiguration. This makes it easier to test this functionality, a single object is taking over the responsibility, and the logic is now in one place. Also, the non-usage of the global constant makes life easier. Resolves: #90147 Releases: master Change-Id: I9db0d6fc3b10f75a3735017cb9ac0d9bfd4ff02b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62843 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Mar 21, 2020
-
-
Benni Mack authored
"GeneralUtility::isRunningOnCgiServerApi()" is now deprecated in favor of "Environment::isRunningOnCgiServer()". Resolves: #90800 Releases: master Change-Id: Ib9e9e38d0e53ca00f3c58eb3255943d57cf7c0e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63680 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Daniel Haupt <mail@danielhaupt.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Mar 13, 2020
-
-
Georg Ringer authored
The classes have been marked as internal and never contained any logic. Therefore and in order to streamline the codebase of Extbase, the files will be removed with TYPO3 11.0. Resolves: #90692 Releases: master Change-Id: I12398224f729672d6503285ba7d7e9dd10de1d18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63641 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Frank Nägler <frank.naegler@typo3.org>
-
- Mar 11, 2020
-
-
Oliver Hader authored
Handling constructor arguments in extension scanner did not work since constructors are not directly called like a method would be called. Constructors are invoked instead using the `new` statement. Besides that `GeneratorClassResolver` only supported string class names (like `'Example\\MyClass'`) when being invoked using `GeneralUtility::makeInstance`. Scanner configurations related to `__construct` invocation (in terms of creating a new class instance) are now handled in a dedicated new `ConstructorArgumentMatcher`. Besides that, `GeneratorClassResolver` now supports `GeneralUtility::makeInstance(Example\MyClass::class, 123)` as well. `NameResolver` and `GeneratorClassesResolver` are executed in two consecutive `NodeTraverser` instances - otherwise class names cannot be resolved in a reliable way. Resolves: #90722 Releases: master, 9.5 Change-Id: I0154b04674d2637fda817d39a1136c2c8fa389d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63676 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Mar 10, 2020
-
-
Georg Ringer authored
The Extbase model `FileMount` has never been used and there is also no need to have a model for every table. To streamline the codebase, the class has been marked as deprecated. Resolves: #90686 Releases: master Change-Id: I141a3171dd9f8c2b7d961541753653886f787d41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63639 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Mar 06, 2020
-
-
Benni Mack authored
Extbase's SignalSlot Dispatcher has had its good run - it served as a possible successor instead of Hooks but lacked a good standardized API for stopping propagation, and defining interfaces for slots. The new PSR-14 based event system has superseded SignalSlot logic from Extbase. Everybody is encouraged to not use Signal Slot logic anymore. TYPO3 Core does not use SignalSlots anymore, and the SignalSlot Dispatcher will be removed in TYPO3 v11.0 - and is therefore annotated as deprecated. Several advantages of PSR-14 over Signal Slot logic defined here again: - PSR-14 has a stoppable interface so event listeners can define that an event should not propagate anymore. - PSR-14 events are pure and plain PHP classes so it is VERY clear what can be read or modified. - TYPO3's implementation is fully compatible with other frameworks PSR-14 event-based system, so everything can be developed against the interface, not a concrete implementation (thanks to DI), and TYPO3 can exchange its own implementation against a different one. - All available listeners are registered during "DI-build-time" and not in ext-localconf.php anymore which can have an impact on performance. Please note that using SignalSlot Dispatcher will not trigger a deprecation warning as it is still used throughout many extensions. Resolves: #90625 Releases: master Change-Id: I09764b5056777fd3673a9e158762c9d5a9182997 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63099 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Susanne Moog <look@susi.dev>
-
- Feb 28, 2020
-
-
Jan Stockfisch authored
All felogin pibase hooks and classes are now deprecated. For each hook a replacement event is provided. Resolves: #88740 Releases: master Change-Id: I178f49d78c03a1fb9cd03990bebcbc1cf39b90d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62584 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Susanne Moog <look@susi.dev>
-
- Feb 25, 2020
-
-
Anja Leichsenring authored
The upcoming release of TYPO3 10.3 requires all documentation to be placed into the version folder. Resolves: #90510 Releases: master Change-Id: Ieccc5fa1c71a3f2d0513a4a1e6d2f053a0bb0c3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63393 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Feb 18, 2020
-
-
Benni Mack authored
Since TYPO3 v7, the new ModuleTemplate API is in place, which contains a fluid-based and fluent interface possibility to add DocHeader components and to render content. Resolves: #90421 Releases: master Change-Id: I5634ea0427486f37fbbfe3ee00695fc98e52d980 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63290 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Feb 14, 2020
-
-
Benjamin Franzke authored
Transform CommandRegistry into a symfony CommandLoader which allows console commands to be created on demand. That means commands are lazy loaded in order to avoid creating all commands with all their dependencies in every console invocation. Command will now be loaded when they are either executed or when command metadata is required (e.g. for the command listing) The `site:list` command is adapted to make use of dependency injection. Releases: master Resolves: #89139 Change-Id: I64256bf2dc21f0f3fe434aa5dff6176f0fe22233 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61630 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jan 31, 2020
-
-
Benni Mack authored
The RteHtmlParser has two public methods: ->init() ->RTE_transform() init() was introduced in early PHP4 times when there was no constructor in PHP. RTE_transform() contained a lot of parsing of properties, which is not needed anymore since TYPO3 v8. init() itself is not needed anymore. Since TYPO3 v8, RteHtmlParser is much cleaner towards the developer, and the last step for this PHP class is to clearly separate the logic for the transformations in each direction, making two new entrypoints: ->transformTextForRichTextEditor($content, $configuration) ->transformTextForPersistence($content, $configuration) This way, all logic is separated in these two methods, and the existing RTE_transform() method is just a shell, which is not needed anymore. Resolves: #90258 Releases: master Change-Id: Iba140d71c5cd954dab4cf1fe4bfaca2233527e50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63070 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jan 30, 2020
-
-
Benni Mack authored
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Jan 16, 2020
-
-
Susanne Moog authored
Preview functionality was only implemented in the Admin Panel. Previewing itself (as in being able to preview pages with access or user restrictions) should also work without having the admin panel installed and open. The basic process is now like this: - Backend generates preview URLs for pages with access restrictions -- starttime, endtime, fe groups --> parameters ADMCMD_simUser and ADMCMD_simTime are appended to the FE URL - Frontend PreviewSimulator Middleware uses these parameters to modify the current Context - Adminpanel - if installed and open - takes given parameters as settings for preview date/time/group - when user changes those, they are overwritten Technical Changes: - BackendUtility: Enable link generation for a specified context - DateTimeAspect: Add new property to aspect to mirror SIM_ACCESS_TIME global - PageRepository: Use new DateTimeAspect context property for enable fields - AdminPanel: Set $_GET params in settings if given, remove $_GET vars if user saves admin panel settings (to allow user to change date/time in AdminPanel) Resolves: #86653 Releases: master, 9.5 Change-Id: I3a2302845461e9c18f9349438e10f1c059a85e48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59927 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-