- Sep 24, 2021
-
-
Wouter Wolters authored
In some cases it can improve performance too. Resolves: #95210 Releases: master Change-Id: I4915bb1391ec99ff891248545080640965c8f62a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70204 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benjamin Franzke authored
Ensure `grunt build` generates a timestamp in Build/.cache/grunt-newer/terser/typescript/timestamp by using `newer:terser:typescript` instead of `terser:typescript`. This is for `grunt newer:terser:typescript` (as executed by `grunt scripts`) to able to pick this timestamp in subsequent builds to avoid re-tersing files that have already been tersed in a previous full-run (grunt build). Background: With the changes in #95016, `grunt terser:typescript` became a static task that executed terser for all typescript files in Build/JavaScript/. Prior to that change the list of files to be tersed was dynamically configured only for changed files in `grunt copy:ts_files`. Now, that means `grunt newer:copy:ts_files terser:typescript` was equal to `grunt newer:copy:ts_files newer:terser:typescript`. That changed with #95015 because `grunt build` creates a cache for incremental builds of tsc but not for newer:terser. Note: Using newer: during `grunt build` has no impact on which files are processed as `grunt build` cleans all cache files upfront and therefore `newer:terser:typescript` will terse all files in that context and only creates the timestamp additionally. Releases: master Resolves: #95341 Related: #95016 Change-Id: I90b74198f8982012935d86db94f8e1e71fedc548 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71226 Tested-by:
-
Guido Schmechel authored
When renaming pages, the pages in the automatic redirect are now saved with the TYPO3 protocol. Resolves: #89327 Releases: master, 10.4 Change-Id: I0207b4c4b81381f85b7522a130d17cbd20fe8b58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68202 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Benni Mack authored
A few methods within the *UserAuthentication have arguments deprecated. * AbstractUserAuthentication->writeUC() - first argument deprecated * AbstractUserAuthentication->unpack_uc() - first argument deprecated * BackendUserAuthentication->isInWebMount() - third argument deprecated * BackendUserAuthentication->backendCheckLogin() - first argument deprecated Resolves: #95320 Releases: master Change-Id: Idc62a78d9238a7837770531ad94dcf40988c9d93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71182 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benni Mack authored
The hook "$GLOBALS['TBE_MODULES_EXT']['xMOD_db_new_content_el']['addElClasses']" is now marked as deprecated, as the $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms']['db_new_content_el']['wizardItemsHook'] which has been in place for a long time should be used instead. Resolves: #95343 Releases: master Change-Id: I248671e4b897c087df81ff8b81b4239c525a510f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71218 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
This change moves code from PagePositionMap into the subclass ContentMovingPagePositionMap. This code is only used (showing colPos) when a content is placed / moved, and thus does not need to reside in the main class. Resolves: #95342 Releases: master Change-Id: I8ea0cedd01f585064576e2fbdd0fe80b40b2bb46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71227 Tested-by:
-
Oliver Bartsch authored
In order to allow conditional service registration based on ExtensionManagementUtility::isLoaded() checks in Services.php, the PackageManager is pushed to ExtensionManagementUtility before container creation. This has been the case prior to #91500 in order to support runtime activated packages, but got removed as isLoaded() checks in Services.php have never been an intended usecase. They have been documented in example code nonetheless and therefore usage is now fixed: https://docs.typo3.org/c/typo3/cms-dashboard/master/en-us/Configuration/WidgetRegistration.html#services-php-file Documentation should be adapted to recommend conditional services checks (ContainerBuilder::hasDefinition) instead. Once that is done, isLoaded() in Services.php can be marked as deprecated in future patches. Resolves: #95327 Related: #91500 Releases: master Signed-off-by:
Benjamin Franzke <bfr@qbus.de> Change-Id: Ifec470bd6364727ec0d9a5937106e6c94c0e18c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71214 Tested-by:
-
Jonas Eberle authored
With #94209 the ViewHelper be:moduleLayout was deprecated. That ViewHelper injected the used FlashMessageQueue into the created ModuleTemplate which took care of rendering messages. This is now just replaced by a very explicit <f:flashMessages /> in the templates. Resolves: #95334 Releases: master Change-Id: Ia45effdb7abfcbf491b98a28d91d332400ca28d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71222 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Oliver Hader authored
Previously, `fieldChangeFunc` items have been declared as string and were forwarded as plain inline JavaScript to the client application using HTML attrs `onchange` and `onclick`. This change introduces semantic objects for those `fieldChangeFunc` items that either can be used as structured configuration (JSON) or still "serialized" to inline JavaScript for legacy applications. New `OnFieldChangeInterface` provides a hybrid component that is backward compatible and still supports inline JavaScript as fallback. Using scalar (string) instructions for `fieldChangeFunc` will trigger PHP deprecation errors. Resolves: #91787 Releases: master Change-Id: I691ea8d12accfcf1568c34e178ce2087fd6ef609 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71072 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Oliver Bartsch authored
Resolves: #95335 Releases: master Change-Id: I5969032e5e8ec6b25cca87f098209bb458ab8e34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71220 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
Using Node 16 (will become LTS in Oct 2021) is only possible by updating node-sass 6. See https://github.com/sass/node-sass/issues/3077 and https://github.com/sass/node-sass/releases/tag/v6.0.0 Used command: * yarn add "node-sass@^6.0" --dev Resolves: #95340 Releases: master Change-Id: I686fab7247b17ad777d13381d4b76927554a5a13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71224 Tested-by:
-
Oliver Bartsch authored
In #95331 the legacy usage of the wizard as a full document has been removed. This patch removes some further leftovers. - Unused definition of docheader buttons is removed - Protected property $moduleTemplate is removed due to single usage - Protected property $menuItemView is removed due to single usage - Guard clause is added to prepareContent() Resolves: #95339 Related: #95331 Releases: master Change-Id: If022edf286ed8c0398a7434c1c87751dd4726b0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71225 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Sep 23, 2021
-
-
Benni Mack authored
Before TYPO3 v7 introduced modals, TYPO3's New Content Element Wizard could be opened within the list frame as a full document. The corresponding controller code has now been removed, along with some legacy functionality and inline JavaScript related to PagePositionMaps, which are used within the NewContentElementController, along with some legacy GeneralUtility::_GP() calls. In addition, the ContentCreationPagePositionMap does not inherit from PagePositionMap anymore, as it only had a minor overlap of functionality. Resolves: #95331 Releases: master Change-Id: If87e4743c05aaab0550cc6939310ebed9d095813 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71219 Tested-by:
-
Benni Mack authored
This change cleans up the NewRecordController which hasn't been touched since ages. It cleans up the render-related functionality into a Fluid Template. Within Fluid, Bootstrap 5 styling is now applied properly. Resolves: #95332 Releases: master Change-Id: Ic6a2e8967cfe8ee7ee0876300244e8bce9ca5c57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71216 Tested-by:
-
Oliver Bartsch authored
The file listing in the link browser is using bootstraps' "List group" component. In case a list group item is active, it receives "z-index: 2", to slightly overlay the neighbor items. To avoid conflicts with element browser components, which also use "z-index: 2", this patch increases the z-index of those components to "3". Resolves: #95323 Releases: master Change-Id: Ibd18992797cc8500518f589d4bebed9640b318f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71217 Tested-by:
-
Benni Mack authored
Due to some setups within e.g. shortcut elements did not have a proper information anymore when used in language mode and mixed setups. Resolves: #95324 Related: #95302 Releases: master Change-Id: Ic2022ab113c2ec0f75fb05d5c1a34be39387ec87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71212 Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
-
Peter Kraume authored
Resolves: #95329 Releases: master Change-Id: I680b667971b09ce71f304f1a8180dfd1ab80d519 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71215 Tested-by:
-
Wouter Wolters authored
Replace static:: with self:: in final classes. Resolves: #95319 Releases: master Change-Id: If375daf637c31f94c86f24d9189e85f8bae32581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71190 Tested-by:
-
Benni Mack authored
There was a time when new code for TYPO3 Core was introduced by using "MyClass::getInstance()" to act as a factory for this class, which _would_ be OK if these classes are actually prototypes and not services (or singleton services), as GeneralUtility::makeInstance() or DI via Services.yaml works as well. This change deprecates all getInstance methods around such code with GeneralUtility::makeInstance() calls. At a later point, proper DI can be introduced in these cases. * TYPO3\CMS\Core\Resource\Index\ExtractorRegistry::getInstance() * TYPO3\CMS\Core\Resource\Index\FileIndexRepository::getInstance() * TYPO3\CMS\Core\Resource\Index\MetaDataRepository::getInstance() * TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\OnlineMediaHelperRegistry::getInstance() * TYPO3\CMS\Core\Resource\Rendering\RendererRegistry::getInstance() * TYPO3\CMS\Core\Resource\TextExtraction\TextExtractorRegistry::getInstance() * TYPO3\CMS\Form\Service\TranslationService::getInstance() * TYPO3\CMS\T3editor\Registry\AddonRegistry::getInstance() * TYPO3\CMS\T3editor\Registry\ModeRegistry::getInstance() Resolves: #95326 Releases: master Change-Id: Ie3160c67792e115cf5488dc800bd717c0b913ab9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71178 Tested-by:
-
Benni Mack authored
The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/browse_links.php']['browserRendering'] is deprecated in favor of the ElementBrowser API implemented in TYPO3 v7.6 via https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/7.6/Feature-66369-AddedLinkBrowserAPIs.html Also, calling "wizard_element_browser" with mode=wizard or "mode=rte" is deprecated, instead extensions should link to "wizard_link", which also exists since TYPO3 v8. Resolves: #95322 Releases: master Change-Id: I4ad30fa0b0c0684767e1060d99cebc11b7db9710 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71180 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Oliver Bartsch authored
Revert a style change, added in #95325, which led to disabled checkboxes are being shown, while only their label should be visible. Those checkbox classes hide the actual checkbox, while the label acts as one. This allows extended styling, e.g. "icon checkboxes" or "toggle checkboxes". Instead add the disabled style to the correct checkbox component, which is acutally using the checkbox element and no label. Resolves: #95325 Releases: master Change-Id: I0842c184e629a3c4327c18db92affde58c32924d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71213 Tested-by:
-
- Sep 22, 2021
-
-
Robert Kärner authored
On PHP 8.0, renaming a folder in the backend might fail with a "PHP Warning: Uninitialized string offset 0". This is fixed by utilizing the substr() function instead. Resolves: #95273 Releases: master Change-Id: Ib642a25492c933b6fae857206c4535b7a861cc3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71123 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Simon Gilli authored
The import was removed shortly before https://review.typo3.org/c/Packages/TYPO3.CMS/+/71032 was merged so it's added again. Resolves: #95321 Related: #95189 Related: #95190 Releases: master Change-Id: If44ba57ab6a390fac07c1ee12bbd8f36d2e7539f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71191 Tested-by:
-
Stefan Bürk authored
Core has been working with id and type as query parameter to display FE pages and switch between defined TypoScript page definitions. Speaking url has been integrated for v9 through the new routing feature to do it in a more determistic way as in comparision to ext:realurl. As there might be instances using id/type query parameters for ajax call switches (and eventelly for eid scrips) in the frontend, normalization has been implemented to keep this option alive (#88028). Recently there has been a try to fix a bug for so some use cases, which broke this support (#94537). For future it should be considered if it is possible to drop this option in the future to free id/type query arguments for instances in the frontend. There a several issues in this area, for example broken subfolder installation support and id/type query parameter on a full speaking url overrule it with selected id, which is not expected. To validate that the test fails if support is broken change in PageRouter following line (150): $urlPath = str_replace($scriptName, '', $urlPath); to $urlPath = str_replace( '/' . $scriptName, '', $urlPath); Build/Scripts/runTests.sh -s functional \ typo3/sysext/frontend/Tests/Functional/SiteHandling/\ SiteRequestTest.php This patch acts as pre-patche to fix these. Resolves: #95096 Related: #95096 Releases: master, 10.4 Change-Id: Iff97f04d7bf7e7b2462425d830e0451a8d7a8686 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70880 Tested-by: -
Christoph Schwob authored
Replace '.input-group-addon' with '.input-group-text' Resolves: #95148 Releases: master Change-Id: I3d855d93da79e8edd39d77ead46fe4637639decd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70966 Tested-by:
Dennis Prinse <dennis.prinse@maxserv.com> Tested-by:
-
Simon Gilli authored
With the change #82000 the DistributionWelcome image was removed by accident. This patch adds the image again with a proper fallback to the Distribution image. Resolves: #95313 Releases: master Change-Id: I1bfb281af43e80fa83c72e43aff95dc35fb56f7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71187 Tested-by:
-
Benni Mack authored
To further improve the recordlist UI, the "Localize to" column is not longer shown, in case there are no more records to localize. Resolves: #94794 Releases: master Change-Id: Ib08508a25a6eac677d92b3b4f539d7ee4e84c1c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70403 Tested-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
-
Benni Mack authored
With TYPO3 v7.6 the internal DataHandler command to "inlineLocalizeSynchronize" was migrated to an array-based syntax, and TYPO3 Core uses this ever since. With TYPO3 v11 it is time to deprecate the old behavior. Resolves: #95317 Releases: master Change-Id: I325f54d3cf3ab318a7528a393bf0d848e8b5e3b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71184 Tested-by:
-
Benni Mack authored
Various methods within TypoScripFrontendController are now "protected" as they are marked as internal. Resolves: #95315 Releases: master Change-Id: Iae9691457b250305c617b11fa5f558ac4e55c2b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71179 Tested-by:
-
Oliver Bartsch authored
In case a site in the TYPO3 page tree only features the default language, the module menu of the page module does no longer add "All languages" as option, since this led to misbehaviour, e.g. empty views in some cases. Resolves: #95308 Releases: master Change-Id: I54f72c99ff5c8511fd119e024493153408be33c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71173 Tested-by:
-
Sybille Peters authored
A new function StringUtility::multibyteStringPad() is introduced to handle multibyte strings instead of str_pad() which will not pad strings with multibyte characters correctly. The new function is now used for: - Fluid ViewHelper format.padding - TypoScript stdWrap.strPad Resolves: #95189 Resolves: #95190 Releases: master Change-Id: I4b8bf4b42e049b17754b260003ac064fbbb6246a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71032 Tested-by:
-
Benni Mack authored
The parseFunc.sword functionality wraps HTML (usually a span tag) around RTE-based content if: * GET parameter ?sword[]=search-word is set * no_cache=1 is set via GET parameter or TypoScript This feature only works in non-cached environments due to the actual problem that the search term should never be cached. This happens if a result page in indexed search is clicked, which then receives a no_cache=1 argument. This feature is highly discouraged due to the possible server load that is created, and thus removed. The existing solution is far from optimal and should rather be handled in third-party extensions (such as EXT:solr does it via a HighlightViewHelper). Resolves: #95318 Releases: master Change-Id: If74247bad14a87c55d092322f0a609c3663f2e67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71176 Reviewed-by:
-
Alexander Opitz authored
In web_layout we show for every language the content if defLangBinding is set. Resolves: #94568 Releases: master, 10.4 Change-Id: Ic48f141ac45e2d2e32b3e2d53b70c4e156dfc551 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71073 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Eric Chavaillaz <eric.chavaillaz@gmail.com> Tested-by:
-
Oliver Bartsch authored
With #93526, multi-factor authentication was introduced to TYPO3. This came with several configuration options, such as the possibility to require MFA for specific users and user groups. Previously, the only result of this option was a warning, displayed in the MFA configuration module. Obviously, this did not really help administrators, trying to enforce MFA in their system. Therefore, this patch adds the missing endpoint, which is automatically called for all users, required to set up MFA, as soon as they have successfully passed the first authentication step (e.g. username + password). While it's a new endpoint, the actions still call the MFA providers the same way, the MFA configuration module does. Therefore, no changes to the API. Resolves: #95287 Releases: master Change-Id: Ib82ae53cbd5bd0782418d81d166c1f3d7e9a7ab1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71132 Tested-by:
-
Oliver Bartsch authored
A couple of patches changed the amount of columns, shown in the filelist module listing. For example, since column selector component. Also multi record selection, introduced in #94906, adds an additional column, providing the checkbox. This patch therefore adjusts the DragUploader component to take this into account while dynamically adding rows for uploaded files. Resolves: #95300 Related: #84184 Related: #94906 Releases: master Change-Id: I0fcadc1c38da94a3365f6524c5407fe487fc4e21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71166 Tested-by:
-
Christian Kuhn authored
Ever wondered the icons of the main core extensions that use the TYPO3 logo all look subtly different, for instance in EM? The patch aligns them to the 'white logo with orange background' svg version. Resolves: #95310 Releases: master Change-Id: Ifd04c8bbe03e7988c44b0db34a15aa0a11b31eb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71175 Tested-by:
-
Benni Mack authored
ext_localconf.php still references "localconf.php" even though it is called "LocalConfiguration.php" since TYPO3 v6.0. Resolves: #95314 Releases: master, 10.4 Change-Id: Idd8f85bbc9351959b0be35e353f8237cf33b54e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71183 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benjamin Franzke authored
This change allows module URLs to be automatically framed by the TYPO3 main controller whenever they are directly opened in the browser address bar in a secure environment (e.g. https:// or .localhost TLD) (In this case the Sec-Fetch-Dest=document is sent by browsers). See: https://w3c.github.io/webappsec-fetch-metadata/#sec-fetch-dest-header Note: This header is already supported by Chrome, Edge and Firefox nightly, only Safari does not deliver this header yet. Non supporting browsers or unsafe http connections will gracefully fallback to showing the module contents without the TYPO3 main frame being added. This fallback behaviour is only triggered when a link is opened in a new tab. Regular clicks are intercepted and directly dispatched via module-router/iframe, as before. This change allows to render the module menu with anchor tags instead of buttons which lets users decide how and where a module should be opened. Long term goal is to improve accessibility by using real links not only in module menu (as we had in TYPO3 v7), but actually everywhere (for example in the database record list), in order for the user to decide whether to open a link in the current or a new tab. This will require enhancing FormEngine routes with module information and is therefore out of scope for this change. Resolves: #94084 Releases: master Change-Id: Iaad8fe62644ec6c9cb1aaa4c92ce2e8e3eeab7bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69058 Tested-by:
-
Benni Mack authored
Resolves: #95299 Releases: master Change-Id: I4882a9ca07948718afdeb1a5fb5b3a518eb86c38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71163 Tested-by:
-
