- Feb 27, 2020
-
-
Andreas Fernandez authored
The dependencies of the dashboard are now properly imported to fix loading issues. Resolves: #90546 Releases: master Change-Id: I9f86e9e9dc87082269cda777b373bc02df414153 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63472 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Franz Holzinger authored
Releases: master, 9.5 Resolves: #90552 Change-Id: Iece6f3a354419b6b48c704394d45ea94f4bf45d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63450 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
To make examples more clear more meaningful terms are now used. Resolves: #90550 Releases: master, 9.5 Change-Id: Iee68811177fdee85b0f89f5ce120b217222039f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63445 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Alexander Schnitzler authored
This is a followup patch for the introduction of Argon2id. https://review.typo3.org/c/Packages/TYPO3.CMS/+/63077 That commit introduced access to class constants that are only available through late static binding. This approach does not follow a contract and uses a bit of a magical approach instead. It's hard to read for the user, cannot be type checked and it is possibly unstable and may produce unforeseen issues when inheriting AbstractArgon2PasswordHash without defining said class constants. To have a clean architecture with a contract driven approach an interface is introduced which child classes of AbstractArgon2PasswordHash have to implement. This ensures that the algorithm in AbstractArgon2PasswordHash can reliably fetch necessary information from the child classes. Releases: master Resolves: #90508 Change-Id: I950da09762bcc859b5c03ad8ffeeefe46af2ed02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63391 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Susanne Moog <look@susi.dev>
-
Alexander Schnitzler authored
Passing a non object variable or non null value as third argument "$ref" into method GeneralUtility::callUserFunction has been deprecated. As of TYPO3 version 11.0 said method argument must be either null or of type object. Releases: master Resolves: #90377 Change-Id: I83d75c1c78d1d41d94b6e497b04644e704b902db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63075 Tested-by:
-
Manuel Munz authored
When 'Index Records immediately when saved?' is enabled in indexing configurations for records, then on saving the record the string 'null' is used for this indexingconfiguration and passed to SearchController::preparePageLink(), which expects an array and therefore throws an exception. This commit fixes this by checking if $this->conf['staticPageArguments'] is an array and only then json_decode that, else it sets the value to null. Resolves: #89816 Related: #86994 Releases: master, 9.5 Change-Id: I96d3fb963ecb508bc536967afece064ad12bb989 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63414 Tested-by:
-
Cypelt authored
make annotation comment of the isValid method from UrlValidator more clear Releases: master Resolves: #90549 Change-Id: I119ca5d586cff037d905e26189a460585d7e4725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63444 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Georg Ringer authored
Remove the outdated note about using in unit tests only and set the method to internal as it used by the core but shouldn't be any public API. Resolves: #90516 Releases: master. 9.5 Change-Id: I422e3982844b06d34fbb66ab77b26ace48fd537b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63442 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Georg Ringer authored
Once upon a time there was a doktype 5 for "not in menu" pages which has been moved to a checkbox since a long time. The outdated information can be removed. Resolves: #90472 Releases: master Change-Id: I8755a69cad778afe25527e90521963b5cb87de68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63441 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Feb 26, 2020
-
-
Florian Schuhmann authored
The existing ProcessedFiles identifier check must be adjusted, since the default value is an empty string for entries that uses the original file. Resolves: #89716 Releases: master, 9.5 Change-Id: Iea68cfbc02da0872b14a5645d3a0d4d60263738c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62538 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Helmut Hummel authored
AssetCollector is a singleton, but of course does not survive requests. Since uncached plugins should be able to access asset state from cached TypoScript or other uncached plugins, we must make sure this state is serialized in the cache (PageRenderer is serialized) and restored from cache. Releases: master Resolves: #90537 Change-Id: I6f954aecf0d83e0e81fca45167cdb31734af9e81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63433 Tested-by:
-
Oliver Bartsch authored
The two new ViewHelpers `CssViewHelper` and `ScriptViewHelper` automatically render the content of their body if no source file is supplied in the ViewHelpers argument. However if the body is empty, NULL is passed to the AssetCollectors add inline code functions. This leads to a TypeError as these parameters are type hinted. Therefore the body content is now checked before the methods get called to prevent passing NULL or an empty string. Resolves: #90539 Releases: master Change-Id: I80feb9551f50e6ab8ac56740b605c4bbbfbe3069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63437 Tested-by:
Jens Ulrich <jens.ulrich@snk.de> Tested-by:
-
Andreas Fernandez authored
The postMessage sent to IRRE when uploading a file via drag & drop missed the actionName, which resulted in ignoring the message. The actionName is now used and also streamlined to match the actual behavior. Resolves: #90534 Releases: master Change-Id: Ic56059762a6822e27ac64ea6fc07b5d37fc34c9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63434 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
-
Susanne Moog authored
Releases: master Resolves: #90538 Change-Id: I51038d26371577ee3795b9774814766f39f9cc1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63436 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
- Feb 25, 2020
-
-
c.essl authored
This patch adds $TSkey labels to a few calls to cObjGetSingle() to improve the debugging experience with the TS tree in the AdminPanel and to avoid nondescriptive "__" strings as labels. It also improves the profiler output for cObjectViewHelper Resolves: #64906 Releases: master, 9.5 Change-Id: Iaf500390f0c6e329e15b2ff6677e8c3ebb54df5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60820 Tested-by:
-
Oliver Hader authored
Change-Id: I0bdeb9a461dd2a6e5378075425412667f6126523 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63413 Tested-by:
-
Oliver Hader authored
Change-Id: I46bd52fe097a1c9d212bc4b23951efbb1cee18d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63412 Tested-by:
-
Daniel Siepmann authored
The existing behaviour was changed when introducing the AssetCollector. The existing variable $imagesOnPage was overwritten with all information from collected media. Originally only specific information were added. Providing all information lead to closures ending up in serialization of information during storing in cache. This patch reverts back to original behaviour, only necessary information are added. Relates: #90522 Releases: master Change-Id: I22a34ad333d966c032386cc983a5f3205ba3ffe3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63411 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benjamin Kott authored
Widget footer is now only rendered if the optional footer section for widgets is used and contains content. In addition, minor styling issues were resolved. Templates were cleaned up again. Some extra conditions were added to prevent empty tags. Resolves: #90530 Releases: master Change-Id: Idb4a6858395622a62448041fec3d510bec6fb271 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63410 Tested-by:
-
Anja Leichsenring authored
The upcoming release of TYPO3 10.3 requires all documentation to be placed into the version folder. Resolves: #90510 Releases: master Change-Id: Ieccc5fa1c71a3f2d0513a4a1e6d2f053a0bb0c3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63393 Tested-by:
-
Georg Ringer authored
With #78450 the StandardContentPreviewRenderer creates an instance of the `PageLayoutView` to keep the existing hooks alive. However 2 more properties need to be filled to improve the compatibility. Resolves: #90528 Releases: master Change-Id: I0c56988bdc9d524f1cfa411ae0c62d00ad1789dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63408 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
ochorocho authored
Add example for elements of type RadioButton/MultiCheckbox. Releases: master, 9.5 Resolves: #90520 Change-Id: Ifaeac0d2e3ef017aeb717aa52bc7c763ba16e8ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63409 Tested-by:
-
Oliver Bartsch authored
Before the final release of the dashboard some clean up is done. Among others following tasks are performed: * Add missing PHPDocs * Remove unused methods * Remove superfluous properties * Unify namespace format * Fix some typos * Fix some formatting * Make closures static * NoDashboardAvailableException is removed as it is never be thrown * Extend documentation for missing widget groups Resolves: #90524 Releases: master Change-Id: Ia0f7d71def358bf0ee8ab42d97f012c14cdede1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63407 Tested-by:
-
Claus Due authored
This introduces a new approach to registering and rendering previews; for content elements initially but possible to apply to any record type, and possible to call from other contexts than the PageLayoutView, e.g. AJAX-based preview rendering. Basically, this turns the old hook approach into a proper pattern where preview renderers are registered for a specific CType and must implement proper interfaces. A Resolver pattern is also introduced with a standard implementation and a standard renderer is registered for backwards compatibility. Resolves: #78450 Releases: master Change-Id: Ibf85d9b50b7bc6506d72c1ee63078373eaf9e433 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/50389 Tested-by:
-
Benni Mack authored
AssetCollector is a concept to allow custom CSS/JS code, inline or external, to be added multiple times in e.g. a Fluid template (via <f:script> or <f:css> ViewHelpers) and only be added once. It considers best practices by having a "priority" flag to be either be moved in the <head> area (for CSS useful in above-the-fold concepts) or at the bottom of the <body> tag contents. AssetCollector helps to work with content elements as components, reducing effectively the amount of CSS to be loaded and also incorporates the HTTP/2 power where it is not relevant to have all files compressed and concatenated in one file (although this could be added later-on). AssetCollector is implemented as singleton and should slowly replace the various existing options in TypoScript which seem to be confusing. AssetCollector also collects information about "imagesOnPage" effectively taking off pressure from PageRenderer and TSFE to store common data in FE - as this is now handled in AssetCollector, which can be used in cached and non-cached components. Resolves: #90522 Releases: master Change-Id: I6ce8141ad8891a7a8ee6d4f8a7377d93a894c3b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63327 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Daniel Gohlke <daniel.gohlke@extco.de> Tested-by:
-
- Feb 24, 2020
-
-
Daniel Gohlke authored
The resolveControllerAliasFromControllerClassName returns an alias respecting subfolders in controller namespace to avoid same aliases for different controllers and to load the templates from corresponding directories. Resolves: #90480 Releases: master Change-Id: I3ed691e126579a4cfcc35f9589beb017b06a2f82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63361 Tested-by:
-
Oliver Bartsch authored
A new widget is added which displays a list of security advisories from the typo3.org RSS feed. Resolves: #90512 Releases: master Change-Id: Ie01eb859c8f434efea7383e43134aafa251fdc10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63397 Tested-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Stefan Froemken authored
- Add possibility to use records of sys_file_reference - Add possibility to resize images - Add possibility to apply cropVariants Resolves: #90068 Releases: master Change-Id: Ib80021dc25b42e7021cf5429b2df8029aac1fd8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Susanne Moog authored
This reverts commit a848ba4f. While the feature works well on fully configured sites, in case of errors this is currently too unstable and may result in infinite recursions when a page is not configured (for example if no TS Template is present). When reimplementing we should add more tests and recursion prevention in order to stabilize the behaviour. Change-Id: I9f6f5155a78e7d515107f8b6b8d16dc55b78b7dd Resolves: #90523 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63308 Tested-by:
-
Georg Ringer authored
GeneralUtility::validEmail uses now Egulias\EmailValidator instead of the method `filter_var` for validating an email address. This allows more email addresses to be valid. Resolves: #90370 Releases: master Change-Id: I29bf4c994d730c789828cdecc247080dd669d9fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63235 Tested-by:
-
Sybille Peters authored
Linkvalidator should show broken links only in the list of broken links, if current backend user has edit access to the field. This way the editor will no longer get an error message on trying to edit records he has no permission to edit. Whether the editor has access depends on a number of factors. We check the following: * The current permissions of the page. For editing the page, the editor must have Permission::PAGE_EDIT, for editing content Permission::CONTENT_EDIT must be available * The user has write access to the table. We check if the table is in 'tables_modify' for the group(s) * The user has write access to the field. We check if the field is an exclude field. If yes, it must be included in 'non_exclude_fields' for the group(s). * The user has write permission for the language of the record * For all tables with type fields: The type is in list of explicitly allowed values for authMode (or not explicitly denied depending on the setting). Resolves: #84214 Releases: master Change-Id: Iade53d0452e0a5dec98e9d5b7b149d137f170949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61786 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Claus Due authored
Fixes a couple of issues: * Missing button text for "new content" button * Two cases of access to undefined variables * Add missing f:format.raw in record footer * Add missing paste-after icon Resolves: #90506 Releases: master Change-Id: I9facb46ecaf6dfb7ebc76a2733a4a8c6e2cb3c93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63390 Tested-by:
-
Oliver Bartsch authored
A new widget is added which displays the number of failed logins during the last 24 hours. Resolves: #90355 Releases: master Change-Id: I24e9e40fd7ed567f97867910d6988d8662fd7a14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63364 Tested-by:
Koen Wouters <koen.wouters@maxserv.com> Tested-by:
-
Daniel Siepmann authored
Include current day when collecting data and labels for sys log widget. Resolves: #90517 Releases: master Change-Id: Idc65d03df0e6d115450cc080c479b52759636123 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63400 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Daniel Siepmann authored
sqlite3 doesn't return casted values right now, everything is a string. Some methods require integers, e.g. uid of a record. In order to prevent TypeError due to mismatch, values are casted to integer. Resolves: #90515 Releases: master Change-Id: Ibb1654a412f94b5bd511dac5bed75a1af0683fe9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63399 Reviewed-by:
-
Christian Eßl authored
The PageContentErrorHandler provided by the core can take in either a URL or a page uid for resolving an error page in the frontend. In both cases, the class would then start a Guzzle/cURL request to fetch the error page content. This has now been changed for internal pages, where a page uid has been given. In this case, the PageContentErrorHandler will now dispatch an internal SubRequest instead, to avoid an unnecessary cURL call. In staging environments, the website would often be access protected with basic auth options (for example a .htpasswd auth file on Apache Webservers). In such a case, error pages with the default PageContentErrorHandler would have failed before, as the internal cURL call for fetching the error page was lacking these required basic auth options. For internal pages, a sub request is now used, bypassing the need for an external cURL call. This solution is mostly based on Benni Mack's LocalPageContentErrorHandler with his approval. Resolves: #90505 Releases: master Change-Id: I9da835cd42503d7a52f9050ae5658eae53336a56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63389 Reviewed-by:
-
Oliver Bartsch authored
All widgets should be registered the same way to increase consistency in the core file. The second registration variant is documented in the corresponding rst file anyway. Resolves: #90502 Releases: master Change-Id: I3e12890cecb130f4ea6815e01501691c5081735b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63387 Tested-by:
-
- Feb 23, 2020
-
-
Christian Eßl authored
In the new fluidbased page module view, if a previously configured BackendLayout has been removed. (For instance, the extension providing it has been removed), the module would throw an uncaught error, because the script would try to call a method on a non-existing BackendLayout. This patch fixes this problem by automatically falling back to the "default" BackendLayout, if the requested one couldn't be provided. This is the same way as the old PageLayoutView would have reacted to this problem. Resolves: #90479 Releases: master Change-Id: I76127e9b53bcb0ac55875857ca11262a323c6013 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63370 Tested-by:
-
Daniel Siepmann authored
Prior only an warning was logged, and a fallback rendering jumped in. With this change an error is rendered in addition to logging. No fallback will be triggered anymore. This should raise awareness and ease integration for integrators. Please note that already broken elements might now show an error instead of fallback preview. This is only activated for admin users and enabled BE|debug system setting. Resolves: #90427 Releases: master Change-Id: I1f24a1e775ba4f12917ed26dc29b0ea78ab81a1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63318 Reviewed-by:
Ingo Fabbri <ingo.fabbri@gmail.com> Reviewed-by:
-
Christian Eßl authored
The changes made to the ElementInformationController in #88901 had a few problems and regressions: - A lot of information for files and folders, that has previously been shown, was now missing. - Metadata for files was missing as well, because this information is saved in a separate table. (sys_file_metadata) This patch brings back all the lost information. Also, the Metadata of a file can now be viewed in the ElementInformation window as well. Resolves: #90441 Related: #88901 Releases: master Change-Id: Idb710c83b74845e6ec8b6e2dc7c3d906841ea6ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63332 Tested-by:
-
