- Oct 17, 2017
-
-
Benni Mack authored
TYPO3 Core does not use isAdmin() API of BackendUsers consistently, as there are some places where a direct access to $BE_USER->[admin]. Resolves: #82783 Releases: master Change-Id: I5ae42a79826a3512be8755aabb32b910f4f6c826 Reviewed-on: https://review.typo3.org/54414 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Tymoteusz Motylewski authored
Move calls to addInlineSettings out of the foreach loop, and place them together with other similar calls. Resolves: #82781 Releases: master Change-Id: Ia2269833f7649559a1552a9290773984bebcc102 Reviewed-on: https://review.typo3.org/54413 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Oct 16, 2017
-
-
Benni Mack authored
TSFE does the same logic as $GLOBALS['LANG'] (= LanguageService) for fetching labels and language files, but with a different language key. However, LanguageService is not a singleton, so it _can_ be used multiple times at the same request, so why not use the LanguageService for labels based on config.sys_language, and the $GLOBALS['LANG'] record based on the current backend user. So, TSFE only acts as a wrapper for LanguageService instead of having duplicate code. A few now useless internal properties are dropped, some other methods are deprecated: - TSFE->LL_files_cache - TSFE->LL_labels_cache - TSFE->readLLfile() - TSFE->getLLL() - TSFE->initLLvars() Resolves: #81217 Releases: master Change-Id: Iae85ac2eda4d7f77960de2d66b9069f6017c31d8 Reviewed-on: https://review.typo3.org/52799 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Benni Mack authored
This patch straightens several areas to use proper API calls, and separates bigger methods into smaller methods. Resolves: #82778 Releases: master Change-Id: Ibfa80589a026966f4cbd0f2e6e7e4062033b3ab8 Reviewed-on: https://review.typo3.org/54408 Tested-by:
-
Tymoteusz Motylewski authored
Adds some JS doc and renames few properties to make code more readable. Resolves: #82775 Releases: master Change-Id: I8cb66ee1d52be00ea6e556d369607aecc7e4e2fb Reviewed-on: https://review.typo3.org/54406 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Riccardo De Contardi authored
Adds to page with doktype=199 (spacer) the tab "Appereance" with palette "backend layout" and the tab "Resources" with palette "TSConfig". Resolves: #77892 Releases: master Change-Id: I3c5a47fcc551858bc889a7fe127d241b0f961faf Reviewed-on: https://review.typo3.org/53810 Reviewed-by:
-
Benni Mack authored
ConditionMatcher has a log method which is never used. Resolves: #82770 Releases: master Change-Id: I8554f253260601a8511dacdbca3ddfc894be80bd Reviewed-on: https://review.typo3.org/54402 Tested-by:
-
Benni Mack authored
Properties which are only accessed inside of GraphicalFunctions and should remain inside are marked as protected, are migrated to arrays (to avoid inList calls instead of in_array()), removed or renamed to remove classic kasper's-style double negation namings. Resolves: #82768 Releases: master Change-Id: If45a9198c3a2979a6fe0a1619a9841bd37a2708e Reviewed-on: https://review.typo3.org/54318 Tested-by:
-
Gianluigi Martino authored
This patch enable the "Today" button on the bottom of the DateTimePicker. Clicking the "Today" button will set the date and time to now. Resolves: #82723 Releases: master, 8.7 Change-Id: I262e0206754b2a9e785a6f1184712ba8cc26ad12 Reviewed-on: https://review.typo3.org/54396 Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Benni Mack authored
The goal is to minimize TYPO3_MODE usage in ext_localconf and ext_tables and provide a clear process for extension developers where to put what. This extension streamlines the whole usage within all system extensions, and documents the expected behaviour of all third-party extensions, which will also be included in docs.typo3.org. Resolves: #82692 Releases: master Change-Id: Id83ff0dfc6198564443f2f42e273bcd4f6f25e3e Reviewed-on: https://review.typo3.org/52533 Reviewed-by:
-
Benni Mack authored
The following changes were made: 1. enableLogging is now only checked within the log methods (if no extra CPU / DB requests were made in the if statements). 2. Introduce a getter for $GLOBALS['LANG'] instead of using the hard-coded object (and using IF statements, although the comment on top of the PHP class states that LanguageService MUST be initialized). 3. Simplify switch-cases / nested-if statement to a regular IF condition 4. Use Logger API instead of plain debug() calls Resolves: #82769 Releases: master Change-Id: Icd74057ac64ec8fc219c55b7996f766020fd5ad8 Reviewed-on: https://review.typo3.org/54401 Tested-by:
-
Andreas Fernandez authored
The RequireJS module `TYPO3/CMS/Backend/Utility` is migrated to TypeScript. This patch marks the global object `TYPO3.Utility` as deprecated. Any occurrence is migrated to properly use the module instead. Resolves: #82609 Releases: master Change-Id: Ic0deaa29074080edd71928891fd09c3fb2af63fd Reviewed-on: https://review.typo3.org/54251 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Georg Ringer authored
Add the user who deleted a record to the recycler information and also show the avatar of the user. Resolves: #69340 Releases: master Change-Id: Id7d86d737b2759c6746baefa4b60659b6e9527eb Reviewed-on: https://review.typo3.org/54379 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Oct 15, 2017
-
-
Georg Ringer authored
When using FLUIDTEMPLATE with Typoscript "template.file = filename", it will fail silently if filename does not point to a file. Also check for template source when using Typoscript "file = filename" in FLUIDTEMPLATE object. Resolves: #65340 Releases: master Change-Id: Id6aa148408cad14e49b65c0a9f4c7887cfb3fa16 Reviewed-on: https://review.typo3.org/37273 Tested-by:
-
- Oct 13, 2017
-
-
Nicole Cordes authored
This patch adds missing functional tests for \TYPO3\CMS\Backend\Controller\FormInlineAjaxController::createAction Related: #82330 Releases: master, 8.7, 7.6 Change-Id: I61c8c07dd0d2c6a92bb445d7f2b6baee23251f5d Reviewed-on: https://review.typo3.org/54171 Tested-by:
-
Gianluigi Martino authored
If the foldertree in filelist is to long, the rightclick context menu on the bottom of the window is not completly visible. With this patch the position of the menu is calculated based on the windows width and height and so completly visible. Resolves: #82732 Releases: master, 8.7 Change-Id: Ied9204371491059efda61143e9ca9c2f3c8a9b9d Reviewed-on: https://review.typo3.org/54390 Tested-by:
Wittkiel Gruppe <ts@wittkiel-gruppe.com> Tested-by:
-
Frank Naegler authored
Resolves: #82751 Releases: master Change-Id: Ie87cccc2d890ffaf93fe8558f2a67da82ee8c495 Reviewed-on: https://review.typo3.org/54383 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Loek Hilgersom authored
Resolves: #82749 Releases: master, 8.7 Change-Id: I1de1157ca8e28da3a9fd3ffb3783bb73b1f8e845 Reviewed-on: https://review.typo3.org/54382 Tested-by:
Gianluigi Martino <gmartino27@gmail.com> Tested-by:
-
Christian Kuhn authored
Modernize the code base of the lowlevel ConfigurationController: * No more _GP usages * Get rid of MOD_SETTINGS and friends * Don't use BackendUtility::funcModule and other crude helpers * Get and apply changes to be_user->uc directly * Move last html pieces to view Change-Id: I24af6c53b9c55c82e0e1fc1ee79de97768fd9b2c Resolves: #82754 Releases: master Reviewed-on: https://review.typo3.org/54389 Tested-by:
-
Frank Naegler authored
Resolves: #82604 Releases: master Change-Id: I9b9ff38c635902f2713602955ad9a3d04734ec88 Reviewed-on: https://review.typo3.org/54367 Tested-by:
-
- Oct 12, 2017
-
-
Georg Ringer authored
To avoid exceptions with complex structures, the strict flag must be used in the in_array check. Resolves: #82736 Releases: master, 8.7, 7.6 Change-Id: I3ecf859e3e3cc70ab40b10ef9052d46e8b486957 Reviewed-on: https://review.typo3.org/54372 Reviewed-by:
-
Christian Kuhn authored
Setting / unsetting the checkbox "Use regular expression" fails with JavaScript error "jumpToUrl is not defined". Add that to the document body. Change-Id: I0a5928e008972493d070a35d1219a0acca579ce8 Resolves: #82746 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/54377 Reviewed-by:
-
Christian Kuhn authored
The two "view" classes are clearly controllers and are renamed with this patch accordingly. Change-Id: Ic1cdc405ae24b87aa6224cda79b7226ce5eeec64 Resolves: #82744 Releases: master Reviewed-on: https://review.typo3.org/54375 Tested-by:
-
Christian Kuhn authored
To further phase out BaseScriptTask "SOBE", the scheduler controller class no longer extends it and copies left over usages to itself. A general cleanup is applied along with this patch: * Hard code some general variables like "moduleName" * Remove some duplicate class attributes * Additional namespace usages Change-Id: I937b66e0b59d65591547144763026dbbd2d6c5f0 Resolves: #82727 Releases: master Reviewed-on: https://review.typo3.org/54364 Tested-by:
-
Christian Kuhn authored
To reduce BaseScriptClass "SOBE" usages, the lowlevel controller "ConfigurationView" no longer extends this class and inlines some of the detail methods into routing target "mainAction". Change-Id: Icc284f5a3b4f0f9d50482a9f8865b0d7d1c16f4f Resolves: #82728 Releases: master Reviewed-on: https://review.typo3.org/54365 Reviewed-by:
-
Christian Kuhn authored
To reduce BaseScriptClass "SOBE" usages, the lowlevel controller "DatabaseIntegrityView" no longer extends this class and inlines some of the detail methods into routing target "mainAction". Change-Id: I67b0bae5848607166d19988cb005c91301754413 Resolves: #82729 Releases: master Reviewed-on: https://review.typo3.org/54366 Tested-by:
-
Stanislas Rolland authored
RecordLinkHandler->canHandleLink should check record identifier, otherwise the element browser may open the wrong tab when multiple record identifiers are configured. Resolves: #82737 Releases: master, 8.7 Change-Id: Ie12c6d7484bdb51577dfe02a653e80fe1d7b63ea Reviewed-on: https://review.typo3.org/54369 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Christian Kuhn authored
The call tree of the extension manager "configuration form" ext_conf_template.txt parser is a mess: The ext:extensionmanager ConfigurationUtility calls ext:core ConfigurationForm which is a class that extends ExtendedTemplateService which extends TemplateService. The "TypoScript" a-like parsing then uses class TypoScriptParser. This compiles to a huge list of dependencies. The patch compiles this mess down to a series of methods within ConfigurationUtility directly, effectively adding needed parts of TypoScriptParser and ConfigurationForm as protected methods. The class ends up with way less direct and indirect dependencies. The various detail parsing methods are still messy and hard to follow, but rewriting the parser heart does not really make sense since the ext_conf_template.txt format will bite the dust sooner or later anyway and having all in one place is already much better than before. So putting some days of energy into rewriting these specific parts of the TypoScript parsing did not seem to be worth it, even if it in the end could probably solved with 1/4 of code. Class ConfigurationForm is deprecated but could also be removed as breaking patch later if anyone wants to refactor the remaining ExtendedTemplateService and TemplateService classes in v9. Note this patch is an intermediate step before the ConfigurationUtility class form ext:em is moved into the install tool. Change-Id: I62d9fafb6444d954e17c980358e6367a83b033b8 Resolves: #82725 Releases: master Reviewed-on: https://review.typo3.org/54362 Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
- Oct 11, 2017
-
-
Andreas Fernandez authored
The package `codemirror-minified` used as a drop-in replacement of `codemirror` is not maintained well and is replaced with the original package again. To still get the benefits of page loading speed, at least the JavaScript files are compressed by our own toolchain now. CSS can't get compressed now as the original copyright gets replaced by our own "banner". Resolves: #82713 Releases: master Change-Id: Ic12a7e9e70c63f2c0ae322e470453fe056c99155 Reviewed-on: https://review.typo3.org/54346 Tested-by:
-
Andreas Fernandez authored
This patch fixes a condition that fails when a CSV export in the record list is requested. The maximum limit of records is set, if `$iLimit` is larger than 0 to avoid a `LIMIT 0` query. Resolves: #82710 Related: #81651 Releases: master Change-Id: I49779e4fa4b31e44d5457f90939e6f96a41e497b Reviewed-on: https://review.typo3.org/54341 Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Oct 10, 2017
-
-
Tymoteusz Motylewski authored
Resolves: #82726 Releases: master, 8.7 Change-Id: I779dbf4cdecf931cae4f2734f561aa1c9eab4efb Reviewed-on: https://review.typo3.org/54352 Reviewed-by:
-
Markus Klein authored
If the IP of the client changes and is not within the lockIP range anymore a new session is now created. Resolves: #82490 Releases: master, 8.7 Change-Id: I7dc5033318fa9eb1efc929af126b38cc9840e964 Reviewed-on: https://review.typo3.org/54347 Tested-by:
Franz Holzinger <franz@ttproducts.de> Reviewed-by:
-
Tymoteusz Motylewski authored
Fixture data for functional tests in impexp contains correct height for one image now. Resolves: #82722 Releases: master, 8.7 Change-Id: I3fea831a5a030eb525fabe9bbb6e891a3a722fd7 Reviewed-on: https://review.typo3.org/54350 Reviewed-by:
-
Benni Mack authored
Previously, it was possible to disable the handling of references / child-parent relations in workspaces on publishing, due to legacy functionality this was an option introduced back in v4. The behaviour (option switch via TSconfig) was enabled by default on all installations. It automatically resolves dependencies (= publishing dependencies in relations automatically), having this option disabled could lead to side effects in the past. Resolves: #82701 Releases: master Change-Id: I4f152fd337e4c405eaa0f1386601629a688a05d4 Reviewed-on: https://review.typo3.org/54319 Tested-by:
-
Benni Mack authored
The FAL security checks which adds additional checks for Backend Users are currently placed within TYPO3_MODE === BE which applies to CLI as well. In order to even use the FAL API via CLI, a user has to be authenticated (just for browsing files). Therefore, the check needs to be handled via TYPO3_REQUEST_TYPE which excludes symfony commands on CLI basis. Additionally, the REQUEST TYPE checks are handled within the Slot and not when to register the hook (see other cleanup patch as well). Resolves: #82691 Releases: master, 8.7 Change-Id: I7b895a119a17ea166331eb1dbcb75e57fffbd388 Reviewed-on: https://review.typo3.org/54315 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Benni Mack authored
The TCA Inline behaviour option "localizeChildrenAtParentLocalization" is dropped. This functionality is now always enabled. A TCA migration wizard is removing the option. On a side note, the removed functional tests when removing "localizationMode=select" were re-added. Resolves: #82709 Releases: master Change-Id: Idad3443417bf08fc4c93fa6475079ac2fd779c1e Reviewed-on: https://review.typo3.org/54326 Tested-by:
-
- Oct 09, 2017
-
-
Gianluigi Martino authored
On the left side of the "Record selector" window a popup with the content element id is showing hovering the content element icon. With this patch it works also on the right lower side icons in the same window. Resolves: #82708 Releases: master, 8.7 Change-Id: Ib091f61b13923d787e94cb93e85257c39978dbb5 Reviewed-on: https://review.typo3.org/54340 Tested-by:
Raphael Graf <graf@netvertising.ch> Tested-by:
-
Benni Mack authored
The syntax is very confusing, and the second argument is not necessarily needed - most of the TYPO3 Core code uses only the first argument. In order to streamline the API the second method argument is deprecated but still works as before. Resolves: #82702 Releases: master Change-Id: Ib2238ff90edf932f9410cf87c214e23d0a1c4826 Reviewed-on: https://review.typo3.org/54323 Reviewed-by:
-
Joshua Westerheide authored
Resolves: #82697 Releases: master, 8.7, 7.6 Change-Id: I64bf51d5efd0394f4d3269965820281cbaf2de90 Reviewed-on: https://review.typo3.org/54317 Tested-by:
-
Benni Mack authored
Resolves: #81990 Releases: master, 8.7 Change-Id: Id52849587f3ad438d65f48d01a8930a646829dd4 Reviewed-on: https://review.typo3.org/54298 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
