- Feb 10, 2014
-
-
Michiel Roos authored
Calling stat() is cheaper than calling filemtime() AND filesize(). Change-Id: I8fc3cb46d934b3c49f6919f7f178e2b232fd62e1 Resolves: #55574 Releases: 6.2 Reviewed-on: https://review.typo3.org/27256 Reviewed-by: Marcin Sągol Reviewed-by: Karol Lamparski Reviewed-by: Michał Jankiewicz Reviewed-by: Stefan Neufeind Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Łukas Jurys authored
protected LocalizationUtility::setLanguageKeys() is only called from static initializeLocalization and needs to be static, too. Resolves: #47983 Releases: 6.2 Change-Id: I7d0a4f5e8fc09ee049a6a7af1be65d5d5e8bf5e4 Reviewed-on: https://review.typo3.org/27506 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Oliver Klee Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Felix Kopp authored
Bring standard styles for UL/OL html elements. Ordered and unordered lists are styled with disc bullet and decimal. Also overrides those new standard definition for non standard "lists" like tabs or trees. Resolves: #55819 Releases: 6.2 Change-Id: I6f4317d46d503f6d5737015710d19d9c2361b14c Reviewed-on: https://review.typo3.org/27517 Reviewed-by: Marcin Sągol Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Anja Leichsenring authored
The function menu of info module API method can create proper link targets without mentioning index.php. The patch is a preparation for switching the entry point of info module to mod.php. Resolves: #55796 Relates: #55672 Change-Id: Ida807864ea8d75a2737313c88d8f89b37bb816b6 Reviewed-on: https://review.typo3.org/27479 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Georg Ringer authored
Change-Id: I40990623e3d53e70666438acafc27275ac36b621 Resolves: #55827 Releases: 6.2 Reviewed-on: https://review.typo3.org/27523 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Feb 09, 2014
-
-
Oliver Klee authored
Resolves: #55822 Releases: 6.2 Change-Id: I32dd5119a3580df3990997d1c812f33c062c39ba Reviewed-on: https://review.typo3.org/27521 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Łukas Jurys authored
Method Generalutility::htmlspecialchars_decode() was replaced by htmlspecialchars_decode(). Also Generalutility::htmlspecialchars_decode() has been marked as deprecated Resolves: #54777 Releases: 6.2 Change-Id: Idc9b12d8a1dc2746ee0f742c37c640118c9f69c3 Reviewed-on: https://review.typo3.org/27473 Reviewed-by: Oliver Klee Reviewed-by: Karol Lamparski Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Stefan Neufeind authored
There is no such icon in typo3/sysext/backend/Resources/Public/gfx/ Usually the default-icon is overwritten in CSS anyhow by specifying the icon to use, so the bug does not show. But the path is still wrong. Change-Id: Ie321cecfb888664a3ec782933e72cfa89e6f41ec Resolves: #55799 Releases: 6.2 Reviewed-on: https://review.typo3.org/27494 Tested-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Christian Kuhn authored
Two tests check getUrl() by calling some resource on typo3.org. This smells funny and the tests are unstable if network, dns or typo3.org is down or slow. Mocking is not easily possible with the lowlevel nature of getUrl(). The tests are removed for now. Change-Id: I85a83345404c833a67c2f532e820fd28bb7c08e7 Resolves: #55821 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/27518 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Jigal van Hemert authored
getNumericTypo3Version() needs to be more flexible when converting the defined version number into one that can be used by the EM. Resolves: #23902 Releases: 6.2 Change-Id: Ie2ed54c1383e3c6ff9631608e2e9e471ef109952 Reviewed-on: https://review.typo3.org/27509 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Przemysław Krukowski authored
Exception codes are unique now. Resolves: #52294 Releases: 6.2 Change-Id: I4ad49b1ff0342ea36147b6ba0b01d270d9d9f3c5 Reviewed-on: https://review.typo3.org/27462 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Andreas Wolf authored
``GeneralUtility::revExplode()`` is implemented in a very performance-intensive way: it always does a complete cycle with multiple array operations, be it necessary or not. To make the method more performant, it is split into different cases. Currently, the only used value for the ``$count`` in the core is 2, but we have to implement all others, too, of course. The performance increase for $count=2 is greater than 50%; the others will at maximum be as bad as the old implementation, plus a very tiny overhead for checking the value of ``$count``. Change-Id: I79d9a87b790935415c636ee87e6a6db952e0baa4 Resolves: #55564 Releases: 6.2 Reviewed-on: https://review.typo3.org/27255 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Felix Kopp authored
Brings the central table mark-up and style definition "t3-table" to file_list backend module. Thanks to the unification few lines of duplicated css definitions can be tossed. Also moves the localization icons into the html table row. This is a semantic clean-up and gives every file entry one table row. -> Buttons can be added to title cell since cell is always visible. Note: RequireJS module is moved to EXT: file_list. By hiding the flag icons from within html right away there is no flashing between render & ready (JS hide()). Change-Id: Ic84450b8327c9533037ea21054799d6ad9d8d74b Resolves: #55810 Releases: 6.2 Reviewed-on: https://review.typo3.org/27512 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Removes old class files from ext:openid except the two current entry points for _eid and _return. Change-Id: Ibdeca07881aad92af28c9f0e81c42a4ee1b600c2 Resolves: #55808 Related: #47756 Releases: 6.2 Reviewed-on: https://review.typo3.org/27507 Reviewed-by: Oliver Klee Reviewed-by: Marcin Sągol Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Michiel Roos authored
Change-Id: I740b4f481f05ac7bb32028739d534dbb1c41864c Resolves: #55762 Releases: 6.2 Reviewed-on: https://review.typo3.org/27410 Tested-by: Oliver Klee Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Markus Klein authored
CONTENT/RECORDS elements prevent to render the same object twice. Resolves: #53768 Resolves: #28745 Releases: 6.2, 6.1, 6.0 Change-Id: I30750f2dc848521999c3734129439d7f6f90aae1 Reviewed-on: https://review.typo3.org/25512 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Stefano Kowalke Reviewed-by: Andreas Wolf Tested-by: Andreas Wolf
-
Christian Kuhn authored
Change-Id: I5d2233c5eb0860740e1858bf2f96a919fee26e5e Resolves: #55804 Related: #47756 Releases: 6.2 Reviewed-on: https://review.typo3.org/27505 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Klee Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Feb 08, 2014
-
-
Felix Kopp authored
TYPO3 configuration knows a global date format configuration within the installation tool. See TYPO3_CONF_VARS/SYS/ddmmyy. Use this global format as the default for all fluid based date format outputs if not overwritten in place. Change-Id: I508d7f61f63760aa1301f52663c432feeb539bf4 Resolves: #55790 Releases: 6.2 Reviewed-on: https://review.typo3.org/27456 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Łukas Jurys authored
Resolves: #41593 Releases: 6.2 Change-Id: I3863789ad2489055169f3f008cb4dac0085fde82 Reviewed-on: https://review.typo3.org/27463 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Marcin Sągol Reviewed-by: Michał Jankiewicz Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Tymoteusz Motylewski authored
fileList() of Rtehtmlarea\SelectImage is almost an exact copy of the parent implementation from ElementBrowser. The patch removes fileList() from SelectImage and merges changes to ElementBrowser. It also fixes some bugs in magic image selector from RTE: * Missing columns * Wrong links to info page * Fix "import selection" option Resolves: #55765 Releases: 6.2 Change-Id: I78cb23de16b9516f953628aad10cf548f558bfd7 Reviewed-on: https://review.typo3.org/27414 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Wouter Wolters authored
When using a HTTPS backend the download of CSV is not working in Internet Explorer browser versions lower then 9. Add the needed header to fix this problem. Change-Id: Iefa63fb37d57491fb73bfd504b6caed5b76c8cac Resolves: #16491 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Reviewed-on: https://review.typo3.org/20902 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Felix Kopp authored
Brings tree-level icons based on sprite icons utility for treeviews and abstract tree view (e.g. Web>Info Localization, Web>Perm). Refactors the Web>Perm permission matrix table and edit view. Both are now based on table.t3-table unified CSS. All individual CSS styles for Web>Perm are obsolete now since only standard core styles are necessary and used. Change-Id: Icd8bcc476891bc44107acfbe1b81bafd6fd4e3c0 Resolves: #55784 Related: #45502 Releases: 6.2 Reviewed-on: https://review.typo3.org/27438 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Peter Niederlag authored
In some places a wrong namespace \TYPO3\CMS\TsTemplate was used. \TYPO3\CMS\Tstemplate is the correct namespace for the tstemplate sysext. This fixes a problem in links between TSOB and Template Analyzer. Resolves: #55764 Releases: 6.2 Change-Id: Iad84baa842b68f18468c1ff6b92c75c09710815e Reviewed-on: https://review.typo3.org/27415 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: Id7cd8fdaecf663462b8d02a4bf2ca272293cea4f Resolves: #55792 Related: #47756 Releases: 6.2 Reviewed-on: https://review.typo3.org/27460 Reviewed-by: Marcin Sągol Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Marcin Sągol authored
If the List Module is in extended view, the colspan of the footer is wrong if there are more than 20 records of a type. Fix this by increasing the colspan with one if the List Module is extended view. Resolves: #55443 Releases: 6.2 Change-Id: I4c9a45cdab3d1c5267566663fbb6c7cbb702f32a Reviewed-on: https://review.typo3.org/27448 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Felix Kopp authored
Adds default parameter array() for controllerActions in registerModule. This way an own main module group can be added with \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule( 'VENDOR.' . $_EXTKEY, 'newMainGroup' ); Change-Id: I1218a5069d7787f65e77d1d23a58d307461f7743 Resolves: #54869 Releases: 6.2 Reviewed-on: https://review.typo3.org/26717 Reviewed-by: Christian Kuhn Reviewed-by: Marcin Sągol Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
matw authored
Add missing mapping between pps, ppsx and the powerpoint application. Resolves: #53833 Releases: 6.2 Change-Id: I9ecd8ec899bb24245326ca42a469ee41de9b2c79 Reviewed-on: https://review.typo3.org/27457 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Thorsten Kahler authored
Add missing label action_1_5 and fix label action_1_4. Resolves: #55698 Releases: 6.2, 6.1 Change-Id: I7f04aaf9d8b53cbe3109dbf72f4fddb0c089e9ad Reviewed-on: https://review.typo3.org/27361 Reviewed-by: Wouter Wolters Reviewed-by: Marcin Sągol Reviewed-by: Jan Bartnik Tested-by: Jan Bartnik Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Felix Kopp authored
Scheduler backend module comes with an execute button. Add icon to the button. Change-Id: I842683c4b332a87653474237a893dd65d5bd1b5d Resolves: #55789 Releases: 6.2 Reviewed-on: https://review.typo3.org/27451 Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Łukas Jurys authored
Fixed typo from "Drop & Drop to upload files" to "Drag & drop to upload files" Resolves: #55756 Releases: 6.2 Change-Id: I35ebde8ee46fe673764c25019551130810241677 Reviewed-on: https://review.typo3.org/27441 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Marc Bastian Heinrichs authored
The count in LazyObjectStorage for relation type HAS_MANY has to use the count on storage items after initialization. Otherwise the wrong count is returned for a not persisted storage. Resolves: #54724 Releases: 6.2, 6.1, 6.0 Change-Id: I817ce86dde11b175e6a5765a8f6518770ba75f28 Reviewed-on: https://review.typo3.org/27357 Reviewed-by: Wouter Wolters Reviewed-by: Nico de Haen Tested-by: Nico de Haen Tested-by: Peter Beernink Reviewed-by: Stefan Neufeind Reviewed-by: Marcin Sągol Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Benjamin Mack authored
Parts of the JavaScript code used in TCEforms is put inline, coming from the PHP file. There is no concept of using HTML5-data attributes to store information. Plus, most of the JS functions are inline in the HTML output and called in onclick etc. handlers in the HTML elements. Thus, the functionality cannot be abstracted from the markup, and the JS functionality cannot be cached by the browser. Previously, the JS functionality is based on plain MSIE4-compatible JS code without any framework (no prototype, jQuery etc), and are not in any namespace. This approach extracts TCEforms JS code to an external file (AMD module / RequireJS), and rewrite it to current jQuery and JS standards. But since the JS code of TCEforms is very complicated, it is hard to do it all at once, and the task is split into separate parts. The beginning marks the functionality around select fields in TCEforms, the functions for importing values from the Element browser, from any other source. The patch does this: * Extract the static functions from the PHP code to an external JS file, in a new RequireJS module named "TYPO3/CMS/Backend/FormEngine.js" * Add options that are page-specific (backPath, formName, callback fn) to PHP so JS can access it. * Add classes and data-attributes and remove onclick... functionality in order to reduce the HTML code and split the data from the logic. * Functionality for icons like "move up" etc are rewritten * Functionality for adding elements from a two-select (like "Access" element in pages) is rewritten, using CSS classes and data attributes. By keeping the global variables for the old functionality, the old functions still work as expected. Resolves: #46357 Releases: 6.2 Change-Id: I3b9936143342d99eec3058cd55fefdb006060cd4 Reviewed-on: https://review.typo3.org/18971 Reviewed-by: Andreas Wolf Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Tested-by: Felix Kopp Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
- Feb 07, 2014
-
-
Nicole Cordes authored
When creating a new page inside the top level of a DB mount which is only a sub tree, the pages up and down from the DB mount root will be displayed in the position selector if the logged-in user has read permissions for these pages. This is unwanted information disclosure as the permissions should not matter for pages which are outside the DB mount. Resolves: #18797 Releases: 6.2, 6.1, 6.0 Change-Id: I98008bc7f4308c9fb32dae645325e7cb1b44e413 Reviewed-on: https://review.typo3.org/22632 Reviewed-by: Markus Klein Reviewed-by: Xavier Perseguers Reviewed-by: Wouter Wolters Tested-by: Markus Klein Reviewed-by: Marcin Sągol Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Stefan Neufeind authored
Change-Id: I2fdd722f56e69c2c6b2bae23d9944973eed3c066 Resolves: #55745 Releases: 6.2 Reviewed-on: https://review.typo3.org/27387 Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Stanislas Rolland authored
The RTE magic still copies images to the old upload folder and does not use the processed file functions of FAL. This patch changes the RTE magic so storage 0 is not used any more and that the FAL API is used for processing the images. Resolves: #51807 Releases: 6.2 Change-Id: I07d609f9e638d79e785be4ebfd25631c70e3d141 Reviewed-on: https://review.typo3.org/23663 Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
Tymoteusz Motylewski authored
In ResourceStorage in the method getUniqueName second argument passed to fileExistsInFolder should be string instead of object. This fixes an exception thrown when trying to insert magic image in the RTE. Resolves: #55763 Releases: 6.2 Change-Id: I4ed624d4ea5a3602936cf8493052ef111a391990 Reviewed-on: https://review.typo3.org/27412 Reviewed-by: Michiel Roos Reviewed-by: Marcin Sągol Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Benjamin Mack authored
The TMENU code has "RO" functionality in its class. This code might be used from TMENU_LAYERS, but not from the core itself. The core should remove the according places. If extensions need this functionality they could implement their own menu functionality. The patch itself just removes the functionality of rollovers, which is currently not documented nor used. The idea of the content object with its extProc classes is outdated and should be replaced by hooks and/or signal slots. As all methods that are removed, are private, they can IMHO be removed directly. In a second patch, there will be a hook interface in order to manipulate the items. Releases: 6.2 Resolves: #55751 Change-Id: Ibd5862124a6f8bc9f06254234cfbf179893c27cc Reviewed-on: https://review.typo3.org/27396 Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Markus Klein authored
$this->typ needs to be $this->type Resolves: #55753 Releases: 6.2 Change-Id: I5414de0a00b4d0b7adecd783243990397cccb0b7 Reviewed-on: https://review.typo3.org/27403 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Michiel Roos authored
Replace JscharCode() with GeneralUtility::quoteJSvalue() Instead of making JavaScript use a String.fromCharCode, it will now use a sanitized quoted string. Change-Id: Idf81d5524d4bbb60b515670aa13648aa52064905 Resolves: #55009 Releases: 6.2 Reviewed-on: https://review.typo3.org/27380 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Michael Schams authored
This patch updates the named constant TYPO3_copyright_year and updates the second year number to the current year: 1998-2014. Resolves: #55747 Releases: 6.2 Change-Id: If3b9d9b25b6ec6a7d2c8a0327dc7b330f0f09f8c Reviewed-on: https://review.typo3.org/27392 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-