- Sep 30, 2018
-
-
Benni Mack authored
When an extension author writes a display condition in TCA and by incident uses a wrong format for the displayCondition (see ticket) the strtoupper fails due to the lack of an associative array because it's a numeric-key array. An additional check fixes the issue. Resolves: #79692 Releases: master, 8.7 Change-Id: I4455bdc908e0be1a373f86680e718e876aa5ddd7 Reviewed-on: https://review.typo3.org/58480 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #85305 Releases: master Change-Id: I01c62adede04f5f74c506c15e28d471ad3185593 Reviewed-on: https://review.typo3.org/57261 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
A new TCA option for TCA type "slug" is added, called "prependSlash", which adds a "/" in front of the field. For pages (pages.slug), this is mandatory and cannot be configured, as the slug field has to be filled and set to "/" as a base for the root page. For other database fields, this is optional (and disabled by default), and can be enabled via "prependSlash" in TCA config. This option is mostly useful for recursive records, like categories, but for most "flat" structures like "news" or "events", this is not suitable. For pages, it is hard-coded and cannot be (un-)set. Resolves: #86457 Releases: master Change-Id: I997908ed74af7ca21873b0793674e9185cc581ce Reviewed-on: https://review.typo3.org/58474 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Oliver Hader authored
* adds test cases for resolving and generating enhanced links * fixes locale issues when dealing with persisted mappers * removes PersistedAliasMapper.valueFieldName and uses TCA 'uid' field per default, which is required for proper language based resolving as well * introduces language based resolving to PersistedAliasMapper and PersistedPatternMapper Resolves: #86444 Releases: master Change-Id: Ib9c9ea8efc25a8a5adb727f8402a2b6b1e6a1602 Reviewed-on: https://review.typo3.org/58461 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Susanne Moog authored
To allow others to use the new upgrade wizard API the interfaces are no longer marked as @internal. Resolves: #86448 Releases: master Change-Id: I2e146e6d27c5aaed922a004054b3df2bbea88cb8 Reviewed-on: https://review.typo3.org/58466 Tested-by:
-
Benni Mack authored
When hooks modify _GET or _POST parameters, it is important that these changes reflect the PSR-7 request for now, as long as TYPO3 access the _GET/_POST parameters via GeneralUtility::_GP(). In order to move away from global access, we still want to avoid places where it is unclear to use $_GET/$_POST vs. $GLOBALS['TYPO3_REQUEST'] until all parts are completely "global-scope free" for GET/POST parameters. The change adds the initial GET/POST parameters to the request object in the very first middleware of the frontend. If these have been modified when the RequestHandler builds up the content, they are added on top of the PSR-7 request object. Additionally, if the PSR-7 request object has been modified, these changes are put back in the global scope to reliably use _GPmerged within Extbase and Additionally, if _GET/_POST have been modified, a warning will be shown in the TimeTracker to find out that there have been modifications. Until then, it is safe to continue to access _GET/_POST within Hooks and Frontend, however it is highly discouraged to *modify* _GET/_POST directly as this functionality will be breaking in TYPO3 v10.0. Bottom line: This safety net can now trigger deprecation warnings if _GET/_POST have been modified during PSR-15 middleware hooks. Bottom line 2: If these have been modified, they are put inside the current request object. Bottom line 3: If the request object has been modified, global state will be modified ONCE in one place to ensure that we work with the same object during the request phase. Bottom line 4: We cannot get away from the current state of running a TYPO3 Frontend Request from another source, and we try to maintain compatibilty for legacy scripts for now. However, this will be breaking in TYPO3 v10.0. Resolves: #86458 Releases: master Change-Id: Ic8f4f123bb5ea0d660e500494cf06a965dea03c4 Reviewed-on: https://review.typo3.org/58443 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
RteHtmlParser has never received a good clean up, that's because it was there since PHP 4 ages. In order to rename, reorder code, all internal methods and properties are now declared as protected. Resolves: #86440 Releases: master Change-Id: I204efa8156abcf9ae07a607fa03fa04fbb269885 Reviewed-on: https://review.typo3.org/58457 Reviewed-by:
-
- Sep 29, 2018
-
-
Josef Glatz authored
This patch re-adds a missing functionality to CKEditor. Due to the move from htmlArea to CKEditor, the well-known wordcount information was gone. The wordcount information is added to all existing CKEditor presets per default. In addition, it is now possible to customize the displayed information below the editor. - It's possible to switch paragraph-, word- and/or character count. - You can define if spaces are counted as charactars. - You can define if HTML tags are taken into account. - You can define if linebreaks are taken into account. Beside that, the used plugin enables also setting up maximum values for word- and/or character count. This can be easily used for custom RTE presets. The fact that the global configuration is located in the Base.yaml makes it possible to overwrite settings partially or completely in any inherited RTE preset. With that it is easy possible to realize word/character limits. Following commands were used to add the external package as a dependency and copy the plugin files/folders to the final location: `yarn add --dev ckeditor-wordcount-plugin && yarn build` Resolves: #86395 Releases: master Change-Id: I2c76d7bfebc9a5a57c1f105788af206bdffb00f2 Reviewed-on: https://review.typo3.org/58405 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Benni Mack authored
Normalized Params only needs serverParams and $TYPO3_CONF_VARS[SYS] to work with, so the object is modified in order to simplify further work on the object. Resolves: #86454 Releases: master Change-Id: I30f2c6195468b275e61570c1de67b39f281bb494 Reviewed-on: https://review.typo3.org/58471 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Nikita Hovratov authored
The tooltip has to be removed at that point, because as soon as any data is deleted the row disappears and it's not possible to trigger the mouseout event manually. Resolves: #81856 Releases: master, 8.7 Change-Id: I2f7388b6a278de9ba19e81ec20ed3ae0052b1698 Reviewed-on: https://review.typo3.org/58463 Reviewed-by:
-
Georg Ringer authored
Sort the extension settings by the extension key. Resolves: #86452 Releases: master Change-Id: I6fb0110820d4a8406f01b617b3279640be9aa743 Reviewed-on: https://review.typo3.org/58470 Reviewed-by:
-
Benni Mack authored
Instead of explicitly call loadJQuery() this should be handled by requireJS or - even better - use vanilla JavaScript instead. Resolves: #86438 Releases: master Change-Id: Iecc2ceb7fa01578b00a63262f393bd1b92fa13e1 Reviewed-on: https://review.typo3.org/58455 Reviewed-by:
-
Benni Mack authored
The following methods will trigger a deprecation warning if they are called from the outside: - TemplateService->prependStaticExtra() - TemplateService->versionOL() - TemplateService->processIncludes() - TemplateService->mergeConstantsFromPageTSconfig() - TemplateService->flattenSetup() - TemplateService->substituteConstants() Several other methods have been marked as internal. Resolves: #86439 Releases: master Change-Id: Ifabbda8048449e6919d054da4111f01065a5eeab Reviewed-on: https://review.typo3.org/58456 Reviewed-by:
-
Benni Mack authored
Install Tool still uses TYPO3's own RequestHandler interface which exists since TYPO3 v7, but is superseded with PSR-15's RequestHandler concept. Install Tool now uses PSR-15 and the old interface in order to still use the priority concept. In a further step, both RequestHandlers should be migrated to Middleware+RequestHandler concept. Resolves: #86451 Releases: master Change-Id: I55cf31a2b803951491ba072969a4cff68ef2c2ac Reviewed-on: https://review.typo3.org/58469 Reviewed-by:
-
Benni Mack authored
The phpDoc comment "@internal" is used in most places during the development of TYPO3 v7, TYPO3 v8 and TYPO3 v9 and denotes that this specific method, class or property is not part of the Public API, and does not even need any notice if it is removed. However, we still have/had various places in TYPO3 core where "@access private" was used. This is now migrated to "@internal". "@access public" is not needed and is removed. Resolves: #86446 Releases: master Change-Id: Iaef206b04aee13c280d62b107dd7eac04a38c700 Reviewed-on: https://review.typo3.org/58462 Reviewed-by:
-
Susanne Moog authored
As the core uses American English, 'analyze' should be spelled with a `z`. This looked especially strange in the install tool, where both spellings were mixed on one card. Resolves: #86447 Releases: master Change-Id: I484f75a05d3cf988baaebf91df30cd936f454eac Reviewed-on: https://review.typo3.org/58454 Reviewed-by:
-
Benni Mack authored
The property "checkWorkspaceCurrent_cache" is now protected. Second method argument of "modAccess()" is deprecated. "isPSet()" is not in use anymore, and will be removed in TYPO3 v10.0. Some other methods, which are workspace-related, are marked as internal in order to properly move them into EXT:workspaces in the next version. Resolves: #86441 Releases: master Change-Id: Ie776e71cdc7485937b2a38e7cfc93c13aba925ab Reviewed-on: https://review.typo3.org/58458 Tested-by:
-
Benni Mack authored
Use @internal where access private was marked, also add some meaning to currently public methods that should only be used by TYPO3 Core. Resolves: #86442 Releases: master Change-Id: If90f1a6dc6cad1edb0db2179cb87f5e6eb18f2ec Reviewed-on: https://review.typo3.org/58459 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Benni Mack authored
Page-based routing can now be configured within a site configuration to add so-called "route enhancers" which allow to add more placeholders to a route for a page. There are three Enhancers that TYPO3 now ships with: - SimpleEnhancer - PluginEnhancer - ExtbasePluginEnhancer It is also possible to add custom enhancers by third- party extensions. Each placeholder within an enhancer can receive a so-called "Aspect", usually used for mapping speaking values instead of IDs, or month-names in an archive link, and "modifiers" to modify a placeholder. The simple enhancer transfers a link parameter, previously maybe used to add a `&product=123`, which will now result into `/product/123` for a page. PluginEnhancer adds a namespace, common for simple plugins or Pi-Based plugins, and the ExtbasePluginEnhancer adds logic for multiple route variants to be added, depending on the controller/action combinations. Aspects are processors / modifiers / mappers to transfer a placeholder value back & forth to make each placeholder value more "speaking". TYPO3 Core ships with the following aspects: * LocaleModifier (for localized path segments) * StaticValueMapper (for path segments with a static list) * StaticRangeMapper (for pagination) * PersistedAliasMapper (for slug fields) * PersistedPatternMapper (for database records without slug fields) Routing now returns a so-called "PageArguments" object which is then used for evaluating site-based URL handling and the cHash calculation. It is highly discouraged to access _GET or _POST variables within any kind of code now, instead the PSR-7 request object should be used as much as possible. Releases: master Resolves: #86365 Change-Id: I77e001a5790f1ab3bce75695ef0e1615411e2bd9 Reviewed-on: https://review.typo3.org/58384 Tested-by:
-
Christian Kuhn authored
With the new routing, TYPO3 relies on a default redirect to index.php for FE requests. The patch checks during installation if apache or IIS are used and creates the default .htaccess / web.config files. Change-Id: I9406a7e4d91050d3f5bf96dd63e4bf63e8f71250 Resolves: #86173 Releases: master Reviewed-on: https://review.typo3.org/58451 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Anja authored
Change-Id: I6fccf8db0ab996139692a07be8d08ceb8feee86f Releases: master Resolves: #86434 Reviewed-on: https://review.typo3.org/58448 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
lsascha authored
Releases: master, 8.7 Resolves: #86396 Change-Id: I198fe52a8024dcf392582a78c3fce0f134ed6b7a Reviewed-on: https://review.typo3.org/58406 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Christian Kuhn authored
This adds a dummy wizard to remind admins during upgrade to check the live system for argon2i support if the local instance uses it, or to select a different hash algorithm. Having this wizard gives this information to admins early in the upgrade phase, so they have time to check the live system or to select a different mechanism before too many passwords have been upgraded. Resolves: #86402 Releases: master Change-Id: I2b1f75ecf079dc2e29d2675dda558c79b67f77e0 Reviewed-on: https://review.typo3.org/58411 Tested-by:
-
Helmut Hummel authored
During generation of processed files a wrong processed folder is evaluated when the processed folder resides on a different storage. We now ensure to ask the correct storage for the processed folder. Also ensure that correct storage is used for checking file existence when original file and processed files are on different storages. Fixes: #86399 Releases: master, 8.7 Change-Id: I254b9a0bf86a156ae135510a4439e87737ec1a29 Reviewed-on: https://review.typo3.org/58410 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Benni Mack authored
Most of the occurrences have been replaced by using Environment API. On top, labels are now moved into "var/labels" for existing composer-based installations, moving XLF files out of the document root when the environment is configured to allow files outside of the document root. For non-composer-based installations, labels are still available under "typo3conf/l10n". Resolves: #85560 Releases: master Change-Id: Ib0a9e8e3dcd685109b9d922aee1970e68b265179 Reviewed-on: https://review.typo3.org/57600 Reviewed-by:
-
Benni Mack authored
We recently removed the "site" base prefix within the yaml configuration file of a site configuration. However, the indention is wrong when using FormEngine to edit the site configuration within the "old" syntax. Resolves: #86437 Related: #86323 Releases: master Change-Id: I487940188b04c4977d179337cb142f2452c3bace Reviewed-on: https://review.typo3.org/58449 Tested-by:
-
Benni Mack authored
We want the latest dependencies in our LTS version, so this should ship the latest versions in the zip/tarballs. Used command: composer update symfony/* \ doctrine/* \ friendsofphp/* \ nikic/php-parser \ --with-dependencies Resolves: #86432 Releases: master Change-Id: I46b7ea46033d4f2c4d0148de537728d2b9ff22c2 Reviewed-on: https://review.typo3.org/58447 Tested-by: -
Anja authored
Provide a silent upgrader the same way as for BE/loginSecurityLevel to avoid FE login to fail after upgrade. Change-Id: I8c27c370206effc1f88fd5334b9f20f01a628757 Resolves: #86417 Releases: master Reviewed-on: https://review.typo3.org/58429 Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Benni Mack authored
The following legacy TypoScript options have been deprecated - stdWrap.filelist - stdWrap.filelink - stdWrap.addParams The acompanied methods are deprecated as well - cObj->stdWrap_addParams - cObj->stdWrap_filelink - cObj->stdWrap_filelist - cObj->addParams - cObj->filelink - cObj->filelist - cObj->typolinkWrap - cObj->currentPageUrl These are not in use anymore, due to removal of CSS Styled Content. Resolves: #86433 Releases: master Change-Id: Ie90dce49c050092c1a359491301ad3f3dd04ee4f Reviewed-on: https://review.typo3.org/58418 Tested-by:
-
- Sep 28, 2018
-
-
Benni Mack authored
In order to be in line with the new PageArguments object, this newly introduced class is now renamed. Resolves: #86431 Releases: master Change-Id: I96575338538641fc27a578c49868b21100b61ed3 Reviewed-on: https://review.typo3.org/58446 Reviewed-by:
-
Tymoteusz Motylewski authored
Resolves: #86423 Releases: master, 8.7 Change-Id: I5c1e0f92fe5f9d28eaaf0250677cd3dedcbd6082 Reviewed-on: https://review.typo3.org/58436 Tested-by:
-
Andreas Fernandez authored
To render the „Executing foo“ text in the progress bar when a upgrade wizard is executed correctly, a missing `data-title` attribute is added. Resolves: #86430 Releases: master Change-Id: I53f6f1a551de132452695a400561e46e9c1e4fb4 Reviewed-on: https://review.typo3.org/58442 Tested-by:
-
Georg Ringer authored
The cropping element shows an information if no dimensions are known. The styling of this information is now improved. Resolves: #86429 Releases: master, 8.7 Change-Id: I28b6e4da560e591a57e6c849488f59ddf5cd5736 Reviewed-on: https://review.typo3.org/58441 Reviewed-by:
-
Oliver Hader authored
When previewing translated pages in the backend, URLs contain `&L=x` at the end. This is due to a missing transformation into the `_language` parameter as well a missing SiteLanguage resolving. Resolves: #86421 Releases: master Change-Id: I5da496d0224635b1ee849dd7a724145ad2c0d408 Reviewed-on: https://review.typo3.org/58438 Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Frank Naegler authored
Resolves: #86427 Related: #86404 Releases: master Change-Id: Iec990bd910ac62805d4584c468b265f57c0fd17d Reviewed-on: https://review.typo3.org/58437 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Susanne Moog authored
A new key "site" for TypoScript "getText" has been introduced which allows accessing site configuration. Resolves: #86422 Releases: master Change-Id: Id0efae08445b8890021fb2b68a88c4ac8db5a6fa Reviewed-on: https://review.typo3.org/58434 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Christian Kuhn authored
Using the element browser for a type=group, internal_type=file_reference TCA field leads to an exception due to a missing registration for this mode. Register the file browser, similar to internal_type=file. Resolves: #80541 Releases: master, 8.7 Change-Id: I54be7084f10d63ed262e903c296294589521f3df Reviewed-on: https://review.typo3.org/58431 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Christian Kuhn authored
Properties $MOD_SETTINGS and $modTSconfig of RecordListController are still used by DatabaseRecordList through $GLOBALS['SOBE']. These two have to stay public for the time being to not trigger a bunch of deprecation log entries on each call of the list module. Change-Id: I87188b2065f4933e45203de58027f92db98bf840 Resolves: #86418 Related: #86198 Releases: master Reviewed-on: https://review.typo3.org/58430 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Gianluigi Martino authored
During the translation process the option "disablePrependAtCopy" is not respected. With this patch the option is respected again for pages and tt_content. Resolves: #86293 Releases: master, 8.7 Change-Id: I821f3fed7d3e0637298262c4bd2c11003618f1c5 Reviewed-on: https://review.typo3.org/58424 Tested-by:
-
Guido Schmechel authored
Now it is also possible to add private Vimeo links. Releases: master, 8.7 Resolves: #83852 Change-Id: Icb425d4aea98a687b91216fefcd69b5fecc1a01e Reviewed-on: https://review.typo3.org/58404 Tested-by:
-
