- Jun 04, 2024
-
-
Andreas Kienast authored
The stylesheet loading process in IRRE was kept for several years and moved from version to version. A recent change in #103375 migrated a usage of `delete` to `.splice()`, breaking stylesheet loading as the original iterated object was modified. Since the code was quite dated and had other potental bugs, the whole loading sequence has been transformed to functional programming style to reduce complicated, potentially error-prone, array operations. Resolves: #103971 Related: #103375 Releases: main, 12.4 Change-Id: I18caafc68ceebce53723b7208270043faafc7458 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84487 Tested-by:
rogier Helmer <rogier.helmer@maxserv.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
rogier Helmer <rogier.helmer@maxserv.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Andreas Kienast authored
This commit updates ckeditor to 41.4. See changelog at [1]. Executed commands: # Override ckeditor5 package to avoid pulling in all/too # many available packages. See: # https://github.com/ckeditor/ckeditor5/issues/16360 npm --prefix overrides/ckeditor5 version 41.4.2 npm install --save ./overrides/ckeditor5 npm install --save \ @ckeditor/ckeditor5-alignment@^41.4.2 \ @ckeditor/ckeditor5-autoformat@^41.4.2 \ @ckeditor/ckeditor5-basic-styles@^41.4.2 \ @ckeditor/ckeditor5-block-quote@^41.4.2 \ @ckeditor/ckeditor5-clipboard@^41.4.2 \ @ckeditor/ckeditor5-code-block@^41.4.2 \ @ckeditor/ckeditor5-core@^41.4.2 \ @ckeditor/ckeditor5-editor-classic@^41.4.2 \ @ckeditor/ckeditor5-engine@^41.4.2 \ @ckeditor/ckeditor5-essentials@^41.4.2 \ @ckeditor/ckeditor5-find-and-replace@^41.4.2 \ @ckeditor/ckeditor5-font@^41.4.2 \ @ckeditor/ckeditor5-heading@^41.4.2 \ @ckeditor/ckeditor5-horizontal-line@^41.4.2 \ @ckeditor/ckeditor5-html-support@^41.4.2 \ @ckeditor/ckeditor5-indent@^41.4.2 \ @ckeditor/ckeditor5-link@^41.4.2 \ @ckeditor/ckeditor5-list@^41.4.2 \ @ckeditor/ckeditor5-paragraph@^41.4.2 \ @ckeditor/ckeditor5-paste-from-office@^41.4.2 \ @ckeditor/ckeditor5-remove-format@^41.4.2 \ @ckeditor/ckeditor5-select-all@41.4.2 \ @ckeditor/ckeditor5-show-blocks@^41.4.2 \ @ckeditor/ckeditor5-source-editing@^41.4.2 \ @ckeditor/ckeditor5-special-characters@^41.4.2 \ @ckeditor/ckeditor5-style@^41.4.2 \ @ckeditor/ckeditor5-table@^41.4.2 \ @ckeditor/ckeditor5-theme-lark@^41.4.2 \ @ckeditor/ckeditor5-ui@^41.4.2 \ @ckeditor/ckeditor5-undo@^41.4.2 \ @ckeditor/ckeditor5-upload@^41.4.2 \ @ckeditor/ckeditor5-utils@^41.4.2 \ @ckeditor/ckeditor5-watchdog@^41.4.2 \ @ckeditor/ckeditor5-word-count@^41.4.2 npm install --save-dev \ @ckeditor/ckeditor5-dev-utils@^40.0.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v41.4.2 Resolves: #103840 Releases: main, 12.4 Change-Id: I46dc33ab8e8cfcc75aa13bfe50d8850fb704f75e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84281 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- Jun 03, 2024
-
-
Stefan Bürk authored
The `symfony/yaml` package provides the `yaml-lint` commandline tool to lint yaml files. This change introduces yaml file linting checks using the symfony tool, differencing `Services.yaml` from other yaml files. Resolves: #103931 Releases: main, 12.4, 11.5 Change-Id: I9442b38c439fb5f2d5507ca0ab70235b2dfd194a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84420 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Jun 01, 2024
-
-
Anja Leichsenring authored
Phpstan claims the contract guard condition can never be true (in which case an exception will be thrown) but this is not true. So we keep the condition, but suppress the error. PHPStan gets updated and pinned to lowest version 1.11.3 with composer require --dev phpstan/phpstan:^1.11.3 Resolves: #103962 Related: #99146 Releases: main, 12.4 Change-Id: I8c184ef24ed95c7277e1e6b5ac8b8c9ea3ad0521 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84472 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- May 31, 2024
-
-
Andreas Kienast authored
This commit updates some colors in the color picker component. The dark background is removed from focussed input fields. Also, the input styling now matches FormEngine styling. Resolves: #103891 Releases: main Change-Id: I9a3a9e10c48be0bf49395d388be55cb8c8535693 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84379 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- May 27, 2024
-
-
Ayke Halder authored
This enables the already available `phpstan-phpunit` rules: * PHPStan\Rules\PHPUnit\AssertSameBooleanExpectedRule * PHPStan\Rules\PHPUnit\AssertSameNullExpectedRule * PHPStan\Rules\PHPUnit\AssertSameWithCountRule * PHPStan\Rules\PHPUnit\MockMethodCallRule * PHPStan\Rules\PHPUnit\ShouldCallParentMethodsRule `ShouldCallParentMethodsRule` is of great interest: It checks for missing calls to `parent::setUp` and `parent::tearDown`. `AssertSameWithCountRule` replaces `assertSame($expectedCount, count($variable))` with `assertCount($expectedCount, $variable)`. Resolves: #103880 Related: #103929 Releases: main Change-Id: I43a69d0dcf342cc65d34eb03f2d9800b1e70e8a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84351 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Stefan Bürk authored
This change modifies the `runTests.sh` helptext to mention the `checkIntegrityPhp` correctly added with #103465. Resolves: #103930 Related: #103465 Releases: main Change-Id: I0ffdb66236bbc0c82f702cf960bf9462dedbdfcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84419 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
- May 26, 2024
-
-
Christian Kuhn authored
$this->count() in phpunit always returns 1 and has no arguments as correctly found by phpstan. Fix a test to actually assert subject result count. Resolves: #103924 Releases: main, 12.4 Change-Id: I396b695eaeaa986a4cd9883e028ed6032d2f6339 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84412 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
GeneralUtility::callUserFunction() has only three parameters, as detected by phpstan. Resolves: #103923 Releases: main, 12.4 Change-Id: I31fc48f343558dd2e0d73feeb3933e249fa625a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84410 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
Two unit tests are skipped since they try to verify correct behavior while the system under test returns something broken or not implemented. The patch activates the tests to document the broken behavior and adds `@todo` annotations explaining what is going wrong or should be expected. Resolves: #103922 Releases: main Change-Id: Ib93bfa6baa3cb8369e084bd01a7dd0d40c7a4bee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84409 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- May 25, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.1.1 npm run build Resolves: #103890 Releases: main Change-Id: Id8cd17bbb1142a0522e1fd80f7dbd0f83455720a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84378 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
- May 24, 2024
-
-
Andreas Kienast authored
Previously, the internal method `loadFromServer()` from the module `@typo3/backend/storage/persistent` fetched the data, wrote it into an internal property `data` and also returned it. The code is now simplified to only return the response. Setting `data` is now done within the public `get()` method, which is now also simplified a bit. Resolves: #103886 Releases: main Change-Id: I975a6ad0c2761afdadadfdc05dfa9c11a47779fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84374 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Marvin Buchmann <marvin.buchmann@typo3.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- May 22, 2024
-
-
Christian Kuhn authored
Shuffle the permutations of php, dbms, composer/non-composer sets/sys_template and locked/min/max for ac tests around to reduce job count and still catch lots of different combinations. Resolves: #103876 Related: #103869 Releases: main Change-Id: I5b2082f59f2890afd02890aaf2a2622ebcd09401 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84345 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- May 21, 2024
-
-
Stefan Bürk authored
With change #103465 a couple of code integrity checks based on the `nikic/php-parser` have been combined into one file scanning script. The goal is to collect the information per visitor type over all files in a internal visitor state, to output per visitor result after all php file have been scanned. However, the visitor message state is reset for each file with the call of `startProcessing()` method within `AbstractPhpIntegrityChecker`, thus keeping only the result of the last error. This change removes the message reset from the the `startProcessing()` method to keep all error, thus displaying all errors in one go. Resolves: #103868 Related: #103465 Releases: main Change-Id: I96395ff648f39fed7e8216e2c32026a3071a41fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84333 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com>
-
Christian Kuhn authored
Less jobs while keeping general pipeline times low. * Simplify runner cache configuration * sqlite pre-merge 3 instead of 5 jobs * sqlite nightly 4 instead of 6 jobs * merge checkIntegrityPhp to general integrity job * merge checkGruntClean to general js job * merge php lint jobs into one * avoid composerInstall for unitJavascript * merge acceptance install jobs into less jobs Note backports are similar but deviate in details. Change-Id: I832543e002824977a98d3ffb35c3d08355b1f5be Resolves: #103869 Releases: main, 12.4, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84336 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Ayke Halder authored
Use all available CPUs with `Build/Scripts/runTests.sh -s lintPhp`. Note podman CI is configured with a cpu-share to prevent starving other jobs when one is greedy, so this change is ok with CI, too. Resolves: #103864 Related: #103851 Related: #102385 Releases: main, 12.4, 11.5 Change-Id: I1cb7079f119677b36d6f4004398ae24bd8c5d284 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84286 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- May 17, 2024
-
-
Wouter Wolters authored
Use parallel runner to use more than 1 CPU. composer require --dev friendsofphp/php-cs-fixer:^3.57.1 Resolves: #103851 Releases: main, 12.4, 11.5 Change-Id: I59b5e2566a385792cad1b6c11b9b84b63fd21b98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84284 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
This commit fixes an long standing typo in the `dataset` of the delete buttons in the record list. `l10parent` is now correctly named `l10nparent`. Resolves: #103852 Releases: main Change-Id: Ibd2bb8425ef502a9b8ca255a48359b8181222dba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84287 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com>
-
- May 16, 2024
-
-
Anja Leichsenring authored
With one traverser class and several checkers all necessary checks can be executed within one CI job, which saves time and resources. By feeding all checkers with the same set of files, we can be safe not to lose any files that should be checked. Resolves: #103465 Releases: main Change-Id: I4a2f54c6fac37177c8387a999f5e60102951eba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83568 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- May 14, 2024
-
-
Benjamin Franzke authored
Encode non prepared output of BackendUtility::getRecordTitle. The string returned by getRecordTitle is only HTML encoded if the third parameter (`$prep`) is set to true, ensure that non-prepared usages are encoded on render. Resolves: #103782 Releases: main, 13.1, 12.4, 11.5 Change-Id: I96b9530d118a21163d6679ebf7120aa40c7ac7b6 Security-Bulletin: TYPO3-CORE-SA-2024-008 Security-References: CVE-2024-34356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84265 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- May 13, 2024
-
-
Benjamin Franzke authored
When a content element (CE) gets edited or the visibility is toggled, the page module is reloaded with an anchor in the URL to scroll to the content element that was updated. After #103381 it was not possible anymore to click the "+ Content" button above such CE. The reason is that a pseudo element `:target:before` is generated with a specific height and margin to overcome the height of the floating module docheader, overlaying the CE action button. In the patch mentioned before, `overflow: hidden` was removed to make the `box-shadow` of the CE visible, finally causing this bug. To solve this issue the pseudo element add it #97036 is replaced by the CSS option scroll-padding-top. It incorperates the maximum docheader size plus a slight margin that is slightly lower than the grid margin – but not equal to – to move shadows of adjacent elements out of sight. Resolves: #103672 Related: #103381 Related: #97036 Releases: main, 12.4 Change-Id: I8d5c9eadd45e5507e39b1fb728de65d31c1d6689 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83998 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
André Buchmann <andy.schliesser@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Stefan Bürk authored
New core-testing-* images has been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2][3] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below - at least for the phpXY images. * core-testing-php82: No change required, patchlevel image version change only and pulled on gitlab runner already. * core-testing-php83: No change required, patchlevel image version change only and pulled on gitlab runner already. * core-testing-apache24: Minor version release thus raising version required. * core-testing-nodejs22: Minor version release thus raising version required. * core-testing-nodejs22-chrome: Minor version release thus raising version required. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/df1e05ed52e724e0934e552c214395930022413b [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/f754d7fbd2c3cbed98296c8a772869362487d073 [3] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/4f93c5e93eb4e00fc936c13280918e60e62be567 Resolves: #103821 Releases: main, 12.4 Change-Id: I085cc0ce80682dfd009e5648f236974a380b8176 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84214 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 10, 2024
-
-
Willi Wehmeier authored
The add widget modal has a cancel button on the bottom of the modal now to match the other modal windows in the backend. Resolves: #103787 Releases: main, 12.4 Change-Id: I0c2c970b1148dfddadff1c3722d04dfcc939a69d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84142 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
- May 08, 2024
-
-
Andreas Kienast authored
The containers used in the backend module of EXT:styleguide are now based on flex boxes and don't use absolute positioning anymore. This enabled the possibility to scroll when the navigation needs more space than the actual content and also fixes positioning in right-to-left scenarios. Resolves: #103794 Releases: main Change-Id: Ie3fcbf7f7141bf16749dc66b45e185168e469260 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84147 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com>
-
- May 03, 2024
-
-
Andreas Kienast authored
The module `@typo3/backend/element/table-wizard-element` is tightly coupled to FormEngine's `TextTableElement`, therefore said module is moved to the FormEngine namespace. Additionally, the element gets renamed to `typo3-formengine-table-wizard`. Resolves: #103725 Releases: main, 12.4 Change-Id: I1c020a4ec6045007ab4c1f42289fe0a9c842f794 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84022 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Nedbal authored
Newer rollup major versions feature optimizations in build output. The rollup source files are now natively parsed as ESM modules by NodeJS. Earlier rollup versions implicitly transpiled ESM to CJS and allowed a mixture of ESM and CJS imports (both `import` statements and `require()` calls) in one module. With the switch to ESM-only modules we now make use of `createRequire` utility method when node-require resolution is needed for CJS path lookups. Since our main project (Build/) is still in CJS mode by default (for grunt), we apply a sub-project module type overwrite for the Build/rollup/ folder via Build/rollup/package.json to ensure rollup configuration runs in native ESM mode. See https://nodejs.org/docs/latest-v18.x/api/packages.html > Node.js will treat the following as ES modules when passed to node as > the initial input, or when referenced by import statements or import() > expressions: > […] > * Files with a .js extension when the nearest parent package.json ...
-
Benjamin Franzke authored
The node version used for building TYPO3 assets is raised to 22.0. See https://nodejs.org/en/blog/announcements/v22-release-announce for further details. Resolves: #103780 Releases: main, 12.4 Change-Id: Ibc5b8c88ca5baedb7ae500adb5ef26a33617df4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84103 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- May 02, 2024
-
-
Willi Wehmeier authored
The clear-input button now has a proper title and additionally an aria-label to guide visually impaired users. The button isn't read out by screenreaders when navigating the site linearly (due to tabindex="-1") but when hold-pressing the button with the mouse pointer, a screenreader will search for a human readable label. We therefore add an aria-label attribute. The title attribute is added for sighted users but will be ignored by screenreaders since it's value equals the value of the aria-label attribute. Resolves: #103417 Releases: main, 12.4 Change-Id: I4cbbe5200476a7d84ef1d675911ddd51f5899e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83501 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
- Apr 30, 2024
-
-
Frank Naegler authored
This patch adjusts the flash message and notifications elements by removing the h4 tag to prevent incorrect header flow throughout the content structure, allowing for better flexibility based on different use cases. Resolves: #103762 Releases: main, 12.4 Change-Id: Ide330150145d5c4965410fbf61973ef682bb96b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84082 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com>
-
Frank Naegler authored
This patch adjusts the infobox/callout element by removing the h4 tag to prevent incorrect ordering in the content structure, allowing for better flexibility based on different use cases. Resolves: #103761 Releases: main, 12.4 Change-Id: I2556ea0df0e55ffcdf752c9c0574b843ffea44ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84081 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com>
-
- Apr 29, 2024
-
-
Jasmina Ließmann authored
The title of the linked page was missing a hover style, which is now ensured with this patch. An appropriate link title is also added. Resolves: #103715 Releases: main, 12.4 Change-Id: I4ec60ef43fd7ced6cdc5ede88445931a37e12c3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84011 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
- Apr 28, 2024
-
-
Andreas Kienast authored
With the update of Bootstrap to v5.3, the implementation of progress bars has changed for accessibility reasons [1]. This commit updates all usages of progress bars to the new markup. [1] https://getbootstrap.com/docs/5.3/migration/#progress-bars Resolves: #103718 Releases: main, 12.4 Change-Id: I208e3561b4943e382caa09e23e75d350bd702a6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84014 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su>
-
- Apr 27, 2024
-
-
Jasmina Ließmann authored
As in the backend module "Configuration", search results can be displayed as badges next to the search input field. When the search input field is displayed with a label instead of placeholder text, the badge was displayed out of place. This patch aligns the badge to the search input field. In addition, the search field now takes up full width for small breakpoints. Resolves: #103716 Releases: main Change-Id: I322b4ab4c62823fa6dcf9d00fc30bc8671c57f09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84013 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
- Apr 26, 2024
-
-
Benjamin Kott authored
Both extensions core and linkvalidator do not ship css files. PostCSS cannot find any files to process here. Resolves: #103731 Releases: main, 12.4 Change-Id: Ibdfcecb4dd813b04e89bab5d2fcfe3a55b0bf4b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84033 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org>
-
Benjamin Kott authored
We're enhancing our backend by introducing a refined system for shadows. The default and strong shadows remain for simple components, while tooltips, flyouts, dialogs, and windows have dedicated ones. This streamlines shadow definitions across elements, ensuring consistency. Shadows support both light and dark modes for visibility across all settings. Resolves: #103726 Releases: main Change-Id: Id02122a9f48833df03e28613642499b63c339b45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84019 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com>
-
Benjamin Franzke authored
Provide a new (default) EXT:styleguide frontend generator that uses site set infrastructure provided by #103437, #103439 and #103522. The old sys_template-root based renderer is preserved and tested independently Resolves: #103034 Related: #103437 Related: #103439 Related: #103522 Releases: main Change-Id: I53c986d7a47c8c2687b2a240410f9d4130fbae4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83696 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
- Apr 25, 2024
-
-
Willi Wehmeier authored
The modal form to rename a file needs a proper label for the filename input field. Resolves: #103724 Releases: main, 12.4 Change-Id: I29018d288ced1de6001d38b841ef37a1231f7394 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84021 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Kott authored
We're currently in a mixed mode where some components support dark mode, while others don't. To facilitate the migration of components currently incompatible with dark mode, we're setting the default to light mode for now. This allows us to gradually migrate components and enable the dark mode switch once both a component and its context are ready for it. Resolves: #103723 Releases: main Change-Id: I39e31d9b7170ac5592f58afe9f9dced0fd14c4c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84020 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Apr 24, 2024
-
-
Andreas Kienast authored
The grunt module `grunt-newer` was introduced with #90200 to help improving build times on consecutive single builds by running tasks on changed files only. This is nowadays not required anymore in JS build context, as it's possible in TypeScript to compile changed files only, which is already incorporated for quite a while. Therefore, the usage of `newer` is now removed in this context. However, to avoid running `terser` multiple times on the same, previously compiled files, the directory `Build/JavaScript` now gets removed before each TypeScript compilation. The postcss calculation is fast enough to not require grunt-newer at all, therefore grunt-newer is dropped here as well. Executed commands: npm remove grunt-newer Resolves: #103712 Releases: main, 12.4 Change-Id: I1c6b88945a45cb9a394a2beaa2ec8198865880b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84006 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- Apr 23, 2024
-
-
Andreas Nedbal authored
In the current frontend tooling, we invoke Rollup twice: * via grunt-rollup to build library modules * via the command line to build everything related to CKEditor This commit gets rid of the first way and moves the library compilation to a JS-backed configuration as well, so we can get rid of a grunt package and also unify the tooling a bit. We also make use of @rollup/plugin-terser instead of the deprecated rollup-plugin-terser module that was used in ckeditor build before. To match the new behaviour, the "exec:ckeditor" task also was renamed to "exec:rollup". Executed commands: npm remove grunt-rollup npm remove rollup-plugin-terser npm install @rollup/plugin-terser --save-dev npm run build Resolves: #103686 Releases: main, 12.4 Change-Id: I8057dcceae2d039c637c6db68cf51b3ef1f12406 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83942 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-