- Oct 22, 2020
-
-
Benni Mack authored
The RedirectService should have a ServerRequestInterface object that can properly set up TSFE when linking to pages. Resolves: #92666 Releases: master Change-Id: I39fddb224396410bfc0bffb229ea16eaeef5adeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66140 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Benni Mack authored
This is a pre-patch as a cleanup to extract the file system related functionality and the "zip file" related functionality in separate classes, to remove further cross-dependencies between PHP classes in Extension Manager code. Resolves: #92669 Releases: master Change-Id: I55710f4d4354b1ea239738d219ca778e74306396 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66189 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
* Merge import .csv files and rename file to "ImportDefault.csv" * Extend assert .csv files to contain all tables in the same order as the import files. This allows to easily diff the before/after files and to get a have overview if viewing them side-by-side. Additionally, this shows unwanted side effects from patches more easily. Change-Id: I9a5c37de4492d34903f9bda1b398884e6f6ac7e4 Resolves: #92677 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66245 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Georg Ringer authored
The marker ###POSTJSMARKER### is not replaced anymore and can be removed. Resolves: #92673 Releases: master Change-Id: Iddc2d7c0ee9d0c36383c179143f06e7440e2e67d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66250 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Danilo Caccialanza authored
Consider the case you have N workspaces and some BE "advanced users" and "limited users” having access to a workspace. "Advanced users" have access to all workspace’s page tree and also LIVE workspace, in this case everything works correctly. "Limited users" have access only to a limited page tree of the workspace and cannot access to LIVE workspace. When the user logs in, the page tree doesn’t show up and the system indicate the following error: "Page tree error Got unexpected response from the server. Please check logs for details" This patch fixes the "limited user" problem. Resolves: #91918 Resolves: #91594 Releases: master, 10.4 Change-Id: I0029add1940504ad1d274eac4ab02ff2af69f96d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65755 Tested-by:
Danilo Caccialanza <supercaccia@bluewin.ch> Tested-by:
cbugada <christian.bugada@ti.ch> Tested-by:
-
Oliver Hader authored
Using view helper `f:form.select.optgroup` with argument `disabled` throws PHP type error, since array is expected, but string given. Resolves: #92656 Releases: master, 10.4, 9.5 Change-Id: I7f1fd3a1f81c7befb15e4657c9e59ff862e663e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66242 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
Markus Klein authored
With #86219 the migration from sys_domain records to Sites was faulty. Formerly all known domain records were inspected in order to decide whether a domain was local or not. This was changed to an invalid check covering the current site only. This change now again validates all known sites. Resolves: #92626 Related: #86219 Releases: master, 10.4, 9.5 Change-Id: I2ce4dc0e8891ee2b438c42d20fff10428fafa7e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66227 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Georg Ringer authored
The attribute alt is not allowed for the element "textarea". Resolves: #92633 Releases: master, 10.4 Change-Id: I70790e529a270300f73d3b22cb598e2d8197e07c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66225 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
-
- Oct 21, 2020
-
-
Oliver Bartsch authored
The paste content button in the page module was not accessible via the keyboard because of it being an anchor element without a `href` attribute (so no tabstop). The button is therefore now changed to use a button tag, allowing it to be accessed via the keyboard. Resolves: #92653 Releases: master, 10.4 Change-Id: Ied665d2899b6364046ff7920dfa9dcb006de0d87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66238 Reviewed-by:
-
Georg Ringer authored
The attribute href is not allowed on spans. Resolves: #92635 Releases: master, 10.4 Change-Id: I34079953da58784ca7384c94f1839b8941c5cd1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66226 Tested-by:
-
Oliver Bartsch authored
Since the column is using the `invertStateDisplay` the label must take this into account otherwise the display in e.g. single-table-view is wrong. Resolves: #92654 Releases: master, 10.4 Change-Id: I022efb771e0fce393f29dff86543f1ca6a8297a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66240 Tested-by:
-
Georg Ringer authored
Attribute alt is not allowed on span elements. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/span#Attributes Resolves: #92632 Releases: master, 10.4 Change-Id: If4e5762cf95535130b373d4e297a28b547686702 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66223 Tested-by:
-
Georg Ringer authored
Instead of using the shorthand ternary operator use a regular ternary operator to avoid an invalid HTML attribute '1'. Resolves: #92640 Releases: master, 10.4 Change-Id: Ibf14dfaafd34158c71d71c99ddbc70d04795f3d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66229 Tested-by:
-
Oliver Bartsch authored
All iframes must contain a description to allow screen readers to identify the content or purpose of them. Therefore all iframes are now equipped with a proper title attribute, describing their content. Resolves: #92646 Releases: master, 10.4 Change-Id: I6af29e2587f51c3800c8b7590ed91f57e4fafd20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66235 Tested-by:
-
Georg Ringer authored
The capslock information is improved by the following changes: - Change the position to avoid covering the clear icon - Add the role="status" to improve the accessibility - Clear the alt attribute as it contains the same information as the title attribute. Resolves: #92645 Releases: master Change-Id: I676dd76627d1de2b765913b239ea1d21e1d55e17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66234 Reviewed-by:
-
Georg Ringer authored
Resolves: #92642 Releases: master, 10.4 Change-Id: Ic2012c25f15ae460ec03aa78f07c190e988351f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66230 Tested-by:
-
Georg Ringer authored
A '"' is too much in the record list. Resolves: #92638 Releases: master Change-Id: I00eb74b3376d42ddf614d389d3bf9336e225d20c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66228 Tested-by:
-
Georg Ringer authored
Related: #92529 Resolves: #92617 Releases: master Change-Id: I6fed72dae3574f1350b53a7fb962dde4141d33f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66217 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Alexander Schnitzler authored
Using controller aliases, i.e. the controller name only, for plugin registration has been deprecated and is now removed. \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin() and similar methods do expect fully qualified class names instead. Controller aliases are derived from the class name. Releases: master Resolves: #92609 Change-Id: I06186760dbec8ed5c639066a4e3a835a65bf4673 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64671 Tested-by:
-
Christian Kuhn authored
Bugfix release brings a deprecation fix that is going to be removed in master. composer require --dev typo3/cms-styleguide ~11.0.1 Resolves: #92614 Related: #92609 Releases: master Change-Id: I553824de255f9c1136e96df9b28f6108feecc5c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66216 Tested-by:
-
- Oct 20, 2020
-
-
Oliver Bartsch authored
Since over a decade (according to the timestamp), GeneralUtility::uniqueList() does not allow an array as first argument and furthermore doesn't use the second parameter anymore. Since then, both have thrown an `InvalidArgumentException`. Furthermore, this method does not belong to GeneralUtility at all. Therefore this method is now deprecated and a new one, using proper type hints, a return type, no second argument and a correct PHPDoc is added to StringUtility. All usages in the core are replaced with the new method, ensuring proper types. Resolves: #92607 Releases: master Change-Id: Ibca5c2c312258dfc63c74f0ff11408d11226f7b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66190 Tested-by:
-
Georg Ringer authored
The method :php`\TYPO3\CMS\Core\Utility\GeneralUtility::validEmail` is used to validate a given email address through the core and TYPO3 extensions. The validation can now be configured by providing the used validators to be used in the LocalConfiguration.php or AdditionalConfiguration.php. Example: $GLOBALS['TYPO3_CONF_VARS']['MAIL']['validators'] = [ \Egulias\EmailValidator\Validation\RFCValidation::class, \Egulias\EmailValidator\Validation\DNSCheckValidation::class' ]; The RFCValidation validator is still be used as default. Furthermore, following validators are available: - Egulias\EmailValidator\Validation\DNSCheckValidation - Egulias\EmailValidator\Validation\SpoofCheckValidation - Egulias\EmailValidator\Validation\NoRFCWarningsValidation It is also possible to provide own validators which must implement the Egulias\EmailValidator\Validation\EmailValidation interface. If multiple validators are provided, each validator must return TRUE. Resolves: #92531 Releases: master Change-Id: I9c5a0573c2f9bff56bf869dc221a2c0ffd75417b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66179 Tested-by: -
Daniel Goerz authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92578 Change-Id: I4532bbbd9ed907fe364f56caf6f330feda7c32bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66157 Tested-by:
-
Alexander Schnitzler authored
All fluid widgets and the core widget functionality has been removed due to its complexity and the fact that fluid widgets did and do bring more trouble than benefit. The most commonly used paginate widget can be replaced with a recently introduced new core api. Examples of how to use it can be found in the core itself. Extensions be_user and extensionmanager did use the pagination widget before and do now use the core pagination api. Custom widgets and their functionality have to be reimplemented in another way. The usual way to replace a widget is to put its functionality into the controller action and move the widgets query params into the query param namespace of the plugin that formerly rendered the widget. Releases: master Resolves: #92529 Change-Id: I3342214d467a85dfcd6d684f4a7678f70fd67146 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66095 Tested-by:
-
Anja Leichsenring authored
By unsetting the PHP version in config platform.php, we ensure the highest possible packages for the currently available PHP version are installed. Resolves: #92335 Related: #92251 Releases: master, 10.4 Change-Id: Id6359014aa950bd65622e7fd8dac26313a6778c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65754 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Oct 19, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92579 Change-Id: I488edd51d9af44107969335b8f955cb69734c42b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66158 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christoph Lehmann authored
This commit adds the missing field forget_header to the upgrade wizard. The field is available in 9.5 and in 10.4 as "settings.forgot_header" and thus needs to be migrated. Resolves: #92585 Releases: master, 10.4 Change-Id: Icb55a962873042aab946cc227e2374675eb8c98e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66166 Tested-by:
-
Benni Mack authored
When the admin panel is active, the rendered page should always be marked as "preview mode" so TSFE will later set TSFE->no_cache which then allows to not store anything in the Page cache. Resolves: #92242 Releases: master, 10.4, 9.5 Change-Id: I6ef326d0a65b3b2c0dfdec7bf2bc29831c267b10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66156 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Daniel Goerz authored
BackendUtility::wrapClickMenuOnIcon() has a boolean flag to let the method return an array with tag parameters instead of a fully build HTML tag as string. As this are two completely different things and cause problems when analysing return types it should not be done in the same method. Calling BackendUtility::wrapClickMenuOnIcon() with the 7th and last argument $returnTagParameters set to true has been deprecated alongside the 5th and 6th arguments that are already unused. Resolves: #92583 Releases: master Change-Id: Ia536aa3a52085e4ebe7956997b505047340102e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66161 Tested-by:
-
Benni Mack authored
In previous TYPO3 versions (due to historic reasons) the frontend groups were always resolved within TSFE when a page and the rootline was resolved. However, this left the actual Frontend User, which is initialized at the very beginning of a frontend request, in an incomplete state: A user was (correctly) found and "logged in", but the groups were resolved at a later point. This was due to the fact that the Admin Panel allowed to "include hidden records" which also considered fe_groups, and thus be set later-on. This change now moved the resolving of the groups (and setting the right frontend.user aspect) right after the user resolving. This means that the groups are now available much earlier, and not bound to the TSFE instance anymore, allowing to use Middlewares much more professionally without depending on TSFE for custom Routing / APIs. Future options: It would even be possible to filter out PageRouter pages that are not available, which would make the Router itself faster. Resolves: #92562 Releases: master Change-Id: Ia522697433049b0e549f3c65caf6757053ff37e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66066 Tested-by:
-
Tymoteusz Motylewski authored
FrontendUserRepository::fetchUserInformationByEmail now returns empty array when there is no user with given email. Resolves: #92601 Releases: master, 10.4, 9.5 Change-Id: Iad1d862de9e7c59879b4cfebdf15bc0d8e7fde55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66174 Tested-by:
-
Benni Mack authored
In the past, the API methods: * PageRepository->versionOL() * BackendUtility::workspaceOL() returned the PID of the moved record in a workspace in the field _ORIG_PID and the live record value in "pid". The methods "fixVersioningPid()" were used to return the moved PID (of the versioned records) and set the "_ORIG_PID" to the value of the live record. This inconsistency can be overcome by simply using workspaceOL returning the newly moved location as "pid" and keep the "_ORIG_pid" of the live record for later purposes. This way, fixVersioningPid is not needed anymore, if workspaceOL/versionOL is applied. TYPO3 Core is not using the fixVersioningPid methods anymore now and they are marked as deprecated. As this is a breaking change ("behavior of overlay and value of _ORIG_pid") an RST explains the new behavior. Resolves: #92598 Releases: master Change-Id: I618d282d490b386e1a75caae3ab657f1605e3cb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66169 Tested-by: -
Mohsin Khan authored
Add the possibility to provide custom Error messages to the RegularExpressionValidator. In some cases the default message will not suffice in supporting the user to fill in a valid value. It is now possible to equip a validator with static or translatable messages, like e.g. "Invalid Mobile Phone Number Format". Resolves: #91719 Releases: master Change-Id: Ib423202feb6aa043cb3d48b3c805db3044ffc416 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64940 Tested-by:
-
Christian Kuhn authored
This drops all left over calls that suppress the refindex integrity checks in DataHandler functional tests, except those within ManyToMany tests: This area needs more work before the reference index can be fixed. Two bugs indirectly related to the reference index are fixed along the way, those can't be separated as standalone patches: * When a translated page is deleted in workspaces, the DataHandler deleted live records on this page, too. This is fixed by adding a proper db restriction. This also fixes the reference index state in this scenario. * When publishing a delete placeholder that has inline children, workspace delete placeholders are created for the children, which is wrong. This happens because the user is not set to the live workspace during the publish operation. Temporarily changing the user workspace to live not only fixes the reference index, but does not create the bogus inline children placeholder records anymore, too. Change-Id: I897f6a93b1d5a579bfa5c52e93e65119a018e4aa Resolves: #92589 Related: #92467 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66152 Tested-by:
David Steeb <david.steeb@b13.com> Reviewed-by:
-
Benni Mack authored
Currently, Extension Manager allows to upload files in t3x format, via the GUI, which was actively disabled by extensions.typo3.org a few years ago. The Core does not handle t3x files by users anymore, and currently only handles t3x files within the TerRemote class now. Resolves: #92590 Releases: master Change-Id: I2976487f2b6c96b4a9bf1e1a64dfe1265314fa65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66171 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92581 Change-Id: I2c8bdca108c75e0d8eb862fec66630e9dca1a1ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66160 Tested-by:
-
Oliver Hader authored
Resolves: #92597 Related: #90234 Releases: master, 10.4 Change-Id: I2b98f6ad8cc707231b5f8981954cb963db903864 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66173 Tested-by:
-
Christian Kuhn authored
The 'Make textareas resizable' setting is quite ancient. The patch drops this option from the user settings and enables 'growing' text areas by default. To prevent text areas from growing indefinitely, the user setting 'max height' with a default of 500px is kept. Change-Id: I0497c6823b96b077c05d25a2e63ae58c079400b7 Resolves: #92582 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66162 Tested-by:
-
Benni Mack authored
Since the move placeholder code is gone, some variables / methods are still "cryptic" and some comments are outdated. This change modifies some places to make the code more readable for its current state. In addition, the RootlineUtility code is now more focussed and explained on the move pointer retrieval. Resolves: #92592 Releases: master Change-Id: I651bcad138cffc9fc0bdfe2d21a9a7666b93e4ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66172 Tested-by:
-
Benni Mack authored
The "cMR" flag is removed, which indicated some functionality called "condensed mode" which existed in TYPO3 v3+v4, and was removed some time in TYPO3 v4.x development. The flag serves no purpose for over a decade now and is removed. Resolves: #92591 Releases: master Change-Id: Ib9a26293009d32a8d8ac67fded589a828483606e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66153 Tested-by:
-
