- Jun 11, 2024
-
-
Jochen Roth authored
Currently, Services.yaml files are used to register a services as public. This has been changed throughout the core (where possible) to use the PHP attribute "Autoconfigure" to have all options in one place. Resolves: #104023 Releases: main Change-Id: I3165806fb635c17d10b42f268cc2f0cd194dde56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84548 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Andreas Kienast authored
Resolves: #104050 Releases: main Change-Id: Ie5e3ce1af90d6d28de19dc9d5fdb76c5b49b73c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84612 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Jasmina Ließmann authored
The "About" module lists, among other things, all backend modules available in the system. If an admin or editor does not have access to a module, it will not be displayed in the "About" module list. Some of the modules listed contained a note that the module was only accessible to administrators. With the introduction of the system maintainer role, this note is no longer applicable. In addition, this note was missing for some modules that cannot be made accessible to the editor at all (e.g. "Access" module). If an admin/system maintainer wants to check which backend modules an editor can access, he usually switches to the backend user (via the "Backend Users" backend module). Calling the "About" module is not sufficient at this point, as settings in backend user groups and the backend user accounts themselves also influence whether a backend user can access a backend module or not. For this reason, this note in the "About" module is now being removed. Resolves: #104040 Releases: main, 12.4 Change-Id: Ib27581a9f1fc48985d42550622caffcf0615a0d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84610 Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
Lina Wolf authored
No backport is needed as only the main version of the changelog is rendered. Resolves: #104026 Releases: main Change-Id: I47e30da3b0ad0c372313419c84c1df4820a37fef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84615 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Stefan Bürk authored
The nightly CI run recently revealed a regression within phpunit [1] which has been fixed meanwhile upstream [2] by Sebastian Bergmann. This change raises phpunit to the bugfix version and the conflict is removed. Used command(s): composer require --dev "phpunit/phpunit":"^11.2.1" [1] https://github.com/sebastianbergmann/phpunit/issues/5857 [2] https://github.com/sebastianbergmann/phpunit/releases/tag/11.2.1 Resolves: #104036 Releases: main Change-Id: I8f83ca4b574d174dc0f13bb4a59ad5f35a905204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84595 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
This commit introduces a new component to render progress bars in a streamlined fashion, addressing common accessibility issues by providing proper aria attributes. The component supports a `max` value and a relative `value` attribute. If `value` is omitted, the progress bar is rendered in an indeterminate state. If `value` is present, an optional `severity` attribute can get passed to visually describe the state of the progress bar. Please note that only successful, warning and error states are supported. Additionally, an optional `label` can get passed, describing the progress bar and its current state. Important note: this component is rather experimental by now and may change in a few details. Until further notice, this component is strictly for internal use only. Resolves: #103767 Releases: main Change-Id: I2a99c10e589482a2972935f49af87119ea899f34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84038 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Benjamin Franzke authored
Avoid redirecting to /typo3/empty, which is not helpful to the context. As long as there is not module context in shared record-edit links, it's best to show the first backend module on close of such a view. Resolves: #104028 Releases: main, 12.4 Change-Id: Ia7d50f4e906e92b7f93b6e444f7b18fafcc1ea1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84573 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Jun 10, 2024
-
-
Garvin Hicking authored
When the configuration for `mod.web_layout.BackendLayouts` contains column definitions with an empty content, this will make both the list view and the normal page view in the backend fail. This makes using the GUI editing of the 'backend_layout' records impossible to be fixed/addressed. This patch now does a more lax check on the 'columns.' array to prevent PHP error notices on invalid array key access. Resolves: #103425 Releases: main, 12.4, 11.5 Change-Id: I68c9b5a1ee8f0a70e3808338aa9dd2ed6f12c882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84538 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
Jasmina Ließmann authored
The "About" backend module provides overviews of the modules available in the system, installed external libraries, authors of installed extensions, as well as general information about TYPO3 and its community. This patch standardizes the appearance of the cards in this module with those from the "Admin Tools" area. In addition, the heading structure has been updated and some headings have been added. In addition, links are now colored blue, similar to those in the "System Information" toolbar element, and email links in the extension authors list were removed because they violated the Content Security Policy. Resolves: #104009 Releases: main Change-Id: Ia3a0811e973edea579e8d66d2f0d7f01e9ded0c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84400 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
Willi Wehmeier authored
The aspect ratio buttons in the image cropping tool have a visible focus state now to make them usable when navigating with the keyboard tab key. Additionally the button can now be pressed with the space and return key. Resolves: #103760 Releases: main, 12.4 Change-Id: Id221daddeee9d5b61497cb74604dbf151d25e3ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84079 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Oliver Bartsch authored
When inserting a record via the element browser, the value argument needs either to be formatted manually or left empty, allowing the element browser to format the identifier automatically. By omitting the value in the `PageBrowser` module, the value is now correctly formatted by the element browser to "pages_<uid>". This makes the "node-action" usable for TCA group fields, which allow more than one record type. The same logic is also used by the `BrowseDatabase` module, which also omits the value argument. Resolves: #103700 Releases: main, 12.4 Change-Id: I80e2cc696d85b5ec83432c35a263b19f9752b0ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84018 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Sandra Erbel authored
Releases: main, 12.4 Resolves: #104024 Change-Id: Ie2ffbbaa4867c1d8f0724a0f2352551599caef59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84547 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Sandra Erbel authored
Releases: main, 12.4 Resolves: #104022 Change-Id: I31703188cd154cd8fec433b4ce47f8acbb93bab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84546 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Rath-Ulrich authored
Resolves: #104016 Releases: main, 12.4 Change-Id: I509554667d6aa5a97a51419ecef79fd60ccb377a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84542 Reviewed-by:
morgane garcia <morgane.garcia@ideative.ch> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
morgane garcia <morgane.garcia@ideative.ch>
-
Stefan Bürk authored
PHPUnit changed the way how double creation is handled internally and now emits an exception if a manually defined `mock class name` should be registered. In some places within the unit tests, manual mock class names have been used, because the names are needed for cross referencing at a later point. For this, different approaches have been used, for example hardcoded MD5 hashes as strings or creating hashes of static values like `md5('1')`, and also reused hashes in different places or in tests using data providers. This now leads to an exception: PHPUnit\Framework\MockObject\Generator\NameAlreadyInUseException The name "b70551b2b2db62b6b15a9bbfcbd50614" is already in use This change mitigates the issue by using `StringUtility::getUniqueId('somePrefix')` as is already done in other places. As a sideeffect, four phpstan baseline entries can be removed. Used command(s): Build/Scripts/runTests.sh -s phpstanGenerateBaseline [1] https://github.com/sebastianbergmann/phpunit/pull/5804 Resolves: #104005 Releases: main, 12.4 Change-Id: Icc558844275c9ae9f67a0e7c20daa318f5ad6b41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84530 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org>
-
Oliver Bartsch authored
A new TSconfig option `mod.web_list.searchLevel.default` is added, which allows to define the default search level for record search. The option expects one of the available level items as value. Those items can already be customized using `mod.web_list.searchLevel.items`. Resolves: #103706 Releases: main Change-Id: I6dc558ec5976d0abc9276bce53255952ed97e843 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84009 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
- Jun 09, 2024
-
-
Stefan Bürk authored
PHPUnit refactored the double creation to support doubling readonly classes [1], thus breaking classes where the class constructor is called with constructor arguments, but calling itself a class method which is mocked using the `onlyMethods()` setup option. This leads now to some internal state setup issue and is reported as `regression` [2] providing steps to reproduce it. This change adds `phpunit 11.2.0` as conflict to the monorepo version to avoid using it in nightly tests for now, until a proper regression fix has been implemented in phpunit. Used command(s): \ cat \ <<< $(jq --indent 1 --tab \ '."conflict" += {"phpunit/phpunit": "11.2.0"}' \ composer.json) > composer.json \ && Build/Scripts/runTests.sh -s composer -- update --lock [1] https://github.com/sebastianbergmann/phpunit/pull/5804 [2] https://github.com/sebastianbergmann/phpunit/issues/5857 Resolves: #104007 Releases: main Change-Id: Ia384ff98a9ea4e318738a48bd9ff8afcc4faff15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84533 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Jun 08, 2024
-
-
Jasmina Ließmann authored
The "Included TypoScript" submodule shows the type of tree child as a badge. This patch adds a missing corresponding language key for the newly introdued site sets. Resolves: #103992 Related: #103437 Releases: main Change-Id: Ia7ef1b7b49f9ca1a6c1859c37a62f0101265f2f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84517 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
Georg Ringer authored
Use ILIKE instead of LIKE for PostgreSQL as this is case insensitive and to be in sync with the ExpressionBuilder. Resolves: #103961 Releases: main, 12.4 Change-Id: I859301554642f0f163e660c6151415ff3d3ba95c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84451 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
- Jun 07, 2024
-
-
Torben Hansen authored
Extbase validators use hardcoded translation keys to display messages when a validated value is not valid. It is however only possible to overwrite the translation keys globally, which in many scenarios is not suitable. It is also not possible to define an individual translation key on property or validator basis, so translated messages can not be individualized for the current usage scope. This feature introduces the possibility to define custom translation keys or a custom message for extbase validators by using validator options. This allows developers to provide individual translation keys for the current usage scope as shown in the example below: ``` 'validator' => 'NotEmpty', 'options' => [ 'nullMessage' => 'LLL:EXT:my_extension/Resources/Private/Language/locallang.xlf:validation.myProperty.notNull', 'emptyMessage' => 'LLL:EXT:my_extension/Resources/Private/Language/locallang.xlf:validation.myProperty.notEmpty', ], ])] protected string $title = ''; ``` This change also deprecates the validator option `errorMessage` of the `RegularExpressionValidator` in favor to the new `message` option. Additionally, 3 unused translation keys in the locallang.xlf file have been removed. Resolves: #102326 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Ie1932c7d51a29ac5655adf2ce226b2bd44a682f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81696 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Thomas Hohn authored
This patch extends the access checks for modules. This is done by checking both the module identifier and potential aliases. Resolves: #103967 Releases: main, 12.4 Change-Id: Ifc534356f75244ccac81b763bd624fe13f68aa72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84478 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Andreas Kienast authored
With the upgrade of alwan to 2.x, CSS was completely overhauled. This snuck in some issue regarding the color previews, where always either a dark or light background was rendered, depending on user configuration. This commit fixes the CSS to use the internal `--color` custom property, which reflects the actual color value. Resolves: #103995 Related: #102735 Releases: main Change-Id: I326498995d2ddea5569f5e9a5c35b3e620f8872a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84522 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com>
-
Julian Hofmann authored
By default, resources are displayed as tiles in listings since TYPO3 v12.1 (#99155). The preferred view mode can be selected by a user and is saved in his uc data. With the new User TSconfig option `options.defaultResourcesViewMode` it's now also possible to define the inital view mode for a user (group). Resolves: #102155 Related: #99155 Releases: main Change-Id: Ibbdf03504b853519a14a360110b51491b916e14f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84508 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Julian Hofmann <info@julian-hofmann.net> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Julian Hofmann <info@julian-hofmann.net> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Charles Krüger authored
A few minor spelling mistakes and uppercase notation is changed with this patch. Releases: main, 12.4, 11.5 Resolves: #103993 Change-Id: Ie71257dcd94e008bff2fd29ca6152152019eedae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84519 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Christian Kuhn authored
The new v12 TypoScript parser works pretty well. It is time to rule out some of its rough edges in v13: In hinsight, the biggest structural issues of the rewrite reside in the IncludeTree structure, which has been oversimplified at some places. One problem is reflected within the BE modules 'TypoScript -> Included TypoScript' and 'Page TSconfig -> Include page TSconfig', which are not as easy to grasp as they could be. Those are essentially a straight view of the created IncludeTree. The patch changes a single decision within these trees: "condition end" token ("[END]" / "[GLOBAL]") have been added to the line stream of the currently given tree object until now, but they should be a dedicated node reflected in the tree. The patch turns "condition stop" into dedicated objects within the tree. This makes BE include tree display more easy to grasp and allows simplified scanning for missing and superfluous condition stop lines in the future. It is also a base for better rendering of the "code view" within the modules. Additionally, condition and condition-else now render their condition tokens in the BE modules, which should help integrators to understand the tree more easily by simplified matching to known parts of TS source. Resolves: #103990 Related: #97816 Related: #102103 Releases: main Change-Id: Ifb375ba321d98a17a372f49a5a096968387893ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84511 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- Jun 06, 2024
-
-
Garvin Hicking authored
The directory to reference removing Documentation-GENERATED-temp breaks out of the current working directory scope and could possibly delete files in a completely unrelated directory. Also, it does not remove the actual temporary files. Resolves: #103989 Releases: main, 12.4, 11.5 Change-Id: I685a398aa0d5abee3177ab3def4e271d493d59ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84513 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Garvin Hicking authored
The use of the backtick operator inside the help output leads to an error message: Build/Scripts/runTests.sh: line 175: --: command not found on macOS (probably others, too). This patch replaces the backticks with normal quotes. Resolves: #103988 Releases: main, 12.4, 11.5 Change-Id: Ib6809dc6943a98e4d45d04f4ec02601e830518cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84512 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
Jochen Roth <rothjochen@gmail.com>
-
- Jun 05, 2024
-
-
Christian Kuhn authored
Constant substitution in TS parser is implemented in ConstantAwareTokenStream. It kicks in by casting the stream to string after existing constants have been set using ConstantAwareTokenStream->setFlatConstants(). To not have a "polluted" stream after setFlatConstants(), the constants are reset using setFlatConstants(null) after use. Ugly. Patch #102742 established a partial solution already by cloning the stream instead. Finish the clone approach to disallow setFlatConstants(null). Add two missing void return annotations at related places along the way. Resolves: #103982 Related: #97816 Related: #102742 Releases: main, 12.4 Change-Id: I964bb40dfa1e29b23f876ba85ad05ba2a94ca6d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84506 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Ziad Abdul Hai authored
Prevent an undefined array key warning in case a non-admin-user save his profile with disabled avatar field, for example with setup.fields.avatar.disabled=1 Resolves: #103873 Releases: main, 12.4 Change-Id: I1c91fb65b8508445928a5ec405b9447f452c1fdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84339 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benjamin Franzke authored
Workaround a PHP issue which will produce an open_basedir restriction warning if `is_dir()` is used on a regular file when the trailing slash is provided. Resolves: #103943 Releases: main, 12.4, 11.5 Change-Id: Iaa83658113ff8abb0ab8051b519f76135effd627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84452 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com>
-
Jasmina Ließmann authored
In single result view of the "Indexing" backend module, the words found on the page are listed in three tables, each sorted by count, frequency and name. This patch removes the tables "Words by top count" and "Words by frequency" and extends the remaining table to sort by table columns "Word", "Word count" and "Frequency". If no words were found, an info box is now displayed. Resolves: #103727 Releases: main Change-Id: I5b11b9b455452bafc969baa5f246f67101a3a02a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84023 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
Garvin Hicking authored
The TYPO3 Contribution Guide lists DDEV as an easy way to get started with a TYPO3-Core legacy-based installation. The installation itself shows a big warning for the "Trusted Host Pattern" mismatch when utilizing https:// for the installation, which many people might do. While the Contribution Guide mentions this as a sidenote, the actual warning can be improved to better reflect the reason and solution. (Note that the installation can actually continue even with this error, but may hint people at this being an installation show-stopper, so it is now stated clearer, that a working host pattern will be actually set and should be adjusted after installation is complete) Resolves: #103959 Related: #88846 Related: #86356 Releases: main, 12.4 Change-Id: I7988a7dad45b53d5b1c8314e1dfdcbc1d8feb6a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84450 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Mathias Bolt Lesniak <mathias.bolt.lesniak@typo3.org> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Marcin Sągol authored
It might not be clear to users how the allowed_languages field works by default when setting permissions for a backend user or group. If no languages are selected from the allowed_languages list, all languages will be available for the given user or group. To make this clearer, a description has been added to explain it straightforwardly. Resolves: #103757 Releases: main, 12.4 Change-Id: If0c0fd9c998f51a0e44617faae3365f2e02bc82e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84078 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de>
-
Christian Kuhn authored
Sometimes - for unknown reasons - a session gets lost in acceptance tests. Tests then hang in BE login waiting for BE load and fail with a timeout. We now catch this timeout and relogin, and also enable cookie debug output to increase chances to fix the real issue. Resolves: #103981 Related: #103086 Releases: main, 12.4, 11.5 Change-Id: I0b10118968933b52523bbee8f8f608db60ad884e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84499 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
Frontend TypoScript 'constants' do support conditions. But constants can not be used within conditions, just like constants in general can not be used within constants. The patch adapts the "new TS parser" ReST to clarify. Resolves: #103953 Related: #97816 Releases: main, 12.4 Change-Id: I0e21a320582f2f0edbde432fe36767540ab7993b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84497 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Garvin Hicking authored
We missed a TypoScript feature with the new parser. Function operator modifier values can use constants: foo = 42 foo := addToList({$my.constant}) The solution is two fold: Until now, the value of a function body was a single T_VALUE token. This is turned into a stream of tokens that can consist of multiple T_VALUE and T_CONSTANT tokens. This is handled in the tokenizers. Secondly, the AST builders need to deal with these token streams now, and take care available constants are hand over to ConstantAwareTokenStream before the stream is cast to string and single functions are evaluated. The BE modules *do* reflect constant substitutions in function modifier bodies, but not in an ideal way. An @todo within the responsible CommentAwareAstBuilder outlines ideas how this could be improved. Note TYPO3 v13 supports constant fallbacks here as well, this syntax feature came with #103671. This works, but is NOT supported in v12: foo := addToList({$my.constant ?? $fallback.constant}) Resolves: #102742 Related: #97816 Related: #103671 Releases: main, 12.4 Change-Id: Ib5e0872fe1ea2b78bd0a7e05caccd9874b5668d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82633 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jun 04, 2024
-
-
Christian Kuhn authored
There is a subtle difference between a PHP error and a dedicated thrown exception: When an object knows it should return something, but can't, because it has not been set up correctly, then the implementation is responsible of throwing a "i'm incomplete" exception: This is not an error in the class, but a wrong set up usage, and this should throw, and should not error out with a return type mismatch error. The patch changes two getters of TS parser related IdentifierFunctionLine to obey this difference and now throws in case it "has been set up incompletely". In this case, an IdentifierFunctionLine is only "complete" after at least an identifier token stream and a function name token has been set: After being fully set up, these two properties must have a value. The object knows this and the two getters now throw an exception instead of failing with a type error. Resolves: #103977 Related: #97816 Releases: main, 12.4 Change-Id: I772d774fbaae3c2ec7ff4c9abc6ef4964254259d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84495 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Add a missing return value in ConstantAwareTokenStream->setFlatConstants(). Resolves: #103976 Related: #97816 Releases: main, 12.4 Change-Id: Ia4d10f846db2bf26f721c5eb03781d3592073a08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84493 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
The 'original value token stream' is a helper used in BE TypoScript modules to render a possible constant substitution. It is enough if the CommentAwareAstBuilder handles this, which is used in those cases: getOriginalValueTokenStream() is only called by fluid as 'child.originalValueTokenStream' when rendering TS trees in the backend. Those use CommentAwareAstBuilder and not "production" AstBuilder. The patch avoids calling setOriginalValueTokenStream() as a minor micro optimization which may also help the garbage collection to clean up some objects more early in FE. Resolves: #103975 Related: #97816 Releases: main, 12.4 Change-Id: Ifa54b36877d5eb1c1d712433efa2d07fd1ad8bd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84491 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Andreas Kienast authored
This commit updates the markup of the `Cards.html` files to make use of containers in the Install Tool to align its cards horizontally to make better use of the available space. Resolves: #103621 Releases: main Change-Id: Icad70957dc2565bc3830e9101d9fea4ce1798104 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83778 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-