- Nov 07, 2020
-
-
Oliver Hader authored
PHP versions 8.0-RC1, 7.4.12, 7.3.24 introduced a different behavior for `stream_wrapper_restore()` and would throw a PHP notice which is mitigated with this phar stream wrapper release. see https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.6 composer require typo3/phar-stream-wrapper:^3.1.6 Resolves: #92789 Releases: master, 10.4, 9.5 Change-Id: Ia2bc9b4fd7f568b9a4390205e1d332050904a15b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66560 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Daniel Siepmann authored
When using renderType textTable for text fields in TCA, the controller will pass the currently stored value to underlying API. This API always expects a string. Most of the time those fields might have null as default in persistence leading to a PHP TypeError. Therefore a check is added which will fall back to empty string as proper default for internal API. Resolves: #92761 Releases: master, 10.4, 9.5 Change-Id: I29ef4076e21a1f93f9b6834afcc163c4041a0909 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66381 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 06, 2020
-
-
Benni Mack authored
The TCA definitions for sys_file.fileinfo and sys_file_metadata.fileinfo were marked "user" but without any database definition, leading to side-effects when automating translations (e.g. in l10nmgr). However, they only provide information (= a virtual field), so the definition should be of type "none". Resolves: #92312 Releases: master, 10.4 Change-Id: I9941e07a304ecade5c8b0de7ce82591178172d68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66378 Tested-by:
Jo Hasenau <info@cybercraft.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92111 Change-Id: I28058d9e9e9886f1156a0124f0b360d9788dfdc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65466 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
manuel_winkelhofer authored
Add autocomplete attributes to Login form and ForgetPasswordForm Inputs Use `autocomplete="email"`, `autocomplete="username"` and `autocomplete="current-password"` for the form fields before logged in. Resolves: #92624 Releases: master Change-Id: Iff12afc08f30e82fd6fafc559c04c51a654c0c1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66312 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Alexander Schnitzler authored
With this patch, Extbase does no longer handle/return extbase responses whose api was defined by the extbase ResponseInterfacer. Instead, Extbase does create a PSR-7 compatible response object and passes it back through the request handling stack. Since PSR-7 requires response objects to be immutable, the response object is no longer accessible as property of class ActionController. It is also no longer accessible through the ControllerContext class. In fact, the response is completely hidden from the user and can no longer be changed. To address this issue, an upcoming patch will enable users to return user controlled responses from within controller actions instead of just returning content strings. User will then be forced to return response objects with the content and all necessary headers, such as the content-type, set. Since the Response class has been deleted, it is no longer usable in user land code. It should be replaced with PSR-7 compatib...
-
Torben Hansen authored
Increased contrast ratio to at least 3:1 for input fields of the class "input-login" and also a box shadow has been added to those elements. Resolves: #92623 Releases: master Change-Id: I9ca741a1a308077bcf05092de52c56133e83d355 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66260 Tested-by:
-
- Nov 05, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #91576 Change-Id: Idb80fced22515fbd25365ff43b64b6618d5cedc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64449 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Olaf Schmidt-Wischhöfer authored
The dropzone for file uploads now uses two <button> tags instead of <div> tags. One for the dropzone itself and the other one for the close button. The dropzone button now has got an `aria-labelledby` attribute pointing to the dropzone title. The close button got an `aria-label` attribute. Both to support screen readers. Resolves: #92680 Releases: master, 10.4 Change-Id: I32ce15dfc8c36c6fbfd17ef993ceacb8e5aaf3e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66270 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
Oliver Bartsch authored
The "select all" and "deselect all" buttons in the "Send to stage" modal in workspaces are now proper button tags. This also allowed to remove the superfluous preventDefault() call in JavaScript. Resolves: #92776 Releases: master, 10.4 Change-Id: I1480ad06df501a4064609e516c8b10d6b4567425 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66453 Tested-by:
-
Christian Kuhn authored
In workspace frontend preview, clicking the "Send to stage" button renders a modal to select mail recipients to notify recipients. The two "Check all" / "Uncheck all" buttons don't work since the click events are not registered in preview mode. The patch adds them. Resolves: #92759 Releases: master, 10.4 Change-Id: I9b97f9a5f476d8abc4f846af297ec60049abcd69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66380 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Nov 04, 2020
-
-
Andreas Fernandez authored
This patch updates @typo3/icons to version 2.x delivering icon sprites. Using icon sprites greatly improves backend performance for several reasons: - A single sprite file contains multiple icons which need to be loaded once only - The DOM is reduced as it's not necessary to load SVG icons inline anymore to apply styling Todo for a later patch: - Replace aliases with "real" icon identifiers Resolves: #92689 Releases: master, 10.4 Change-Id: Ib3018c4e7f5471274e10c261438792b530c77cde Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66094 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Anja Leichsenring authored
This reverts commit 605b3e51. Reason for revert: fails on mssql Change-Id: Ia576730f34347716d732c92d904288019ed4a4b8 Resolves: #92773 Reverts: #87655 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66395 Tested-by:
-
Benni Mack authored
The BootstrapInterface was used in the original design to allow interchangeability, but was never flexible enough and much bound to cObj to have any effect. The interface was marked as internal in previous TYPO3 versions and is removed. Analysis throughout Extbase extensions in TER have shown that e.g. TypoScript references use the Bootstrap class directly. Resolves: #92767 Releases: master Change-Id: I2514af70d760e9affda8f3150560440c3d842337 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66416 Tested-by:
-
Oliver Bartsch authored
When dragging content elements in page module, the colPos value of the dragged element is updated based on the dropped area. A drop area is a table cell `td` in which the elements are placed as `div`. The cell itself has the colPos set via a data attribute. This means moving an element (`div`) to another cell (`td`), the element gets updated with the colPos of the new cell. This did not work if `defLangBinding` was activated because all elements are then assigned to separate cells which missed the colPos information completely. The colPos information is now added to all cells in the `defLangBinding` view. Resolves: #92454 Releases: master, 10.4, 9.5 Change-Id: I1ab5cb0b3dd5574b6d3397dc52397365dc59d1ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66015 Tested-by:
-
- Nov 03, 2020
-
-
Elias Häußler authored
Slug fields currently only support slug recreation if the given generator fields are directly visible in the backend. However, this makes it impossible to recreate slugs even if some postModifiers are defined who can take care of successful slug generation. This commit allows slug recreation if at least one postModifier is defined, even if the defined generator fields are not usable for slug generation. Therefore also EditDocumentController was adjusted to not automatically add slug fields to columnsOnly in case postModifiers are defined for this record. Resolves: #89187 Releases: master, 10.4 Change-Id: Ifd50ec106b5b302cea23d37e470eafae840c8993 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61716 Tested-by:
-
Stefan Froemken authored
When using the extbase persistence and setting a custom query with group by statements via $query->statement($statement), calling $query->execute()->count() did not return the right amount of records. Instead the database backend chose the first column of one of the returned records which resulted in the count of a subset of grouped records. To fix this, the database backend needs to build a count query with a distinct statement on all fields that are used for the grouping. Resolves: #87655 Releases: master, 10.4 Change-Id: Ia7ad4535a39f5b285efd9249807b5ddd4725b90c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59641 Tested-by:
Rémy DANIEL <dogawaf@no-log.org> Tested-by:
-
Helmut Hummel authored
To benefit from faster operations and cleaner updates Composer 2 usage is now enforced by requiring ^2.0 of composer-runtime-api. Although currently there is no real code dependency yet to the runtime API introduced for Composer 2, this requirement enforces usage of Composer 2 for all interactions with this package (install/ update). The package is required as dev dependency to still allow "manual" usage of this package for classic installs and make the breaking impact low (composer install --no-dev will still work with Composer 1) For TYPO3 v11 this dependency will likely be a production dependency as well. composer up --lock composer req --dev composer-runtime-api:^2.0 Resolves: #92753 Releases: master, 10.4, 9.5 Change-Id: Ie919c0cf36a0818eea2124bb9623485d3d642066 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66375 Tested-by:
-
- Nov 01, 2020
-
-
Tymoteusz Motylewski authored
This make it easier to debug/monitor cache/lock related issues. Resolves: #92724 Releases: master Change-Id: I045232a988db57a62304d7a8903ed8118ec1f8c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66327 Tested-by:
-
Benni Mack authored
This is a pre-cursor for enhancing Backend Routing in general. This change implements Symfony Routing for Backend Routes (currently based on the "route" GET/POST argument) internally to make use of their compiled routes later-on. This was previously done in a simplified version where only the path was checked against, and most Symfony features were not in use, which we still don't use yet, but more can now be added. When Backend Routing was added in TYPO3 v7, the API was heavily influenced by Symfony but we did not have a lot of experience yet, which we benefitted in TYPO3 v9+ for Frontend Routing. With this experience (and with PSR-15) we can gradually move to a more streamlined and faster API. The proposed solution still works as expected with &route GET parameters, but opens up the door for flexible Route arguments. Resolves: #92723 Releases: master Change-Id: I48475fcb3cc15f99cc102dac36ae15bca9f3032e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66316 Tested-by:
-
Oliver Bartsch authored
The DateTimeAspect which supersedes the superglobals like $GLOBALS['EXEC_TIME'] now properly returns the timestamp as integer. Resolves: #92736 Releases: master Change-Id: Ib16cc1131024bdc208526a57332bec80817e75c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66357 Tested-by:
-
Anja Leichsenring authored
Resolves: #92744 Related: #92335 Releases: master, 10.4 Change-Id: Id003abf300f63096cd521d4a050254736dc919d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66364 Tested-by:
-
- Oct 31, 2020
-
-
Andreas Fernandez authored
With splitting the FormEngine in smaller parts, a regression has been introduced in the behavior of selectMultipleSideBySide. This select type supports "exclusive values" which are mutually exclusively selectable. However, due to a typo in the fetched (non-existent) data attribute, the whole behavior was broken. This patch fixes the typo. Resolves: #92737 Related: #87324 Releases: master, 10.4 Change-Id: Ice5de95c49d81df94ee1a8257ecab3abfe7d21d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66361 Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Andreas Fernandez authored
Resolves: #92739 Related: #92735 Releases: master, 10.4, 9.5 Change-Id: I94dc49ec3ef1c55a565cecab8a4d1553099acefa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66358 Tested-by:
-
- Oct 30, 2020
-
-
Oliver Bartsch authored
The rebuildSlugsForSlugChange function of SlugService updates slugs of sub pages and also creates redirects for them, after changing the slug of their parent page. This process requires to fetch the corresponding site configuration. In cases like changing the slug of a localized root page this throws a SiteNotFoundException, because the site is always mapped to the default page id which can not be determined for localized root pages because their pid is 0. It's therefore necessary to always use the default page id for fetching the site through SiteFinder. Resolves: #92733 Releases: master, 10.4 Change-Id: I8b41647d63d444982b2d2d6f209dea4278034488 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66353 Tested-by:
-
Andreas Fernandez authored
Executed command: composer require --dev friendsofphp/php-cs-fixer:^2.16.7 Resolves: #92735 Releases: master, 10.4, 9.5 Change-Id: I569b5566745b966c23e3f14a943bae38c4b52ca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66354 Tested-by:
-
Olaf Schmidt-Wischhöfer authored
Resolves: #92681 Releases: master, 10.4 Change-Id: Ibd8af66dbcbab596d2f1538e2342092235a98f2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66254 Tested-by:
-
Thorsten Griebenow authored
Add tabindex of -1 to disabled tab links to remove them from the tab keyboard navigation Resolves: #91701 Releases: master Change-Id: Ib8488831b169fb61b8e3a131467cd0cca7666e9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66321 Tested-by:
-
- Oct 29, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92273 Change-Id: Ifb45f980a08efd79f5e3f288e0f20e1ac283e1f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65664 Tested-by:
-
manuel_winkelhofer authored
To announce the buttons correctly when using assistive technologies there needs to be an aria-label, as there will not be a real label attached to the top bar buttons. Resolves: #92667 Releases: master Change-Id: I5cd6eae2da613ba87205835da4d1926b3076c6f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66320 Tested-by:
-
Georg Ringer authored
Remove the upper range from the TCA of the fields imagewidth and imageheight of tt_content. There is no reason to set it to a random number which might have been high 10 years ago. Resolves: #92659 Releases: master, 10.4 Change-Id: I3d7db5b67dbd3d523365eaca63d6c9e7a516c3b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66246 Tested-by:
-
Daniel Siepmann authored
The actual method name is format, not setFormat, that should be respected by changelog docs. Resolves: #92732 Releases: master, 10.4 Change-Id: Iaca271783da78440b973b7afcae41ba62bc1b561 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66352 Tested-by:
-
Alexander Schnitzler authored
JsonView did set content type headers in its render method which is a problem since the view should only be responsible for rendering the content of the to be returned response. The current approach, setting those headers in the action controller, is just a temporary solution until Extbase is capable of handling PSR-7 responses which then makes it superfluous to set headers magically. Instead people will need to set headers manually or use a JsonResponse object instead and let the core handle setting headers further down in the request/response handling stack. Releases: master Resolves: #92692 Change-Id: Idfa417cfd25d7f692dea2e6d6822f1d3a44cb38d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66078 Tested-by:
-
- Oct 28, 2020
-
-
Sybille Peters authored
Information for working with Linkvalidator as editor is added. Resolves: #92718 Releases: master Change-Id: I5c116c4561b91b2f8020f6803f6a1d50cd18a413 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66275 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Chris Müller authored
With the release of v10.4 the changes of master were removed from the changelog. Now it is here again. Resolves: #92730 Releases: master Change-Id: I5a96dbfa3d62c426aba3b3033118bbe2f4379e52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66331 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Georg Ringer authored
Always show the edit button so that users know this functionality. Additionally the element is transformed from an link to an actual button to be accessible for keyboard users. Resolves: #92658 Releases: master Change-Id: I50e4f0aa4d904843a9bd5e2e9fcc20c7f2a971e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66243 Tested-by:
-
Christian Kuhn authored
A couple of not needed assignments throughout the core and a 'too many arguments' fix. Resolves: #92605 Releases: master Change-Id: I883dc2fcc12c72c525bc7a44236cac8311d96f11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66182 Tested-by:
-
Christian Kuhn authored
This reverts commit e6bd4f02. Reason for revert: Firefox acts funny with missing autocomplete. Change-Id: If6ecdbacb4a1cd7f81464f820975dc1508e6564c Reverts: #92619 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66336 Tested-by:
-
Sybille Peters authored
Resolves: #92717 Releases: master Change-Id: Id6aee19c74ff3fe1765d0c2bb9caa91a4d425648 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66267 Tested-by:
-
Mark Leutl authored
This merge request removes the autocomplete attribute of the login button. Resolves: #92619 Releases: master, 10.4 Change-Id: I6a2ba3e82c87f261fa7415f7124c70b657e7d3a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66317 Tested-by:
-
