- Jul 12, 2024
-
-
Christian Kuhn authored
BcryptPasswordHash has an option to set a cost value. The lower barrier used to be identical to PHP constant PASSWORD_BCRYPT_DEFAULT_COST. Tests use the lower barrier to speed up tests. With PHP <8.4, PASSWORD_BCRYPT_DEFAULT_COST is 10, it has been raised to 12 with PHP 8.4. The patch frees our code from access to this constant and hard codes 10 as lower barrier check. This keeps the API as is, and this hash is by default set to 12 already in default options if none are provided. Resolves: #104373 Releases: main, 12.4, 11.5 Change-Id: I4c1e94fdc50aa3075570549ccdd3b81a2de2e98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85236 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
As a PHP 8.4 preparation, phpunit is raised to latest version of current major version. > composer req --dev phpunit/phpunit:^10.5.27 -w Resolves: #104372 Releases: main, 12.4, 11.5 Change-Id: I395b8487bc3aca2dc34d4b7fe86c03d58a7a8709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85233 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Georg Ringer authored
As only `Resources\File` provides the method `setMissing` an additional check is provided - just as on multiple other places in the class. Resolves: #95102 Releases: main, 12.4 Change-Id: I75dc0cb29c3f66e06e9658d9c5cb27da3a6ca816 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85197 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
When using boolean attributes there are two things to consider: 1. The default value must be FALSE 2. Presence of the attribute always means TRUE It's therefore not possible to have a boolean attribute, which defaults to TURE and it's also not possible to set an attribute to FALSE via its value (e.g. "0" or "false). See for reference: https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attributes Therefore, to properly handle the "is writeable" state in the language packs module, the default is set to FALSE an the attribute only gets added (which defines the TRUE state) in case corresponding data attribute is set in the template. Resolves: #104353 Releases: main, 12.4 Change-Id: I82f440ae4fbeba405c35bbfa859804e2bc0660c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85239 Tested-by:
-
Oliver Bartsch authored
The `OtherLanguageThumbnails` field wizard renders thumbnails of each crop variant from the default language for images in translations. However, on the first view, the cropped (processed) image is not created yet, leading to the public url being an absolute url to the `image_processing` route, e.g. "https://example.com/typo3/image/process?token=abc&id=123". This URL can not be used by `getIconHtml()` to create the markup. However the function call is not needed at all, since we can just render the markup directly as no icon is about to be generated. Resolves: #104355 Releases: main, 12.4 Change-Id: Ic624f8fd7114da18e01d7f33a9c8714bc8db026c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85238 Tested-by:
-
Torben Hansen authored
When a CKEditor configuration by intention does not include the `softhyphen` toolbar item, the item is automatically added in `CKEditor5Migrator`. This change removes the forcibly added softhyphen toolbar item, allowing integrators to create a CKEditor configuration that does not include the `softhyphen` toolbar item. Resolves: #103919 Releases: main, 12.4 Change-Id: I72a926a75e5c1b791d90921b0ff4c94eb7e938b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85196 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jul 11, 2024
-
-
Xavier Perseguers authored
When the plugin is configured to use the referrer to redirect after a successful login, it should not honor it when the referrer is the password reset form and the user just updated their password. Resolves: #104214 Resolves: #101581 Related: #21943 Releases: main, 12.4 Change-Id: I6fcf3927de0a7157958c4d20682bfcf5390826c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85195 Reviewed-by:
-
Georg Ringer authored
Extend the identifier used within the DOM by an additional field, as already done in #97042 to make flexform sections within inline child records work. A styleguide example makes it easy to reproduce the edge case. Resolves: #100937 Related: #97042 Releases: main, 12.4 Change-Id: I40120ea13b892c6387833dab444dad86951cf96f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85230 Tested-by:
-
- Jul 10, 2024
-
-
Daniel Siepmann authored
PHP will cast array keys to int if they are valid integers. The code applies htmlspecialchars() on the keys. The function expects a string as first argument, which wouldn't be the case if the actual value would be an int. Therefore the key is casted to a string within the function call to prevent TypeError. Resolves: #104341 Releases: main, 12.4 Change-Id: Ic9aef0fd37f2e883a2a8fa626cfda2e813e3b289 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85194 Tested-by:
-
Garvin Hicking authored
With the introduction of the new filelist functionality, the list view of folders no longer showed their last modification timestamps. Without this information, the list view could no longer sort the whole item list by date. With this patch, the information is now fetched not only for files, but also for folders. Folders and files are sorted on their own, so no file will be sorted in between a list of folders (and vice versa). (Note that for filesystem folders there is only one timestamp, so "last modified" and "created at" will use the same timestamps. Remote folders with their distinct drivers may provide distinguishable information.) Resolves: #100520 Releases: main, 12.4 Change-Id: I4e9ceb597946cc7532b76ec2ee4bec3d52d17fdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85193 Tested-by:
-
Andreas Kienast authored
The flatpickr integration in TYPO3 is configured to use luxon for date time formatting operations, which consumes different format tokens. This leads to the situation that aria labels generated by flatpickr are now broken. This commit changes the option `ariaDateFormat` to luxon's `DDDD` token, which renders a "localized date with full month and weekday", according to [1]. [1] https://moment.github.io/luxon/#/formatting?id=table-of-tokens Resolves: #104342 Releases: main, 12.4 Change-Id: I7902d39209ad59e0c3196db7f906b93533d7b7cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85192 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Jul 09, 2024
-
-
Christian Kuhn authored
Bump dependency to latest 1.0 patch level to gain PHP 8.4 support. Do not raise in composer.json to not disturb existing instances. > composer u lolli42/finediff Resolves: #104340 Related: #104339 Releases: 12.4, 11.5 Change-Id: I8017bc89186ed1496bcaa509978163582857a285 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85184 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Kienast authored
The date time picker module `@typo3/backend/date-time-picker` uses flatpickr, but wasn't aware of it due loose `any` usages. The code is modified to make use of the typings shipped with flatpickr. To solve this long-standing issue, the module identifier is changed from `flatpickr/flatpickr.min` to `flatpickr`, which requires an additional entry in the `JavaScriptModules.php` configuration, but allows to remove a module declaration. Resolves: #104338 Releases: main, 12.4 Change-Id: I3feed53627c639e21e4812855fd4ce2defe91c14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85188 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Stefan Bürk authored
This change adds PHP8.4 as allowed version to the `Build/Scripts/runTests.sh` script as preparation to validate and check the Core and 3rd party libs with PHP8.4 locally. Note that unit tests already revealing deprecation and errors for 3rd party extension which can now be reported and for checked upstream updates. Resolves: #104337 Releases: main, 12.4, 11.5 Change-Id: I76d3e37b393c347173fcdbe874d6a0737fb76d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85179 Tested-by:
-
Daniel Siepmann authored
The menu generation must not reuse the page record from the current page but must use the data from the linked page. This got already fixed for #101883. But that fix didn't take into account that ->createLink() might throw an exception. This is now considered and the state is properly re- initialized also on exceptions. Resolves: #104335 Related: #103582 Related: #101883 Releases: main, 12.4 Change-Id: Ib4c1f1fba68a83dca32a9ffd7ee14c31cf60bab5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85177 Tested-by:
-
Oliver Hader authored
Change-Id: I72e06646233894cfbd8017bef8a5620e17caf32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85174 Tested-by:
-
Oliver Hader authored
Change-Id: I20500c48221bf14b56baef7551a423571883c6a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85173 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Andreas Kienast authored
This commit fixes the event binding on the "Close" action to trigger the correct actions when e.g. the icons within the buttons are clicked. Resolves: #104333 Releases: main, 12.4 Change-Id: I448c0b68de376a1b0e8517cc58c5bf2d2576b662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85172 Tested-by:
-
- Jul 08, 2024
-
-
Georg Ringer authored
Version 7.15 officially supports TypeScript 5.5, which we use since #104189 and therefore eliminates a build-time warning. Also update TypeScript from 5.5.2 to 5.5.3, while at it. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.15 \ @typescript-eslint/parser@^7.15 \ @typescript-eslint/typescript-estree@^7.15 \ typescript@^5.5.3 npm run build-js Resolves: #104317 Related: #104189 Releases: main, 12.4 Change-Id: Ibe242b42ecf9c5e986217a85283174220ae18bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85151 Tested-by:Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Loek Hilgersom authored
Fixes exception in impexp when an extension does not have a value for TCA[tableName][ctrl][rootLevel] Resolves: #104308 Releases: main, 12.4, 11.5 Change-Id: Ia2b8095c35ba6b07827525a65e0dcbb6fa1d060e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85154 Tested-by:
-
- Jul 07, 2024
-
-
Garvin Hicking authored
Similar to #104228 there was another place where the 'actiontype' array key of a history record was checked for 'BE' context, instead of the proper 'usertype'. There should now be no more remaining instances of core usage for 'actiontype' with a 'BE' check. Resolves: #104314 Related: #104228 Related: #98024 Releases: main, 12.4 Change-Id: I1833929d16ecef937ba260fe498e9abdee94b9c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85144 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- Jul 05, 2024
-
-
Oliver Bartsch authored
The debug information of each element in FormEngine now displays the correct field names for FlexForm fields in a container. Additionally, do the container elements itself display the correct (field) name now. Resolves: #104303 Releases: main, 12.4 Change-Id: Ic2a92bc0deea4b3165f4aa77103c56050cb3dc63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85109 Tested-by:
-
- Jul 04, 2024
-
-
Guido Schmechel authored
An example for the addition of multiple CSS classes to editor.config.style will be added to the existing RST files. Resolves: #104310 Releases: main, 12.4 Change-Id: I8a77aae8c402608857b3b7ea690da23f4f8134c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85113 Tested-by:
-
Georg Ringer authored
Use a local variable to remember the path of a file before it is moved and use that in the flash message and log. Resolves: #104194 Releases: main, 12.4 Change-Id: Ib13eb28e5d8674ce1fe3df0ab29a9cd5c3b72c78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85112 Tested-by:
-
- Jul 03, 2024
-
-
Garvin Hicking authored
It is possible in Flexform containers to set a XML configuration that uses the same input field names, but within different sheets. The `FlexFormSectionContainer::render()` method used a HTML DOM id attribute that did not consider the Flexform sheet name, which has lead to the same id attribute being re-used. The JavaScript events (add and delete items from a container) would then fire only on the first instance, but as many times as there were wrongly regarded "duplicate" containers using the same id. This fix introduces another identifier section to the id attribute, containing the Flexform sheet name. This XML attribute is compatible with allowed CSS class names, so no further escaping is done with it, similar to the use of `$flexFormFieldName`. Resolves: #97042 Related: #99947 Releases: main, 12.4 Change-Id: Ic1c81c658b090cb7b9c1a4230c0b4e75c12560dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85097 Tested-by:
-
- Jul 02, 2024
-
-
Stefan Bürk authored
This change modifies the `php-cs-fixer` ruleset and activate two rules related to nullable types. Following options are added: 'nullable_type_declaration' => [ 'syntax' => 'question_mark', ], 'nullable_type_declaration_for_default_null_value' => true, `nullable_type_declaration` ensures to use `?<type>` declaration instead of union type `<type>|null` as a convention for properties, method and return types. For already union types the nullable is added as additional null union type `ObjectOne|ObjectInterface|null`. `nullable_type_declaration_for_default_null_value` ensures to use nullable type declarations to mitigate implicitly nullable method arguments [1] which has been already fixed with a series of dedicated changes. Used command(s): Build/Scripts/runTests.sh -s cgl [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #103751 Releases: main, 12.4, 11.5 Change-Id: Ia790a6757c5fbe92da45298333037c5b5d36575d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85089 Tested-by: -
Georg Ringer authored
Instead of showing outdated versions above the listing of wizards, use the actual version. Resolves: #104289 Releases: main, 12.4 Change-Id: Ife6486978010a7e4b85238722125734abd9c6082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85087 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104284 Releases: main, 12.4, 11.5 Change-Id: Iadea4cde1d3b80962a47ffa4c183a885504bef6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85053 Tested-by:
-
- Jul 01, 2024
-
-
Garvin Hicking authored
When multiple crop variants are defined (for example in EXT:styleguide "Form engine elements - imageManipulation" for "crop_5" with "mobile" and "desktop), the currently selected aspect ratio and the size of the cropping box was only computed based on the first crop variant. This patch uses a wrapping container for each variant and adjusts the JavaScript to operate on that context. The information for the current cropping box size is now also based on this context. Resolves: #103879 Releases: main, 12.4 Change-Id: I38e235ddb5ed5f7463a5f0931608944326097f9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84963 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104278 Releases: main, 12.4, 11.5 Change-Id: Ia3a4bc344b369b8697c88ed14ac06354dd988dce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85041 Tested-by:
-
Christian Reifenscheid authored
This commits adds the following hints: * module classes needs to be set to public * module classes needs to implement the ShortInfoProviderInterface * description on how to add custom page settings * description on how to add custom module settings Resolves: #104242 Releases: main, 12.4 Change-Id: Id495359e007bf09e38a80bc1097c95946f964217 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84962 Tested-by:
-
Stefan Bürk authored
Apply the latest rules of php-cs-fixer for both fixer (code and header-comment) also in the `Build/Scripts` folder. The Build folder is now added to the usual php-cs-fixer execution for code and header fixer scripts to avoid code style drifitng in this folder for the future. Used command(s): Build/Scripts/runTests.sh -s cgl ; \ Build/Scripts/runTests.sh -s cglHeader Resolves: #104274 Releases: main, 12.4, 11.5 Change-Id: I7977e2254b9e271c45b840c6696cd7600ab0b1aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85035 Reviewed-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christoph Lehmann authored
When the record does not exist anymore, then the FlexForm definition might also not exist anymore (imagine a removed plugin) and it results in an Exception. Resolves: #102656 Releases: main, 12.4 Change-Id: I3eac287a50366ae8ca66416080738634eb65ae97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84643 Tested-by:
-
- Jun 30, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104263 Releases: main, 12.4, 11.5 Change-Id: I7f132b2d3f7df9ba620b26656bbfca7fd038f32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85014 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104265 Releases: main, 12.4, 11.5 Change-Id: Ifb6887a9fc77bc74c2d287b34a6876cc5da477da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85020 Reviewed-by:
Mogens Fiebrandt <mogens.fiebrandt@googlemail.com> Tested-by:
-
Garvin Hicking authored
In the Admin Tools > Settings > Extension Configuration module, extensions can provide a ext_config_template.txt file. Comments inside that file dictate where and in which order a configuration option is listed. The syntax is: ``` # cat=SomeCategory//0; type=boolean; label=some config bar = 0 # cat=SomeCategory//1; type=boolean; label=other config baz = 0 ``` The parsing routine however could not properly deal with "0" entries for the input element order because checking this was using an "falsy" statement instead of allowing also "0" as a string. In this case, such a zero-based config element was not displayed. This is fixed, and an example is added to the EXT:styleguide extension configuration. Note that the error would not cause problems when either: * Another category assignment of another input element took place before, thus properly initializing the sort ordering. * The key did not use "0" as a sorting index, but anything non-falsy. * The string "cat=SomeCategory//0" was replaced with "cat=SomeCategory/0" (thus having an unset sorting key). Resolves: #102760 Related: #97816 Releases: main, 12.4 Change-Id: I6954bcf8f840d9e45372fc8fa8099381ce2b8b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85027 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104266 Releases: main, 12.4, 11.5 Change-Id: I731d63dbbb13df6b3e0b6f40641ac0a98e92519f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85023 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104264 Releases: main, 12.4, 11.5 Change-Id: I64badf36faf69bc84f622cc9e7d5c1949c928ff1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85017 Tested-by:
-
David Mellen authored
This commit allows to use environment variables in YAML keys as well. Resolves: #99889 Releases: main, 12.4 Change-Id: I1e0272aade1188a483089412156c18e291d1ffbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84961 Tested-by:
-
- Jun 29, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104250 Releases: main, 12.4, 11.5 Change-Id: Ic0842784b1a647fbde6e0472a8efef934ce03663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85005 Tested-by:
-
