- Nov 25, 2021
-
-
Oliver Bartsch authored
In case a record from a no longer existing table is stored as recently opened in the user session, a PHP warning is triggered whenever the toolbar items are updated (e.g. because user opens another record). This is fixed by adding corresponding fallbacks. Resolves: #96075 Releases: master, 11.5 Change-Id: Ia99371711f2a8ef9fa6a96844476148674b5b843 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72285 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 23, 2021
-
-
Oliver Hader authored
BackendUtility::getUpdateSignalCode() returned plain inline JavaScript code which got replaced by new BackendUtility::getUpdateSignalDetails(). The new function is capable of handling inline JavaScript code (for backward compatibility reasons) and HTML markup using corresponding `<typo3-immediate-action>` custom element. OpendocsToolbarItem::updateNumberOfOpenDocsHook has been adjusted as well to use the script-less implementation. Resolves: #96002 Resolves: #96012 Releases: master, 11.5 Change-Id: I248db207600ae5c7452471a093f84f3802050c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72206 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Apr 13, 2020
-
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
- Mar 22, 2020
-
-
Andreas Fernandez authored
A new close button is rendered next to the "Open Documents" headline in the dropdown menu which enables to close all open documents at once. Resolves: #89053 Releases: master Change-Id: I4a1a7503cd0140210f4f78148f9dec1312d67dda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63836 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
- Jan 16, 2020
-
-
Felix Althaus authored
Menu entries in both open documents and recent documents list of the opendocs extension were htmlspecialchar‘ed twice. One level of escaping was removed. Resolves: #89553 Releases: master Change-Id: Id04f8742e3b91ad3ce8618f4d49f2d4e12b93d71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62161 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Feb 17, 2019
-
-
Frank Naegler authored
Resolves: #87703 Releases: master Change-Id: Ie44d5feae31b8c4cf64c621d12a42d6f7e6d574e Reviewed-on: https://review.typo3.org/c/59692 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Feb 16, 2019
-
-
Andreas Fernandez authored
When the opendocs toolbar item gets initialized, the document count shows a bogus value as deleted records are not removed from the calculation. As the documents are loaded deferred since #84412, the correct value gets in place automatically which renders the initial counting obsolete and is removed with this patch. Additonally, a wrong class hint in OpenDocumentController is fixed. Resolves: #87725 Related: #84412 Releases: master, 9.5 Change-Id: I0684e0950d0f4daf11042d6c078b5598bfb3d4be Reviewed-on: https://review.typo3.org/59708 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Oct 01, 2018
-
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:indexed_search - EXT:info - EXT:linkvalidator - EXT:lowlevel - EXT:opendocs - EXT:recordlist - EXT:recycler - EXT:redirects - EXT:reports - EXT:scheduler All @api annotations have been removed. Resolves: #86511 Releases: master Change-Id: I80de460142266305c1af3ad437f939b7e4448676 Reviewed-on: https://review.typo3.org/58530 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- May 13, 2018
-
-
Christian Kuhn authored
The patch deprecates BackendUserAuthentication->getTSConfigVal() and ->getTSConfigProp() and adapts usages to rely on getTSConfig() without arguments. The array nesting is done directly within consuming code and is combined with ?? to a fallback value. Advantages: * Expensive and recursive string operations within getTSConfig() are not used anymore. * The weird 'value' / 'property' based sub array juggling is gone. * Full TSconfig path including fallback can be easily seen within consuming code * Notice free array access using null coalescence operator Change-Id: I6d5777ebd533dcfdc6018e0226bfb3e513cfa652 Resolves: #84993 Related: #84982 Releases: master Reviewed-on: https://review.typo3.org/56953 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- Mar 29, 2018
-
-
Mathias Brodala authored
Change-Id: I786353379221af8da1436b77f654779d40fa77d3 Resolves: #84412 Releases: master Reviewed-on: https://review.typo3.org/56358 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Feb 16, 2018
-
-
Christian Kuhn authored
To further support the PSR-7 / PSR-15 and removal of GeneralUtility::_GP() and friends efforts, all controllers no longer use the second 'ResponseInterface $response' argument given by dispatchers: Dispatchers should not assume which type of response a controller returns, there is no point in preparing this object. Instead, controllers now always create one of HtmlResponse, JsonResponse or RedirectResponse on their own and return these objects. Changes overview: * Always use "new" to instantiate a response, PSR-15 middlewares allow fiddling with the object if needed, xclassing these classes is never needed, we instead can rely on proper API usage. * All controller actions drop the second $response argument and add ResponseInterface return type hint. * Some controllers action also drop first $request argument, but only if the action does not need access to ServerParams at all. Those controllers that access _GP or _POST or similar currently, keep $request for now - they have to be refactored later anyway and then need $request. Change-Id: Icce283b3c19be14ef1adeec761cfd63c90ab24c5 Resolves: #83939 Releases: master Reviewed-on: https://review.typo3.org/55754 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Dec 27, 2017
-
-
Wouter Wolters authored
Using null coalescing operator in PHP 7 simplifies code structure. Resolves: #83129 Releases: master Change-Id: I449415c99ccb0ea158d3943800bc824514f7629c Reviewed-on: https://review.typo3.org/54810 Reviewed-by:
-
- Nov 30, 2017
-
-
Benni Mack authored
The new PSR-7-based solution since TYPO3 v7 should be used everywhere instead of "BackendUtility::getModuleUrl()". This is possible because modules can be addressed via the "route" GET parameter instead of the "M" parameter since a few months. The patch changes all occurrences within TYPO3 Core to use the new API. Resolves: #83172 Releases: master Change-Id: Iec40e8ae00f1d900d7479b84a3a62827ddba653b Reviewed-on: https://review.typo3.org/54755 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Mar 30, 2017
-
-
Benni Mack authored
- Move everything to Fluid (also icon generation and labels) - Remove a lot of get* shorthand protected methods - Add PHP comments and remove PHP comments where applicable Resolves: #80554 Releases: master Change-Id: I9c417a02b2ac41fee95b815ee626ff44523c96f5 Reviewed-on: https://review.typo3.org/51909 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- Mar 28, 2017
-
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Feb 15, 2017
-
-
Wouter Wolters authored
Code cleanup based on the static analyser Psalm. https://github.com/vimeo/psalm Resolves: #79815 Releases: master Change-Id: I67dd33a79564b81931515f210644e980f83d3b7b Reviewed-on: https://review.typo3.org/51679 Reviewed-by:
-
- Nov 05, 2016
-
-
Andreas Fernandez authored
`list($x, )` does not work on empty arrays, causing `$x` being null then. The code now checks whether there are actually open docs and then does the list() stuff. Resolves: #78051 Releases: master Change-Id: I73d2c3ca40bea8c3dce2ac1de0ec97e136bf228b Reviewed-on: https://review.typo3.org/50512 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Andreas Fernandez authored
The properties `$openDocs` and `$recentDocs` are described and treated as arrays, but initialized as null values. This patch changes the declaration to array. Resolves: #78051 Releases: master Change-Id: I859c13478b17ddd9fbb7ab7686099f27b3c0e7ea Reviewed-on: https://review.typo3.org/50511 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #78051 Releases: master Change-Id: I579734bd47bd20cbc5d23d3bd4d8fe27426c248e Reviewed-on: https://review.typo3.org/50029 Tested-by:
-
- Oct 29, 2016
-
-
Markus Klein authored
Fix invalid content type in toolbar items. Resolves: #78493 Releases: master, 7.6 Change-Id: Ie4341136a9978e1c446f3871ba44602dd7d7f53d Reviewed-on: https://review.typo3.org/50426 Tested-by:
-
- Oct 18, 2016
-
-
Benni Mack authored
The name of the iframe is now available via top.list_frame and top.nav_frame instead of top.content.list_frame and top.content.nav_frame. All tests are adapted as well. Resolves: #78323 Releases: master Change-Id: I6cfdafec410e45bd97cee7849fa47c1ecab814b4 Reviewed-on: https://review.typo3.org/50255 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Oct 10, 2016
-
-
Kay Strobach authored
A responsive CSS viewport replaces the legacy the ExtJS component TYPO3.Viewport. Resolves: #52877 Releases: master Change-Id: I6d9c6c4e32cf67df3eeb072448e6b4322853d10c Reviewed-on: https://review.typo3.org/47637 Reviewed-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
Andreas Fernandez authored
If a record that was opened by the opendocs menu gets closed, the user now gets the record list of the record's pid. Resolves: #77675 Releases: master, 7.6 Change-Id: I90014ea639ce191ad0ee2d1a1cd650d2aaaebc52 Reviewed-on: https://review.typo3.org/49627 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
- Jun 10, 2016
-
-
Helmut Hummel authored
Resolves: #76449 Releases: master Change-Id: Ie0a7302d8a2f2d9aabfb7a351114f7e91e7d7ac8 Reviewed-on: https://review.typo3.org/48442 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
- May 28, 2016
-
-
Stephan Großberndt authored
Resolves: #76356 Releases: master Change-Id: I47c8b35eded79d6010b14e828f47b0790c09a6e9 Reviewed-on: https://review.typo3.org/48368 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Valentin Despa authored
Remove the second parameter of sL and replace it with htmlspecialchars directly in the code. Resolves: #76325 Related: #71917 Releases: master Change-Id: I6668eea01d80446a6b6f2ec95435c6e3d93cb0c3 Reviewed-on: https://review.typo3.org/48346 Reviewed-by:
-
- May 27, 2016
-
-
Wouter Wolters authored
Remove the second parameter of getLL and replace it with htmlspecialchars directly in the code. Resolves: #76321 Related: #71917 Releases: master Change-Id: Iaccd3e31b235632fac9022e9120a35426bd5d99b Reviewed-on: https://review.typo3.org/48320 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- Nov 20, 2015
-
-
Wouter Wolters authored
Resolves: #71738 Releases: master Change-Id: I71edcdb8ed1804bf94479237bd7f6c120420f779 Reviewed-on: https://review.typo3.org/44834 Reviewed-by:
Martin Kutschker <martin.kutschker@ymail.com> Tested-by:
-
- Oct 21, 2015
-
-
Frank Nägler authored
Resolves: #70155 Releases: master Change-Id: I5fbe9bd2610cf1d40f229981f689deae7c1c0169 Reviewed-on: https://review.typo3.org/43611 Reviewed-by:
Benjamin Kott <info@bk2k.info> Tested-by:
-
- Oct 09, 2015
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- Oct 05, 2015
-
-
Frank Nägler authored
Resolves: #70417 Releases: master Change-Id: Ie855b996636b749562acf3baa67b1756c2ad3db2 Reviewed-on: http://review.typo3.org/43826 Reviewed-by:
-
Benjamin Mack authored
The AjaxRequestHandler now first checks in the Router if an AJAX route exists. A new flag "ajax" in the routing mechanism allows to call ajax-based URLs which are then handed to the AJAX Request Handler. All controllers now receive proper Request and Response objects. All previous logic still works, but can slowly be migrated to the Routing concept. Resolves: #69916 Releases: master Change-Id: I1e67d5a341a4dd2769247531246c9e1fad900c76 Reviewed-on: http://review.typo3.org/43365 Reviewed-by:
-
- Sep 22, 2015
-
-
Frank Nägler authored
Deprecate the IconUtility class from EXT:backend and handle its calls using the new IconFactory from EXT:core. Kudos to Benjamin Kott, Stephan Großberndt, Andreas Fernandez and Frans Saris for the great support on this big project. Resolves: #69057 Releases: master Change-Id: I27a045b7a3b9d31e6e3e915e1452d44af56b0cee Reviewed-on: http://review.typo3.org/42613 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
-
- Sep 20, 2015
-
-
Stephan Großberndt authored
Implement replacement and replace all core usages of IconUtility::getSpriteIconForRecord() with IconFactory->getIconForRecord(). Register and fix several icon definitions for core tables. Resolves: #69754 Releases: master Change-Id: I5adf4f58a0331c77458049e19c7c8ca441b9e4cf Reviewed-on: http://review.typo3.org/43272 Reviewed-by:
-
- Sep 11, 2015
-
-
Morton Jonuschat authored
Replaces all IconUtility::getSpriteIcon calls for the1icon apps-toolbar-menu-opendocs with the new IconFactory. Resolves: #69683 Releases: master Change-Id: I7910f9b00c48348deae296948e7188a84dd72866 Reviewed-on: http://review.typo3.org/43208 Reviewed-by:
-
- Aug 08, 2015
-
-
Markus Guenther authored
Replaces all IconUtility::getSpriteIcon calls for the icon actions-document-close with the new IconFactory. Change-Id: I097d1b83bd7b76ec14c9050fb5bc74411729809e Resolves: #68839 Releases: master Reviewed-on: http://review.typo3.org/42383 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Jul 15, 2015
-
-
Markus Klein authored
@author information can be found in version control. Cluttering our code with these tags does not make much sense and they are outdated by definition or would sum up to impressive lists. As decided on acme 2015, we drop them now. Releases: master Resolves: #68152 Change-Id: Iec1ea0f873b44ab6027c94ba8353a9fdb5477bdd Reviewed-on: http://review.typo3.org/41264 Reviewed-by:
-
