- Nov 25, 2021
-
-
Oliver Bartsch authored
In case a record from a no longer existing table is stored as recently opened in the user session, a PHP warning is triggered whenever the toolbar items are updated (e.g. because user opens another record). This is fixed by adding corresponding fallbacks. Resolves: #96075 Releases: master, 11.5 Change-Id: Ia99371711f2a8ef9fa6a96844476148674b5b843 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72285 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #96069 Releases: master, 11.5 Change-Id: I2d883ebb7682ac7f402cdcb91b015ca74bdb72b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72283 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
Functional tests that extend AbstractDataHandlerActionTestCase test for correct sys_refindex in tearDown(). This can be avoided by setting assertCleanReferenceIndex to false, which is only a temporary solution until reference updating fully works. The patch changes some import fixtures that come without proper sys_refindex rows to avoid setting this property to false. One last call needs a dedicated bug fix and will have a dedicated patch. Change-Id: I7daa4d961372812312389dda7af13a5ac9fe8cef Resolves: #96074 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72284 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
ext:backend Form/Element recently got a trait with #95954 that can be easily avoided by adding the method to AbstractFormElement, which all elements should extend. Resolves: #96071 Related: #95954 Releases: master, 11.5 Change-Id: I8dc73f17b976f8191bf39bae5b51f2609778797c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72281 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Stefan Bürk authored
This patch fixes a bug where a t3 page URI with _language != 0 was resolved to a page in the default language. This caused automatically generated redirects to translated pages to redirect to the page in the default language. We now use the same override handling for the '_language' parameter (as already existed for 'L') when t3 page URIs are resolved. Also, we ensure that both parameters are always removed when the final URL is generated. Furthermore, this patch adds tests to cover these cases. Using the historical 'L' parameter still works and has been added to be handled as language override. Background information: The '_language parameter' is the preferred parameter to be used to specify the language in a t3 URI, not 'L'. The behaviour of creating auto redirects on slug changes was changed previously: The target was added as LinkHandler URI (instead of the path). Along with this change, the '_language' parameter was used to ensure the target URL is generated in the needed language (#89327). This introduced a problem where a redirect always redirected to the page in default language if a t3: page URI was used with '_language'. Resolves: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I95bdeff4827eed3be30528c02331b9c9ff2836b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72242 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Oliver Bartsch authored
Using "readOnly" for a TCA field with renderType "selectCheckBox" previously led to the fact, that nothing was rendered at all. This can be seen with `tx_styleguide_elements_select.select_checkbox_4`. This is now fixed, while the whole element got a light code cleanup. This will increase performance a bit, since unneeded JavaScript is no longer loaded. Additionally, this also fixes the "expandAll" option, which was broken due to the bootstrap 5 upgrade. Resolves: #96058 Resolves: #96068 Releases: master, 11.5 Change-Id: I762d328c9f4c83558dd8fd98683f8ccfe6c4b3f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72279 Tested-by:
-
- Nov 24, 2021
-
-
Christian Kuhn authored
This fixes issues regarding sys_refindex handling when dealing with workspace mm relations. Various DataHandler tests run with disabled refindex check after performing mm related operations. All those are enabled now, so all known issues in this area are fixed. The patch touches various areas in DataHandler, ReferenceIndex and RelationHandler to achieve this. The key changes are triggered by a database scenario that is unique for mm relations. Usually, when creating a workspace record or overlay, child record overlays (for instance inline children) are also created in this workspace. For mm records, this can be different: When the local or foreign side of a record is created in a workspace, it does not necessarily mean that a connected opposite side is also created as workspace overlay. This would otherwise create the need for a recursive operation that would basically end up with "everything" being created as workspace overlay. However, mm table entries are created for these relations, leading to a situation that a workspace record can point to a non-workspace record through the mm table. Reference index entries for mm table connections are always handled from the 'local' side. For instance, with categories, 'sys_category' table is the local side, with 'pages', 'tt_content' and others being the foreign side. If now one of the records on the foreign side gets a workspace overlay record, sys_refindex rows of all connected records of the affected local side need to be created. This can lead to the funny situation that we end up with refindex rows that point from a non-workspace to a non-workspace record, but have a non-0 workspace entry. Those additional rows are needed to have "the full set" and proper sorting when looking at refindex of such a relation from the local side. The patch basically handles especially these 'foreign side has a workspace overlay' scenarios, plus the side effects that have to be taken care of when discarding and publishing these records. Additionally, a couple of side effects are tackled: First, the ReferenceIndex->updateIndex() - that's the main logic when running cli referenceindex:update command - is tuned to drop reference index entries related to meanwhile deleted workspaces. This is covered with additional tests and is done now since the code needs to iterate over existing workspaces for local-side mm records that may have workspace overlays on the foreign side. So most of the code had to be created now anyways. RelationHandler->readMM() receives a fix for a long standing bug (Issue #83582, introduced by #57169), to no longer show workspace relations in live when looking at local-side records, for instance when looking at category items in live when one of the connected items has a workspace overlay. Next to lots of comments explaining details in place and referencing the test cases that nail specific scenarios, a couple of @todo's are added to point out things we may want to tackle in the future. All in all, the patch resolves a series of issues that will especially lead to 'categories' being much more reliable in workspaces. Change-Id: I24407f93665852fa761f6fbe6c5ab249473468d2 Related: #57169 Resolves: #83582 Resolves: #96067 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72250 Tested-by:
-
Oliver Bartsch authored
With #94222, the TSconfig preview of a TCA field with renderType= belayoutwizard was adjusted to use the CodeMirror plugin - in case EXT:t3editor is installed. With this change, also the default "preview" was changed form a <code> element to a <textarea>. This therefore led to the field being editable. However, any manual change will always be overwritten on adjusting the grid via the editor or on saving the record. To avoid confusion for the user and to be in line with the CodeMirror variant, the previous behaviour is restored by adding the readonly attribute to the <textarea> element. Resolves: #96064 Related: #94222 Releases: master, 11.5 Change-Id: Iaa41df59cbfd0420962c2239a42d329c249adb6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72278 Tested-by:
-
Oliver Bartsch authored
TCA renderType=belayoutwizard did previously not work for custom fields, as can be seen in styleguide `tx_styleguide_elements_basic.text_20`. BackendLayoutWizardElement used the hardcoded field name "config", which however is only used for the "backend_layout" table. Additionally, using the raw database value instead of the processed "itemFormElValue" led to further issues, e.g. when the field is defined with "l10n_display=defaultAsReadonly". This is now fixed by using the "itemFormElValue", since this is the correct value, which is also added to the corresponding input field and would also contain the "default" for new records. Additionally, the given parsed itemFormElValue is now checked to start with the correct root level key "backend_layout.". This prevents undefined array key warnings, triggered when a malformed default value is used for the field. Resolves: #96060 Releases: master, 11.5 Change-Id: I2d7c40bf3b33d6d2528c7575febe67d105ab5e12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72276 Tested-by:
-
Oliver Bartsch authored
In case a TCA field with renderType=belayoutwizard is configured to be not in the initially visible tab, the CodeMirror editor remains empty, when switching to the tab, containing the editor. The reason is, CodeMirror needs to be refreshed, after becoming visible. Therefore, the GridEditor, holding the configuration, is now observed, if not initially visible. As soon as it becomes visible, the CodeMirror instance - if any - is refreshed. Can be tested with `tx_styleguide_elements_basic.text_20`. Resolves: #96062 Releases: master, 11.5 Change-Id: Ic03c315e8f12bc2f3623fdb11a1782d5c1081a23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72277 Tested-by:
-
- Nov 23, 2021
-
-
Benni Mack authored
This change makes some FE calls easier for testing in extensions, such as EXT:solr. Resolves: #96050 Releases: master, 11.5 Change-Id: I3482ac0abe4e813ff5cba795da9b730ee0efbdee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72249 Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
-
Oliver Bartsch authored
The compare view of EXT:beuser does a couple of f:translate calls with dynamic values as key. Since some of those calls did not properly check the provided key, before passing it to the view helper, this previously led to exceptions. This is now fixed by properly checking the key, before passing it to the f:translate view helper. Additionally, some defaults are added to support static labels. Resolves: #94202 Releases: master, 11.5 Change-Id: Iff14f7c3b17108288227b108b5005d28611e20a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72248 Tested-by:
David Menzel <foxxdav@yahoo.de> Tested-by:
-
Oliver Hader authored
DispatchNotificationHook in ext:redirects has been adjusted to trigger events using a script-less implementation. Resolves: #96003 Releases: master, 11.5 Change-Id: I496331820813150cad610f07adae60ff538be3bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72240 Tested-by:
-
Oliver Hader authored
BackendUtility::getUpdateSignalCode() returned plain inline JavaScript code which got replaced by new BackendUtility::getUpdateSignalDetails(). The new function is capable of handling inline JavaScript code (for backward compatibility reasons) and HTML markup using corresponding `<typo3-immediate-action>` custom element. OpendocsToolbarItem::updateNumberOfOpenDocsHook has been adjusted as well to use the script-less implementation. Resolves: #96002 Resolves: #96012 Releases: master, 11.5 Change-Id: I248db207600ae5c7452471a093f84f3802050c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72206 Tested-by:
-
Torben Hansen authored
The ContentObjectRenderer throws a warning under certain circumstances in PHP8. The warning is generated by code, which is unused. This patch removes the unused code in ContentObjectRenderer. Resolves: #95921 Releases: master, 11.5 Change-Id: Ifb6f3557434626ec71f37d92181a5b156f6b39e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72272 Tested-by:
-
Nikita Hovratov authored
By setting the display property of buttons inside of input-groups to "flex", the height of the element inside the button can be easier controlled. Resolves: #95451 Releases: master, 11.5 Change-Id: Ia41d6bf4421d8ad078509893c8b0177708767e5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71459 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Nov 22, 2021
-
-
Ingo Fabbri authored
The backend usergroup compare view requires to fetch the group data of the groups to compare. Since this operation depends on a user array, UserInformationService creates such dummy user. Since #93233 the dummy user array also contains a workspace id `-99`. To successfully overcome workspace access-checks, set the admin-flag for this fake-user. Use workspace uid 0, to avoid any database operations on workspace access checks. Workspace 0 additionally prevents the log-message, which led to the exception message described at #93894. Resolves: #93894 Related: #93233 Releases: master, 11.5 Change-Id: Ieb5da95082cb6dfd5c030fbd04d735863d587510 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70056 Tested-by:
-
Stefan Bürk authored
TCA slug field generator option 'prefixParentPageSlug' has been added to be used for page records only. Slug generation for non-page records with pid=0 has been fixed with #94655 which introduced a endless loop if 'prefixParentPageSlug' is used as slug field generator option for record tables. This patch only process 'prefixParentPageSlug' for page records, thus ignoring it for non-page records and avoiding the endlees loop and as such prevent segmentation faults or memory_limit fatal errors. Resolves: #95485 Related: #94655 Releases: master, 11.5, 10.4 Change-Id: I20e1ac68bad6ad9447b03debbedb646495045ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72168 Reviewed-by:
-
Rudy Gnodde authored
Add option to copy page access settings from the parent page. Set by setting Page TSconfig TCEMAIN.permissions.* to "copyFromParent". Can be set for groupid, userid, user, group and everybody. For example: TCEMAIN.permissions.groupid = copyFromParent Resolves: #89917 Releases: master Change-Id: I4dd11177f533fd752f3b75287db2d8cb60c67005 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62750 Tested-by:
-
Jochen Roth authored
Currently when a language in site configuration is removed the modal cancel button does not remove/cancel the modal. This has been fixed by adding a trigger to close the modal when the cancel button was clicked. Resolves: #96016 Releases: master, 11.5 Change-Id: I100d84a7fa5f6a84d1045fec0a63d7c20789b42d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72219 Tested-by:
-
- Nov 21, 2021
-
-
Anja Leichsenring authored
For easier testing, ext:irre_tutorial "foreignfield" setup is extracted to a dedicated extension. Tests concerning these tables can now load the smaller test extension, which reduces system load and simplifies maintenance. Resolves: #95952 Releases: master, 11.5 Change-Id: I6fc581ac20821a4dcaff724cef4b3768e7f33dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72208 Tested-by:
-
- Nov 20, 2021
-
-
Christian Kuhn authored
Using the "translate" button in page module and localizing records from non-default language may lead to funny content element sorting in the target language. This has been mitigated with probably #85300 and #84951 a while ago already, but there still exists a codewise misbehavior in DataHandler::getPreviousLocalizedRecordUid(). The patch streamlines the method and applies a fix so records calculate the correct "before" uid even in "localization of a localization" context. Resolves: #83079 Resolves: #83469 Related: #85300 Related: #84951 Releases: master, 11.5 Change-Id: I03c566054bd4939fed96206f62633b2abe4f195f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/54750 Tested-by:
-
- Nov 19, 2021
-
-
Oliver Bartsch authored
The RequestUpdate component, handling the TCA "onChange" functionality, adds an event listener to the main HTML field. In case of TCA type "input", this field never dispatches such event, because the user always changes the "human readable" field in the GUI. The main field is only updated manually by FormEngine after validating the new value. Therefore, the "onChange" property never had any effect for TCA type "input" fields. This is now fixed by dispatching a "change" event for the main field after its value has been updated. Resolves: #93613 Releases: master, 11.5 Change-Id: I9facf3548619b3733975fb5c8f28622d03002e7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72205 Tested-by:
-
Jochen Roth authored
Given you have a user which has no access to the current page or no page at all, a "access array offset on value of type" is thrown in PHP8. This has been fixed by adding a fallback in case the array key does not exist which then throws the expected exception. Resolves: #96026 Releases: master, 11.5 Change-Id: I335a74fb6c2566d7a3e65632977dbc2740249414 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72228 Tested-by:
-
Eric Chavaillaz authored
This adds the NumberedPagination class from the ext:numbered_pagination of Georg Ringer as "SlidingWindowPagination" to the Core. Resolves: #94625 Releases: master Change-Id: If8631da405d95103c7a2f3a58a831835f08e45b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70069 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
When comparing user groups, a fake user record is created to fetch the group data for. This led to a couple of undefined array key warnings, which are now fixed. Resolves: #96038 Releases: master, 11.5 Change-Id: Ia1ed0dcf4483bf5b8bef26992c8943284c32de29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72238 Tested-by:
-
linawolf authored
New changelog entries now go to the release that they will be integrated in, currently 12.0. Updated the Howto.rst to adhere to current documentation standards and use current branches and versions as examples. Updated the section about where to put .rst files in the Changelog. Fixes: #96036 Releases: master Change-Id: Id5eef8caa3b53137507b283387884148ea8c63f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72235 Tested-by:
-
frpuser authored
Releases: master, 11.5, 10.4 Resolves: #96040 Change-Id: Idc83eedacc1ab00f761e179e394e173a071b6b0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72239 Tested-by:
-
Benjamin Franzke authored
This applies to rendering of database mounts (from groups or from workspaces): They are now shown as children of the virtual root page (uid=0) as it used to be in TYPO3 v8. This is to allow workspace users to get an overview of all changes of all mounts by navigating to the virtual page uid=0. Releases: master, 11.5, 10.4 Resolves: #95854 Related: #95972 Related: #91145 Change-Id: I7f6370f327711396193cf56b63f15876350c2559 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72028 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Simon Ackermann authored
Return an empty array if the key does not exist. Resolves: #96023 Releases: master, 11.5 Change-Id: I41cbea8c74ac91062c2e46efc16b4b6580be066b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72225 Tested-by:
-
- Nov 18, 2021
-
-
Christian Kuhn authored
The DataHandler 'regular' functional import DataSet uses a duplicate sorting value for tt_content records 296 and 297. This is an artificial setup - the DataHandler won't create this itself. To make sorting values in tests easier to understand and follow, the import set is adapted to use distinct sorting values for these rows. This is a pre-patch to fix a localization related sorting issue. In case the "duplicate sorting value" scenario should be tested, it should receive dedicated tests. Resolves: #96035 Related: #83079 Releases: master, 11.5 Change-Id: I281eae5ca8f57ed8e16e147d27ce7c40f07b7ffe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72234 Tested-by:
-
Oliver Hader authored
Closing a popup window does not use inline JavaScript code anymore. Resolves: #96019 Releases: master, 11.5 Change-Id: Iea2354e30d51ddcd24d9288fe5fa87b924259c13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72222 Tested-by:
-
Anja Leichsenring authored
There was a copy&paste leftover, leading to translated records being related to the wrong table. By fixing the wrong TCA configuration, sys_refindex entries in several test fixtures had to be adjusted. Resolves: #96025 Releases: master, 11.5 Change-Id: I197688e80e98a45a595e5304a49249ecfdcbfe91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72230 Tested-by:
-
Oliver Hader authored
Uses GlobalEventHandler functionality instead of onchange events. Resolves: #96018 Releases: master, 11.5 Change-Id: Ib217b294b9f3d0ff27c005b0d4f397aa2bfd665c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72221 Tested-by:
-
Oliver Hader authored
When resolving inline JavaScript invocations in issue #95954 it looked like AJAX-aware elements in FormEngine would share a common abstract implementation in the client-side handling. Actually AJAX response handling is independent for each of those elements... This change now applies changes, that previously have been made to `TYPO3/CMS/Backend/FormEngine/InlineRelation/AjaxDispatcher`, to `TYPO3/CMS/Backend/FormEngine/Container/FlexFormSectionContainer`. Resolves: #96027 Releases: master, 11.5 Change-Id: Icf507a32399f72182597e9c8d650fb2d9a35e480 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72231 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Helmut Hummel authored
Calling the TYPO3 extension installer with a root package of a different type will lead to an exception to be thrown. Move the install path check after the type check, to be sure to call the installer only with extension types. Resolves: #96028 Related: #96021 Releases: master, 11.5 Change-Id: Icdebc1a541a0b43461559e8f7a4a999fb1b327f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72229 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Oliver Hader authored
Resolves: #96022 Releases: master Change-Id: I6d9be94a4013d1380f75ef6f6f8f7f330d15f9f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72224 Tested-by:
-
Helmut Hummel authored
In case extensions are installed in vendor (in a future version of composer installers), linking an extension root package to the target location (vendor) does not make sense and is now skipped. Resolves: #96021 Releases: master Change-Id: Ifdee432c10135df35f3a47e54d2c366714ca32ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72223 Reviewed-by:
-
- Nov 17, 2021
-
-
Simon Gilli authored
Composer 2.1 supports PHP 5.3 and higher and to avoid issues during the deployment or on systems where the CLI version is not equal to the FPM version, the PackageArtifactBuilder is relaxed to also support PHP 7.1 and higher. Resolves: #96017 Releases: master Change-Id: I008368c2dbdb2023eb95bdc3650f2e00f528eb23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72220 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Hader authored
Due to a bug, inline form fields were initialized twice, causing internal application state issues in FormEngine and Modal handling. Resolves: #96009 Releases: master Change-Id: I07f75ae90826eec77515ec84e69f4154828295a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72214 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
