- Nov 26, 2021
-
-
Chris Müller authored
The work on this interface was 7 years ago, time to remove the todo. Resolves: #96093 Related: #62928 Releases: master, 11.5 Change-Id: Ieaf08a17eb02c60109f9fcdaf279c608f3a4a146 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72315 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Sep 24, 2021
-
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Sep 23, 2021
-
-
Wouter Wolters authored
Replace static:: with self:: in final classes. Resolves: #95319 Releases: master Change-Id: If375daf637c31f94c86f24d9189e85f8bae32581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71190 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Sep 03, 2021
-
-
Oliver Bartsch authored
A new PSR-14 based event "ModifyClearCacheActionsEvent" is introduced in favour of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['additionalBackendItems']['cacheActions'] hook, which is now marked as deprecated, along with its interface "ClearCacheActionsHookInterface". The new event features the same functionality as the hook. Additionally a new convenience method `add` is available for the class properties, allowing extension authors to add their custom actions more easily. This might be the most common use case for using this event. Resolves: #95083 Releases: master Change-Id: I1e621a00b04cdf43978a6e982b66c397e9437a29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70870 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Sep 03, 2018
-
-
Wouter Wolters authored
Resolves: #86088 Releases: master Change-Id: Ia011b8ca85b8665edd80a093844b5a60a5fe2e29 Reviewed-on: https://review.typo3.org/58129 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Jun 01, 2018
-
-
Mathias Brodala authored
Code which uses enumerations expects a known set of values, adding more values by extending these classes leads to undefined behavior. Since it is now impossible to create a mock of an enumeration also drop a few Enumeration tests and stick to testing of the public API. Resolves: #85025 Releases: master Change-Id: I3d0238c85ae916052dc1aa503f7f8e39c1765ac6 Reviewed-on: https://review.typo3.org/56976 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
-
- May 13, 2018
-
-
Christian Kuhn authored
The patch sets all user TSconfig related properties of class BackendUserAuthentication to protected. Existing usages of property "userTS" are adapted to call getTSConfig() instead. Resolves: #84984 Related: #84982 Releases: master Change-Id: I6fd10164c29959e4e705699776d694d63d7f5596 Reviewed-on: https://review.typo3.org/56940 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Nov 20, 2015
-
-
Wouter Wolters authored
Scalar types should always be written in the same form. "int", not "integer"; "bool", not "boolean"; "float", not "real" or "double". Resolves: #71746 Releases: master Change-Id: I47d43e5b68187cd07301d277875ba333325e29c7 Reviewed-on: https://review.typo3.org/44844 Reviewed-by:
-
- Oct 09, 2015
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- Sep 25, 2015
-
-
Sascha Egerer authored
The Enumeration implementation of InformationStatus provides a mapStatusToInt() method that must expect a InformationStatus instance as parameter instead of a string. The method mapStatusToInt() has also been replaced by "isGreaterThan" as a comparison method fits better into the enumeration usage. This change is breaking but should not really break anything as it was introduced in 7.4 and only used at one place in the core. Change-Id: I84548ba291360d1b20a607fa1e5149b95ca93bda Resolves: #69224 Releases: master Reviewed-on: http://review.typo3.org/42804 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
- Aug 04, 2015
-
-
Wouter Wolters authored
Resolves: #68732 Releases: master Change-Id: Ic3c2059ee90185551f77e5b658b686d473291d72 Reviewed-on: http://review.typo3.org/42256 Reviewed-by:
Ralf Merz <info@merzilla.de> Reviewed-by:
-
- Jul 15, 2015
-
-
Markus Klein authored
@author information can be found in version control. Cluttering our code with these tags does not make much sense and they are outdated by definition or would sum up to impressive lists. As decided on acme 2015, we drop them now. Releases: master Resolves: #68152 Change-Id: Iec1ea0f873b44ab6027c94ba8353a9fdb5477bdd Reviewed-on: http://review.typo3.org/41264 Reviewed-by:
-
- Apr 01, 2015
-
-
Andreas Fernandez authored
* Align status constants to FlashMessages and Modals * Add additional badge-info class * Display non-production environments as warning Resolves: #65767 Releases: master Change-Id: Ib78860bffcd10b6a623fc498647048794d02bc67 Reviewed-on: http://review.typo3.org/38420 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Andreas Fernandez authored
This patch introduces a new System Information dropdown item that contains several system information. By default it displays: * PHP version * Database version * Application context * git revision (if TYPO3 version has "-dev" suffix) * Operating system The item list is extendable by the SystemInformationHookInterface. Resolves: #65767 Releases: master Change-Id: I2e7489f53198d44edea9995fe4cce49696a2f888 Reviewed-on: http://review.typo3.org/37881 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Frank Nägler <typo3@naegler.net> Reviewed-by:
-
- Dec 30, 2014
-
-
Xavier Perseguers authored
Method getAdditionalAttributes() returns an array of HTML attributes. Resolves: #64058 Releases: master Change-Id: I38022eceffd8eb8d0121046e5323b9f81d56092b Reviewed-on: http://review.typo3.org/35670 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
- Dec 13, 2014
-
-
Roland Waldner authored
At the moment in some classes you can find an empty line between the copyright comment and the first PHPdoc bock comment. In some other classes there is no such empty line. This commit adds an empty line between those comments if there is no empty line. This is not part of the TYPO3 CMS CGL but increases consistency in this area. This regular expression was used to add the empty lines: Search: ( \* The TYPO3 project - inspiring people to share!\n \*/\n)(/\*\*\n \*) Replace: $1\n$2 Resolves: #63828 Releases: master Change-Id: I1d921921a3f60a62c29de3300b25b5df36a43b0a Reviewed-on: http://review.typo3.org/35390 Reviewed-by:
-
Roland Waldner authored
This regular expression was used to replace PHPDoc style comments with ordinary comments: Search: /\*\*(\n \* This file is part of the TYPO3 CMS project.) Replace with: /*$1 Resolves: #63328 Releases: master Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8 Reviewed-on: http://review.typo3.org/35103 Reviewed-by:
-
- Nov 29, 2014
-
-
Christian Kuhn authored
Add .rst file for toolbar refactoring works and hint about future changes of checkAccess() method. Releases: master Resolves: #63431 Change-Id: Ibbe019a4e204d9e99e0f722630395c010520ee8e Reviewed-on: http://review.typo3.org/34780 Reviewed-by:
-
- Nov 15, 2014
-
-
Christian Kuhn authored
Change new interface splitting item and drop down. Refactor all toolbar items accordingly. Styling changes will be done with second patch. Change-Id: I6bfa87dbc85eb0312f4748283de788e27dda590e Resolves: #62997 Releases: master Reviewed-on: http://review.typo3.org/34205 Reviewed-by:
Felix Kopp <felix-source@phorax.com> Tested-by:
-
- Nov 14, 2014
-
-
Markus Klein authored
Removes the hasDropDown() method of the ToolbarItemInterface Resolves: #62929 Releases: master Change-Id: I758e43b0874712c0a6e9e08b2b5c22f189573d6f Reviewed-on: http://review.typo3.org/34191 Reviewed-by:
-
Christian Kuhn authored
Resolves: #62964 Releases: master Change-Id: Ifbf35e815e0f98085004ef82170c7f0f5d4247a9 Reviewed-on: http://review.typo3.org/34182 Reviewed-by:
Thorsten Griebenow <griebenow@alltagsaesthetisierung.de> Tested-by:
-
Christian Kuhn authored
Toolbar items are now registered with its class name in array $GLOBALS['TYPO3_CONF_VARS']['BE']['toolbarItems']. The ToolbarItem interface adds a position method to determine the order of items. Resolves: #62959 Releases: master Change-Id: Ie18d4b2148093f28c1f5387907912d8591797582 Reviewed-on: http://review.typo3.org/34149 Reviewed-by:
-
Wouter Wolters authored
In our effort to remove scriptaculous and prototype.js from the Backend, this patch replaces the existing InPlaceEditor and JS logic with a RequireJS Module and jQuery. Resolves: #62799 Releases: master Change-Id: I2163e8b315fbbb50656bd4a77d3c66cda1792135 Reviewed-on: http://review.typo3.org/33930 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Felix Kopp authored
Toolbar now is based on Bootstrap compatible HTML5 markup. Styles all elements. Removes the previous CSS compatibility layer. Layout in Toolbar dropdown menu is out of scope (#62927, …). Resolves: #62939 Releases: master Change-Id: I701fd7862db331a54fc1f8514c3839e9c8e1be9d Reviewed-on: http://review.typo3.org/34141 Reviewed-by:
-
- Nov 13, 2014
-
-
Wouter Wolters authored
This patch refactors the Toolbar code for clearing caches to use RequireJS and jQuery over Prototype.js. Resolves: #62798 Releases: master Change-Id: Ice57e1bf5d54e002eba631b0fa22896a32ceb99e Reviewed-on: http://review.typo3.org/33929 Reviewed-by:
-
Wouter Wolters authored
* Introduce new (WIP) interface ToolbarItemInterface * Adapt current toolbar items * Toolbar item html scaffolding is done by BackendController Change-Id: I237792bf3277fcbc87762014d21ec655603e150f Resolves: #62929 Releases: master Reviewed-on: http://review.typo3.org/34034 Reviewed-by:
-
Xavier Perseguers authored
Since PHP 5.5 is a requirement, calls to GeneralUtility::makeInstance() should use the ::class construct instead of a string argument. Releases: master Resolves: #61788 Change-Id: Ia2efc5a4cb7ecea80b8a1c8e5ff7b5d6fa9a07ce Reviewed-on: http://review.typo3.org/32913 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
- Nov 03, 2014
-
-
Wouter Wolters authored
Resolves: #62664 Releases: master Change-Id: Ib8e0695fc234ab67a2f73a65737e07cf9a2d19c6 Reviewed-on: http://review.typo3.org/33757 Reviewed-by:
-
- Oct 28, 2014
-
-
Wouter Wolters authored
* Use bool in @return * Use int in @return * Use bool in @param * Use int in @param * Remove extra tabs and spaces in @param Resolves: #62506 Releases: master Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2 Reviewed-on: http://review.typo3.org/33577 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
- Oct 25, 2014
-
-
Wouter Wolters authored
Resolves: #62467 Releases: master Change-Id: I927a16b0fa89c5b859b56a7549548102ac04037f Reviewed-on: http://review.typo3.org/33522 Reviewed-by:
-
- Oct 16, 2014
-
-
Anja Leichsenring authored
Change-Id: I5845baff737e739599cf29847981f56f5cf866e3 Resolves: #62026 Relates: #62013 Releases: master Reviewed-on: http://review.typo3.org/33150 Reviewed-by:
-
- Oct 11, 2014
-
-
Georg Ringer authored
The "@todo Define visibility" is not very helpful because: * Nobody knows what breaks if changing the visibility * The code is flooded with todos which makes it hard to work with in an IDE During ACME it was decided to remove the @todo again. Resolves: #61957 Releases: master Change-Id: I0caa9756bba326dc132b6a2dabe79218c53a32c8 Reviewed-on: http://review.typo3.org/33044 Reviewed-by:
-
- Sep 09, 2014
-
-
Wouter Wolters authored
Use dispatching for file_edit.php Resolves: #56743 Releases: 6.3 Change-Id: Ib25745dd29642a83aa5700752c83cda8e11ea7fa Reviewed-on: http://review.typo3.org/28238 Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
-
- Jul 06, 2014
-
-
Frans Saris authored
During the addition of the token check for mod.php the token in the BE shortcut url was already replaced (#56359) but not in the returnUrl parameter that can be present. This patch makes sure that also the module token is replaced in the returnUrl param. Resolves: #59963 Releases: 6.3, 6.2 Change-Id: I12b9d6022240d0399825aade21b0879bfbc7eb6c Reviewed-on: https://review.typo3.org/31386 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Marcin Sągol Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 28, 2014
-
-
Frans Saris authored
Due to some wrong or missing checks the link to create a shortcut to a create new record form misses the correct name of the "motherModName" as a result the shortcut links are not rendered for non-admins. For admins these links do not work if PHP notices are transformed to exceptions. Resolves: #59946 Releases: 6.3, 6.2 Change-Id: I9acd74fd5dfefea62badc79e42e380466ce6c497 Reviewed-on: https://review.typo3.org/31172 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Marcin Sągol
-
- Jun 22, 2014
-
-
Michael Schams authored
This patch replaces the copyright/license header in PHP files with a new, simplified one. The new header does not show the year figure, nor an author name, and refers to the LICENSE.txt file for the full copyright information. License is: GPL2 or any later version. This is a multi-part commit due to the huge number of changed files. See issue #59782 for further details. Resolves: #59782 Releases: 6.3, 6.2 Change-Id: Idcd11219eb132c8690cfde256950980e9423bafd Reviewed-on: https://review.typo3.org/31027 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Jun 11, 2014
-
-
Zbigniew Jacko authored
Add a new configuration in Install Tool (['SYS']['clearCacheSystem']). If set, the toolbar of clearing system cache is visible (only for admin users). Add it also for Configuration Preset. For Production it is set to FALSE, for Development it is set to TRUE. Resolves: #57230 Releases: 6.2 Change-Id: Id45496c6bc1e64b4454ed7ff78e8db1179387b0f Reviewed-on: https://review.typo3.org/30656 Reviewed-by: Krzysztof Adamczyk Tested-by: Krzysztof Adamczyk Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
