Skip to content
Snippets Groups Projects
  1. Jan 15, 2014
    • Ernesto Baschny's avatar
      [TASK] Document that TYPO3 is not compatible with MySQL strict mode · 9bbad98c
      Ernesto Baschny authored
      Document that in the requirements section of the INSTALL.md.
      
      Resolves: #54883
      Releases: 6.2
      Change-Id: Idd80528493b9920f4488e359f13fe4304ac5fe25
      Reviewed-on: https://review.typo3.org/26725
      Reviewed-by: Wouter Wolters
      Reviewed-by: Philipp Gampe
      Reviewed-by: Aske Ertmann
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Michael Stucki
      Tested-by: Michael Stucki
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9bbad98c
    • Alexander Stehlik's avatar
      [TASK][CONF] Accept other settings in [SYS][setDBinit] · 9c905d15
      Alexander Stehlik authored
      Since the mysqli interface recommends setting the charset using the
      mysqli API the utf8 charset will be initialized when establishing the
      database connection using mysqli_set_charset().
      
      Additionally [SYS][setDBinit] can now be set to any value or can totally
      be removed. To make sure the database connection still uses the correct
      encoding an additional check is added to the database connection process
      that checks the MySQL character set session variables.
      
      Finally the old default value of [SYS][setDBinit] will automatically be
      removed if it is set to the old default value.
      
      Resolves: #41596
      Releases: 6.2
      Change-Id: I8d0a9eba50495d52accb59627147c1c87b6a9bb5
      Reviewed-on: https://review.typo3.org/15369
      Reviewed-by: Wouter Wolters
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Michael Stucki
      Tested-by: Michael Stucki
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      9c905d15
    • Stefan Neufeind's avatar
      [TASK] Cleanup __DIR__ and require/require_once · 47387086
      Stefan Neufeind authored
      * Use __DIR__ instead of dirname(__FILE__) (since PHP 5.3.0)
      * Use require_once for loading classes ("just once")
      
      Resolves: #47203
      Releases: 6.2
      Change-Id: I4b5d003a0bbabd91dcc7e58081eed41b5314da3f
      Reviewed-on: https://review.typo3.org/19952
      Reviewed-by: Xavier Perseguers
      Reviewed-by: Oliver Klee
      Reviewed-by: Alexander Opitz
      Tested-by: Alexander Opitz
      Reviewed-by: Pascal Dürsteler
      Reviewed-by: Stefan Froemken
      Tested-by: Stefan Froemken
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      47387086
    • Steffen Ritter's avatar
      [TASK] FrontendContentAdapterService processes record repeatedly · 3adf7835
      Steffen Ritter authored
      The FrontendContentAdapterService rewrites records so legacy
      TypoScript is able to work on the files to. To do so it queries
      the objects regarding the relations and fills the properties of
      the record new line separated as known from pre-6.x records.
      
      This change adds a runtime cache, so already processed records
      of are not processed again, if the next cObject for the same
      record is started.
      
      Resolves: #54953
      Releases: 6.2, 6.1
      Change-Id: I1f632f175075c9d85079ea83e343e35867a1fcca
      Reviewed-on: https://review.typo3.org/26786
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      3adf7835
    • Benjamin Mack's avatar
      [TASK] Allow more DB and File Mounts for BE users and BE groups · 2750c6ab
      Benjamin Mack authored
      In big installations, more than just 25 DB mount points are needed.
      
      Solution: Raise the default configuration to 100.
      
      Releases: 6.2
      Resolves: #55018
      Change-Id: I613a90bc6c15b7642f2c6b6b6ca4ec8221838c0b
      Reviewed-on: https://review.typo3.org/26834
      Reviewed-by: Tom Ruether
      Tested-by: Tom Ruether
      Reviewed-by: Wouter Wolters
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      2750c6ab
    • Alexander Stehlik's avatar
      [BUGFIX] Correct handling of empty Backend Layouts · 2cfefec4
      Alexander Stehlik authored
      Since the default value of the page properties backend_layout and
      backend_layout_next_level is an empty string the value in the select
      item is changed from zero to an empty string for consistency.
      
      Additionally the BackendLayoutView will treat an empty string equally
      as a zero namely as a non set Backend Layout.
      
      Resolves: #52596
      Releases: 6.2
      Change-Id: Ic792f748d005f5749f24a3e979b304c23320c8fa
      Reviewed-on: https://review.typo3.org/24882
      Reviewed-by: Wouter Wolters
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      2cfefec4
    • Ernesto Baschny's avatar
      [BUGFIX] Images in distributions are not shown · 81202b0a
      Ernesto Baschny authored
      The API of the fluid image viewhelper had changed. This makes that
      change less breaking, by respecting the old order of parameters,
      thus allowing subclasses to continue working as usual.
      
      Also adds some comments in phpdoc for the parameters.
      
      Related: #53700
      Resolves: #54411
      Releases: 6.2
      
      Change-Id: I11c8ec06ee263a18abd72a12e77a25899f73b475
      Reviewed-on: https://review.typo3.org/26407
      Reviewed-by: Helmut Hummel
      Tested-by: Helmut Hummel
      Reviewed-by: Philipp Gampe
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      81202b0a
    • Markus Klein's avatar
      [BUGFIX] PHP warnings in ElementBrowser · 60e488e3
      Markus Klein authored
      The ElementBrowser tries to access array indexes
      which do not exists.
      Fix this to prevent PHP warnings.
      
      Resolves: #54995
      Releases: 6.2, 6.1
      Change-Id: Ief660ae535f01bc593617667ce7eb81f8cd78cd3
      Reviewed-on: https://review.typo3.org/26824
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      60e488e3
  2. Jan 14, 2014
    • Steffen Ritter's avatar
      [TASK] Speedup typolink root-line handling · acc7ff01
      Steffen Ritter authored
      The link generation via typolink needs the domain record as well
      as the rootline to generate the links correctly. To save
      superfluous database queries some local caches are introduced.
      
      Furthermore the rootline cache does not use all information which
      is present after the database query. This information is unpacked
      here, too. As a result less requests to the CacheFrontend need to
      be done.
      
      Resolves: #54959
      Releases: 6.2, 6.1
      Change-Id: Iea7fff4c6c624a03b75523a7352b5f9736f2d57e
      Reviewed-on: https://review.typo3.org/26787
      Reviewed-by: Jo Hasenau
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Helmut Hummel
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      acc7ff01
    • Aske Ertmann's avatar
      [BUGFIX] Folder tree in popup throws JS error · 58bb7153
      Aske Ertmann authored
      When using the folder tree (file, and folder navigation) popup
      (browse_links) a JS error occurs when opening new folders.
      
      This is due to incorrect handling of scope.
      This patch fixes the error for both RTE and normal link browser.
      
      Change-Id: I25fa0871405e06d6fc084985b3beba6396b872ad
      Resolves: #53826
      Releases: 6.0, 6.1, 6.2
      Reviewed-on: https://review.typo3.org/25633
      Reviewed-by: Jan-Erik Revsbech
      Tested-by: Jan-Erik Revsbech
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      58bb7153
    • Peter Niederlag's avatar
      [BUGFIX] Add defaultTypoScript to hierachyInfo · 5fe23203
      Peter Niederlag authored
      Fixes a problem with the TemplateAnalyzer introduced by #43540
      
      - Always add both defaultTypoScript_setup and defaultTypoScript_constants.
      - Add information for defaultTypoScript into hierarchyInfo.
      
      Change-Id: I15ad5f268eb167d6c8f027e1891409d9ead64539
      Resolves: #53352
      Releases: 6.2, 6.1, 4.7
      Reviewed-on: https://review.typo3.org/26738
      Reviewed-by: Markus Klein
      Reviewed-by: Michiel Roos
      Tested-by: Michiel Roos
      Reviewed-by: Stefan Neufeind
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      5fe23203
    • Ingo Schmitt's avatar
      [BUGFIX] Add SQL Index to Processed Files DB table · e7195cf7
      Ingo Schmitt authored
      Added index to original,task_type,configurationsha1
      this improves performance for non-cached pages and
      backend calls
      
      Resolves: #54729
      Releases: 6.2
      Change-Id: I2ecfe62c64b89078da5c04ee708ea3c343d4fc9a
      Reviewed-on: https://review.typo3.org/26628
      Reviewed-by: Oliver Klee
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      e7195cf7
    • Georg Ringer's avatar
      [BUGFIX] Exception in FileMetadataOverlayAspect · 86027526
      Georg Ringer authored
      It is possible that PageRepository::getRecordOverlay() returns NULL which
      throws an exception as ArrayObject::exchangeArray() either needs an
      array or an (array-)object.
      
      The fix adds a small check for the Result of the PageRepository function.
      
      Change-Id: I248125154220e6250c4a2a6fdf29759211bf214b
      Resolves: #54169
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/25914
      Reviewed-by: Steffen Ritter
      Reviewed-by: Oliver Klee
      Reviewed-by: Frans Saris
      Tested-by: Frans Saris
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      86027526
    • Alexander Opitz's avatar
      [BUGFIX] Prevent double loading of session data · 40aa8006
      Alexander Opitz authored
      At the moment we load the session data to verify authentication and
      again to verify session existence. This isn't necessary. Also removing
      the session deletion if we didn't find session data.
      
      Resolves: #53598
      Releases: 6.2
      Change-Id: Ibc3c4ebc5c1bbca970374172f714bddcd37b539a
      Reviewed-on: https://review.typo3.org/25510
      Reviewed-by: Thorsten Kahler
      Tested-by: Thorsten Kahler
      Reviewed-by: Wouter Wolters
      Reviewed-by: Michiel Roos
      Tested-by: Michiel Roos
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      Reviewed-by: Ernesto Baschny
      Tested-by: Ernesto Baschny
      40aa8006
    • Georg Ringer's avatar
      [BUGFIX] Usage of sys_lang_mode in Typo3DbBackend · 29efbe49
      Georg Ringer authored
      Due refactoring the property $languageMode is compared but is never
      filled. The property from the querySettings has to be used.
      
      Change-Id: I8f66a10548213513b8cc5a3a90cc219ed5f91918
      Resolves: #54182
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/25932
      Reviewed-by: Markus Klein
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      29efbe49
    • Georg Ringer's avatar
      [TASK] Proper template for EXT:cshmanual · 1e0254b8
      Georg Ringer authored
      Use the proper template mechanism and a toolbar for the cshmanual ext to
      let it look like all other backend modules.
      
      Change-Id: I6b1a4cfe036034d09caa71a8914eed359f2da930
      Resolves: #54184
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/25933
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      1e0254b8
    • Stefan Neufeind's avatar
      [TASK] Update IDNA-class to 0.8.1 · 9a02a705
      Stefan Neufeind authored
      Change-Id: I1aaf487c43adc7e36fa98aaf972094fa13d1e764
      Resolves: #53902
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/25667
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      9a02a705
  3. Jan 13, 2014
    • Roland Waldner's avatar
      [TASK] Fix typo in copyright notice · 8289e607
      Roland Waldner authored
      "textfile" will be replaced by "text file"
      
      Resolves: #54893
      Releases: 6.2
      Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b
      Reviewed-on: https://review.typo3.org/26736
      Reviewed-by: Michiel Roos
      Tested-by: Michiel Roos
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      8289e607
    • Torben Hansen's avatar
      [BUGFIX] Template dropdown doesn't refresh template title after save · 273958a4
      Torben Hansen authored
      Reloads the template menu after the template title has been changed.
      
      Resolves: #51805
      Releases: 6.2, 6.1
      Change-Id: I5d987a3ffc6a11dfa1ebe54480c9c3b69ccc1959
      Reviewed-on: https://review.typo3.org/26766
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      273958a4
    • Xavier Perseguers's avatar
      [BUGFIX] Only variables should be passed by reference · 6b951001
      Xavier Perseguers authored
      array_shift() takes argument by reference.
      
      Releases: 6.2
      Fixes: #54933
      Change-Id: I94c16bc739f36d669640701561ff94aebd63b1f5
      Reviewed-on: https://review.typo3.org/26779
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      6b951001
    • Markus Klein's avatar
      [BUGFIX] Fix PHP warnings in PackageManager · f294b262
      Markus Klein authored
      Resolves: #54963
      Releases: 6.2
      Change-Id: I58b1f6109872d6eb8059fceb1bec1af7134e84e2
      Reviewed-on: https://review.typo3.org/26789
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Thomas Maroschik
      Tested-by: Thomas Maroschik
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      f294b262
    • Tomita Militaru's avatar
      [TASK] Check for libxml bug in install tool · 51ebe1cf
      Tomita Militaru authored
      Add check for libxml bug when saving special characters ">><<"
      in a flexform
      
      Resolves: #51271
      Releases: 6.2
      Change-Id: I5d120cdfeb9538209273c8761d017cb67256617b
      Reviewed-on: https://review.typo3.org/25089
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Neufeind
      Tested-by: Stefan Neufeind
      51ebe1cf
    • Steffen Ritter's avatar
      [TASK] Calculated hash of File object is never used · a9f111f3
      Steffen Ritter authored
      The indexing pre-calculates the file hash and stores it in
      the sys_file table. Sadly the getter of file objects never looks
      at this again and always recalculates the hash via the driver,
      which is very slow.
      
      Resolves: #54235
      Releases: 6.2, 6.1, 6.0
      Change-Id: I16bfa2126031f26b8e31da8d8c0b3fc07d0217dc
      Reviewed-on: https://review.typo3.org/26689
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      Reviewed-by: Oliver Klee
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      a9f111f3
    • Helmut Hummel's avatar
      [BUGFIX] Ignore dependencies of inactive packages · df96f236
      Helmut Hummel authored
      It might happen that activating or deactivating
      a package throws an exception because other inactive
      packages are available on the system with broken or
      not fulfilled dependencies.
      
      To solve this issue, only active packages
      are regarded when resolving dependencies.
      
      To remove a side effect from this change,
      cache clearing in extension manager is
      moved to a later point (see #54951).
      
      This needs a proper fix in another change,
      but makes this fix work for now.
      
      Resolves: #54879
      Releases: 6.2
      Change-Id: Id81b66b2d2b6f4ba7d1c6ea2d001c271982539b3
      Reviewed-on: https://review.typo3.org/26719
      Reviewed-by: Thomas Maroschik
      Reviewed-by: Markus Klein
      Tested-by: Kasper Ligaard
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      df96f236
    • Ingo Schmitt's avatar
      [TASK] Add index to sys_file_metadata · cc3b0298
      Ingo Schmitt authored
      Since sys_file_metadata records are enabled to be 
      translated the file list module is capable of metadata 
      translations, too. In order to directly link to edit 
      or create a new translation depending on wether this 
      language already has been translated for each file the 
      metadata translations are fetched from the database.
      
      In order to improve that query this patch adds an index 
      including l10n_parent and sys_language_uid.
      
      Resolves: #54927
      Releases: 6.2
      Change-Id: I6cc5c74505e96647c5ddd7e7ee77518176d2ba0b
      Reviewed-on: https://review.typo3.org/26774
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      cc3b0298
    • Ingo Schmitt's avatar
      [TASK] Update SQL definition for sys_file_storage · 85edd0e1
      Ingo Schmitt authored
      There are missing indexes as well as a mismatch between the
      TCA definition (and therefore actual usage) and the SQL
      definition at database level.
      
      This change
      * adds combined index to deleted / hidden to speedup the
        query initializing storages in Be_UserAuth
      
      * changes SQL definition for field "name" to match their
        usage in TCA
      
      Resolves: #54923
      Releases: 6.2
      Change-Id: I86f345a941802304ed7fbe29d00ae38130f8e5d2
      Reviewed-on: https://review.typo3.org/26768
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Oliver Klee
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      85edd0e1
    • Ingo Schmitt's avatar
      [TASK] Add index to sys_category · 1044c801
      Ingo Schmitt authored
      All page, content and file-records TCEforms render a category 
      tree in order to assign these. The tree building executes the 
      same queries quite often. In order to optimize these queries
      this change adds
      * an index "category_parent" to sys_category.parent in order
        to for the parent category while index "parent" currently
        indexes the pid the record is stored.
      
      * a combined index "category_list" to columns pid, deleted 
        and sys_language_uid.
      
      Resolves: #54929
      Releases: 6.2
      Change-Id: I1d42ba7171dc1213d5d5559ae190092acaa57464
      Reviewed-on: https://review.typo3.org/26775
      Reviewed-by: Oliver Klee
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      Reviewed-by: Benjamin Mack
      Tested-by: Benjamin Mack
      1044c801
  4. Jan 12, 2014
    • Markus Klein's avatar
      [BUGFIX] Indexer tries to insert NULL into DB · cca2d700
      Markus Klein authored
      The Indexer of indexed_search tries to insert NULL values
      into NOT NULL columns of the database.
      
      Since #53662 NULL values are passed to the database,
      hence these insert statements now fail.
      
      Resolves: #54917
      Releases: 6.2
      Change-Id: Ia935abe14b9c3be2062f1b38ec98fb63921a1c2f
      Reviewed-on: https://review.typo3.org/26757
      Reviewed-by: Georg Ringer
      Tested-by: Georg Ringer
      cca2d700
  5. Jan 11, 2014
    • Nico de Haen's avatar
      [BUGFIX] Skip validation of uninitialized collections · b90e09b5
      Nico de Haen authored
      Elements in LazyObjectStorages should not be validated,
      since the values would be reconstituted from persistence anyway.
      This patch adds the same behaviour as implemented in Flow and
      adds the tests found in Flow (and one additional test).
      
      Resolves: #53816
      Releases: 6.2
      Change-Id: I65f62a4ef6777e3678b2fdd06fc58d828bb8cb87
      Reviewed-on: https://review.typo3.org/25549
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Steffen Müller
      Tested-by: Steffen Müller
      b90e09b5
    • Francois Suter's avatar
      [BUGIFX] Drop usage of addTofeInterface parameter · ada821d1
      Francois Suter authored
      In #54613, usage of parameter $addTofeInterface in method
      ExtensionManagementUtility::addTCAcolumns() was deprecated.
      However it is used in a few places of the Core.
      Those calls must be modified too.
      
      Resolves: #54899
      Releases: 6.2
      Change-Id: I22696cb4655578dc583edcb9cfa4693b69e228c8
      Reviewed-on: https://review.typo3.org/26745
      Reviewed-by: Oliver Klee
      Reviewed-by: Eric Chavaillaz
      Tested-by: Eric Chavaillaz
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      ada821d1
    • Steffen Müller's avatar
      [BUGFIX] Add missing logger names · b8280294
      Steffen Müller authored
      A logger name is mandatory to configure a particular logger.
      The convention is use __CLASS__ as the logger name when
      instanciating a new logger using LogManager->getLogger().
      
      Resolves: #54909
      Releases: 6.2, 6.1
      Change-Id: I5dbda770ec92fd75c3aff9ed89c68c5666669b07
      Reviewed-on: https://review.typo3.org/26754
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      b8280294
  6. Jan 09, 2014
    • Steffen Müller's avatar
      [BUGFIX] Allow empty values in start/stop filter of belog · beb80664
      Steffen Müller authored
      One can limit records in the backend log module to a custom period
      of time using the "User defined" mode and a start and stop field.
      
      Leaving these fields empty is now supported in the corresponding
      domain model setters by adding default values to the DateTime
      arguments.
      
      Resolves: #53975
      Releases: 6.1, 6.2
      Change-Id: I944322bb3747a29fab33c3d32e17dd070c7cb6db
      Reviewed-on: https://review.typo3.org/26723
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      beb80664
    • Felix Oertel's avatar
      [BUGFIX] Assume pid 0 for global backend context · ba2386e7
      Felix Oertel authored
      If outside from "Web", extbase modules try to figure out some pid,
      while in reality there is just none. The core takes "0" in this
      situations, for looking for typoscript templates and tagging
      cf_cache_pagesection entries.
      
      To enable extbase to use the core's cache entries, we should streamline
      this.
      
      * Return 0, if no pid is set
      * Remove needless unit-tests
      
      Resolves: #54813
      Releases: 6.2
      Change-Id: I58cbaac0b40323e1766229488973b775accd1b97
      Reviewed-on: https://review.typo3.org/26675
      Reviewed-by: Oliver Klee
      Reviewed-by: Stefan Froemken
      Tested-by: Stefan Froemken
      Reviewed-by: Anja Leichsenring
      Tested-by: Anja Leichsenring
      ba2386e7
    • Georg Ringer's avatar
      [TASK] Improve feedit · 545610af
      Georg Ringer authored
      The frontend editing + admin panel needs some polishing.
      Following changes are included:
      
      General
      =======
      - Reformat code
      - Use Sprite API which means using the correct icons
      
      Admin Panel
      ==============
      - Add missing translations
      - Show "Simulate usergroup" only if usergroups are available
      - Remove "Total page count" in Info Tab as information is wrong
        (counting images + document is not the total page size)
      
      Frontend Editing
      =================
      - Remove "edit_editNoPopup", "forceNoPopup", "editFormsOnPage"
        for direct inline editing
      - Remove setting "previewBorder" which is not needed and looks just ugly
      
      Releases: 6.2
      Resolves: #49640
      Change-Id: I35f88bc4e8c138fc21b74c0448b2f3892ab61918
      Reviewed-on: https://review.typo3.org/21859
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      545610af
    • Markus Klein's avatar
      Revert "[BUGFIX] IRRE creates new records when using foreign_selector" · b3a82c72
      Markus Klein authored
      This reverts commit 692bd22c
      
      The patch breaks IRRE. It is impossible to add images.
      
      Change-Id: Iac9f0a7af3cc8532a953ac1947f6877ded4f915f
      Resolves: #43239
      Releases: 6.2
      Reviewed-on: https://review.typo3.org/26726
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      b3a82c72
    • Kai Vogel's avatar
      [BUGFIX] IRRE creates new records when using foreign_selector · 692bd22c
      Kai Vogel authored
      This patch links existing child records correctly to the parent IRRE
      field when selecting it in the generated dropdown.
      
      Scenario:
      
      Parent table configuration:
      ====================================================
      [...]['columns']['irreField']['config'] = array(
        'type' => 'inline',
        'foreign_table' => 'childTable',
        'foreign_selector' => 'childSelector',
      );
      
      Child table configuration:
      ====================================================
      [...]['columns'][childSelector']['config'] = array(
        'type' => 'select',
        'foreign_table' => 'childTable',
      );
      
      What happens?
      ====================================================
      1. The parent IRRE field renders a dropdown field
         before the child records
      2. Selecting one of the items in the dropdown should
         link this child record to current IRRE field
      3. Without patch, it will only create a blank child
         record
      4. Using the patch, it will link the existing child
         to the parent IRRE field
      
      Resolves: #43239
      Releases: 6.2, 6.1
      Change-Id: I2a308cb050962b71e9ba28b64a44962c91bde440
      Reviewed-on: https://review.typo3.org/16690
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      692bd22c
    • Jo Hasenau's avatar
      [TASK] Replace all strcmp() calls with === · 0a761995
      Jo Hasenau authored
      This patch replaces about 300 places using strcmp()
      in the whole core. There are different contexts for strcmp()
      within this set, i.e. checking for strings being '0',
      '', not '' and the like.
      
      strcmp() has to stay when it comes to real sorting of strings,
      which is a rather rare case, otherwise it can be replaced with
      faster alternatives.
      
      The following 'rules' were used for the replacement:
      
      * Use a type cast if you can't be sure about the incoming values.
        We do not need type casts if the types are implicitly defined
        before by another function. i.e. intval(), trim(), substr()
      * Use int-cast whenever the values to be compared are numbers only.
      * Use string-cast for any other combination. i.e
        (string)$len === '0' when $len can be NULL, which is different
        to (int)$len === 0
      
      Resolves: #54085
      Releases: 6.2
      Change-Id: I88fb294ae20d8c23ff58d8296fbb37925d5213c8
      Reviewed-on: https://review.typo3.org/25843
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      0a761995
    • Tymoteusz Motylewski's avatar
      [TASK] Add functional tests from irre_tutorial to the core · c9651784
      Tymoteusz Motylewski authored
      Add irre_tutorial extension as mock extension for functional tests.
      Port functional tests from IRRE tutorial to the functional testing
      framework and include them in the core and workspaces extensions.
      Some tests are skipped for now, because the core is buggy.
      
      Releases: 6.2
      Resolves: #54812
      Change-Id: I691dd97e7649c8239b6e96ce6f9a9d59e9b124c4
      Reviewed-on: https://review.typo3.org/26674
      Tested-by: Markus Klein
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      c9651784
    • Oliver Hader's avatar
      [BUGFIX] Test extensions not considered in functional tests · 82a24fa0
      Oliver Hader authored
      The functional testing framework offers the possibility to define
      custom extension to be installed for each test scenario. However,
      this does not work at all, only extensions that are available in
      the original base installation can be used.
      
      This change cleans and adds the package state definition for any
      extension to be used during a functional test execution.
      
      Fixes: #54857
      Releases: 6.2
      Change-Id: I91b1cd1bc5d147287a154283e94d03d1392ac92d
      Reviewed-on: https://review.typo3.org/26705
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Thomas Maroschik
      Reviewed-by: Oliver Hader
      Tested-by: Oliver Hader
      82a24fa0
    • Mario Rimann's avatar
      [BUGFIX] File browser fails on inexistent expandFolder · a24bfae4
      Mario Rimann authored
      If a user browsed to a directory "foo" and re-opens the file-
      browser later, the same directory is shown expanded.
      
      In case the directory has been moved/renamed/deleted in the
      meantime, the user gets an exception due to the inexistent
      directory.
      
      This change just adds a try/catch block around to handle that
      situation.
      
      Change-Id: I39aab6be46aec1d3f1f365e5d5f5455aca9b3aa2
      Resolves: #50266
      Releases: 6.2, 6.1, 6.0
      Reviewed-on: https://review.typo3.org/26466
      Reviewed-by: Markus Klein
      Tested-by: Markus Klein
      Reviewed-by: Pascal Maechler
      Reviewed-by: Wouter Wolters
      Tested-by: Wouter Wolters
      Reviewed-by: Steffen Ritter
      Tested-by: Steffen Ritter
      a24bfae4