- Aug 12, 2022
-
-
Oliver Bartsch authored
The StandardContentPreviewRenderer still contained special handling for the tt_content.select_key field, which however was already removed in #77934. The leftover is now removed together with related locallang labels. Resolves: #98125 Related: #77934 Releases: main, 11.5 Change-Id: I38ae07a4eced0cbd3f5ed3076661b70081252321 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75420 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 11, 2022
-
-
Česlav Przywara authored
Releases: main, 11.5 Resolves: #98115 Related: #92118 Change-Id: Ibcd5fa26155dbb36216422e1c806c9a4035d878f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75409 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Stefan Bürk authored
With #97989 correct workspace overlays in DataMapProcessor should be used to fix a bug. This introduced a failing default "where" if a child table is not workspace aware. The fix itself is straight forward: Query t3ver_wsid field only if the target table is workspace aware. On functional test level, a new scenario set is added to look at details when a parent table like pages or tt_content is workspace aware, but inline children are not. The new test setup "test_inline_foreignfield_non_ws" is similar to "test_inline_foreignfield", just without the frontend scenarios, which are kinda useless here, at least for now. They reveal various further inconsistencies we should take care of with further patches. For now, these tests should verify the hard "workspace column does not exist" fail can't happen anymore in the future. Resolves: #98103 Related: #97989 Releases: main, 11.5 Change-Id: Id8cb51623b206b5effd57823a28099ce7d545b7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75401 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
-
- Aug 10, 2022
-
-
Sybille Peters authored
Resolves: #98119 Releases: main, 11.5 Change-Id: If5e926d002e877e674548f63b8639acf62d5bf99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75413 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Benni Mack authored
With the fix of using versioned numbered filenames for the TYPO3 Backend, a use-case "absolutely referenced, but relative to public path file" did break for Frontend inclusions of CSS or JS files. This is now overcome by only using the original bugfix in the TYPO3 Backend. Resolves: #98106 Related: #97939 Releases: main, 11.5, 10.4 Change-Id: Iff6251bd95e1c0a93a6f5538b9f560e55ba80b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75412 Tested-by:
-
Tomasz Woldański authored
Patch extracts generating url for workspaces in order to better integrate with external extensions, so when external extension want to replace url, extension does not have to override whole handleRequest method. Resolves: #98112 Releases: master, 11.5 Change-Id: I8c8e18fbe7dfecd2ccd400681588d984ac233178 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75407 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Tested-by:
-
Markus Klein authored
Resolves: #98113 Releases: main, 11.5 Change-Id: Ia996d0e66f381d71699b33a42e4c8f72bf890054 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75410 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
- Aug 09, 2022
-
-
Christian Keuerleber authored
With introducing the overhaul of the TypoScript parser and the related parts like the ObjectBrowser and Template Analyzer, it has been overseen that a invalid variable has been used in a fluid partial. This patch changes the partial to use the correct variable. Resolves: #98087 Releases: main Change-Id: I9c0ec2d99b557fe4df147402e53d04d4f29f76da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75376 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Stefan Bürk authored
This patch raises "typo3/class-alias-loader" which contains some bugfixes. Used commands: > composer req "typo3/class-alias-loader":"^1.1.4" \ --no-update -d typo3/sysext/core > composer req "typo3/class-alias-loader":"^1.1.4" Resolves: #98102 Releases: main, 11.5 Change-Id: I772a40dd9676afc7721e819077f05662ce2c6bd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75396 Tested-by:
-
- Aug 08, 2022
-
-
Alexander Schnitzler authored
To gather information about properties of domain objects, extbase used method DomainObjectInterface::_getProperties() which internally used get_object_vars() which does not return uninitialized properties. This leads to the inability to use such uninitialized properties in models. Hence, those properties are not reconstituted at all when converting an object instance from a database row, eventually leading to fatal errors. To mitigate this issue, extbase does now use the existing information about classes gathered via ClassSchema which gathers information via reflection (anyway). Releases: main, 11.5 Resolves: #95819 Change-Id: I00e2eb4967631ca28a5889e934fd409fd3fdef96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72005 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
Ralf Zimmermann authored
The patchset https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/ has moved the business logic from the RenderViewHelper to the FormRequestHandler. Thereby the process for detecting the prototype name was changed by mistake. The result is that custom prototype names are no longer applied. This patchset restores the correct behavior. Resolves: #98023 Releases: main, 11.5 Change-Id: I5d59e56c0c071879ad60321dd9d82a56cde94172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75288 Tested-by:
Daniel Gohlke <daniel.gohlke@extco.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
Stefan Bürk authored
Raise `typo3/cms-styleguide` to have needed bugfix for `doctrine/dbal` 3.4.x already in composer lock state available. Used command: > composer req --dev typo3/cms-styleguide:"~12.0@dev" Resolves: #98101 Releases: main Change-Id: I29f3ff695518cfb9117263bd618d155f372ddefa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75393 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Kevin Appelt authored
Resolves: #98078 Releases: main, 11.5 Change-Id: Ic177eeb9581c1513076e2e3301f29c0f97de5cd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75372 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Thomas Maroschik authored
Scenario: Given is a cluster of containers/servers that run multiple instances of the same TYPO3 instance. A load balancer round robins requests to those instances. Problem: A backend user logs in and gets a broken backend. No CSS and JavaScript is loaded. Requests to those resources return HTTP 404 errors. Analysis: TYPO3 concatenates assets on the fly per backend module when they are requested and saves them to a local temporary folder. As requests are routed to different containers on every request, the probability of hitting an container/server where the resulting asset is not yet generated, is very high (basically always). The only way to circumvent this, is to put the backend in debug mode, which has other unwanted side effects. Solution: Deactivate asset compression/concatenation altogether for the backend. As most servers deliver HTTP2/3 nowadays, the performance impact should be minimal. By skipping unnecessary processing and allowing browser caching, performance could be even increased. Resolves: #97936 Releases: main, 11.5 Change-Id: Ic696f4a3618e5bed3388ab0262ce2867d334723f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75175 Tested-by:
-
- Aug 07, 2022
-
-
Georg Ringer authored
To avoid a type error the method `EditDocumentController::generatePreviewCode` must also allow null as return value because the called method `PreviewUriBuilder::buildImmediateActionElement` can return null as well. Resolves: #98071 Releases: main, 11.5 Change-Id: Icb021503f8dc6417baa9f2c2f883ec426f92dfb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75351 Tested-by:
Thomas Anders <me@naderio.de> Tested-by:
Matthäus Gundlach <mgu@dauskonzept.de> Tested-by:
-
Rémy Daniel authored
When sql strict mode is enabled on the database server, if a value has a wrong data type for the database column, the INSERT or UPDATE query will fail. This happened during a t3d import: relationships are lost. This patch fixes the issue by using the TCA default value for the field. Resolves: #89103 Releases: main, 11.5 Change-Id: I7e995f10359c6935f6b9a50b1150c31e63937ab9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75385 Tested-by:
-
Simon Schaufelberger authored
Resolves: #98094 Releases: main, 11.5, 10.4 Change-Id: If84f67d6ac91aeaa47849067e21bef6b13854f3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75386 Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
-
Tomas Norre Mikkelsen authored
This adds back the cursor pointer when hovering toggle checkboxes, common checkboxes and radio-buttons. Resolves: #97836 Releases: main, 11.5 Change-Id: Ib4083b95ec76f0909a31788d3e07a3321b8d63ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75127 Tested-by:
-
Andreas Fernandez authored
Any usage of FontAwesome has been removed with #97877 already. This patch removes the integration of FontAwesome from the TYPO3 backend, including the `FontAwesomeIconProvider`, the font files, and any CSS. The polyfill extension is available via Composer via ``` composer require friendsoftypo3/fontawesome-provider ``` and in the TER soon. Resolves: #98089 Related: #97877 Releases: main Change-Id: I28968bc45a43a244b82fe9a888e10d958d42cf1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75342 Tested-by:
-
- Aug 06, 2022
-
-
Andreas Fernandez authored
To make datetimer picker buttons focus the belonging textfield, the buttons were rendered as `<label>` which is a very dirty hack, leading to clitching buttons. To solve this, the `@typo3/backend/global-event-handler` module is now capable of focussing a specific element after clicking a trigger element. Resolves: #98054 Releases: main, 11.5 Change-Id: I828785267e6a8c25f3ed7c17221e903cd4cc3220 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75331 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Xenia Thiem authored
Resolves: #97248 Releases: main, 11.5 Change-Id: I2f9e3f9f2d530c5e416d57ec7e6b2d68a2b85531 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75382 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Chris Müller authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186 the Fluid-based page view layout was introduced. However, a leftover setting from the development of this feature remains in the TYPO3_CONF_VARS setting: BE|fluidPageModule. Instead, a feature flag was used to switch to the deprecated page view layout. See also the comment in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186/50/typo3/sysext/core/Configuration/DefaultConfiguration.php#1078 Resolves: #98095 Related: 90348 Releases: main, 11.5 Change-Id: I8ed24782b53673dc7759bf158fe02186f84c16c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75387 Tested-by:
-
- Aug 05, 2022
-
-
Andreas Fernandez authored
FontAwesome provides CSS classes that align with the old Bootstrap v3 classes, which will cause troubles with the removal of FontAwesome. As another preparation task, those classes are be replaced with the according Bootstrap classes. Classes replaced: * pull-left -> float-start * pull-right -> float-end * sr-only -> visually-hidden Resolves: #98064 Resolves: #94531 Releases: main, 11.5 Change-Id: I4e96572e6b3a0007a7bf68f3018934f73da6249b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75344 Tested-by:
Stefan Kapitza <s.kapitza@neusta.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Simon Schaufelberger authored
Since the persisted file is stored with a sanitized filename, it must be replaced with a sanitized file name as well, otherwise an error occurs that the source with the un-sanitized file name could not be found. Resolves: #98005 Releases: main, 11.5, 10.4 Change-Id: I9b38316f7a25a281521bff787956dcd6373249d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75267 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Georg Ringer authored
Resolves: #98076 Releated: #97201 Releases: main Change-Id: I149cbde864bec608f4aba8429d82d75e6f9420d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75350 Tested-by:
-
Stefan Bürk authored
Quite some issues with docker-compose v2 have been fixed We'll now try to use it again and remove a v1 restriction in `Build/Scripts/runTests.sh`. Resolves: #98086 Releases: main, 11.5, 10.4 Change-Id: I7e4ff82df374db33ba42db0e0d1483f6320ba9ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75374 Tested-by:
-
- Aug 04, 2022
-
-
Oliver Bartsch authored
The element information component displays all the records' field values. In case a TCA field does not have a corresponding database field (e.g. with TCA type "none") it is now skipped to prevent PHP errors. Resolves: #97999 Releases: main, 11.5 Change-Id: I817f1dda4275f262768dfbe8440a57d9d6240f7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75349 Tested-by:
-
Andreas Fernandez authored
The DebugConsole comes from ExtJS times and was triggered when e.g. a request failed to give a developer its response, including the stacktrace. Nowadays, browsers offer a console allowing to investigate requests. Also, PHP debuggers (e.g. xdebug) are commonly known and used, which makes the DebugConsole obsolete. Resolves: #98069 Releases: main Change-Id: I8adcb6594d6434b4d0e0314219087b3230324c9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75348 Tested-by:
-
Oliver Bartsch authored
Creating a sys_filemounts record via the context menu sets the corresponding folders' combined identifier as default value for the new record. With #97922, the previously used separate fields "base" and "path" were replaced by the new "identifier" field. Therefore the default value is now correctly set for this new field. Resolves: #98011 Related: #97922 Releases: main Change-Id: I75bc5248c659522767ca2d798bb8bef2ac58ae3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75347 Tested-by:
-
- Aug 03, 2022
-
-
Nikita Hovratov authored
The TCA option "min" allows to define a minimum number of characters a text field should have. This effectively adds a "minlength" attribute to the input field. If you are short on characters, an alert badge will show you how many characters are missing. The FormEngine won't allow saving fields which don't provide enough characters. Zero characters (empty fields) are allowed, as this is the same behaviour as the html attribute has. If empty fields shouldn't be allowed, a combination with "required=true" is necessary. This option works for default type="input" fields and type="text" fields, except if RTE is enabled. DataHandler will also take care for server-side validation and reset the value to an empty string, if "min" is not reached. Resolves: #92861 Releases: main Change-Id: I985caf9c62e362a9015fde1513a9a5fba0622587 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70196 Tested-by:
-
- Aug 02, 2022
-
-
Christian Kuhn authored
We recently raised php-cs-fixer to a new minor and missed running the fixer on all files which leads to a red nightly. > Build/Scripts/runTests.sh -s cgl Resolves: #98066 Related: #98062 Releases: main Change-Id: I26f873df9f1d40ed35480df79b4bf6a92cdbb213 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75345 Tested-by:
-
- Aug 01, 2022
-
-
Christian Kuhn authored
Bump a series of casual dependencies to youngest versions. Left out: composer, psr, symfony > composer req bacon/bacon-qr-code:^2.0.7 > composer req bacon/bacon-qr-code:^2.0.7 -d typo3/sysext/core/ --no-update > composer req doctrine/event-manager:^1.1.2 > composer req doctrine/event-manager:^1.1.2 -d typo3/sysext/core/ --no-update > composer req lolli42/finediff:^1.0.2 > composer req lolli42/finediff:^1.0.2 -d typo3/sysext/core/ --no-update > composer req nikic/php-parser:^4.14.0 > composer req nikic/php-parser:^4.14.0 -d typo3/sysext/core/ --no-update > composer req nikic/php-parser:^4.14.0 -d typo3/sysext/install/ --no-update > composer req typo3/html-sanitizer:^2.0.15 > composer req typo3/html-sanitizer:^2.0.15 -d typo3/sysext/core/ --no-update > composer req --dev friendsofphp/php-cs-fixer:^3.9.5 > composer req --dev php-webdriver/webdriver:^1.12.1 > composer req --dev phpstan/phpstan:^1.8.2 > composer u typo3/cms-styleguide Change-Id: Ia1848985be5aba038b8971ccee9f58f0b049b84c Resolves: #98062 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75343 Tested-by:
-
- Jul 31, 2022
-
-
Andreas Fernandez authored
Bootstrap is updated to 5.2.0. Due to a behavior change (perhaps a regression), carousels need adoption if they shouldn't slide automatically as the old approach results in indefinitely sliding: ``` - <div class="carousel slide" data-bs-interval="0" data-bs-ride="carousel"> + <div class="carousel slide" data-bs-ride="false"> ``` However, this is also documented at [1]. Executed commands: cd Build nvm use yarn add bootstrap@^5.2.0 yarn add --dev @types/bootstrap@^5.2.0 grunt build [1] https://getbootstrap.com/docs/5.2/components/carousel/#options Resolves: #98051 Releases: main, 11.5 Change-Id: Ic9c284d9edb3881b4cc8663fad3747c19f078613 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75329 Tested-by: -
Larry Garfield authored
Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98006 Releases: main Change-Id: If809683db556c2c91ae5f560a4a796c9477d3631 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75268 Tested-by:
-
Christian Kuhn authored
TCA fields having displayCond='HIDE_FOR_NON_ADMINS' can not be selected as "exclude" fields in user group setup access rights setup. It does not make sense to mark those exclude=true, the patch removes that from affected fields. Change-Id: Ia75248122bb645bd24c7948c7b4b82d2555ed9ee Resolves: #98046 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75324 Reviewed-by:
-
Christian Kuhn authored
When executed in random order, a parent directory may not exist. Take care it's created when needed. Resolves: #98060 Releases: main Change-Id: I102aedc8013157527759111d8080a8ee012c7c8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75338 Tested-by:
-
Christian Kuhn authored
The old TypoScript parser allows implementing own functions for the := operator using a hook: someIdentifier := myCustomFunction(myFunctionArgument) The new TypoScript parser does not implement this hook and adds a new event instead. Resolves: #98016 Related: #97816 Releases: main Change-Id: I66dd4e393333c239b75a5935aacdbde46b1518e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75280 Tested-by:
-
Stefan Bürk authored
Codeception released new major version 5, which unblocks upgrading to symfony 6 components. This patch raises codeception only, thus acting as a pre-patch to raise symfony requirements. Codeception 5 is hard to impossible with core v11, so this patch is v12 only: Codeception 5 requires PHP 8.0, so we'd have to support both 4 and 5 in v11 to allow testing with older PHP versions. This would result in various headaches since some API changes in codeception 5 are hard breaking in PHP, especially due to changed class property type hints. We'll thus keep codeception 4 in v11 and go with codeception 5 in v12. Minor acceptance test related adaptions are needed: * Replaced config option `path.log` with `path.output` * Added proper property type because of inheritance to codeception setup classes * Ensure method return type compatibility * Use `actor`instead of `class name` in suite config * Create acceptance split files in proper folder to ensure group filtering keeps working. Adjust clean up scripts and gitignore for this Used commands: > composer req --dev -w \ typo3/testing-framework:dev-main \ codeception/codeception:^5.0.0 \ codeception/module-asserts:^3.0.0 \ codeception/module-cli:^2.0.0 \ codeception/module-filesystem:^3.0.0 \ codeception/module-webdriver:^3.1.2 \ codeception/lib-asserts:^2.0.0 Resolves: #98047 Releases: main Change-Id: I5cea60c2641988cc032b30ed1fbe3d8b0ed3b3d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75317 Tested-by:
-
Peter Kraume authored
Resolves: #98059 Releases: main, 11.5 Change-Id: I078db9039c2f0acb05933fa6a86ca5d73b3fb5d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75337 Reviewed-by:
-
Christian Kuhn authored
Fluid 2.7.2 brought optional TemplateAwareViewInterface. This is used in two places for proper signatures and makes phpstan a bit more happy. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98057 Related: https://github.com/TYPO3/Fluid/pull/586 Releases: main Change-Id: I8b55af0d58b86a0f68dc3772e3ba66716ea32202 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73611 Tested-by:
-
