- Jul 16, 2022
-
-
Oliver Klee authored
Resolves: #97892 Releases: main Change-Id: Ib704bd1dbf8fb1be71ff80748c379273ded6552b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75096 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Oliver Bartsch authored
Replace wrong null fallback for "width" and "height" with empty string and also cast the values before passing to GraphicalFunctions->getImageScale() which expects them to be string. Resolves: #97952 Releases: main, 11.5 Change-Id: I80174038e54ce41dfbde5e5e35339b0a7429be4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75199 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #97953 Releases: main, 11.5 Change-Id: Ie152dfdb8c08f20a835ac9a1c8cf56f1206c4fa1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75201 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #97767 Releases: main, 11.5 Change-Id: I1c874770ad1201e22a95d0af67e7caf4b09a8aa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75198 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Jul 15, 2022
-
-
Oliver Bartsch authored
The new PSR-14 AfterPageTreeItemsPreparedEvent is added. The Event gets dispatched in the TreeController and allows to further modify the resolved and already prepared page tree items before being returned. The new event is directly used by EXT:workspaces to apply the highlighting of versioned pages. Using this new event allows to remove another cross dependency of EXT:backend. Additionally, the hooks $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Workspaces\Service\WorkspaceService']['hasPageRecordVersions'] and $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Workspaces\Service\WorkspaceService']['fetchPagesWithVersionsInTable'] are now removed, since this can now be done using the new PSR-14 Event. Resolves: #97945 Releases: main Change-Id: I2fa8df42f1820c9d6592d5a0654de9ada050e71c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75184 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
This reverts commit 88a8a246. Reason for revert: Accidentally merged without enough votes. Mixed up with a backport. Change-Id: Ice9ccc3cf27758673358f1b6501c3f71130e732d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75149 Tested-by:
-
Oliver Bartsch authored
Replace wrong null fallback for "width" and "height" with empty string and also cast the values before passing to GraphicalFunctions->getImageScale() which expects them to be string. Resolves: #97952 Releases: main, 11.5 Change-Id: I3c2eafd89f81f0b5d606a1c936c43a8bca57659c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75197 Tested-by:
-
Georg Ringer authored
The provided width and height must be cast to a string to avoid notices. Resolves: #97911 Releases: main, 11.5 Change-Id: Ifa7428571026fbd0b0905729ea8ad699ab080bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75196 Reviewed-by:
-
Andreas Fernandez authored
The templates used for the element browser are now separated into several templates, based on their usage. The element browser used in combination with FAL does not share the template with the folder-based element browser anymore. Resolves: #97933 Releases: main Change-Id: Ia1c4278c8fb656c8979dec9b60f2f892af18bd4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75172 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
When AbstractContentObject is fetching ->getPageRepository() but TSFE hasn't been fully initialized yet, the Context from TSFE should be used, and not the global one. Resolves: #97951 Releases: main, 11.5 Change-Id: I99880839f5458469e7181467de6a8fb667ef9828 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75194 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
-
Stephan Großberndt authored
This change makes sure hyphens are kept as part of a word instead of removing them. Removing them led to "casesensitive" instead of "case-sensitive" being lexed and added to the index, which in turn led to that occurrence not being found when searching for "case-sensitive". Releases: main, 11.5 Resolves: #93401 Resolves: #77644 Change-Id: I72f8d297384cea002e1ca6cb8e3b1973774199f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71885 Tested-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Tested-by:
-
Andreas Fernandez authored
FontAwesome will be phased out in a short while. As a precursor patch, login providers are prepared to accept a new option `iconIdentifier` which takes any icon from the Icon Registry. To ease the migration for 3rd party extension authors, this patch is aimed to be backported to v11. To make the login view itself a bit more logical, the link to reset a user's password is now moved above the available login providers. Resolves: #97950 Releases: main, 11.5 Change-Id: I96f6026c6726cf9dbc2635484bc7ad527f70b4d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75191 Tested-by:
-
Christian Kuhn authored
Creating a version overlay of a record that has flexform sections and moving or deleting some of these sections at the same time fails in DataHandler due to a wrong uid lookup for the section command array. The patch fixes this scenario in the DataHandler flexform processing code and leaves an according explanation comment. Resolves: #73761 Releases: main, 11.5 Change-Id: Ib1c910c59a2ebfe9b7545cabb258f44bac2cd273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75116 Tested-by:
Tina Westner <tina.westner@bgm-gmbh.de> Tested-by:
-
Jochen Roth authored
Resolves: #97931 Releases: main, 11.5 Change-Id: I745bffa0c6873f6b8ff5fb15f32da4cd6538959a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75170 Tested-by:
-
Andreas Fernandez authored
The CSS of @typo3/icons has changed with v3, but the web component `typo3-backend-icon` was not updated accordingly, which may cause glitches in the rendering. The CSS is now updated accordingly to match the CSS of @typo3/icons v3. Resolves: #97876 Releases: main Change-Id: I3149e3b1ef31d2766143589fc9fef4b0ee4b9616 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75051 Tested-by:
-
- Jul 14, 2022
-
-
Sybille Peters authored
Resolves: #97946 Releases: main Change-Id: I3454255329a5cac29fa5ee8ed78f78ca47133e89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75185 Tested-by:
-
Oliver Klee authored
This helps static code analysis in extensions. Resolves: #97893 Releases: main, 11.5 Change-Id: Ie2eee8244438cc8d4624608ce261f5418540c672 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75097 Tested-by:
-
Frank Naegler authored
Resolves: #97036 Releases: main, 11.5 Change-Id: I4342011309a35233d278aec73e36a6dcf542babc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75131 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
This change adapts the QuerySettings functionality for Extbase in v12 to allow to work with a LanguageAspect which contains all information regarding the language ID and the overlay mode. For this reason, the following method definitions are removed within Extbase's QuerySettingsInterface - setLanguageOverlayMode() - getLanguageOverlayMode() - setLanguageUid() - getLanguageUid() However, it is still possible to use the existing methods on the QuerySettings implementation of TYPO3 for TYPO3 v12. It is now recommended to use ->getLanguageAspect() and ->setLanguageAspect(). This change is a pre-requisite to extend language handling across TYPO3 and Extbase. Resolves: #97926 Releases: main Change-Id: I38a685fcfdb98d5ec3c82b02e6cc78df12062fa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75093 Tested-by:
-
linawolf authored
The reference "Inside TYPO3" is not available anymore since TYPO3 8.7. The sentences are quite useless anyway. Releases: main, 11.5, 10.4 Resolves: #97913 Change-Id: I2d496726db8b22de667d230a99f7d17341fd309d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75157 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Andreas Fernandez authored
To clean up cluttered severity definitions for flash messages and reports, a new `ContextualFeedback` enum is introduced. The enum is backed, means it holds actual values, which match the previously known integer values for severities. An internal `transform()` method may be used to maintain backward compatibility where needed and to trigger deprecation notices. Resolves: #97787 Releases: main Change-Id: I44b706c929277bc765bf302b2b1d32aa1da31f85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74925 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
In case GU::createVersionNumberedFilename() receives a file with an absolute path, no back path should be resolved since the resolved path will always be invalid, which led to no version number got added to the filename anymore. This is now fixed by checking for the path being absolute. Resolves: #97939 Releases: main, 11.5, 10.4 Change-Id: I5bb0150fa27b8c9c1af2aa99bd8baacd55889245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75179 Reviewed-by:
-
Benni Mack authored
Symfony 5.4 ships with a new feature to add "aliases" to routes. TYPO3 can now replace legacy and complicated names for routes or modules with new ones while keeping backwards-compatibility with old links / references. See https://symfony.com/blog/new-in-symfony-5-4-route-aliasing for more details. Module registration now allows to define "aliases" (array), same for route registration. As an example, complicated module name such as "web_WorkspacesWorkspaces" is renamed to "workspaces_admin" which reflects the current possibilities for module identifiers much better. An upgrade wizard migrates the current backend user and backend group permissions ("userMods" and "groupMods") to the new logic. Resolves: #96515 Releases: main Change-Id: I3c6c9a3be3fddabe2910df4890528cc4f85a4586 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72960 Tested-by:
-
Nikita Hovratov authored
Resolves: #97938 Releases: main, 11.5 Change-Id: I711a541a9d38f7cd9ea2b1828a5353a8d1f7e0e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75176 Tested-by:
-
Christian Kuhn authored
The testing-framework functional test db snapshot helper expects the database to be empty when withDatabaseSnapshot() is called. Rows should only be populated within the create callback. There was a workaround in testing-framework to relax this restriction due to unfortunate backend user related setup code flow. This has been resolved with #97928, so the testing-framework snapshot can be more strict on this now. The patch adapts a couple of snapshot usages to align to this enforced restriction. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I50d6dda3671729bd603899e37e7c7d0979c094fe Resolves: #97935 Related: #97928 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75174 Tested-by:
-
Nicole Cordes authored
If a record with associated inline records gets copied, the DataHandler always handles the record creation as new versions. This raises some warning when the corresponding table doesn't support workspaces. This patch prevents warnings when a corresponding irre-table cannot create any new version of a record. Resolves: #97712 Releases: main, 11.5 Change-Id: Iadcdf693f82d021eca5af1350855803ba433c37b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75166 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Using functional test related .yaml scenario setup which uses DataHandler to prime the test database is pretty slow. TreeControllerTest can speed up using the withDatabaseSnapshot() method to cache db results for subsequent tests. Resolves: #97934 Releases: main Change-Id: I4c8f40f181f77bf07a0b26825138cb1577fe441e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75173 Tested-by:
-
Stefan Bürk authored
Two functional tests use the testing-framework db snapshot feature without really needing it. Those can be simplified. This patch removes the `withDatabaseSnapshot()` usage, and cleans one test which fails to free an only partially fetched db result set, which otherwise leads to fails with sqlite. Resolves: #97932 Releases: main Change-Id: I52d97000c1e8129bc0faa601d990e5274f416d4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75171 Tested-by:
-
- Jul 13, 2022
-
-
Christian Kuhn authored
The testing-framework method setUpBackendUserFromFixture() is kinda flawed since it does two things at once: It creates db records and creates global state. This is unfortunate in various cases, especially when db snapshoting is used. Additionally, it relies on a class property which defaults to a fixture file delivered by testing-framework in XML format. We want to get rid of the .xml fixtures, and we don't want that the testing-framework delivers default fixtures. The patch adapts all usages of the property and of method setUpBackendUserFromFixture() by splitting it into two calls to first insert a local extension fixture .csv file and to then call the backend user init helper method. This finishes the removal of .xml fixture uses in the core. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I32a5c43a6c8176a9e9182d08e08b42b5ff279634 Resolves: #97928 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75168 Tested-by:
-
Benjamin Kott authored
Resolves: #97929 Releases: main Change-Id: I2957673006b874a3d35a605c7bf204bedf897334 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75169 Tested-by:
-
Frank Naegler authored
This patch combines the two fields base and path into a new field identifier. In the backend UI, the new TCA type folder is used to select the folder. This change improves the performance in the backend if the storage contains a massive amount of folders and subfolders. Besides that, the usability is better because of the browsing feature of the folder type. Resolves: #97922 Related: #52374 Release: main Change-Id: I3054ef98d31fd1615174d2fed68f639cf78f5f6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75163 Tested-by:
-
Benni Mack authored
"config.doctypeSwitch" was used to bring TYPO3's Frontend into "Quirks Mode" when using XHTML, important for Internet Explorer. Internet Explorer is not supported by Microsoft anymore, and XHTML is superseded by HTML5. For this reason, TYPO3 Core should not support such an edge-case anymore. Resolves: #97927 Releases: main Change-Id: Ifa9ad9dd460d1c9690cefcd905be469b6d508574 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75167 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Christian Kuhn authored
This avoids using importDataSet() in functional tests using .xml fixture files from the testing framework. Usages are converted to importCSVDataSet(), fixture files are added as .csv to the according extension. XML handling in functional tests is now down to setUpBackendUserFromFixture() which will be prepared in testing-framework and adapted in core with another patch. Change-Id: Ifc3cc30d4b824775dc6ccc7e1d982d9d122f39d9 Resolves: #97924 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75165 Tested-by:
-
linawolf authored
Releases: main Resolves: #97915 Change-Id: I5dd0812847d1984b312e1d452ff38232b20f100a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75159 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Christian Kuhn authored
The acceptance test base class in testing-framework now allows to load .csv instead of .xml files to prime the database with records. These files are easier to read and maintain and we avoid a fixture dependency to the testing-framework this way. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I7055215a2006d985af1b19929157bdef2190854d Resolves: #97921 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75156 Tested-by:
-
Stefan Bürk authored
Docblock annotations with more then one space between a wildcard character `*` and the annotation start character `@` was not found. Additionally, annotation identifiers did not regonize hyphens as valid identifier character, thus cutting of e.g. phpstan annoations. This patch now properly finds annotions with multi-space separations and annotation identifiers containing hyphens. Additionally, two phpstan specific annotations are allowed. > https://phpstan.org/writing-php-code/phpdoc-types#local-type-aliases Summarized contained tasks: > find multi-space separated annotations e.g. `* @<AnnotationIdentifier>` > properly extract full annotation identifier containing hyphens e.g. `* @annoation-identifier-with-hyphen` > add `@phpstan-type` and `@phpstan-import-type` as allowed annotation, but only on class level, and not on class-property or class-method level Resolves: #97917 Resolves: #97918 Resolves: #97919 Releases: main, 11.5, 10.4 Change-Id: Iab69ffd87d407088f1237168e19b67a8dc846c8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75160 Tested-by:
-
Andreas Fernandez authored
The NoopPasswordHash fixture is currently used in MFA provider tests only. To declutter the Tests/ directory, the fixture directory is now moved to core/Tests/Unit/Authentication/Mfa/Provider/. Resolves: #97920 Releases: main, 11.5 Change-Id: I86544bf897a26a2565278e2432831adde7154be8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75161 Tested-by:
-
- Jul 12, 2022
-
-
Andreas Fernandez authored
Since Symfony 5.x, the Command class offers constants for possible return values to be used in a commands `execute()` method. All commands are adjusted. Resolves: #97912 Releases: main Change-Id: I14f7e13ceb1b10cb21528bb420a6f8c1a20f8ab3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75154 Tested-by:
-
Larry Garfield authored
PHPStan identified these code paths as impossible. On code inspection that's true, so they have been removed as dead code. That allowed for the properties of the class to be typed. Small related cleanup is included to make verifying that the code paths were indeed dead easier. Resolves: #97621 Releases: main Change-Id: Icc5e53ef72fedb9fc5de659b22229d61c8502f1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74636 Tested-by:
-
Andreas Fernandez authored
With the removal of datatables in #86343 the search terms used to filter tables were not stored anymore, leading to unfiltered tables after requesting pages with such again. This is found to be annoying in the extension manager when many extensions with the same prefix need to get managed. The search terms are now stored in the browser session and the local extension list is filtered again when visiting the extension manager. Resolves: #93628 Related: #86343 Releases: main, 11.5 Change-Id: Ib99e1fbf0ad420826164f8fed019c5235f8c43d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75153 Tested-by:
-
