- May 07, 2023
-
-
Oliver Bartsch authored
The record title in the delete confirmation modal of FilesControlContainer is now properly replaced. Resolves: #100815 Releases: main, 12.4 Change-Id: I6a66242a9d2e5fdea28191d3d98da036c3af77aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78947 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- May 06, 2023
-
-
Stefan Bürk authored
Used command(s): > composer req --dev "sokil/php-isocodes-db-i18n":"^4.0.13" > Build/Scripts/updateIsoDatabase.php Resolves: #100822 Releases: main, 12.4 Change-Id: I5412a28306892af4fe3bb7ea511f138256c738db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78951 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
- May 05, 2023
-
-
Oliver Klee authored
Resolves: #100820 Releases: main, 12.4 Change-Id: I56e1bafc3f8036aa3b43ca374f0427947056c53c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78948 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Oliver Bartsch authored
Selecting an offline folder in element and link browsers no longer triggers a `FolderDoesNotExistException`. Resolves: #100793 Releases: main, 12.4 Change-Id: I7942f791a9376def3ae2ba869f0cbcc6d68072da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78926 Reviewed-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Andreas Fernandez authored
The identifier used to get a container in `type=files` based on `querySelector()` which flawed if the identifier contained a dot. The example identifier "#foo-data-foo.bar" resulted in "find an element with id 'foo-data-foo', having the class 'bar'", which is wrong. To solve this issue, while still limiting the scope to the web component, the selector is changed to use the `[id='']` syntax, which doesn't show the erroneous behavior. Resolves: #100777 Releases: main, 12.4 Change-Id: I9edff128c612cc6a614b65866533c3fb1c731f4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78943 Reviewed-by:
-
Oliver Bartsch authored
In case a site is missing a proper site configuration - having no default language a fallback SiteLanguage object is used in the page module. This fallback however does provide an empty string as flag identifier, which does no longer result in a broken icon. Resolves: #100799 Releases: main, 12.4, 11.5 Change-Id: I23f3d9347d2ea8a63520086054b9fa842a9f5cfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78929 Reviewed-by:
-
Christian Kuhn authored
Minor release update from ^2.7.4 to ^2.8.0: - main/v13: Require ^2.8.0 - v12: Require ^2.8.0, projects will update with next core patch level release - v11: No change, projects *may* be able to update if running PHP ^8.1 and having mbstring - v10: No change, projects won't be able to update since core does not allow PHP 8.1 Notable changes: - Require PHP ^8.1 and mbstring - Syntax improvement: A comma with spaces and line breaks on last fluid "arrays" and inline syntax is now parsed as expected. <f:variable name="myArray" value="{ 0: 'first item', 1: 'second item', }" /> {f:if( condition: myVariable, then: 'yes', else: 'no', )} - Syntax improvement: Resolve multi variable references correctly. {foo}bar{baz} foo.{bar}.{baz} - PHP 8.1 fix when resolving invalid variable references {{notExistingVariable}} - General performance improvements when resolving variables. This boosts templates that access lots of variables which resolve to object methods like {object.name} to $object->getName(). This has measurable impact for instance in the backend "log" module when rendering many rows, and reduces overall parsetime by about 1/4 in the TypoScript "Active TypoScript" module when rendering bigger TypoScript trees like the bootstrap package. Commands: > composer req typo3fluid/fluid:^2.8.0 > composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/adminpanel > composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/core > composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/fluid > composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/redirects Change-Id: Iaad13cdd327642b52e9e706997485f95ab951032 Releases: main, 12.4 Resolves: #100812 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78939 Tested-by: -
Anja Leichsenring authored
In preparation of composer based test setups, all fixture extensions require fully functional `composer.json` files. For starters, the minimal required `composer.json` is added. We will adjust as we go. Extensions without classes don't receive PSR-4 class loading definitions as those are not needed. As a convention, all fixture extensions have their composer name use the vendor `typo3tests`. Classes will have the vendor `TYPO3Tests`. This way, fixture extensions are easy to identify, both by providing tests that use the extensions, as well as in development to not accidentally use such an extension or class. Resolves: #100783 Releases: main, 12.4 Change-Id: I476864b528eaab1acec0a950c85d5ff92be7b516 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78913 Tested-by:
-
Anja Leichsenring authored
In preparation of composer based test setups, all fixture extensions require fully functional `composer.json` files. For starters, the minimal required `composer.json` is added. We will adjust as we go. Extensions without classes don't receive PSR-4 class loading definitions as those are not needed. As a convention, all fixture extensions have their composer name use the vendor `typo3tests`. Classes will have the vendor `TYPO3Tests`. This way, fixture extensions are easy to identify, both by providing tests that use the extensions, as well as in development to not accidentally use such an extension or class. Resolves: #100782 Releases: main, 12.4 Change-Id: If609f995dd31bd4549248436e660b3f86ce91687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78914 Tested-by:
-
- May 04, 2023
-
-
Jan Delius authored
With this change it is again possible to give backend users their own password when creating. Previously, any new user record was created with a random password - even if the given password matched the password policy. Resolves: #100762 Releases: main, 12.4 Change-Id: I61a0a3ddc7fbb6322c2f7dab0caa8825f5a9961a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78877 Reviewed-by:
Jan Delius <me@jandelius.eu> Tested-by:
Rico Drexler <rico.drexler@gmx.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Chris Müller authored
The method "withAttribute()" expects a string or null as second argument. Resolves: #100801 Related: #96641 Releases: main, 12.4 Change-Id: I2b8ef43c51159bd92730edbc47b07c2350d5f399 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78931 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- May 03, 2023
-
-
Andreas Nedbal authored
RecoveryService::prepareMail creates a FluidEmail, but returns it as Symfony\Component\Mime\Email. Setting the signature to the proper type, which also is used in the SendRecoveryEmailEvent, allows easier adjustment of the sent email. Resolves: #100174 Releases: main, 12.4 Change-Id: Ic88e23fea52cfc6f61efc885eb24267fb461628f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78384 Reviewed-by:
-
Oliver Hader authored
Change-Id: Iceddddf38a028e8587848a88d7ec1a3dc7c0888a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78925 Tested-by:
-
Georg Ringer authored
The mime type 'audio/x-wav' must be added to the AudioTagRenderer to render those files as audio file. Resolves: #100138 Releases: main, 11.5 Change-Id: Icce1698f2de725161fc5add2b711a8b764ee6c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78087 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
abohn_hebotek <alexander.bohn@hebotek.at> Tested-by:
Florian Heder <florian.heder@hebotek.at> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Hader authored
The fix for issue #100695 reorganized the logic for setting new cookies. However, the assumption - to only set a cookie when the class property `$dontSetCookie` is disabled or a permanent cookie is used - is wrong. Previous TYPO3 versions were issuing new cookies, when `AbstractUserAuthentication::setSessionCookie()` was invoked. This change restores the previous behavior. Resolves: #100787 Releases: main Change-Id: I661a64546b99459eb81e466fdd5b03e56aeb6e93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78923 Tested-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- May 02, 2023
-
-
Oliver Bartsch authored
Since #100623, the content object might be NULL as it is no longer set up when initializing the UriBuilder, but instead when handing in the current PSR-7 request. This patch adds a fallback for v12 to ensure having the content object available when generating frontend urls. Resolves: #100788 Related: #100623 Releases: main Change-Id: I733b0019a974889970d63845e3afcff5113570d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78920 Tested-by:
-
Helmut Hummel authored
When defining a default value in column overrides e.g. for tt_content TCA field sys_language_uid this value from TCA will override the value that will be set via the page module when adding a content element for a different language, because the change introduced in #86876 does not respect default values that are set via defVals (which are passed to form engine as defaultValues) A check if such values are set is now added, so that the fix for #86876 will still work, but default values set via editing forms are also respected Resolves: #99381 Releases: main, 11.5 Change-Id: Ib4270665b396bbe520afb21a7f145d0d549305ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77172 Tested-by:
-
Andreas Fernandez authored
Clicking the "Remove all" button in the CSP backend module now closes any open report. Resolves: #100757 Releases: main Change-Id: Ie6b4b5d581c2b44385f40c9db8d3b5bcbd1b8a2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78879 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Oliver Bartsch authored
Properly check for the given value being an object before passing it to corresponding method, which is type-hinted since #100068. Resolves: #100774 Related: #100068 Releases: main, 11.5 Change-Id: I704ef93ebbbfd1f161bf56dd7ef0058bd2b4875d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889 Tested-by:
-
Torben Hansen authored
With #96874, the timestamp example plugin for CKEditor has been added to `ext:rte_ckeditor`. The plugin is however not used or referenced anywhere, so it can safely be removed. Resolves: #100781 Releases: main Signed-off-by:
-
Oliver Bartsch authored
The PageLayoutResolver, which is used for "tree.pagelayout" TypoScript conditions requires the passed page record to contain the "backend_layout" field value. Since this field is by default not a rootline field, the TSFE->page array is now passed again instead of the shrinked record from the rootline. Resolves: #100764 Related: #100047 Releases: main Change-Id: I28ea56fb70b026e6d88b1cb00838490b35c2d5d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78891 Tested-by:
-
Oliver Klee authored
This helps static analysis of projects using this class. Resolves: #100778 Releases: main, 11.5 Change-Id: I41cbf38477fb6743e5039dd9905ed38be81e96fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78888 Tested-by:
-
- May 01, 2023
-
-
Georg Ringer authored
If files are used given like `news.setup.typoscript` and the TypoScript inclusion is used with `extension="setup.typoscript"`, the proper files must be allowed. Resolves: #100763 Related: #97816 Releases: main Change-Id: If161821d97bece80f272f6a3d94934e6d712024f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78878 Reviewed-by:
-
- Apr 29, 2023
-
-
Stephan Großberndt authored
Further improvements, most of them as proposed by Michael Schams Releases: main Resolves: #100755 Related: #100747 Related: #100740 Change-Id: I4111a8e1025eb7c2e5e5c3273e320505c153e4ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78875 Reviewed-by:
Michael Schams <typo3.mschams@2023.schams.net> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
- Apr 28, 2023
-
-
Andreas Fernandez authored
The "Webhooks" view in the "Configuration" module now shows the Symfony Messenger transport configured per webhook. Resolves: #100752 Releases: main Change-Id: I809cb376a24591249697c828b9454e4168e7bbd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78841 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #100776 Releases: main Change-Id: I1c602d05fb36d147a484755f4107f68c554c7ba1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78887 Tested-by:
-
Andreas Fernandez authored
With #100688, the module `es-module-shims` was updated. Unfortunately, with 1.5.3 an incompatibility with Firefox < 108 was introduced, affecting current Firefox ESR releases (currently at 102, at the time of writing this patch). To workaround this issue, the init scripts used in the Install Tool now use `importShim()` for the time being, until Firefox ESR hits version 108. Resolves: #100756 Related: #100688 Releases: main Change-Id: I1337ebbf1f01db287a53ff7ccad50cb4631250d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78881 Tested-by:
-
Anja Leichsenring authored
In preparation of composer based test setups, all fixture extensions require fully functional `composer.json` files. For starters, the minimal required `composer.json` is added. We will adjust as we go. Extensions without classes don't receive PSR-4 class loading definitions as those are not needed. As a convention, all fixture extensions have their composer name use the vendor `typo3tests`. Classes will have the vendor `TYPO3Tests`. This way, fixture extensions are easy to identify, both by providing tests that use the extensions, as well as in development to not accidentally use such an extension or class. Resolves: #100773 Releases: main Change-Id: Ibc1788031e39113dc1efda4ca7e4400e9cda444d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78886 Tested-by:
-
- Apr 27, 2023
-
-
Oliver Bartsch authored
Resolves: #100770 Releases: main, 11.5 Change-Id: I549371e78de399195d6810858d337528f39ce0ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78882 Tested-by:
-
Andreas Fernandez authored
The list of ids generated by `getSearchableWebmounts()` may contain duplicated values being passed into an `IN()` criteria, causing additional load to the database server. The values are now de-duplicated by applying `array_unique()` onto the list before passing the list around. Resolves: #100750 Releases: main, 11.5 Change-Id: Ib49bf1a5903cca2fbaa12ea240050caa7908f69c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78873 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Christian Eßl authored
In a list of backend users, using the avatar viewhelper, the instantiated Avatar class would always be the same instance. Each time, getImage() is called, the avatar providers would be initiated again, flooding the $avatarProviders variable with superfluous providers. - Which meant, when rendering a list of just 50 backend users, we suddenly have 1275 calls to the avatar provider class, instead of just the expected 50. Resolves: #100366 Releases: main Change-Id: I8b2eed49b47853c52a4350eb06e671081e90e373 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78339 Tested-by:
-
Anja Leichsenring authored
In preparation of composer based test setups, all fixture extensions require fully functional `composer.json` files. For starters, the minimal required `composer.json` is added. We will adjust as we go. Extensions without classes don't receive PSR-4 class loading definitions as those are not needed. As a convention, all fixture extensions have their extension name start with `test_`, and their composer name will use the vendor `typo3tests`. Classes will have the vendor `TYPO3Tests`. This way, fixture extensions are easy to identify, both by providing tests that use the extensions, as well as in development to not accidentally use such an extension or class. Resolves: #100737 Releases: main Change-Id: I312c2dd2f906d3299dae3a1d54a977cde3ce0b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78815 Reviewed-by:
-
- Apr 26, 2023
-
-
Andreas Fernandez authored
`text-overflow: ellipsis` only works in Firefox if the parent element has an explicit width. Therefore, `button` and `a` elements are now set to a width of 100%. This also fixes an issue where images appear to be squeezed in Firefox. Resolves: #100743 Resolves: #100761 Releases: main Change-Id: I750f553b0fbdc0a05652074b785ec5028d3937bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78876 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Chris Müller authored
Resolves: #100753 Releases: main Change-Id: Ia3d98fad1be54ad3056b746c436556f33d2a7818 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78842 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Benjamin Kott authored
The clearable javascript was never included or initialized. Wrappers handled by the clearable implementation have been dropped from the templates. Resolves: #100754 Releases: main Change-Id: I39f6f995821bfbda549e088b51d8d63865fb478c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78872 Reviewed-by:
-
Frank Naegler authored
Resolves: #100726 Releases: main Change-Id: I49384e7bbf3f199504ee7a978a816df1285474ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78805 Tested-by:
-
- Apr 25, 2023
-
-
Stefan Bürk authored
Used command(s): > composer u typo3/testing-framework > composer u typo3/cms-styleguide Resolves: #100751 Releases: main Change-Id: Ie5983bc76593e088190b1c81f0d33b23e98e4759 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77624 Reviewed-by:
-
Gilbertsoft authored
This patch avoids undefined key warning and properly casts the haystack argument of the `InArrayViewHelper` to an array. Resolves: #100748 Releases: main Change-Id: Ifc7d3597374eb98441aa29ac3af4e1dd8eb24409 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78840 Reviewed-by:
-
Andreas Fernandez authored
The docs for configuration message routing mention the non-existent array `$GLOBALS['TYPO3_CONF_VARS']['SYS']['queue']`. This is now fixed to be `$GLOBALS['TYPO3_CONF_VARS']['SYS']['messenger']` instead. Resolves: #100744 Related: #97700 Releases: main Change-Id: Iad8b40d9e0ba2695a60cee60379316bafed7adf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78838 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Stephan Großberndt authored
Releases: main Resolves: #100747 Change-Id: Ifd39f0813996674620fe1b89aef29ca87351e5b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78839 Reviewed-by:
-
