- Sep 30, 2018
-
-
Benni Mack authored
PageArguments are fetched and added on top of PSR-7 request queryParams right after they are validated from the PageRouter. They are also re-populated after config.defaultGetVars has modified global state. But they do not need to be set to TSFE again within the the PageArgumentValidator middleware. Resolves: #86483 Releases: master Change-Id: I03df4223832845038d4207417cfcab7cbcc687dc Reviewed-on: https://review.typo3.org/58507 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
The Installer uses a full grid which is a lot of white space if not needed. So, the whole layout is put into a col-md-6 grid with a col-md-offset-3 offset. Resolves: #86482 Releases: master Change-Id: If2e409deae98c0cf23eb7606a6cf35b950834874 Reviewed-on: https://review.typo3.org/58506 Reviewed-by:
-
Nikita Hovratov authored
* The last item in panel-collapse has now proper padding to its bottom. * With a different behaviour of firefox a container having overflow-y ignores padding-bottom. A workaround is a pseudo-element reserving the same space as the padding attribute would have. Resolves: #86445 Releases: master Change-Id: I55b6318f1b59ceda65857726828deab5bc8a306f Reviewed-on: https://review.typo3.org/58460 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Benni Mack authored
When checking the parent page for an existing slug, the parent page should not be used if the parent page is a sys folder, spacer or recycler (pages.doktype), but the traversal goes up. This makes it a bit easier for editors to work with better-speaking URLs and keep the rootline traversal as best practice. Resolves: #86456 Releases: master Change-Id: I2c46d096e41fb3a325fd42bf86b8968b79d6305b Reviewed-on: https://review.typo3.org/58473 Tested-by:
-
Benni Mack authored
While introducing Page URL handling, the workspace functionality still built the URL with `/index.php` although the Router should take care of that now. As drive-by fix, the BackendUtility preview URL hook now works again due to some refactoring back in TYPO3 9.2. Another drive-by fix allows to register the middleware at the right place to render the workspace preview in general. Resolves: #86480 Releases: master Change-Id: Icfa5a5eee304c27db39cf25903b9a14452c81168 Reviewed-on: https://review.typo3.org/58502 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Hader authored
When generating slugs it might happen, that double slashes are generated. This basically results from both prepending and appending slashes at the same time. Resolves: #86479 Releases: master Change-Id: I441fee333cd0b3fbad3dde1a130eb08356bd4c2d Reviewed-on: https://review.typo3.org/58503 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Hader authored
Improve processing by deferring those mappers that invoke persistence the latest possible time. In case mappers do not match the processing is stopped earlier to avoid superfluous checks and invocations. Resolves: #86464 Releases: master Change-Id: I4f9ec66611e84b49a54223f77aee824033a2fb7a Reviewed-on: https://review.typo3.org/58483 Tested-by:
-
Wouter Wolters authored
Shorten \TYPO3\TestingFramework\Core\Unit\UnitTestCase to UnitTestCase Resolves: #86478 Releases: master Change-Id: I5dc7704fb2776cff26f1bbf89b35e28fecd9a79e Reviewed-on: https://review.typo3.org/58501 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Jigal van Hemert authored
In the fieldWizard defaultLanguageDifferences the opposite value must be displayed if invertStateDisplay is active in fields of type "check". Resolves: #86205 Releases: master Change-Id: Iac8fa73406b076b3d26a6ed3aed7e21b79220750 Reviewed-on: https://review.typo3.org/58238 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Christian Kuhn authored
Resolves: #86476 Releases: master Change-Id: I182bd77895744d13ba535b43e46b802def49cb45 Reviewed-on: https://review.typo3.org/58498 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Resolves: #86474 Releases: master Change-Id: I2265e9167dc0604f8d2605121028c029fe3eebfc Reviewed-on: https://review.typo3.org/58496 Reviewed-by:
-
Wouter Wolters authored
Add the phpdoc_no_access rule to the php-cs-fixer configuration to prevent the @access annotation from entering the core again. Resolves: #86475 Related: #86446 Releases: master Change-Id: I9db729ae1375434bea49f92468f7d490a554b4fb Reviewed-on: https://review.typo3.org/58497 Reviewed-by:
-
Wouter Wolters authored
Resolves: #86477 Releases: master Change-Id: I9595a1f1a4d90566d732dcf3c3f8b883a08a6bbe Reviewed-on: https://review.typo3.org/58500 Reviewed-by:
-
Tymoteusz Motylewski authored
Make Extbase fetch records in the same way as in TypoScript rendering, making QuerySettings options mean the same as corresponding settings from TypoScript. This change allows e.g. to filter and sort by translated values of the aggregate root. To make upgrades easier a feature switch is introduced which enables the new behavior. It can be disabled with TypoScript if somebody relies on the old behavior. The feature switch is enabled by default in v9 and will be gone in v10 so in version 10 the fixed way will be the only way to fetch records in Extbase. Releases: master Resolves: #82363 Resolves: #84011 Change-Id: I58d0a24c1f73debc6b9251efea9c28c9cf09d6d0 Reviewed-on: https://review.typo3.org/53974 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Georg Ringer authored
Remove nested class "form-group" in backend user module form Resolves: #86450 Releases: master Change-Id: I15a46b772d55ee8c0ea6fe9de00ef5a3cf53f27e Reviewed-on: https://review.typo3.org/58468 Tested-by:
-
Benni Mack authored
The TypoScript Parser has been around since PHP 4 and hasn't been touched much since 12ys. In order to speed up TypoScript processing in the future, it is important to first streamline all usages and mark internal functionality as "protected" instead of "public". Some other parts for sys_template rendering has been marked as internal as well. Resolves: #86461 Releases: master Change-Id: I4ab0852bc0fb386aa9016b8845f7f8f15a7c3166 Reviewed-on: https://review.typo3.org/58477 Reviewed-by:
-
Benni Mack authored
The extracted extension should use the new DB API. Resolves: #86373 Releases: master Change-Id: Ibcb58f3c795cc888285b61bc7f3e2251f15cd328 Reviewed-on: https://review.typo3.org/58495 Reviewed-by:
-
Benjamin Franzke authored
Neither the backend user authentication should try to perform database queries, nor the extbase services. As a side effect this allows to run the cli tool when LocalConfiguration.php or PackageStates.php are missing, which allows to run commands like `dumpautoload` in that case. Note: *Only* in that case, not if a database connection is configured, but not available – for that usecase failsafe booting will be needed, as proposed in https://review.typo3.org/c/58298/ and/or https://review.typo3.org/c/58300/ As a drive-by we also add a null coalescing operator to IconRegistry::registerModuleIcons() which is currently required because ext_tables.php files are loaded in incorrect order if PackageStates.php is missing (reported in another bug: #86408). Although this workaround will not be strictly required when that bug is fixed, that functions should still properly handle that case. Change-Id: I7d339e21160d25b5aee5dd0e2f25491a22ec83e9 Releases: master Resolves: #86416 Related: #86408 Reviewed-on: https://review.typo3.org/58427 Tested-by:
-
Benni Mack authored
Resolves: #86473 Releases: master Change-Id: I19f499533636b6a187adde51f2a4ca96149cc45f Reviewed-on: https://review.typo3.org/58493 Reviewed-by:
-
Benni Mack authored
The descriptions and listings of site language in FormEngine hasn't been worked on since its introduction. This is now streamlined in terms of wording and grouping, to help people find things in a better way. Resolves: #86470 Releases: master Change-Id: I3692b8466c779b32d8a52d58469e5b87874643fa Reviewed-on: https://review.typo3.org/58489 Tested-by:
-
Claus Due authored
PageRepository is now used independantly from TSFE most of the time, and a new instance is created each time a content element gets rendered. This means that the current cache strategy using class properties gets flushed repeatedly and multiple identical SQL requests to be sent to the DB. By replacing the class property caching with runtime cache which survives across instances, the problem is solved. On some sites this represents a reduction of several hundred SQL requests. Change-Id: Ib606ada46c3c262fd9004a12166b79d80bbc5edb Resolves: #80138 Releases: master Reviewed-on: https://review.typo3.org/51953 Tested-by:
-
Sascha Egerer authored
The mountpoint variable must be respected in the key used for the menu runtime cache. Without that part in the key all links generated to a mount-point sub-page will link to the first mount target page in the menu. Resolves: #80970 Resolves: #62248 Releases: master, 8.7, 7.6 Change-Id: I8ccfebabd515d6da9f78388de51d24603e9fe532 Reviewed-on: https://review.typo3.org/57532 Tested-by:
-
Christian Kuhn authored
Resolves: #86469 Related: #86441 Releases: master Change-Id: Iff35a1be7c436ff3aceab7b9eb82af773278b363 Reviewed-on: https://review.typo3.org/58488 Reviewed-by:
-
Christian Kuhn authored
Resolves: #86468 Related: #86440 Releases: master Change-Id: I1e0cf65d487b8ea95edb7acdad50c671da3277a5 Reviewed-on: https://review.typo3.org/58487 Reviewed-by:
-
Christian Kuhn authored
Resolves: #86467 Related: #86439 Releases: master Change-Id: If14e53972535458ec493454d8e42c48eb67dc35c Reviewed-on: https://review.typo3.org/58486 Reviewed-by:
-
Christian Kuhn authored
To untie authentication services from user authentication a bit better, the fetchUserRecord() method of AbstractAuthenticationService now implements fetchUserRecord() on its own instead of calling the method with the same name of $pObj. AbstractUserAuthentication->fetchUserRecord() is then unused and can be deprecated. Resolves: #86466 Releases: master Change-Id: Ia144ea2dfb8a7c7462ed12875ee35caab9763ba2 Reviewed-on: https://review.typo3.org/58485 Reviewed-by:
-
Jigal van Hemert authored
Flag icons that come with core, the flags that are registered in the icon registry, the lists in sys_language and site_language are now in sync again. Releases: master Resolves: #86460 Change-Id: I1e274b3e274b305486b6e37d600a915177ef484c Reviewed-on: https://review.typo3.org/58476 Tested-by:
-
Josef Glatz authored
Leftover .htaccess files were savedly removed, as the root .htaccess (for Apache webserver) / .web.config (for IIS webserver) already takes care of access rules. Resolves: #86463 Releases: master Change-Id: I1186a5cdd068c2052d3d6ab2a4210d931d8684cd Reviewed-on: https://review.typo3.org/58482 Tested-by:
-
Benni Mack authored
When an extension author writes a display condition in TCA and by incident uses a wrong format for the displayCondition (see ticket) the strtoupper fails due to the lack of an associative array because it's a numeric-key array. An additional check fixes the issue. Resolves: #79692 Releases: master, 8.7 Change-Id: I4455bdc908e0be1a373f86680e718e876aa5ddd7 Reviewed-on: https://review.typo3.org/58480 Reviewed-by:
-
Tymoteusz Motylewski authored
Resolves: #85305 Releases: master Change-Id: I01c62adede04f5f74c506c15e28d471ad3185593 Reviewed-on: https://review.typo3.org/57261 Tested-by:
-
Benni Mack authored
A new TCA option for TCA type "slug" is added, called "prependSlash", which adds a "/" in front of the field. For pages (pages.slug), this is mandatory and cannot be configured, as the slug field has to be filled and set to "/" as a base for the root page. For other database fields, this is optional (and disabled by default), and can be enabled via "prependSlash" in TCA config. This option is mostly useful for recursive records, like categories, but for most "flat" structures like "news" or "events", this is not suitable. For pages, it is hard-coded and cannot be (un-)set. Resolves: #86457 Releases: master Change-Id: I997908ed74af7ca21873b0793674e9185cc581ce Reviewed-on: https://review.typo3.org/58474 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Oliver Hader authored
* adds test cases for resolving and generating enhanced links * fixes locale issues when dealing with persisted mappers * removes PersistedAliasMapper.valueFieldName and uses TCA 'uid' field per default, which is required for proper language based resolving as well * introduces language based resolving to PersistedAliasMapper and PersistedPatternMapper Resolves: #86444 Releases: master Change-Id: Ib9c9ea8efc25a8a5adb727f8402a2b6b1e6a1602 Reviewed-on: https://review.typo3.org/58461 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Susanne Moog authored
To allow others to use the new upgrade wizard API the interfaces are no longer marked as @internal. Resolves: #86448 Releases: master Change-Id: I2e146e6d27c5aaed922a004054b3df2bbea88cb8 Reviewed-on: https://review.typo3.org/58466 Tested-by:
-
Benni Mack authored
When hooks modify _GET or _POST parameters, it is important that these changes reflect the PSR-7 request for now, as long as TYPO3 access the _GET/_POST parameters via GeneralUtility::_GP(). In order to move away from global access, we still want to avoid places where it is unclear to use $_GET/$_POST vs. $GLOBALS['TYPO3_REQUEST'] until all parts are completely "global-scope free" for GET/POST parameters. The change adds the initial GET/POST parameters to the request object in the very first middleware of the frontend. If these have been modified when the RequestHandler builds up the content, they are added on top of the PSR-7 request object. Additionally, if the PSR-7 request object has been modified, these changes are put back in the global scope to reliably use _GPmerged within Extbase and Additionally, if _GET/_POST have been modified, a warning will be shown in the TimeTracker to find out that there have been modifications. Until then, it is safe to continue to access _GET/_POST within Hooks and Frontend, however it is highly discouraged to *modify* _GET/_POST directly as this functionality will be breaking in TYPO3 v10.0. Bottom line: This safety net can now trigger deprecation warnings if _GET/_POST have been modified during PSR-15 middleware hooks. Bottom line 2: If these have been modified, they are put inside the current request object. Bottom line 3: If the request object has been modified, global state will be modified ONCE in one place to ensure that we work with the same object during the request phase. Bottom line 4: We cannot get away from the current state of running a TYPO3 Frontend Request from another source, and we try to maintain compatibilty for legacy scripts for now. However, this will be breaking in TYPO3 v10.0. Resolves: #86458 Releases: master Change-Id: Ic8f4f123bb5ea0d660e500494cf06a965dea03c4 Reviewed-on: https://review.typo3.org/58443 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
RteHtmlParser has never received a good clean up, that's because it was there since PHP 4 ages. In order to rename, reorder code, all internal methods and properties are now declared as protected. Resolves: #86440 Releases: master Change-Id: I204efa8156abcf9ae07a607fa03fa04fbb269885 Reviewed-on: https://review.typo3.org/58457 Reviewed-by:
-
- Sep 29, 2018
-
-
Josef Glatz authored
This patch re-adds a missing functionality to CKEditor. Due to the move from htmlArea to CKEditor, the well-known wordcount information was gone. The wordcount information is added to all existing CKEditor presets per default. In addition, it is now possible to customize the displayed information below the editor. - It's possible to switch paragraph-, word- and/or character count. - You can define if spaces are counted as charactars. - You can define if HTML tags are taken into account. - You can define if linebreaks are taken into account. Beside that, the used plugin enables also setting up maximum values for word- and/or character count. This can be easily used for custom RTE presets. The fact that the global configuration is located in the Base.yaml makes it possible to overwrite settings partially or completely in any inherited RTE preset. With that it is easy possible to realize word/character limits. Following commands were used to add the external package as a dependency and copy the plugin files/folders to the final location: `yarn add --dev ckeditor-wordcount-plugin && yarn build` Resolves: #86395 Releases: master Change-Id: I2c76d7bfebc9a5a57c1f105788af206bdffb00f2 Reviewed-on: https://review.typo3.org/58405 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Benni Mack authored
Normalized Params only needs serverParams and $TYPO3_CONF_VARS[SYS] to work with, so the object is modified in order to simplify further work on the object. Resolves: #86454 Releases: master Change-Id: I30f2c6195468b275e61570c1de67b39f281bb494 Reviewed-on: https://review.typo3.org/58471 Reviewed-by:
-
Nikita Hovratov authored
The tooltip has to be removed at that point, because as soon as any data is deleted the row disappears and it's not possible to trigger the mouseout event manually. Resolves: #81856 Releases: master, 8.7 Change-Id: I2f7388b6a278de9ba19e81ec20ed3ae0052b1698 Reviewed-on: https://review.typo3.org/58463 Reviewed-by:
-
Georg Ringer authored
Sort the extension settings by the extension key. Resolves: #86452 Releases: master Change-Id: I6fb0110820d4a8406f01b617b3279640be9aa743 Reviewed-on: https://review.typo3.org/58470 Reviewed-by:
-
Benni Mack authored
Instead of explicitly call loadJQuery() this should be handled by requireJS or - even better - use vanilla JavaScript instead. Resolves: #86438 Releases: master Change-Id: Iecc2ceb7fa01578b00a63262f393bd1b92fa13e1 Reviewed-on: https://review.typo3.org/58455 Reviewed-by:
-
