- Nov 08, 2022
-
-
Christian Kuhn authored
With last non-b/w compatibility related calls to TypoScript/TemplateService being removed, we can now actively deprecate method usages of this class. The deprecation has been mentioned with v12.0 in Breaking-97816-NewTypoScriptParserInFrontend.rst already, the patch adds trigger_error() calls and streamlines some left over comments. Another ReST file is added pointing to the new Request attribute added in Frontend context. Resolves: #99020 Related: #98503 Related: #97816 Releases: main Change-Id: Id01f4a4cb230f632f599e06ff4efe67fd53717c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76477 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Oliver Bartsch authored
Due to changes in #98960 the resolved entity name might contain slashes, which need to be quoted to prevent PHP warnings. Resolves: #99023 Related: #98960 Releases: main, 11.5 Change-Id: I75eecbdbbddc82b5b1189388413fabd7370d4229 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76488 Tested-by:
Dmitry Dulepov <9csxfqr4jy@liamekaens.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
Generation of a slug proposal based on defined generator fields does now also work for basic select fields, which were previously not considered by the JS component, because they do not use the FormEngine specific visible / hidden field combination. Resolves: #94371 Releases: main, 11.5 Change-Id: Iedd2d17e97db8abd9cf5c4a3b476825fcd854191 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76485 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Torben Hansen authored
Resolves: #98823 Resolves: #98824 Releases: main Change-Id: I81f0ccf1d76316635ad6f41d5b1bcfe7112442cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76484 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
Resolves: #99022 Related: #99019 Releases: main Change-Id: Ia43b20a18e0a385603ed78964325980206a4ea2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76482 Tested-by:
-
Christian Kuhn authored
TypoScript TLO _GIFBUILDER has been bug fixed with a previous patch. This patch adapts forgotten matches in auto completion. Resolves: #99021 Related: #98720 Releases: main Change-Id: I32fe0e01b176cf4b9ba075221dd76d6d043ac96a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76480 Tested-by:
-
Torben Hansen authored
Resolves: #98825 Releases: main Change-Id: I78bf3d08d4c996e57ceb1415cd9cf8bc2904a731 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76479 Tested-by:
-
Torben Hansen authored
Resolves: #98826 Releases: main Change-Id: I4ee06fd0e36f89e82b05050d9bc46b81d0d4c045 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76478 Tested-by:
-
Christian Kuhn authored
There is little point in not clearing all caches when extensions are loaded / unloaded using the extension manager. It's easier for extension developers to rely on all caches being cleared, it's one thing less to think about. The patch deprecates the clearCacheOnLoad and clearcacheonload array key in ext_emconf.php and removes the handling in extension manager. Resolves: #99019 Releases: main Change-Id: Id6ff3db02e2ff82813534e1d2a40cbfac0013b8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76474 Reviewed-by:
-
Stefan Bürk authored
Default language page slug usage in combination with the siteLanguage base of non-default language has been resolved and delivering the language content. This made the page accessible with multiple urls. Available and existing translated pages should be only resolved by the language slug, not the default language page slug. However, if page is not translated, using the default language slug for the resolving should be only considered and working if fallback settings are provided. Resolves: #88715 Resolves: #96010 Releases: main, 11.5 Change-Id: Id618880fe2ba26fd3b6ab50b4813968923ec5acb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75101 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Alexander Schnitzler authored
Due to the dependency of those objects to the DataMapper and its own dependency chain, serialization of those objects lead to error: Serialization of \Closure not allowed. To ommit this issue and to reduce the footprint of the serialization data in general, the data mapper should be omitted and reinitialized via __serialize() and __unserialize() Releases: main, 11.5 Resolves: #97190 Resolves: #92148 Change-Id: If8b78a93308eb14d40080c9cceee95754b785ba8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73975 Tested-by:
-
Benni Mack authored
FormEngine's TreeRendering for categories utilizes the TreeDataProvider logic, which is handed over a list of available items loaded by FormEngine's AbstractItemProvider. These records have already been validated and a full record was already loaded by FormEngine at this point. The TreeDataProvider construct then fetches ALL records again, as it only works with the "IDs", but not with already loaded full rows. This makes the construct expensive. It needs a bigger overhaul. To mitigate the performance impact of bigger category trees, the patch applies a hack to suppress loading single category rows multiple times by handing them over from FormEngine to the TreeDataProvider construct. As this change is also backported to 11.5, the optimizations are only done for type=category to minimize impact for other Tree usages. Resolves: #84558 Resolves: #90398 Resolves: #97003 Resolves: #76581 Resolves: #98807 Releases: main, 11.5 Change-Id: Ief183f1673d3a17036ca5e68c62dc18a4277def1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76443 Tested-by:
-
Benni Mack authored
Resolves: #98175 Releases: main, 11.5 Change-Id: Iccc439eafbbb1f959c8c2bc12248b7c4aa560260 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76466 Tested-by:
-
Oliver Bartsch authored
This followup prevents an out of bounds exception and adds a couple of tests for the new functionality. The min length is now set to 8. This is now also checked when using the special "random" option. Resolves: #98540 Releases: main Change-Id: I5e89813794a0178b7d9c835e89c6272128b4b8c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76461 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Torben Hansen authored
Resolves: #98827 Releases: main Change-Id: Ieb71ff04453f4c9b6b3a4c733b4e71732b21ecba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76472 Tested-by:
-
- Nov 07, 2022
-
-
Benni Mack authored
This change adds the basic information for a type when adding a plugin as CType. When adding a plugin with "list_type" (default), then the "list" CType is used, and extension authors are able to add or remove fields easily with the API. However, when encouraging extension authors to use CType, this is currently much more boilerplate and not possible to make this more flexible. As shown, EXT:felogin and EXT:form previously used this concept manually, which does not allow to extend fields properly, but extensions with plugins as CTypes had to define them explicitly. As TYPO3 Core encourages people to use custom CTypes in favor of list_type (moving towards a unifieid Content Block concept), this change will also be available for 11.5. Resolves: #98960 Releases: main, 11.5 Change-Id: Iee5e1a35f2d99faf03081d7265c2fe6e4845397f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76319 Tested-by:
-
Frank Naegler authored
This patch adds a new TCA field control "passwordGenerator" for TCA type "password", which can be used to generate a random password, based on defined password rules. The field control will be used in EXT:reactions the first time. In the future the field control might be combined with the existing password policies functionality. Therefore, most of the new functions and classes are marked as internal for now. Another feature to be added in the future will be (according to #69190) a modal / wizard, which will allow to change rules for the password to be generated. Resolves: #98540 Related: #98373 Releases: main Change-Id: Iab21b8bd0b3c261a702234579f62ba841c54ea0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76002 Tested-by:
-
Christian Kuhn authored
Switch the Extbase BackendConfigurationManager to use the new TypoScript parser. The implementation is quicker for Extbase Backend modules. Change-Id: Icb821fbe8804f219806abc5094ace3d404b96a73 Resolves: #99017 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76447 Tested-by:
-
Andreas Fernandez authored
Resolves: #99018 Releases: main Change-Id: I7d45a2087255b9a0102db31f5718b8d9cb959b6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76458 Tested-by:
-
Oliver Klee authored
Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97420 Releases: main Change-Id: Id1ea668b1f313fa74292437755850eaa36511526 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74344 Tested-by:
-
Torben Hansen authored
Resolves: #98828 Releases: main Change-Id: I1adc2913954610fe678ce5a76a6b3020705f35da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76438 Tested-by:
-
Torben Hansen authored
Resolves: #98829 Releases: main Change-Id: Ica7171dd9cfd4045d8f712315178f745ffeb16b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76437 Tested-by:
-
Achim Fritz authored
Remove doktypes in page tree toolbar when not set in TCA items to prevent an undefined array key PHP 8 warning. Resolves: #99012 Releases: main, 11.5 Change-Id: I0fc98e448aca70dc85f671a68d68d63bba15a166 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76452 Tested-by:
-
Michael Telgkamp authored
Resolves: #99016 Releases: main Change-Id: I020558bcbeb635d3b330f71cc840f1e35450853d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76455 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Achim Fritz authored
Prevent PHP 8.1 undefined array key for wizard items without description or without title. Resolves: #99015 Releases: main, 11.5 Change-Id: I141aa8e0003a2e3b783fb78fddf9db5e602ea40d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76454 Tested-by:
-
Oliver Bartsch authored
The width of the items in the new content element wizard is now properly defined again so that on larger screens, two columns are used and on smaller screens, all items are below each other (taking full width) again. Resolves: #99010 Releases: main, 11.5 Change-Id: I96539dbb962021530b2c29062899aff8b655710c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76451 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Oliver Bartsch authored
The "foreign_table_where" option is no longer forced by TcaPreparation for TCA type "category", which had been introduced with #94622. Resolves: #98656 Related: #94622 Releases: main, 11.5 Change-Id: I8cab56881bab042e46b2325bee80665b83423948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76440 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
- Nov 06, 2022
-
-
Helmut Hummel authored
File meta data extractors have to provide an execution priority and a data priority. The execution priority, which was previously ignored, is now respected and extractors are ordered accordingly in ExtractorRegistry. Extractors with the same data priority can now provide data, while the data was overwritten previously. ExtractorRegistry::getExtractorsWithDriverSupport now returns a flat array of extractors again, not a nested one like introduced in #64942, just like annotated. Because this fix might change the order of the execution of extractors, it can be considered slightly breaking, thus TYPO3 11.5 is not targeted. Related: #64942 Related: #56727 Resolves: #92643 Releases: main Change-Id: I2a54709ba8a389e668b37e6003695ba3316968eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66232 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
This change simplifies further work on the TCA Tree logic. a) use imported names b) ensure to use int|string for Node->getId() as Core uses this for integers within e.g. sys_category c) fix some phpdoc infos d) remove an unused property e) use proper casting for integers f) use $this->lookupField instead of $this->getLookupField() when using 10000 of categories, this function call is superfluous. By using int|string, the changed code if ($node->getId() !== 0 && $node->getId() !== '0') saves 1 (!) DB query on every request. This change is meant also to be backported to v11, for this reason no changes to the types within properties are made (only type hints). Resolves: #99005 Releases: main, 11.5 Change-Id: I291cdd0925f77b0e48e224f207eb5e1b0c4fa041 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76444 Tested-by:
-
- Nov 05, 2022
-
-
Torben Hansen authored
Resolves: #98831 Resolves: #98832 Releases: main Change-Id: I0f34522522d260aa276516716f6d1f3cd02e253b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76435 Tested-by:
-
linawolf authored
Non-marked code-snippets notoriously cause rendering errors in the documentation where ever we render doc-comments. Therefore all code snippets should be marked as such. This also adds some space around code snippets and makes them easier to read for the nacked eye. Some extensive code-snippets might better be moved directly into the documentation but this wa not part of this change. Throughout the Core we have different methods of marking code: Markdown style as applied here and html-style with `<pre>` or `<code>` tags. We can interpret both so I did not attempt to unify this situation. Resolves: #99003 Releases: main Change-Id: Ic65b453a565c62233c1570a2905a834f23cfbb84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76442 Tested-by:
-
- Nov 04, 2022
-
-
Benni Mack authored
The "filter by Page ID" functionality within the page tree now also checks for the live ID ("t3ver_oid") if a page was modified. Resolves: #98444 Releases: main, 11.5 Change-Id: Ia084905d8ddf642736ea1739610db3c0a011cc5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76352 Tested-by: -
Torben Hansen authored
Resolves: #98830 Releases: main Change-Id: I24ee92b2e3cfc7e32ce623fdbf907f634b4a119a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76436 Tested-by:
-
Daniel Ziegenberg authored
Releases: main Resolves: #99002 Change-Id: Ib57a63ff3527c1681c0ba4d646aa1ee90e51b78c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76439 Tested-by:
-
Benni Mack authored
This change splits up the functionality of the "CreateFolderController" into "add folder" and "add file". This also affects: * Buttons in the file list module * Actions in the Context Menu which also uses more specific labels + icons. This way, it is much clearer for editors on specific actions. In addition, the code is split up into CreateFileController and CreateFolderController. Separate steps could be to also split up the online media functionality into a modal. Resolves: #98999 Releases: main Change-Id: I7ccbae09de6b9fa39996e0357129006091601e27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76433 Tested-by:
-
Loek Hilgersom authored
The "hash" cache for (TMENU) menu generation is very ineffective: The cache identifier hash contains the page rootline, so it is single page specific. This leads to quite some pollution of the "hash" cache, often many more entries than page cache entries, without high re-use / cache-hit rate. Looking closer at this, we found the menu generation cache to be so ineffective that it's better to not cache at all. We first thought a runtime cache would be a good solution but even that one is not helpful and there are further runtime caches on lower levels already, for instance to resolve shortcut pages. The patch removes this cache layer, leading to a drastically smaller "hash" cache. Resolves: #98964 Releases: main Change-Id: Iadd3ad77f4d2d4683b91ca7b1f27a779ff899d26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76384 Tested-by:
Loek Hilgersom <loek@netcoop.nl> Tested-by:
-
Andreas Fernandez authored
As a follow-up to #98989, it'd make sense to show a notification if a bookmark was created to give the user some sort of feedback. Resolves: #99000 Related: #98989 Releases: main Change-Id: Idcde0defe302f23356ce37a22feec18e0237adc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76434 Tested-by:
-
Benni Mack authored
WorkspaceRestriction solves all cases, the previous BackendWorkspaceRestriction and FrontendWorkspaceRestriction do not restrict to either a) a specific workspace + LIVE records b) certain version states (esp. NEW/MOVE and DELETED placeholders). It is highly recommended to use WorkspaceRestriction which is available since TYPO3 v9.5.x to overcome these problems step by step throughout TYPO3 Core. Resolves: #98996 Releases: main Change-Id: I5ce61c1e6cc3f900a5c94d7ca001d678d2c15c85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69728 Tested-by:
-
Benjamin Kott authored
Adapting the link behavior to match the default CKEditor5 linking behavior. We are now also introducing the contextual balloon menu. This change makes the need for a dedicated unlink button in the menu bar obsolete and eases the use of editing links. The ballon menu opens with a single click and provides information about the current link as well as edit and unlink options. Resolves: #98997 Releases: main Change-Id: I6f4835bfe9e7674eb7c968a9a972479a54489799 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76259 Tested-by:
-
Stefan Bürk authored
PHPStan recently added a xdebug check The TYPO3 core php testing images has xdebug installed and enabled in cli mode, which now let PHPStan display a speaking notice about this circumstance. This change simply disable xdebug for phpstan calls in runTests.sh, thus avoiding this notice. xdebug is not needed to be enabled for PHPStan executions. Resolves: #98994 Releases: main, 11.5 Change-Id: I2b390884b4ccba85e9c2638bfa815f1a138c23e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76408 Tested-by:
-
