- Jun 24, 2024
-
-
Marcin Sągol authored
The `typo3-backend-icon` component code contains a duplicated code fragment. This patch removes one occurrence. Resolves: #104199 Releases: main, 12.4 Change-Id: I0530f89f646c5c2fda8a170f3792a28a2c04243d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84840 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Kienast authored
This commit updates TypeScript to 5.5, along with its related friends. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.13.1 \ @typescript-eslint/parser@^7.13.1 \ @typescript-eslint/typescript-estree@^7.13.1 \ typescript@^5.5.2 npm run build Resolves: #104189 Releases: main, 12.4 Change-Id: Ic2b66c65485845ae62371228f6f8b62c8a320172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84878 Tested-by: -
Oliver Bartsch authored
Since #96515, is's possible to configure aliases for backend modules. Those are handled by the UriBuilder to allow using those aliases for building links to the corresponding module. Using the ActionDispatcher JS component for building module links via the "TYPO3.ModuleMenu.showModule" action, it's now also possible to use corresponding aliases. Therefore, the BackendController now adds the module aliases to the module information JS array and the module JS component properly checks for those aliases when resolving a given module name / identifier. Resolves: #104165 Related: #96515 Releases: main, 12.4 Change-Id: Ia8372a503f4973d81deb285a9945fa13ade24dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84839 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Jun 21, 2024
-
-
Garvin Hicking authored
When filtering the page tree with characters that have special meaning for a regular expression (for example, ")" or "(" or "?" and some others), the filtering would return a "Page Tree error". JavaScript does not have something like "preg_quote", so this uses the escape string provided by the MDN with fixed special characters. Resolves: #104092 Releases: main, 12.4, 11.5 Change-Id: I4a29c62eaca8b7643c8ef78dda1d8337b3e1e53a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84722 Reviewed-by:Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Rath-Ulrich authored
This commit fixes a minor issue where the header tag in PaletteAndSingleContainer was incorrectly set as h4. The tag has been changed to h3 for better readability and semantics. Simultaneously, visually hidden headers were also added to tabs to improve accessibility. Resolves: #104021 Releases: main, 12.4 Change-Id: Ic2301eabb23d1d17169056ec8e9ec40a5824c52c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84822 Tested-by:
-
Oliver Bartsch authored
Using the multi record selection, it's possible to change the state of checkboxes via multiple ways, e.g. by clicking on the table row. The central functionality for changing the connected checkbox state now also considers the disabled attribute and therefore only changes the checked state in case the checkbox is not disabled. Additionally, next to the custom event, which is triggered on checkbox state changes, the multi record selection now also dispatches the standard "change" event. FormEngine validation for example is listening on this event to mark the field as changed. Resolves: #104142 Releases: main, 12.4 Change-Id: I9854709ee624d88821757fff3baf38c892e5f11d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84823 Tested-by:
-
Leon Dietsch authored
When switching between cropVariants with multiple coverAreas, all of the previous coverAreas are properly removed, only showing those that belong to a specific cropVariant. See details and screenshots in the related ticket. (A new styleguide TCA element crop_9 is also added to showcase multiple coverAreas in multiple cropVariants) Resolves: #103389 Releases: main, 12.4 Change-Id: I7649aa0fe5bc01939326119b24dbdafd5f09a708 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84837 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Jun 18, 2024
-
-
Benjamin Franzke authored
Improve document-service responsiveness by relying on `DOMContentLoaded` and `document.readyState` >= `interactive`. 1) Handle non-loading state as "ready" to avoid waiting for `complete`. `document.readyState` has three states: * `loading` The document is still loading. * `interactive` The document has finished loading and the document has been parsed but sub-resources such as scripts, images, stylesheets and frames are still loading. The state indicates that the DOMContentLoaded event is about to fire. * `complete` The document and all sub-resources have finished loading. The state indicates that the load event is about to fire. If DocumentService.ready was called in "interactive" state we have been skipping this state as we only considered `complete` to be the "ready" state in this case. This is wrong as we actually wait for the DOMContentLoaded if we are launched in the initial readyState (`loading`), that means an initial `interactive` must be understood as: `DOMContentLoaded` has already been fired as state is `interactive` We should actually avoid waiting for `complete` entirely, as document readyState `interactive` means "ready" in terms of document parsing. We're not interested in images or async scripts that are still loading and want event listeners to be registered as early as possible. With this improvement applied we can also drop the (now) unneeded `load` event-listener, as we are no longer skipping interactive state (this made the `load`-listener necessary previously). Note that the `load` workaround was previously needed for IE<=10 as those versions set `document.readyState` to `interactive` prior to the `DOMContentLoaded` event. This applied workaround becomes a race condition once `load` never happens and that is the case with a recent google chrome regression which causes iframe documents to never "complete": https://issues.chromium.org/issues/347724924 2) Drop the timeout logic. It is no longer needed now that we only need to wait for `DOMContentLoaded` – which will always fire (or already fired) – instead of the `load` event. 3) Avoid creation of new promises for every invocation of the ready-method. A promise can be reused without side effects by multiple consumers. This avoids creating a lot of event listeners (and previously timers). 4) Remove unneeded document and window references. Releases: main, 12.4, 11.5 Resolves: #104135 Related: #104139 Change-Id: I42c86961405f8a5c346c17ea429a288a85d58f8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84753 Tested-by:Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Georg Ringer authored
The backend layout wizard now uses a working example by using an existing icon. Resolves: #91910 Releases: main, 12.4 Change-Id: If6df3bd73d1ff6dc1a7a3e71cadf2e89b1a18bd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84752 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Argument passing using `--` works well. It's time to remove the previous `-e` solution. Resolves: #104137 Related: #104131 Related: #102769 Releases: main, 12.4, 11.5 Change-Id: I99577a24dda77c4c96813f8ca14c2a27bdf7f2de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84746 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Stefan Bürk authored
This change requires PHPStan on the current newest version. Note: In v12 the phpstan baseline is regenerated to adopt for changed reporting behaviour. Used command(s): composer req --dev "phpstan/phpstan":"^1.11.5" Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #104136 Releases: main, 12.4 Change-Id: I7f88c4c3942e22e1536e12a883411f66a3eee3ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84744 Tested-by:
-
Christian Kuhn authored
Inline the 'random seed' option for -s unitRandom, replay a specific seed using: > runTests.sh -s unitRandom -- --random-order-seed=<number> Resolves: #104131 Releases: main, 12.4, 11.5 Change-Id: I84e1cc0a0c57a5132a592a140d1b58ceb6d3b059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84736 Reviewed-by:
-
- Jun 14, 2024
-
-
Willi Wehmeier authored
The aspect ratio buttons in the image cropping tool have a visible focus state now to make them usable when navigating with the keyboard tab key. Additionally the button can now be pressed with the space and return key. Resolves: #103760 Releases: main, 12.4 Change-Id: Id221daddeee9d5b61497cb74604dbf151d25e3ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84554 Tested-by:
-
Oliver Bartsch authored
Defining columnsOnly, which is used by the EditDocumentController to instruct the FormEngine to only render a subset of available fields for records is now table aware. This allows to render records from different tables in the same request, while respecting the fields to be rendered on a per-table basis. The "columnsOnly" parameter therefore now requires the fields as array under the corresponding table name: &columnsOnly[pages][0]=title A backwards-compatibility layer is in place, migrating the previous syntax to the new one by adding the configured fields for the tables from the edit configuration. Resolves: #104108 Releases: main, 12.4 Change-Id: I46500100eb369ad117a2cf5c61a9811c6fd5c7a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84712 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104065 Releases: main, 12.4 Change-Id: I48c121620bf84a9444ff3c9d79d1adfd1fa631f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84648 Reviewed-by:
-
- Jun 13, 2024
-
-
Andreas Kienast authored
With the upgrade to Bootstrap 5, the panels have no explicit position anymore, breaking the progress bars in the Extension Scanner found in the Install Tool. This commit adds a relative positioning to the panels. Resolves: #104073 Releases: main, 12.4 Change-Id: Ie67989dbcfa859ebc3020dabaa27913de7ae4b64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84706 Tested-by:
-
Andreas Nedbal authored
Before it was not really clear if/where a select check box header was collapsible. This patch unifies the layout with the one of the recordlist tables, adding a button specifically responsible to collapse/expand the group. Resolves: #98683 Releases: main, 12.4 Change-Id: I6b47cdc9cd2673a85aaa0bfb85dd70534e4ffc33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84638 Tested-by:
-
- Jun 12, 2024
-
-
Christian Rath-Ulrich authored
To improve accessibility, an aria-label is added to all context menu buttons to allow assistive technologies to announce them correctly. Resolves: #102490 Releases: main, 12.4 Change-Id: Ia397ab17a8fcbfe3a1ea75e86733a6a5a778653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84667 Tested-by:
-
Oliver Bartsch authored
The "revert selection" action of the SelectCheckBoxElement does now properly handle the current element's "checked" state. This way, the action button gets visible once the initial state is changed (by checking / unchecking checkboxes) and is disabled again, in case the initial state gets restored. Resolves: #104062 Releases: 12.4 Change-Id: Iad14f36c1b8c0de23f4c152a5fd4ba1a4fbee6da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84628 Tested-by:
-
- Jun 11, 2024
-
-
Oliver Hader authored
Change-Id: I86360df1a2a39b3fb1ebca927fe2a714bc887691 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84600 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: If61da3b4e4166c368989faab63ae87c26330e588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84599 Tested-by:
-
Andreas Kienast authored
The drag&drop issue reported in #103877 also affects the icons in the page tree, which was not fixed back then. This commit now takes care of the page tree icons as well. Resolves: #104033 Related: #103877 Releases: 12.4, 11.5 Change-Id: I92381a07bfba2d90d7fc1a85097c54f0d4a7b282 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84593 Reviewed-by:
-
- Jun 10, 2024
-
-
Oliver Bartsch authored
When inserting a record via the element browser, the value argument needs either to be formatted manually or left empty, allowing the element browser to format the identifier automatically. By omitting the value in the `PageBrowser` module, the value is now correctly formatted by the element browser to "pages_<uid>". This makes the "node-action" usable for TCA group fields, which allow more than one record type. The same logic is also used by the `BrowseDatabase` module, which also omits the value argument. Resolves: #103700 Releases: main, 12.4 Change-Id: I80e2cc696d85b5ec83432c35a263b19f9752b0ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84553 Reviewed-by:
-
Stefan Bürk authored
PHPUnit changed the way how double creation is handled internally and now emits an exception if a manually defined `mock class name` should be registered. In some places within the unit tests, manual mock class names have been used, because the names are needed for cross referencing at a later point. For this, different approaches have been used, for example hardcoded MD5 hashes as strings or creating hashes of static values like `md5('1')`, and also reused hashes in different places or in tests using data providers. This now leads to an exception: PHPUnit\Framework\MockObject\Generator\NameAlreadyInUseException The name "b70551b2b2db62b6b15a9bbfcbd50614" is already in use This change mitigates the issue by using `StringUtility::getUniqueId('somePrefix')` as is already done in other places. As a sideeffect, four phpstan baseline entries can be removed. Used command(s): Build/Scripts/runTests.sh -s phpstanGenerateBaseline [1] https://github.com/sebastianbergmann/phpunit/pull/5804 Resolves: #104005 Releases: main, 12.4 Change-Id: Icc558844275c9ae9f67a0e7c20daa318f5ad6b41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84531 Tested-by:
-
- Jun 06, 2024
-
-
Garvin Hicking authored
The directory to reference removing Documentation-GENERATED-temp breaks out of the current working directory scope and could possibly delete files in a completely unrelated directory. Also, it does not remove the actual temporary files. Resolves: #103989 Releases: main, 12.4, 11.5 Change-Id: I685a398aa0d5abee3177ab3def4e271d493d59ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84464 Tested-by:
-
Garvin Hicking authored
The use of the backtick operator inside the help output leads to an error message: Build/Scripts/runTests.sh: line 175: --: command not found on macOS (probably others, too). This patch replaces the backticks with normal quotes. Resolves: #103988 Releases: main, 12.4, 11.5 Change-Id: Ib6809dc6943a98e4d45d04f4ec02601e830518cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84462 Tested-by:
-
Andreas Kienast authored
With Chrome 125, changes in the drag&drop handling were introduced [1] that trigger a text selection when dragging nodes from the page tree toolbar. In the `dragstart` handler, the default action is now prevented. [1] https://developer.chrome.com/release-notes/125#interoperable_mousemove_default_action Resolves: #103877 Releases: 12.4, 11.5 Change-Id: Iad75db78bba3e7b5ad01a568dcab2eb770f1c4a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84483 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jun 04, 2024
-
-
Andreas Kienast authored
The stylesheet loading process in IRRE was kept for several years and moved from version to version. A recent change in #103375 migrated a usage of `delete` to `.splice()`, breaking stylesheet loading as the original iterated object was modified. Since the code was quite dated and had other potental bugs, the whole loading sequence has been transformed to functional programming style to reduce complicated, potentially error-prone, array operations. Resolves: #103971 Related: #103375 Releases: main, 12.4 Change-Id: I18caafc68ceebce53723b7208270043faafc7458 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84488 Tested-by:
-
Anja Leichsenring authored
Additional potential functionality (DI, XClass resolving, etc.) of GU::makeInstance is usually not a wanted behaviour in unit tests. For creation of system under test `new` should be used. Dependencies, if necessary, should be mocks. This patch reduces the obvious cases, more complicated ones will be tackled with follow ups. Resolves: #103902 Releases: main, 12.4 Change-Id: I07cbe6f10fe11e1239cdd5f0fe7496948eed5a44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84485 Reviewed-by:
-
Andreas Kienast authored
This commit updates ckeditor to 41.4. See changelog at [1]. Executed commands: # Override ckeditor5 package to avoid pulling in all/too # many available packages. See: # https://github.com/ckeditor/ckeditor5/issues/16360 npm --prefix overrides/ckeditor5 version 41.4.2 npm install --save ./overrides/ckeditor5 npm install --save \ @ckeditor/ckeditor5-alignment@^41.4.2 \ @ckeditor/ckeditor5-autoformat@^41.4.2 \ @ckeditor/ckeditor5-basic-styles@^41.4.2 \ @ckeditor/ckeditor5-block-quote@^41.4.2 \ @ckeditor/ckeditor5-clipboard@^41.4.2 \ @ckeditor/ckeditor5-code-block@^41.4.2 \ @ckeditor/ckeditor5-core@^41.4.2 \ @ckeditor/ckeditor5-editor-classic@^41.4.2 \ @ckeditor/ckeditor5-engine@^41.4.2 \ @ckeditor/ckeditor5-essentials@^41.4.2 \ @ckeditor/ckeditor5-find-and-replace@^41.4.2 \ @ckeditor/ckeditor5-font@^41.4.2 \ @ckeditor/ckeditor5-heading@^41.4.2 \ ...
-
- Jun 03, 2024
-
-
Stefan Bürk authored
The `symfony/yaml` package provides the `yaml-lint` commandline tool to lint yaml files. This change introduces yaml file linting checks using the symfony tool, differencing `Services.yaml` from other yaml files. Resolves: #103931 Releases: main, 12.4, 11.5 Change-Id: I9442b38c439fb5f2d5507ca0ab70235b2dfd194a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84481 Tested-by:
-
- Jun 01, 2024
-
-
Anja Leichsenring authored
Phpstan claims the contract guard condition can never be true (in which case an exception will be thrown) but this is not true. So we keep the condition, but suppress the error. PHPStan gets updated and pinned to lowest version 1.11.3 with composer require --dev phpstan/phpstan:^1.11.3 Resolves: #103962 Related: #99146 Releases: main, 12.4 Change-Id: I8c184ef24ed95c7277e1e6b5ac8b8c9ea3ad0521 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84473 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- May 26, 2024
-
-
Christian Kuhn authored
$this->count() in phpunit always returns 1 and has no arguments as correctly found by phpstan. Fix a test to actually assert subject result count. Resolves: #103924 Releases: main, 12.4 Change-Id: I396b695eaeaa986a4cd9883e028ed6032d2f6339 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84413 Tested-by:
-
Christian Kuhn authored
GeneralUtility::callUserFunction() has only three parameters, as detected by phpstan. Resolves: #103923 Releases: main, 12.4 Change-Id: I31fc48f343558dd2e0d73feeb3933e249fa625a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84411 Reviewed-by:
-
- May 22, 2024
-
-
Christian Kuhn authored
Less jobs while keeping general pipeline times low. * Simplify runner cache configuration * sqlite pre-merge 3 instead of 5 jobs * sqlite nightly 4 instead of 6 jobs * merge checkGruntClean to general js job * merge php lint jobs into one * avoid composerInstall for unitJavascript * merge acceptance install jobs into less jobs * update acceptance test matrix to run less jobs in nightly while still catching many configuration permutations in addition to pre-merge. Note backports are similar but deviate in details. Change-Id: I832543e002824977a98d3ffb35c3d08355b1f5be Resolves: #103869 Releases: main, 12.4, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84344 Reviewed-by:
-
- May 21, 2024
-
-
Ayke Halder authored
Use all available CPUs with `Build/Scripts/runTests.sh -s lintPhp`. Note podman CI is configured with a cpu-share to prevent starving other jobs when one is greedy, so this change is ok with CI, too. Resolves: #103864 Related: #103851 Related: #102385 Releases: main, 12.4, 11.5 Change-Id: I1cb7079f119677b36d6f4004398ae24bd8c5d284 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84318 Tested-by:
-
- May 17, 2024
-
-
Wouter Wolters authored
Use parallel runner to use more than 1 CPU. composer require --dev friendsofphp/php-cs-fixer:^3.57.1 Resolves: #103851 Releases: main, 12.4, 11.5 Change-Id: I59b5e2566a385792cad1b6c11b9b84b63fd21b98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84289 Reviewed-by:
-
- May 14, 2024
-
-
Oliver Hader authored
Change-Id: I38c57b5342892945c8b91bb72570faa9b5a28665 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84271 Tested-by:
-
Oliver Hader authored
Change-Id: Iedbda8b0217bab62bb7647a7c962f564faaf003e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84270 Tested-by:
-
Benjamin Franzke authored
Encode non prepared output of BackendUtility::getRecordTitle. The string returned by getRecordTitle is only HTML encoded if the third parameter (`$prep`) is set to true, ensure that non-prepared usages are encoded on render. Resolves: #103782 Releases: main, 13.1, 12.4, 11.5 Change-Id: I96b9530d118a21163d6679ebf7120aa40c7ac7b6 Security-Bulletin: TYPO3-CORE-SA-2024-008 Security-References: CVE-2024-34356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84257 Tested-by:
-
