- Feb 20, 2017
-
-
Morton Jonuschat authored
MySQL has support for backslash escape sequences. Change the tests to have the expected results without the additional escaping and add the additional slashes to the expected result if the database platform running the tests is MySQL. Change-Id: Ib2e30e95db507501aaea095eb3764a0d37135ec9 Resolves: #79799 Releases: master Reviewed-on: https://review.typo3.org/51765 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Tymoteusz Motylewski authored
Since context menu refactoring the file deletion did not work. This patch fixes the issue, by adding missing line in JS. Resolves: #79916 Releases: master Change-Id: I939f153aa1d5eae22f821ede98329774e63a3757 Reviewed-on: https://review.typo3.org/51768 Reviewed-by:
Malte Koitka <malte@cytrus.de> Tested-by:
-
Morton Jonuschat authored
Replace the MySQL specific backtick quoting with the actual quote character in test checking for SQL fragments/quoting of fields. Change assertions that assume integer return values from the database driver to also accept string types using assertEquals(). Resolves: #79797 Releases: master Change-Id: I1f78b0b65cdcceeaefa23902d14fa0988198d849 Reviewed-on: https://review.typo3.org/51764 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
Christian Kuhn authored
The "addAndDeletePage" acceptance test is still unstable, even with multiple people trying to stabilize that thing already. To raise acceptance of acceptance tests during core development, this one is skipped for now. Resolves: #79913 Releases: master Change-Id: I55ac9ede4b241a737046d1c0ee16618c314f9d79 Reviewed-on: https://review.typo3.org/51767 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Frans Saris authored
Resolves: #79854 Releases: master Change-Id: Ib7cc81efda1c59d54ab30af00622456955cf7397 Reviewed-on: https://review.typo3.org/51752 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Fernandez authored
To prevent PHP errors in L10nModeUpdater caused by faulty extensions whose `transOrigPointerField` field is not an integer, the parentId is now always cast to an int. Resolves: #79824 Releases: master Change-Id: I238b89b6fec476731f16807125eb89e9198f50c4 Reviewed-on: https://review.typo3.org/51757 Reviewed-by:
-
Oliver Hader authored
* add more tests for allowLanguageSynchronization & l10n_mode=exclude * enhance inline children synchronization for non-translatable tables using $GLOBALS['TCA'][$tableName]['ctrl']['origUid'] if defined * bugfix for copying records instead of localizing them - the target page-id was missing * integrate handling of l10n_mode=prefixLangTitle for cloning data in memory - DataHandler hooks are not process in that regard Resolves: #79856 Releases: master Change-Id: I7f5ef7edba9e80deba6025fe1394d10ee8e2d78c Reviewed-on: https://review.typo3.org/51714 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Frans Saris authored
Resolves: #79902 Releases: master Change-Id: I42a126369108434e33d3b00d4fe6b556592dc2c9 Reviewed-on: https://review.typo3.org/51750 Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Morton Jonuschat authored
Detect errors during execution of SQL statements using the exceptions thrown by Doctrine DBAL instead of trying to use Connection::errorCode(). The previous code doesn't work on MySQL if an actual error occurs since an exception would be thrown earlier in the process and the relevant code path would not be reached. The happy path worked before because MySQL returns 0 as the code when a statement executed successfully while PostgreSQL returns '00000' which PHP does not consider to be empty. Resolves: #79801 Releases: master Change-Id: I508966b6731d256d1edff2267669d158a8d647bf Reviewed-on: https://review.typo3.org/51731 Tested-by:
-
- Feb 19, 2017
-
-
Thomas Hohn authored
Currently it's hard to read the progress of tasks in the scheduler due to the combination of blue, white and light grey. Change of background color for progress from f5f5f5 to dedede makes it more readable. Resolves: #79844 Releases: master Change-Id: I896e66452e3093d729522c9ca7da6b597e0451c7 Reviewed-on: https://review.typo3.org/51710 Tested-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Reviewed-by:
-
Georg Ringer authored
The change #79857 introduced a wrong check to find the site root pages. Instead of checking pid == 0, the field is_siteroot must be used. Resolves: #79897 Releases: master Change-Id: Ibfff703fc9506505f860c051f65dc3d31083eb1e Reviewed-on: https://review.typo3.org/51756 Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Philipp Kerling authored
Resolves: #79904 Related: #77385 Related: #77137 Releases: master Change-Id: I2036ecfcf380d864438d3e5480ce3aecc96b2634 Reviewed-on: https://review.typo3.org/51754 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Philipp Kerling authored
This is a simple typo in the lib.parseFunc of both fluid_styled_content and css_styled_content. The ATagParams attribute for the typolink function needs to be written with a capital A in order to work, otherwise all additional parameters on <a> tags will be dropped in the rendered output. Resolves: #79896 Releases: master Change-Id: I54d5c18fe6934c03b97ae197aba56055394916e5 Reviewed-on: https://review.typo3.org/51755 Reviewed-by:
-
- Feb 18, 2017
-
-
Christian Kuhn authored
Change acceptance tests log directories for better artifact building in bamboo with screenshots and adapt two tests to be less flacky. Change-Id: Ib86531db23617f8205e5099532249653959662cf Resolves: #79898 Releases: master Reviewed-on: https://review.typo3.org/51747 Tested-by:
-
Sascha Egerer authored
There are 2 places in the local driver test where a true assertion is expected. But instead of the correct usage of `assertTrue()` the method `isTrue()` is being used which does no assertion. Resolves: #79891 Releases: master Change-Id: I68f5e43cb1011dd7aadd2c67479d64810ef88bf3 Reviewed-on: https://review.typo3.org/51741 Tested-by:
-
Christian Kuhn authored
Simplify styleguide "elements basic" acceptance tests to be easier understandable, split them into two Cest files. Change-Id: I37ba7a043134e7b2d2291d517c6d0e6aa4c239ae Resolves: #79893 Releases: master Reviewed-on: https://review.typo3.org/51743 Tested-by:
-
- Feb 17, 2017
-
-
Gianluigi Martino authored
Hide the empty button in the create multiple pages function if TYPO3 Manual extension is not loaded. Resolves: #79884 Releases: master Change-Id: Ib72ddae96512c982e634280ddf888f490289af01 Reviewed-on: https://review.typo3.org/51736 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Wouter Wolters authored
Resolves: #79880 Releases: master Change-Id: Ia4b240614ee2c1c1a220fcea7d0f7d13ad518acb Reviewed-on: https://review.typo3.org/51734 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
Sascha Egerer authored
* Initialize some uninitialized variables * Fix invalid argument count on function calls * Fix case typo in function call * Fix some phpdoc issues Resolves: #79865 Releases: master Change-Id: I4e41940d849daa818735f75169e7cc686ee908c9 Reviewed-on: https://review.typo3.org/51725 Tested-by:
-
Morton Jonuschat authored
Enforce consistent ordering of deleted records. Change-Id: Ibcb5e61c8cf848b2e25702aef3a2d4ca6bd1cfe6 Resolves: #79800 Releases: master Reviewed-on: https://review.typo3.org/51732 Tested-by:
-
Christian Kuhn authored
Fix travis Change-Id: I3be72d1f892167c884a4ca533dd37633139ef879 Resolves: #79869 Releases: master Reviewed-on: https://review.typo3.org/51730 Tested-by:
-
Christian Kuhn authored
This moves all maintenance / check / test scripts from typo3/sysext/core/Build/Scripts to Build/Scripts. This is possible now after the test framework extraction. The artifical Build folder of typo3/sysext/core vanishes and all core related integrity and code sanitation scripts are now located next to all other main core build relevant stuff. This patch is only breaking for core devs who executed one of the scripts, most notably the "cglFixMyCommit.sh" script. Path is now: ./Build/Scripts/cglFixMyCommit.sh Change-Id: I8272d3d18c5e4164d67df8831168476f315db285 Resolves: #79869 Releases: master Reviewed-on: https://review.typo3.org/51729 Tested-by:
-
Tymoteusz Motylewski authored
Provide script for generating files with acceptance tests groups to allow running them in parallel on different hosts. Very useful for bamboo. Usage: Generating 5 dynamic group files: ./components/testing_framework/Resources/Core/Build/Scripts/splitAcceptanceTests.sh 5 Run tests of group 1: ./bin/codecept run Acceptance -g AcceptanceTests-Job-1 -c ... Note group numbers start from 1, not 0. Resolves: #79845 Releases: master Change-Id: Ib74ec0b457ee927a906a77e648041ae15dc727d2 Reviewed-on: https://review.typo3.org/51713 Tested-by:
-
Sascha Egerer authored
Resolves: #79866 Releases: master Change-Id: Iffb59947ae8a2790736352c473637ac184796b36 Reviewed-on: https://review.typo3.org/51726 Tested-by:
-
Sascha Egerer authored
The function GeneralUtility::quoteJSvalue is sometimes called with a second parameter but it does only have on parameter. Resolves: #79867 Releases: master Change-Id: I994501574b798026f43a0e463a633e05ffc1cff3 Reviewed-on: https://review.typo3.org/51727 Tested-by:
-
Sascha Egerer authored
The UriBuilder initialization has been added in f5dd76ca but it is not used anywhere Resolves: #79863 Releases: master Change-Id: I46deb21e5466f3d068f95063034feb4da3b7f60c Reviewed-on: https://review.typo3.org/51723 Reviewed-by:
-
Mathias Brodala authored
Resolves: #79859 Related: #78191 Releases: master, 7.6 Change-Id: Ia2a3ed9b1a793c1be554f73fa99362e3015313df Reviewed-on: https://review.typo3.org/51720 Reviewed-by:
-
Frank Naegler authored
Remove usage of htmlEscape from core templates, because it is deprecated since #75575 Resolves: #79842 Related: #75575 Releases: master Change-Id: I62c53cb9cdba585f5ead920154dcef729c8c02eb Reviewed-on: https://review.typo3.org/51709 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Frank Naegler authored
This patch fixes wrong field escaping due to simple implode of fields in case label_alt is set for select or groups fields. Resolves: #79860 Releases: master Change-Id: Ie0753957e387c1624824d152ac291524cfd34ccd Reviewed-on: https://review.typo3.org/51721 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Georg Ringer authored
If the root page is selected, the following is improved: - show the sitename instead of '[root-level]' - show the world icon for the first pages (all with pid = 0) Resolves: #79857 Releases: master Change-Id: I449a34e356ec43f8679bb9cdcd4c790fd4701004 Reviewed-on: https://review.typo3.org/51719 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Sascha Egerer authored
Fix a fatal error introduced in a previous refactoring of the code. Resolves: #79864 Releases: master Change-Id: Ib50052f2d7b3485da97fbe7a4ad88041bb676dad Reviewed-on: https://review.typo3.org/51724 Tested-by:
-
- Feb 16, 2017
-
-
Sascha Egerer authored
Add some missing variable initialization in EXT:version Resolves: #79862 Releases: master Change-Id: I97d8326675d9d90404b99e501e8756ec045c0d90 Reviewed-on: https://review.typo3.org/51722 Tested-by:
-
Mona Muzaffar authored
Resolves: #79437 Releases: master Change-Id: I5d1c64202d9e59c0a2a8e799df0576af9f6cb82d Reviewed-on: https://review.typo3.org/51556 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Morton Jonuschat authored
Fix reliance on MySQLs implicit secondary ordering by uid within DataHandler. Reset sequenced on non-MySQL database platforms. Sort expected results retrieved from the database and switch to using assertEquals() to avoid string/int type differences in result rows due to different drivers. Change-Id: I95a8cdb81dbbdb6c4bcf2c6c9ad9f0e5f9ae44fe Resolves: #79672 Releases: master Reviewed-on: https://review.typo3.org/51664 Tested-by:
-
Morton Jonuschat authored
Sort expected results retrieved from the database and switch to using assertEquals() to avoid string/int type differences in result rows due to different drivers. Change-Id: I65975967171c28a13c8711d352895d2969d408ea Resolves: #79671 Releases: master Reviewed-on: https://review.typo3.org/51665 Tested-by:
-
Markus Klein authored
This is not the job of the uri builder to decide this. It must simply build an URL from all given parameters. In general, empty parameters can be intended by a dev. Resolves: #79835 Releases: master, 7.6 Change-Id: I0ec3e7c41a78b40ecd81e52381f1d744a1e65608 Reviewed-on: https://review.typo3.org/51704 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Susanne Moog authored
Change-Id: Ib8b787980d90c686457155cbb6c15cd3cd7c0d61 Releases: master Resolves: #79851 Reviewed-on: https://review.typo3.org/51715 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Morton Jonuschat authored
PostgreSQL requires mixed case column names in the database to be quoted at all times, otherwise the name of the column will be forcefully converted to all lowercase. Set a constant in the testrenderer that contains the current database type and switch the WHERE condition in JsonRenderer.ts to a properly quoted version for PostgreSQL Change-Id: I0b7caf4b51006bdf3bc131d995b0993504f49889 Releases: master Resolves: #79651 Reviewed-on: https://review.typo3.org/51569 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Benni Mack authored
There are some unnecessary calls to the core, which are obviously unneeded. Resolves: #79843 Releases: master Change-Id: Ia86f57e56516cc30132a2360d8dc17a44e95531e Reviewed-on: https://review.typo3.org/51706 Tested-by:
-
- Feb 15, 2017
-
-
Oliver Hader authored
* add values of pages.tx_irretutorial_hotels to assertions * extend JSON renderer to reflect pages.tx_irretutorial_hotels Resolves: #79829 Releases: master Change-Id: I27ac88af79aa6cef85e8d34d22f464c62142cbed Reviewed-on: https://review.typo3.org/51712 Tested-by:
-
