- Jan 26, 2017
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a prett...
-
Manuel Selbach authored
Add a functional test to verify that serialized PHP objects can be successfully stored in the database without having encoding/escaping problems. Resolves: #79452 Releases: master Change-Id: I97d586cb8a50e571d99ff8b7fc463c0a83e15f36 Reviewed-on: https://review.typo3.org/51394 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Ralf Zimmermann authored
Render the form label or a placeholder text (if no form is selected) within the page module. Resolves: #78834 Releases: master Change-Id: I5519ce8bec7ae077d22328ff0ad70b29aa1b5af7 Reviewed-on: https://review.typo3.org/51422 Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Andreas Steiger authored
* add attribute role="alert" to error hints * streamline bootstrap 3 error classes * add attribute formnovalidate to previous button of multistep form * remove fieldset wrap from element type 'PAGE' Resolves: #69974 Releases: master Change-Id: I66336879bed0f94752482404c3ed7cfa7028046d Reviewed-on: https://review.typo3.org/51426 Tested-by:
-
Ralf Zimmermann authored
Adds a new button into the form editor module header. Clicking on this buttons shows the form settings within the inspector. Resolves: #79467 Releases: master Change-Id: I767c71fcf65ca5bd58b2b530a60fce1caf75e3c9 Reviewed-on: https://review.typo3.org/51425 Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Ralf Zimmermann authored
Parse finisher option values only if the referenced formelement value is a string. Resolves: #79412 Releases: master Change-Id: Ie379a396473c31907d52c8aa096168fed803510b Reviewed-on: https://review.typo3.org/51381 Tested-by:
Daniel Lorenz <daniel.lorenz@extco.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
-
Georg Ringer authored
- Skip length check of header - Use type "number" for integer types - Apply min & max attributes if available Resolves: #79421 Releases: master Change-Id: I508000547214d3d3ca18a8e311ce68dd03dea09b Reviewed-on: https://review.typo3.org/51386 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Mattias Nilsson <tollepjaer@gmail.com> Tested-by:
-
Thomas Hohn authored
The database field definition for ref_string is limited to varchar(200) and can cause an SQL error when bigger strings are inserted. In addition it makes sense to add a mb_substr() to avoid an error if longer strings are inserted. Fixes: #79425 Releases: master Change-Id: I1f1e672f610f830ad5e02509cb1f0529c9cbeb41 Reviewed-on: https://review.typo3.org/51397 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Mona Muzaffar authored
An error occurs in the createNamedParameter function which expects an array but gets a string instead. Change-Id: I393a6a87c912129ded28f677ca65c081fc4205e7 Resolves: #79309 Releases: master Reviewed-on: https://review.typo3.org/51342 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Manuel Selbach authored
Change-Id: I6db726bfff61c092309a971eb71e074c30cad046 Releases: master, 7.6 Resolves: #79378 Reviewed-on: https://review.typo3.org/51349 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
Thomas Hohn authored
This patch marks some internal cache variables in the Datahandler as deprecated since their visibility should be changed from public to protected or even be replaced by a runtime cache. Since this can't be done before TYPO3 v9 they are marked as deprecated in TYPO3 v8 as a preparation. Fixes: #79441 Releases: master Change-Id: I7d35792fb81e6f16b3b729a3841c1cfda109952f Reviewed-on: https://review.typo3.org/51411 Reviewed-by:
-
Thomas Hohn authored
Switch updateIndex method to use a subselect based approach to avoid errors due to huge parameter lists for manually built NOT IN queries which could exceed the maximum query length. Add a warning if the table doesn't share a connection with the reference index as it can not be updated automatically. Resolves: #79397 Releases: master Change-Id: I563dfe607b24ffe949ef5a0e9d2e62b2312ff8f0 Reviewed-on: https://review.typo3.org/51370 Tested-by:
-
Markus Klein authored
This fixes the issue that lines are wrapped within a HTML entity. Resolves: #79398 Releases: master, 7.6 Change-Id: I0bf1722cb9792fea0f45421fe1f72e1932879002 Reviewed-on: https://review.typo3.org/51369 Tested-by:
Dominique Kreemers <dominique.kreemers@icloud.com> Tested-by:
-
Manuel Selbach authored
Within the refactoring process the optional parameter $useDeleteClause was missed to remove from the parameter list of the method, as it is not implemented in the body and not used anywhere in the core. Releases: master Resolves: #79382 Change-Id: I4db104941b78f44573b0b1f51ad216ded93887bf Reviewed-on: https://review.typo3.org/51351 Tested-by:
-
Manuel Selbach authored
When writing to database tables with BLOB type columns declare the field type for the query parameters in functional tests. This is required for databases that use a different encoding/transport protocol for BLOB fields. Resolves: #79453 Releases: master Change-Id: I1371bb192abaec841be982a1b228cc6b7e6d1cbf Reviewed-on: https://review.typo3.org/51395 Reviewed-by:
-
- Jan 25, 2017
-
-
Mona Muzaffar authored
Change-Id: I6a17811dd5dbc5ed285b6040fcbe97e94b416b8b Releases: master Resolves: #79321 Reviewed-on: https://review.typo3.org/51359 Tested-by:
-
Claus Due authored
A new Fluid ViewHelper, `f:variable`, has become available in TYPO3 after raising the minimum required version of the Fluid engine to 2.2.0. Change-Id: I4f42030ef586e8d9a3d40c54c64137eb1969384d Resolves: #79402 Releases: master Reviewed-on: https://review.typo3.org/51398 Tested-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
-
Anja Leichsenring authored
With the update of cs-fixer to version 2.0, some checks got minor changes in behaviour. The core follows now in applying those suggested changes. Resolves: #79469 Relates: #79361 Releases: master Change-Id: I5d17b750231dcb386002b3e46b3a89c59eca2989 Reviewed-on: https://review.typo3.org/51428 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Frank Naegler authored
This patch adds a missing compilerOption to generate subfolder in the build directory, which fix the copy to final destination problem. Resolves: #79431 Releases: master Change-Id: Ie756d47e12d2ff72aa6db397d87db311eed43b59 Reviewed-on: https://review.typo3.org/51404 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Ralf Zimmermann authored
Adds a new button to the text editors. This splitbutton opens a list with available form elements. If a form element is choosen, the form element identifier will be inserted into the property text editor. Resolves: #79442 Releases: master Change-Id: If40114958311200348bde220f6cf62fb6365260b Reviewed-on: https://review.typo3.org/51424 Tested-by:
-
Anja Leichsenring authored
Change-Id: Ia32a61238bdf46c01a3856376c0a94d9d09339ee Resolves: #79361 Releases: master Reviewed-on: https://review.typo3.org/51423 Tested-by:
-
Anja Leichsenring authored
Change-Id: I118f4d6b9fd94fcaa0da3cef4e0f290b60c57fc8 Resolves: #79460 Releases: master Reviewed-on: https://review.typo3.org/51420 Reviewed-by:
-
Anja Leichsenring authored
We want to use the latest version. Change-Id: I9f41f2b6e58020e01615569350b80afb34a3a067 Resolves: #79459 Releases: master Reviewed-on: https://review.typo3.org/51419 Tested-by:
-
Ralf Zimmermann authored
Add onSubmit callback for toplevel composit elements aka. pages. The ticket provides an example extension for testing. Resolves: #78821 Releases: master Change-Id: Ie521ba75472e426594dae231ee86f68cd241f23d Reviewed-on: https://review.typo3.org/50796 Tested-by:
-
Ralf Zimmermann authored
This patch adds an option to the saveToDatabase finisher which makes it possible to update an existing database record. The forge issue provides an example extension for testing. Resolves: #78839 Releases: master Change-Id: I07d874a72b81a5e43c864f8a468a1310cac57995 Reviewed-on: https://review.typo3.org/50810 Reviewed-by:
-
Ralf Zimmermann authored
Let the JavaScript 'Inspector-PropertyGridEditor' deal with mixed option value types (string / int) Resolves: #79457 Releases: master Change-Id: I7e9a377d9a5d6e9f1336c25bc114c974a70b7284 Reviewed-on: https://review.typo3.org/51421 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Claus Due authored
With the update of fluid to 2.2.0 (e0041459) the backend and frontend break. This patch fixes these problems. Change-Id: I74617650c5feff381421e15f50aa84aeaf2f6aad Resolves: #79439 Releases: master Reviewed-on: https://review.typo3.org/51410 Tested-by:
-
Thorben Nissen authored
Changes the way the svg tree nodes are checked for "indeterminate" state after the data is loaded, so the initial state. Changes code using "rootNode" to using list of all nodes. Removes unused code. Resolves: #79246 Releases: master Change-Id: I7a076a6d3d2c29f0318598227af5d674caa3642f Reviewed-on: https://review.typo3.org/51237 Tested-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
-
Manuel Selbach authored
The unified handling for frontend and backend users requires identical SQL column types to properly escape the input data. Using binary encoding for the uc column in combination with a TEXT type field in the BE fails on PostgreSQL. Resolves: #79451 Related: #79324 Releases: master Change-Id: I08e404ca7050aa169234a4542ffa640cad2cd1ff Reviewed-on: https://review.typo3.org/51393 Reviewed-by:
-
Manuel Selbach authored
Check that a uid is numeric to prevent errors when querying an integer database field with a string value like NEW123456789. Resolves: #79455 Releases: master Change-Id: I03a71f31c537e04bc05fcf13f7153c7f6adb3ae7 Reviewed-on: https://review.typo3.org/51396 Reviewed-by:
-
Johannes Goslar authored
Resolves: #79143 Releases: master Change-Id: I3cc6f0cff6980439f8f967f8ea627e074444f28c Reviewed-on: https://review.typo3.org/51108 Tested-by:
-
Manuel Selbach authored
The core methods dealing with frontend group restrictions expect this field to be of a character based datatype. Comparing an integer based field with string triggers query errors on PostgreSQL which does not perform implict type conversions. Resolves: #79447 Releases: master Change-Id: Idc937e71d578e5f4a81595124c3aef53d32b2ed7 Reviewed-on: https://review.typo3.org/51392 Reviewed-by:
-
Dominique Kreemers authored
Set $propertyPath, $tableName and $className to avoid unnecessary joins and wrong repository results. This is a regression fix after the Doctrine migration. Resolves: #79286 Related: #77379 Releases: master Change-Id: I64489b46b9ca751535b64482f54ceb7b2da05003 Reviewed-on: https://review.typo3.org/51290 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Jan 24, 2017
-
-
Daniel Dorndorf authored
Adding metatags on uncached pages using the pagerenderer didn't work because the metatag array was rendered prior to adding any entries with the 'render-preProcess' hook. Resolves: #79162 Releases: master, 7.6 Change-Id: I2142a5c91fcb0840993d9235caa1e883bbb0c2b4 Reviewed-on: https://review.typo3.org/51143 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
-
- Jan 23, 2017
-
-
Georg Ringer authored
- Use xs instead of sm to support smaller screens - Add an id to the select field Resolves: #79418 Releases: master Change-Id: Ibc0c242d1c9ab54032c2ee383a127b9665cde736 Reviewed-on: https://review.typo3.org/51385 Tested-by:
-
Frank Naegler authored
This patch fix broken links in ClickMenu and DatabaseRecordList which exists since the permissions module refactoring: http://review.typo3.org/33402 Resolves: #79329 Related: #62339 Releases: master, 7.6 Change-Id: Iafe66352a7bac593e249ef09c07f1c9dc9b15359 Reviewed-on: https://review.typo3.org/51330 Tested-by:
-
Gianluigi Martino authored
Prevent the escaping of pidRecordTitle in click menu move element. The escaping is already done in the MoveElementController due to the usage of the third (prep) parameter in BackendUtility::getRecordTitle. Resolves: #79088 Releases: master Change-Id: Ib35e9d5a3da7fc76085db910927ada17dbdd0b06 Reviewed-on: https://review.typo3.org/51041 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Georg Ringer authored
The select field of BackendUtility::getFuncMenu must be styled by the class "form-control". One example can be found in the template module if multiple template records are saved on one page. Resolves: #79417 Releases: master Change-Id: I84967474aadbd88bd844fe3cb7de0245abebd39f Reviewed-on: https://review.typo3.org/51384 Reviewed-by:
-
Georg Ringer authored
The information of a template (title, site title, description) is already escaped by using fluid. Therefore the htmlspecialchars() must be removed in the controller. This is a fix of the regression of the fluidification of #75031. Resolves: #79424 Releases: master Change-Id: Iead09ee8f8f0256eee10c2585408d549dbe5c44c Reviewed-on: https://review.typo3.org/51391 Tested-by:
-
Georg Ringer authored
If a template record does not contain any constants, the information should be rendered by a nice callout. Resolves: #79416 Releases: master Change-Id: I6af7b2676d4a7517bc392595948806df9ae7e042 Reviewed-on: https://review.typo3.org/51383 Tested-by:
-
