- Jun 14, 2018
-
-
Benni Mack authored
Use Environment::getPublicPath() and Environment::getProjectPath() respectively, depending on the use-case instead of PATH_site. Resolves: #85259 Releases: master Change-Id: I7debc10332232f3b8a29c9b8def268f389d71b88 Reviewed-on: https://review.typo3.org/57163 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Frank Naegler authored
yarn upgrade grunt yarn upgrade grunt-contrib-watch yarn upgrade grunt-tslint Resolves: #85224 Releases: master Change-Id: I31ccdc090fa6fdf800c1bf1c62f7d409bb36e4a4 Reviewed-on: https://review.typo3.org/57180 Tested-by:
-
Tymoteusz Motylewski authored
The new name makes the code easier to understand, as the variable contains the column name configured in ['ctrl']['sortby']. Resolves: #85258 Releases: master Change-Id: I0237809c9029a634a50753a6978f74831ae8c14f Reviewed-on: https://review.typo3.org/57214 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Georg Ringer authored
Improve usability by adding a modal to require a second click. Resolves: #85143 Releases: master Change-Id: I310a655711aa730feca0b96e157c19eac8b7fcb0 Reviewed-on: https://review.typo3.org/57170 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
The patch adds SQLite as new DBMS platform to the TYPO3 instance installer if pdo_sqlite is available. * sqlite has no database name and user / password restriction but stores the database in a single file. * the filename contains a random string so it can't be easily guessed if the config directory is within web document root and the web server is configured to deliver .sqlite files. * the feature .rst file mentions possible security risks comes with having a database within document root and documents how to prevent those. * similar to mysql and postgres, an acceptance test verifies the system can be successfully installed using a blank installation and using the introduction package. * bamboo plan spec is adapted to execute the sqlite installer suite * testing-framework is raised to 3.8.1 supporting the ac test: composer update typo3/testing-framework Resolves: #85256 Releases: master Change-Id: I91a8c98f868b5e29bee4ad7dedd3cc8c50346452 Reviewed-on: https://review.typo3.org/55563 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Benni Mack authored
The patch adds a new trait similar to the existing one for propreties to allow setting public methods to protected in a backwards compatible way. Resolves: #85247 Related: #81330 Releases: master Change-Id: Iaf6d7f328f7b5685e179f4a4b8f78fbeb419fb14 Reviewed-on: https://review.typo3.org/57156 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Susanne Moog authored
Keep track of open file handles for resources across instances and close the handle only on destructing the last known instance using it. Resolves: #85245 Releases: master Change-Id: I896f630521136474f843a271b5bd7c752a2efdaf Reviewed-on: https://review.typo3.org/57204 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Jun 13, 2018
-
-
Justus Moroni authored
The FormElementHooks now uses the correct namespace for the generated error. The TranslateElementErrorViewHelper requires the submitted error to be an instance of TYPO3\CMS\Extbase\Validation\Error. The error was an instance of TYPO3\CMS\Extbase\Error\Error. As the instance was wrong, an exception was thrown. Resolves: #85255 Releases: master, 8.7 Change-Id: I6ccce5fb6370d2bf34f494141d73cc602eb923ce Reviewed-on: https://review.typo3.org/57211 Reviewed-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Christian Kuhn authored
* Similar to postgresql, sqlite index names must be unique within the entire database. The patch adds a hash of the table name in front of indexes to make them unique. * SELECT'ing rows from a table and UPDATE'ing them while the select query is still running is not safe in sqlite, single rows may appear over and over again in the select() result set. The patch switches a query combination to a fetchAll() on sqlite platform to prevent this. Change-Id: Ib35ab4f46bbce7867ff9e4624e545b505c4f5e57 Resolves: #85253 Releases: master Reviewed-on: https://review.typo3.org/57209 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
The new Environment API is now used to define hashes or base paths in cache backend classes. Resolves: #85200 Releases: master Change-Id: I08f770bf959274995e7983b800d8a569aee7cd47 Reviewed-on: https://review.typo3.org/57161 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Jun 12, 2018
-
-
Frank Naegler authored
yarn upgrade karma-coverage@1.1.2 yarn upgrade karma-jasmine@1.1.2 Resolves: #85220 Releases: master Change-Id: I44019f08df4e2ab4f104236c055656f72f4d7015 Reviewed-on: https://review.typo3.org/57176 Tested-by:
-
Anja Leichsenring authored
The test uses now a method to check on the element that takes the DOM into consideration, and not the visibility on the interface. Not the backend changed anything, but the testing methods of codeception cause this failure. Using the correct testing method solves the problem. Resolves: #85208 Releases: master, 8.7 Change-Id: I349a555de2ab04c9f6181e5d71e4602fa9552df3 Reviewed-on: https://review.typo3.org/57168 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Benni Mack authored
The property `$GLOBALS['TYPO3_REQUEST']` is not needed when inside a middleware, as the current PSR-7 request object is already available. Resolves: #85242 Releases: master Change-Id: Ib5062725dd74990c6a6003b6fcd8a82afb158c0b Reviewed-on: https://review.typo3.org/57202 Reviewed-by:
-
Frank Naegler authored
yarn upgrade chosen-js@1.8.5 Resolves: #85221 Releases: master Change-Id: Ic97a68ead2145183ef3739584af8556b8a6cc139 Reviewed-on: https://review.typo3.org/57177 Tested-by:
-
Frank Naegler authored
yarn upgrade @types/bootstrap@3.3.39 yarn upgrade @types/jasmine@2.8.8 Resolves: #85219 Releases: master Change-Id: I33d30853ca6d631ae262047daf221c978d548c93 Reviewed-on: https://review.typo3.org/57175 Tested-by:
-
Benni Mack authored
The fileHash property acts as an internal cache for TemplateService->getFileName() and was misued since TYPO3 6.0 for FAL-related information of processed images. As this is a purely runtime-based cache (and internal), the usages here are dropped. Resolves: #85235 Releases: master Change-Id: I96e8630cb8c45be009385aa5eccc01e3875e2d2b Reviewed-on: https://review.typo3.org/57197 Tested-by:
-
Benni Mack authored
TYPO3 has a bound box calculation workaround due to a PHP bug, which was fixed in PHP 7.0.12 / 7.1, which can now safely be removed. Resolves: #85232 Releases: master Change-Id: I72e9ea925ae7e91eea244b89a20b1bec2408ca78 Reviewed-on: https://review.typo3.org/57196 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Frank Naegler authored
Looks like a different file encoding of the images results in marking these icons as changed on OS X. Resolves: #85240 Releases: master Change-Id: I37293134347e9aa16fe05671073e74f8621736d3 Reviewed-on: https://review.typo3.org/57182 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Mathias Schreiber authored
In order to make finding the module more straightforward, its tab label has been set to “Sites” which should be more intuitive. Releases: master Resolves: #85239 Change-Id: I3d6d546f8439e4e107bf932efdc2d41ce65b4c75 Reviewed-on: https://review.typo3.org/57199 Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
There are some places where phpdoc comments and return types are wrong, (an IDE shows this ASAP to you if you open up the file). The patch fixes the small glitches. Resolves: #85231 Releases: master, 8.7 Change-Id: I3550e7631b31144989d09feee79d1c96da3079db Reviewed-on: https://review.typo3.org/57195 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Alexander Schnitzler authored
As the ReflectionService class is only a wrapper to call methods on ClassSchema instances, all wrapper methods should be deprecated and removed to make space for a new, superior api. Releases: master Resolves: #85004 Change-Id: I7daabe1ab09c1c8a95b2b6dad2227c8859929dc0 Reviewed-on: https://review.typo3.org/56896 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Jun 11, 2018
-
-
Oliver Hader authored
Change-Id: I0281fd494612837d46966c4cdcbda5ee11c63809 Reviewed-on: https://review.typo3.org/57187 Tested-by:
-
Oliver Hader authored
Change-Id: I4adf71f27e40df89bc77825e6771d5b249cf1ffd Reviewed-on: https://review.typo3.org/57186 Reviewed-by:
-
Frank Naegler authored
Using the second parameter of TBE_EDITOR.rawurlencode cuts the input to 200 characters for any input value. The parameter is rather useless and its usage can be simply removed to allow URLs with more than 200 characters. Resolves: #85226 Releases: master, 8.7 Change-Id: I8391488d6fb21ede9280041dd41e3feb7e19dbd1 Reviewed-on: https://review.typo3.org/57183 Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
-
Frank Naegler authored
Since EXT:frontend does not have CSS files anymore, the postcss config for Grunt is not necessary anymore. Resolves: #85225 Releases: master Change-Id: Ibdecf246c2841e383d745dfdfbf7f3a7181be19b Reviewed-on: https://review.typo3.org/57181 Reviewed-by:
-
Frank Naegler authored
Resolves: #85213 Related: #84993 Releases: master Change-Id: Ib8cd46951cb5032a7554042e2d8a7a052102788b Reviewed-on: https://review.typo3.org/57174 Tested-by:
-
Benni Mack authored
The EM changes due to the new automatic DB fields addition for TCA-based tables come with a small side-effect, namely that all extensions are now evaluated when doing the SQL create queries. The introduced changes now only do execute "safe" DB updates, but not limited to an extension, but for all installed extensions. Thus, non-safe DB operations are not taken into account for an extension installation/upgrade anymore. The patch reverts the changes to the original behaviour, so that a follow-up patch can introduce the following behaviour: - Install extension - Do _safe_ DB updates for the whole system - Do breaking DB updates for the extensions to be installed/upgraded - Execute ext_tables_*adt.sql files + imports Resolves: #85215 Releases: master Change-Id: Ief1118319eb0afcd586efdff506cf44d00e02fb7 Reviewed-on: https://review.typo3.org/57173 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Christian Kuhn authored
Resolves: #85190 Related: #85188 Releases: master Change-Id: Ia77e74753fcca2c13b0e32b2dce186723c457775 Reviewed-on: https://review.typo3.org/57153 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
-
Christian Kuhn authored
typo3/testing-framework since version 3.8.0 can reset singletons created by makeInstance automatically if $this->$resetSingletonInstances is set to true. This version additionally checks for left over singletons in case that property has not been set and lets tests fail in this case. composer require --dev typo3/testing-framework:^3.8 As advantage, a manual backup of singleton instances within tests is not needed anymore. The patch comes with a set of test case adaptions to cope with this new situation. Change-Id: Ib5f278145e385e32d543541872cf5e1f208fad47 Resolves: #85209 Releases: master Reviewed-on: https://review.typo3.org/57169 Tested-by:
-
- Jun 10, 2018
-
-
Andreas Fernandez authored
The URLs to the create actions for backend users and backend groups were built in a strange way which required some quirks to be fully functional. This patch removes the unnecessary `explodeUrl2Array()` call, which also renders the `rawurlencode()` obsolete. Resolves: #85211 Releases: master Change-Id: I3b8f5864fc398b9a4f8f2c0de5d72a38cb8a471b Reviewed-on: https://review.typo3.org/57172 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Benni Mack authored
Due to moving a class name the import statement in ErrorController was wrong. Resolves: #85210 Related: #85101 Releases: master Change-Id: I17cd062868ca3d0686218abd469a72cbdd08018b Reviewed-on: https://review.typo3.org/57171 Tested-by:
-
Anja Leichsenring authored
Resolves: #85202 Releases: master Change-Id: I6f61db1d2c29a3b9d4794e33cbaf2c6e634e14c7 Reviewed-on: https://review.typo3.org/57158 Tested-by:
-
Christian Kuhn authored
Static method variables are even more pita than static class variables, especially if their state is created from db rows or path information: It is nearly impossible to get rid of this state at a later point again, even reflection does not help here. The patch abandons all 'static $foo' method variables from the system, using these strategies: * Remove some entirely which were used as first level cache and only cache-away simple non db related code structures. * Switch some to use cache framework cache_runtime instead which can be evicted easily. * Use class properties in some cases instead. Change-Id: Ic699846a2c6ec661ee1124ace50df1aa04a1954b Resolves: #85206 Releases: master Reviewed-on: https://review.typo3.org/57167 Tested-by:
-
Michael Schams authored
The fully qualified class name of class `TableGarbageCollectionTask` must be used to configure database tables, which should be cleaned up (inactive or deleted records removed from the system). This change replaces `tx_scheduler_TableGarbageCollection` with the correct class name in the documentation: \TYPO3\CMS\Scheduler\Task\TableGarbageCollectionTask::class Releases: master Resolves: #85205 Change-Id: I13434bf6bc13dd987263605d845f8b59b69e0796 Reviewed-on: https://review.typo3.org/57166 Tested-by:
-
- Jun 09, 2018
-
-
Jan Helke authored
Releases: master Resolves: #85092 Change-Id: I29bb5a3d0546d790d9c8d05c52f448ecefbc8564 Reviewed-on: https://review.typo3.org/57063 Tested-by:
-
Frank Naegler authored
The new IpAnonymizationAdditionalFieldProvider introduced the same JavaScript variable which breaks the garbage collection task. The JavaScript initialization has been removed and the field provider simplified. Resolves: #85068 Releases: master, 8.7, 7.6 Change-Id: Ibb307ee37d6fea33a721373bdc50bbbd3fee1453 Reviewed-on: https://review.typo3.org/57136 Tested-by:
-
Anja Leichsenring authored
New folder and includes to render the changelog for the upcomming version. Change-Id: I0440dcfdaf5541da5e8dbe8b8b681a477951fc14 Resolves: #85202 Releases: master Reviewed-on: https://review.typo3.org/57152 Tested-by:
-
Benni Mack authored
The new SEO extension handles opengraph and twitter (seo-relevant), thus do not need to stay in EXT:core, as they are only for sites which need SEO relevant information to be processed. Resolves: #85201 Releases: master Change-Id: Ib0bf503bb939b47747dc32209f78f8e7ce8622c1 Reviewed-on: https://review.typo3.org/57162 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #85088 Change-Id: Ibd443902f6c89e16946d3d8d2cc39a8e2091054e Reviewed-on: https://review.typo3.org/57059 Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #84722 Change-Id: I0edb98c7713f5c6520cbbc33e3f85ab1b3f4946f Reviewed-on: https://review.typo3.org/56659 Reviewed-by:
-
