[TASK] Properly reset unit test singletons
typo3/testing-framework since version 3.8.0 can reset singletons created by makeInstance automatically if $this->$resetSingletonInstances is set to true. This version additionally checks for left over singletons in case that property has not been set and lets tests fail in this case. composer require --dev typo3/testing-framework:^3.8 As advantage, a manual backup of singleton instances within tests is not needed anymore. The patch comes with a set of test case adaptions to cope with this new situation. Change-Id: Ib5f278145e385e32d543541872cf5e1f208fad47 Resolves: #85209 Releases: master Reviewed-on: https://review.typo3.org/57169 Tested-by:TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
Showing
- composer.json 1 addition, 1 deletioncomposer.json
- composer.lock 6 additions, 6 deletionscomposer.lock
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php 22 additions, 2 deletions...inpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php
- typo3/sysext/backend/Tests/Unit/Controller/LoginControllerTest.php 6 additions, 1 deletion...ext/backend/Tests/Unit/Controller/LoginControllerTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php 0 additions, 7 deletions.../Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php 5 additions, 10 deletions...Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexPrepareTest.php 0 additions, 8 deletions...d/Tests/Unit/Form/FormDataProvider/TcaFlexPrepareTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php 2 additions, 13 deletions...backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php 1 addition, 9 deletions...nd/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php 4 additions, 6 deletions...d/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php 2 additions, 17 deletions...sts/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php
- typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php 2 additions, 12 deletions...sext/backend/Tests/Unit/Form/InlineStackProcessorTest.php
- typo3/sysext/backend/Tests/UnitDeprecated/Form/FormDataProvider/TcaFlexPrepareTest.php 7 additions, 8 deletions...itDeprecated/Form/FormDataProvider/TcaFlexPrepareTest.php
- typo3/sysext/core/Classes/Log/LogManager.php 3 additions, 1 deletiontypo3/sysext/core/Classes/Log/LogManager.php
- typo3/sysext/core/Tests/Integrity/IntegrityTest.php 0 additions, 44 deletionstypo3/sysext/core/Tests/Integrity/IntegrityTest.php
- typo3/sysext/core/Tests/Unit/Authentication/AuthenticationServiceTest.php 7 additions, 1 deletion...e/Tests/Unit/Authentication/AuthenticationServiceTest.php
- typo3/sysext/core/Tests/Unit/Cache/Backend/PdoBackendTest.php 6 additions, 0 deletions...3/sysext/core/Tests/Unit/Cache/Backend/PdoBackendTest.php
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php 2 additions, 12 deletions...e/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php 5 additions, 13 deletions...3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php 7 additions, 3 deletions...re/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php
Please register or sign in to comment